Commit graph

85 commits

Author SHA1 Message Date
Peter Pisljar b93034b72c
inspector table adapter cleanup (#84232) 2020-12-17 12:14:07 +01:00
Marta Bondyra 5b9e285582
[Lens] (Accessibility) focus on adding/removing layers (#84900) 2020-12-16 21:58:14 +01:00
Marco Liberati 62623cdab9
[Lens] New sorting feature for the datatable visualization (#84435)
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 12:37:59 +01:00
Joe Reuter 33c552feee
[Lens] Use eui component instead of custom color stops (#85239) 2020-12-09 16:06:25 +01:00
Wylie Conlon 0fdf76e779
[Lens] Don't assign dimension until it becomes valid (#84972) 2020-12-08 11:29:07 +01:00
Marta Bondyra 2cf4e72394
[Lens] (Accessibility) Added focus state and accessible name to suggestions (#84653)
* [Lens] (Accessibility) Added focus state and accessible name to suggestions

* Apply suggestions from code review

* Update x-pack/plugins/lens/public/editor_frame_service/editor_frame/suggestion_panel.tsx

padding oops

* cr
2020-12-04 19:28:33 +01:00
Wylie Conlon f176e8b7fd
[Lens] Remove extra render when closing flyout with valid column (#84951)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 11:00:10 -05:00
Marta Bondyra 1ff2bb3d8a
[Lens] allow drag and drop reorder on xyChart for y dimension (#84640)
* [Lens] allow drag and drop on xyChart for y dimension

* wip

* tests

* dimension panel fix

* eslint

* fix test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-03 20:30:42 +01:00
Marta Bondyra 145c0a5128
Revert "[Lens] (Accessibility) Focus mistakenly stops on righthand form (#84519)" (#84866)
This reverts commit a9845c6fc2.
2020-12-03 14:12:14 +01:00
Marta Bondyra 487eb2e4e4
[Lens] accessibility screen reader issues (#84395)
* [Lens] accessibility screen reader issues

* fix i18n

* fix: no aria-label on divs

* cr fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-03 13:28:41 +01:00
Marta Bondyra 6900ce2b96
[Lens] Provide single-value functions to show the "First" or "Last" value of some field (#83437) 2020-12-02 19:55:58 +01:00
Wylie Conlon c73de26773
[Lens] Refactor function selection invalid state (#84599)
* [Lens] Refactor function selection invalid state

* Fix types per review comment
2020-12-02 11:16:59 -05:00
Marta Bondyra 9d25669db1
[Lens] (Accessibility) Improve landmarks in Lens (#84511) 2020-12-01 15:03:38 +01:00
Marta Bondyra a9845c6fc2
[Lens] (Accessibility) Focus mistakenly stops on righthand form (#84519) 2020-12-01 15:02:59 +01:00
Marta Bondyra f23d2e6ea1
[Lens] (Accessibility) add aria-label to chart type icon (#84493) 2020-11-30 15:45:26 +01:00
Joe Reuter a763d3302f
[Lens] Calculation operations (#83789) 2020-11-25 09:43:23 +01:00
Mikhail Shustov 5ec6fe315f
[DX] Bump TS version to v4.1 (#83397)
* bump version to 4.1.1-rc

* fix code to run kbn bootstrap

* fix errors

* DO NOT MERGE. mute errors and ping teams to fix them

* Address EuiSelectableProps configuration in discover sidebar

* use explicit type for EuiSelectable

* update to ts v4.1.2

* fix ts error in EuiSelectable

* update docs

* update prettier with ts version support

* Revert "update prettier with ts version support"

This reverts commit 3de48db3ec.

* address another new problem

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
2020-11-24 16:04:33 +01:00
Marco Liberati 423888c14e
[Lens] CSV Export for Lens (#83430)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-24 12:37:27 +01:00
Mikhail Shustov 95861a0fb0
[DX] Prettier v2.2 (#83899)
* update prettier with ts version support

* mute type-error

* run prettier on codebase

* fix examples

* fix errors after master merged
2020-11-23 13:17:05 +01:00
Wylie Conlon b50e7ba7da
[Lens] Implement types for reference-based operations (#83603)
* [Lens] Implement types for reference-based operations

* Update from review feedback
2020-11-20 13:42:12 -05:00
Mikhail Shustov 4917df30b9
Update typescript eslint to v4.8 (#83520)
* update deps

* update rules

use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead

* fix or mute all lint errors

* react-hooks eslint plugin fails on ? syntax

* fix wrong typings in viz

* remove React as a global type

* fix eslint errors

* update version to 4.8.1

* fix a new error
2020-11-18 18:23:08 +01:00
Joe Reuter 95e44f25a6
[Lens] Color in dimension trigger (#76871) 2020-11-17 10:19:13 +01:00
Tyler Smalley aba2068291
Consolidates Jest configuration files and scripts (#82671)
Jest tests are currently organized into main configuration files (src/dev/jest/config.js and x-pack/dev-tools/jest/create_jest_config.js). Both of these are similar, but very slightly due to  previously being in separate repositories. This change consolidates the scripts referenced in those configs and moves them to the `@kbn/test` project.

OSS contained an alias for `test_utils`. Those aliases have been removed in favor of importing these utilities from `@kbn/test/jest`

Blocker to #72569

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-11-12 16:19:56 -08:00
Wylie Conlon ccb0b35452
[Lens] Use entire layers, not specific columns (#82550)
* [Lens] Use entire layers, not specific columns

* Fix types

* Move all of state_helpers over

* Fix tests

* Fix crash and add tests to prevent future issues

* Prevent users from dropping duplicate fields

* Respond to review feedback

* Fix review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-10 13:45:46 -05:00
Luke Elmers c6afc47f32
Remove data <--> expressions circular dependencies. (#82685) 2020-11-09 13:01:22 -07:00
Marco Liberati 97e2dc853b
[Lens] Extend Datasource props validation with VisualizationGroups (#82607)
*  First pass with visualization validation + error messages

* 🔥 Remove indexpattern error handling for now

* 🏷️ Fix type issues

*  Add getErrorMessage test for data table

*  Add tests for pie and metric error messages

* 🌐 Fix i18n checks issues

* 🐛 Fix last issue

*  Add more tests for the XY visualization validation code

* 👌 Included all feedback from first review

* ✏️ Off by one message

* 🌐 Fix i18n duplicate id

* 🌐 Fix last i18n issue

* 🐛 Fixed a hook reflow issue

* ♻️+ Reworked validation flow + tests

* 🏷️ Fix type issue

* 🐛 Improved XY corner cases validation logic

* 🐛 Fix empty datatable scenario

*  +  Improved error messages for invalid datasources + tests

* 🌐 Add missing i18n translation

* 🏷️ Fix type issues

* 🌐 Fix i18n issues

*  Filter out suggestions which fail to build

* 🚚 Migrate datatable validation logic to the building phase, handling it as building state

* 🏷️ Fix type issue

* ✏️ Add comment for future enhancements

* ✏️ Updated comment

* :world_with_meridians: Refactor axis labels

* 🌐 Reworked few validation messages

* 🐛 Fix break down validation + percentage charts

*  Align tests with new validation logic

* ♻️ Fix suggestion panel validation to match main panel

* 🌐 Fix i18n issues

* 🔧 Fix some refs for validation checks in suggestions

* 🐛 Fix missing key prop in multiple errors scenario

* 🐛 Fix swtich issue from XY to partition

* 🌐 Fix i18n messages and aligned tests

* 🐛 Fix suggestions switching bug

* :refactor: Add more validation + refactored validation logic in a single place

* ✏️ Add note about lint hooks disable rule

* 🚨 Fix linting issue

* 🏗️ Add infra API for datasource advanced validation

*  Align tests with new API

*  Fix type issues in tests

* 👌 Early exists added

*  Add layers groups to the API

*  Fix some broken test after the validation change

* 👌 Move to disctionary shape

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-09 15:22:21 +01:00
Joe Reuter 651345b18b
[Lens] Expose active data in some places (#79851) 2020-11-06 17:05:34 +01:00
Kim S. Ly 52e8d1459c
[Lens] Remove visible title in workspace panel (#82234) 2020-11-05 14:33:56 +01:00
Marco Liberati 53ea09078f
[Lens] Visualization validation and better error messages (#81439)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-04 18:28:00 +01:00
Joe Reuter fe3b0538ff
[Lens] Categorical color palettes (#75309) 2020-11-04 11:27:52 +01:00
Marta Bondyra 6689167b64
[Lens] Drag within dimension group to reorder (#80547) 2020-11-03 21:18:44 +01:00
Joe Reuter 512c35e70b
fix Lens heading structure (#81752) 2020-10-30 11:20:54 +01:00
Joe Reuter 59662eefd2
[Lens] Add loading indicator during debounce time (#80158) 2020-10-29 16:06:12 +01:00
Joe Reuter cd84ace53d
[Lens] Leverage original http request error (#79831) 2020-10-13 15:17:40 +02:00
Marta Bondyra cded1ce5f1
[Lens] Don't debounce visualization settings UI (#79625)
* perf: don't debounce settings menu

* perf: fix performance for settings
2020-10-07 10:17:17 +02:00
Wylie Conlon 2de2c70f75
[Lens] Break long titles into multiple lines (#79580) 2020-10-06 11:50:44 -04:00
Joe Reuter 11886bf51c
[Lens] Add search to chart switcher (#77631) 2020-10-06 17:17:41 +02:00
Stratoula Kalafateli 08a4586b14
[Lens] Navigate from discover to lens (#77873)
* Create lens action and unregister the visualize one

* remove console

* Implement Discover to Lens, wip, missing tests

* Add unit tests

* fix embed lens to empty dashboard functional tests

* fix suggestions on save

* Fix bug on save button, query and filters should be transferred from discover

* Add functional test for the navigation from Discover to Lens

* PR update after code review

* unregister visualize action only if the action exists

* Change the test to not be flaky

* Move suggestions to editor frame and hide the emptyWorkspace for visualize field

* Update ui actions docs

* Add a retry to remove test flakiness

* Fix bug of infinite loader when removing the y axis dimension

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 11:15:41 +03:00
Marta Bondyra ce97982522
[Lens] refactor DimensionContainer and fix flyout bug (#79277) 2020-10-05 12:41:09 +02:00
Joe Reuter b66de2ce1d
improve lens lazy loading (#79292) 2020-10-02 21:50:25 +02:00
Marta Bondyra fccfad24cb
[Lens] remove test warnings about improper HTML structure (#79251)
* [Lens] remove test warnings about improper HTML structure
2020-10-02 17:18:20 +02:00
Marco Liberati 198c5d9988
[Lens] Fix embeddable title and description for reporting and dashboard tooltip (#78767)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 18:02:37 +02:00
Caroline Horn e248f32111
[Lens] Consistent Drag and Drop styles (#78674)
* Remove wrapping div of DragDrop and pass props to child
* Using EuiHighlight
* Basic styles in for all DnD states
* Fixing dimension button styles
* Fix FieldButton to accept `…rest` props
* A few other minor fixes
* Fixed horizontal scroll of error message
* Quick fix for invalid link
2020-10-01 11:58:23 -04:00
Marta Bondyra 8948811c63
fix: add EuiOutsideClickDetector (#78733)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 12:54:48 +02:00
Joe Reuter dbef60d3f1
[Lens] Reduce initial bundle size (#78142) 2020-09-29 19:00:29 +02:00
Caroline Horn ba635340be
[Lens] Add a better drag/drop illustration (#78245)
Fixes #76021
2020-09-24 09:46:18 -04:00
Devon Thomson 32abbff685
[Time to Visualize] Lens By Value With AttributeService (#77561)
Used the attribute service to make lens work properly with by value embeddables.
2020-09-23 17:40:52 -04:00
Stratoula Kalafateli c4eb47a46b
[Lens] Settings panel redesign and separate settings per y axis (#76373)
* wip, redsign the xy axis general settings

* pie chart settings. fix tests, initial implementation

* Fix Internationalization

* Cleanup

* remove unused translations

* Add test to check that right axis is enabled

* fix test

* remove unecessary translation

* Added icons and cleaned up some of the visuals for grouped buttons

* Fix types

* Axis Settings Popover Reusable Component

* Legend Popover Reusable Component

* Cleanup unused translations

* Fix right axis behavior

* Revert yLeftTitle to yTitle to avoid migration

* PR fixes

* identify which axis is enabled

* Change the logic on enabling the y axes popovers

* Adjust axis popover on horizontal bars

* fix failing test and change the logic of fetching the y axis titles

* Simpify the axis title logic, make the toolbar repsponsive, add TopAxisIcon

* Ui Changes on legends popover

* Cleanup and more unit tests

* use groupId instead of index to take under consideration all possible scenarios

* fix gridlines

* Remove ts-ignore from icons and move toolbar button to shared components

* Workspace toolbar wraps on smaller devices

* Tooltip on Toolbar appears only if the button is disabled

* clean up

* Add missing translations

* fix eslint

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-16 11:30:19 +03:00
Wylie Conlon e9a4555623
[Lens] Remove dynamic names in telemetry fields (#76988)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-15 18:27:39 -04:00
Joe Reuter 63f0cc0519
[Lens] Stack as percentage (#70703) 2020-09-15 11:24:02 +02:00