Commit graph

320 commits

Author SHA1 Message Date
Luke Elmers
7b0ce9615c
Remove data <--> expressions circular dependencies. (#82685) (#83010) 2020-11-09 14:48:28 -07:00
Marco Liberati
773b77ce8f
[7.x] [Lens] Extend Datasource props validation with VisualizationGroups (#82607) (#82958)
*  First pass with visualization validation + error messages

* 🔥 Remove indexpattern error handling for now

* 🏷️ Fix type issues

*  Add getErrorMessage test for data table

*  Add tests for pie and metric error messages

* 🌐 Fix i18n checks issues

* 🐛 Fix last issue

*  Add more tests for the XY visualization validation code

* 👌 Included all feedback from first review

* ✏️ Off by one message

* 🌐 Fix i18n duplicate id

* 🌐 Fix last i18n issue

* 🐛 Fixed a hook reflow issue

* ♻️+ Reworked validation flow + tests

* 🏷️ Fix type issue

* 🐛 Improved XY corner cases validation logic

* 🐛 Fix empty datatable scenario

*  +  Improved error messages for invalid datasources + tests

* 🌐 Add missing i18n translation

* 🏷️ Fix type issues

* 🌐 Fix i18n issues

*  Filter out suggestions which fail to build

* 🚚 Migrate datatable validation logic to the building phase, handling it as building state

* 🏷️ Fix type issue

* ✏️ Add comment for future enhancements

* ✏️ Updated comment

* :world_with_meridians: Refactor axis labels

* 🌐 Reworked few validation messages

* 🐛 Fix break down validation + percentage charts

*  Align tests with new validation logic

* ♻️ Fix suggestion panel validation to match main panel

* 🌐 Fix i18n issues

* 🔧 Fix some refs for validation checks in suggestions

* 🐛 Fix missing key prop in multiple errors scenario

* 🐛 Fix swtich issue from XY to partition

* 🌐 Fix i18n messages and aligned tests

* 🐛 Fix suggestions switching bug

* :refactor: Add more validation + refactored validation logic in a single place

* ✏️ Add note about lint hooks disable rule

* 🚨 Fix linting issue

* 🏗️ Add infra API for datasource advanced validation

*  Align tests with new API

*  Fix type issues in tests

* 👌 Early exists added

*  Add layers groups to the API

*  Fix some broken test after the validation change

* 👌 Move to disctionary shape

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-09 19:16:08 +01:00
Marco Liberati
9af652ec43
[7.x] [Lens] New value labels config option for bar charts (#81776) (#82849)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-09 15:20:54 +01:00
Joe Reuter
e411757b11
[7.x] [Lens] Expose active data in some places (#79851) (#82856) 2020-11-09 14:46:30 +01:00
Joe Reuter
5c0c8bfa2c
[Lens] Implement time scaling function (#82104) (#82854) 2020-11-06 20:11:34 +01:00
Stratoula Kalafateli
73d2de6503
[Visualize] New visualization wizard (#79627) (#82858)
* [Visualizations] New vis wizard

* Update functional tests

* Create oss plugins for maps and lens and unregister alias function

* Add new plugins to .i18nrc.json

* Add readme and codeowners to the new plugins

* update docs

* fix tests

* fix types

* fixes

* Update development docs

* fix oss functional tests

* Fix jest and x-pack functional tests

* Fix functional test

* changes on the layout

* Cleanup and responsiveness

* cleanup unecessary code

* add common folder to the new OSS plugins

* remove unecessary translations

* Update limits.yml file

* Fix basic label

* Add experimental badge on controls vis

* Nice improvements

* fixes

* Improving styles

* Making modal go full height on smaller screens

* Fixing sass lint warning

* fix lint error

* fix internationalization error

* PR fixes

* PR changes

* Use useCallback where possible

* Remove translations that need to be translated again

* Lazy Load wizard modal

* Remove legacyMapVisualizationWarning

* Import the OSS plugins constants from the plugins

* Export constant from lensOss

* Change the new oss plugins from OSS to Oss

* Add a new line to the kibana.json files of the new plugins

* New nit fix

* Fix spaces

* Change the texts for the first step of the modal

* Fix test

* Fixes some of the PR comments

* Add onClick funtionality to the entire aggregation based card

* Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss

* Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled

* fix eslint error

* Change groupTitles and descriptions

* Change input vis description

* Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint

* Make the disabled cards badge clickable

* Changes from code review

* Fix functional tests failures

* Rename groupTitle to titleInWizard to be more specific

* Change vega vis note

* minor design changes

* fix problem with plugins list docs

* Retrieve maps and lens landing page from docs service and add tracking url param

* Fix funtional test for the new dashboard flow

* Fix logic in alias registry for removing the discardOnRegister alias

* no need to remove the alias entry from the discardOnRegister array

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
# Conflicts:
#	.github/CODEOWNERS
#	docs/developer/plugin-list.asciidoc
#	packages/kbn-optimizer/limits.yml
#	x-pack/scripts/functional_tests.js
2020-11-06 20:49:10 +02:00
Wylie Conlon
7552c17763
[Lens] Fix bug in terms formatting (#82776) (#82842) 2020-11-06 11:59:47 -05:00
Marco Liberati
f461df25d7
[7.x] [Lens] Visualization validation and better error messages (#81439) (#82811)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-06 17:09:43 +01:00
Joe Reuter
65286b2b5f
fix underlying data drilldown for Lens (#82737) (#82818) 2020-11-06 14:11:07 +01:00
Devon Thomson
97164a7c00
[Time to Visualize] Embeddable Error Handling Without ReplacePanel (#82201) (#82742)
Fixed embeddable error handling so that fatal errors are caught and displayed with an errorEmbeddable no matter when they occur.
2020-11-05 12:56:49 -05:00
Joe Reuter
ba05688b35
[Lens] Remove visible title in workspace panel (#82234) (#82712) 2020-11-05 16:38:00 +01:00
Joe Reuter
0452f445cb
[Lens] Categorical color palettes (#75309) (#82586) 2020-11-04 14:10:35 +01:00
Marta Bondyra
2103911c6d
[Lens] Drag within dimension group to reorder (#80547) (#82500) 2020-11-04 09:21:54 +01:00
Joe Reuter
b36873cacb
[Lens] Reload on change via history object (#81753) (#82429) 2020-11-03 16:56:29 +01:00
Pierre Gayvallet
d449d8cbdb
[7.x] SavedObjects tagging MVP (#79096) (#82407)
* SavedObjects tagging MVP (#79096)

* create xpack plugin skeleton, start to implement management section

* add tag creation modal

* first implementation of the tags table

* use InMemoryTable

* add edit modal and delete action

* update plugin list

* add tag list, fix types

* add capabilities check on client-side

* add tag combo box component

* add missing i18n keys

* fix privilege FTR tests

* add base structure for FTR tests

* fix feature ftr test

* use string literals for i18n

* create savedObjectsTaggingOss plugin, move API types to oss plugin, start to wire to SO management page.

* update plugin list

* fix types

* allow to use `_find` with multiple references

* add FTR test for _find API on references fields

* add _find integration tests

* update generated doc

* start to implement tag filtering on SO management section

* update generated docs

* wire tagging API to dashboard listing page

* fix i18n namespace

* fix type & tests

* update dashboard listing snapshots

* adapt FTR listingTable service to search for parsable queries

* wite tagging API to visualize listing

* update tagging plugin limits

* add server-side and client-side validation for tag create/edit

* rename title field to name

* fix types

* fix types bis

* add removeReferencesTo API to SOR/SOC

* update generated doc

* add server-side unit test for `savedObjectsTagging` plugin

* move tagging API types to its own file

* add savedObjectsTaggingOss mock

* add tags_cache tests

* add tests for client-side tag client

* extract uiApi to distinct files

* various API improvements

* add more tests

* add link between tag and so management sections + add connection counts

* add base functional test suite for tagging

* add more FTR tests

* improve feature control func test

* update codeowners

* update generated doc

* fix access to proxy modal

* adapt SO save modal to allow to add tag field

* add SO decorator registry and tag implementation

* add unit tests for SO tag decorator

* add functional tests for visualize integration

* add tag SO read permission for vis/dash feature

* add RBAC api integ tests

* add API integration tests

* add test for getTagConnectionsUrl

* add SOM test suite

* add dashboard integration suite

* remove test line

* add missing unit tests

* improve API types doc

* fix create modal save button label

* remove console.log

* improve doc

* self review

* add refresh interval for tag cache

* improve page object doc

* minor cleanup

* address review comments

* small layout fixes

* add initial focus

* use lazy accessor for tag request handler context

* adapt SOM export and export route to handle references

* remove icon from feature config due to master changes

* fix SO table tests

* update generated docs

* sort tags by name in filter dropdown and listing component

* wire SO tagging to dashboard save modal

* fix types

* - add 'create tag' action in tag selector
- add notifications on update/create/delete from management
- delete modal wording

* add description max length validation

* remove real-time validation

* fix i18n bundle id

* update expected size of savedObjectsTagging plugin

* use own useIfMounted

* update limit again, contract components cannot be lazy loaded atm.

* math is hard

* remove single usage of lodash for bundle size

* add async imports for create/edit modal

* add FTR test for 'create tag' action from tag selector

* allow 'create new' option to prepopulate name field

* extract savedObjectToTag

* add advancedSettings read user for security api_integ suite

* add audit login for security client wrapper

* use import type when possible

* wire SO tagging to lens visualization

* fix lens jest test

* Fix `create tag` option being selected when closing the selector dropdown

* add sorting to tag column from getTableColumnDef

* address some of restrry comments

* rename tag selector's setSelected option to onTagsSelected

* fix audit logging even type for saved_object_remove_references

* update plugin size limit to current size

* adapt maxlength validation wording

* remove selection column until we have batch action menu

* remove connections link when user lack read privilege to savedObjectManagement

* forbid registering multiple SO decorators with the same priority

* add so decorator test

* extract getTagFindReferences and create API mock

* update audit-logging ascidoc

* doc nit

* throw conflict error if update returns any failure

* use refresh=true as default

* wording nits

* export: rename `references` to `hasReference`

* update generated doc

* set description max length to 100

* do not initialize tag cache on anonymous pages

* split fetchObjectsToExport into two distinct functions

* change tag client `delete` call order

* tsdoc nits

* more nits

* add README for oss plugin

* add oss plugin start tests

* SavedObject.find: rename `references` to `hasReference`

* change section description label

* remove url prefix constants

* last nits and comments

* update generated doc
# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-optimizer/limits.yml
#	x-pack/scripts/functional_tests.js

* fix FTR mapping files for 7.x
2020-11-03 14:35:43 +01:00
Marta Bondyra
b3ff73ea6d
[Lens] Fix console error by passing I18nProvider to metric vis (#82282) (#82337)
* [Lens] Fix console error by passing I18nProvider to metric vis

* Update expression.tsx
2020-11-03 10:01:30 +01:00
Nathan Reese
fcc12a609a
[lens] fix unhandled promise rejection when saving Lens with duplicate title (#82195) (#82342)
* [lens] fix unhandled promise rejection when saving Lens with duplicate title

* more clean up

* restore getDisplayName, used by return of checkForDuplicateTitle

* fix jest test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-02 13:20:28 -07:00
Devon Thomson
fc4a04bf61
[Time to Visualize] Small Attribute Service Fixes (#82072) (#82316)
* Removed some dashboard-centric wording from the Attribute Service & removed type argument from save method
2020-11-02 13:28:50 -05:00
Thomas Watson
df4f66b4ac
[7.x] Upgrade to hapi version 18 (#80468) (#82265) 2020-11-02 15:49:43 +01:00
Greg Thompson
df1f03155c
Upgrade EUI to v30.1.1 (#81499) (#82210)
* eui to v30.0.0

* removed unused RecentLinks component

* update compressed -> display prop

* euiformrow compressed -> display

* euipopover remove withtitle

* euibuttongroup prop updates

* remove euibuttontoggle

* src snapshot updates

* tutorial euibuttongroup update

* x-pack snapshot updates

* euibuttongroup test updates

* TODO

* misc. js file updates

* remove euinavdrawer scss references

* translation removals

* more x-pack snapshot updates

* update data-test-subj lookup

* icons logoAMP -> logoObservability

* cypress selector updates

* update euibuttontoggle onchange, test interaction

* Fix auto-update toggle in Visualize

* some more change -> click test updates

* idtoselectedmap change

* Fix feature table button group

* Remove empty SASS file

* Fix feature table button group II

* Using `compressed` to also dictate dual range row

* Fix a few security labels

* An ML fix

* Apply suggestions from code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* remove unused translation

* update view_type_toggle snapshot

* more snapshot updates

* eui to 30.1.0

* undo temp ts-ignore

* more x-pack snapshot updates

* eui to 30.1.1

* update feature privilege text

* Update x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/sub_feature_form.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* reuse i18n token

* Adapt log entry action button to new `minWidth` prop

* clean up label

* Combine auto apply strings into one

* ternary fix

* cases status useCallback

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
2020-10-30 18:21:00 -06:00
Joe Reuter
ed03cb5907
fix Lens heading structure (#81752) (#82112) 2020-10-30 14:04:04 +01:00
Anton Dosov
ae055722b3
[Search] Use session service on a dashboard (#81297) (#82036) 2020-10-30 11:42:10 +01:00
Michael Marcialis
195b1cf5c7
[Lens] Adjust Lens Visualization Padding in Dashboards (#81911) (#82079)
* reduce padding on lens visualizations in dashboard

* tweak padding and axes title colors to match lens

* remove faux padding (border) to match lens padding

* update snapshots

* Revert "update snapshots"

This reverts commit c63cf2bf1c.

* update functional test baseline screenshot
2020-10-29 18:47:24 -04:00
Wylie Conlon
df94673a78
[Lens] Stop using multi-level metrics in Lens pie charts (#81523) (#82024)
* [Lens] Stop using multi-level metrics in Lens

* Fix linting

* Simplify even more
2020-10-29 15:33:28 -04:00
Joe Reuter
253a6b4a89
[Lens] Add loading indicator during debounce time (#80158) (#82028) 2020-10-29 17:42:16 +01:00
Marco Liberati
06278dcdec
[7.x] [Lens] Improved range formatter (#80132) (#81826)
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-10-28 12:23:31 +01:00
Joe Reuter
d16d005582
Log reason for 404 in field existence check (#81315) (#81743) 2020-10-28 10:11:37 +01:00
Joe Reuter
7f27785fbf
[Lens] Fix URL query loss on redirect (#81475) (#81744) 2020-10-27 14:30:27 +01:00
Joe Reuter
57c31e8cd3
fix flaky unit test (#81466) (#81496) 2020-10-22 18:58:28 +02:00
Stratoula Kalafateli
9b85df05c4
[Lens] Rename X/Y axis to horizontal/vertical (#80991) (#81459)
* [Lens] Rename x/y axis to horizontal/vertical ones

* Change configuratio

* Add unit tests to cover the change

* Change texts to follow EUI guidelines

* Fix the translations ids

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-22 14:51:22 +03:00
Gidi Meir Morris
831dbf9068
[Task Manager] Cleans up legacy plugin structure (#80381) (#81139)
This PR addresses a list of legacy code debt the plugin has incurred over the past year due to extensive changes in its internals and the adoption of the Kibana Platform.

It includes:
1. The `TaskManager` class has been split into several independent components: `TaskTypeDictionary`,  `TaskPollingLifecycle`,  `TaskScheduling`,  `Middleware`. This has made it easier to understand the roles of the different parts and makes it easier to plug them into the observability work.
2. The exposed `mocks` have been corrected to correctly express the Kibana Platform api
3. The lifecycle has been corrected to remove the need for  intermediary streames/promises which we're needed when we first introduced the `setup`/`start` lifecycle to support legacy.
4. The Logger mocks have been replaced with the platform's `coreMocks` implementation
5. The integration tests now test the plugin's actual public api (instead of the internals).
6. The Legacy Elasticsearch client has been replaced with the typed client in response to the deprecation notice.
7. Typing has been narrowed to prevent the `type` field from conflicting with the key in the `TaskDictionary`. This could have caused the displayed `type` on a task to differ from the `type` used in the Dictionary itself (this broke a test during refactoring and could have caused a bug in production code if left).
2020-10-20 15:56:49 +01:00
Marco Liberati
421fe04983
[7.x] [Lens] Remove Over time suggestions for numeric intervals (#78442) (#81117)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-20 15:55:39 +02:00
Joe Reuter
1bf85f314f
[Lens] Add toast notification when visualization is saved (#80788) (#81136) 2020-10-20 15:20:40 +02:00
Joe Reuter
ac0766153f
[Lens] Lazy load lens telementry and attribute service (#80479) (#81008) 2020-10-20 09:04:57 +02:00
Wylie Conlon
066fa9cb9c
[Lens] Split up dimension panel code (#80423) (#81030)
* [Lens] Split up dimension panel code

* Fix test failures

* Style updates

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-19 15:38:26 -04:00
Peter Pisljar
d25c84f6f4
removing kibana_datatable in favor of datatable (#80548) (#80875) 2020-10-16 20:59:39 +02:00
Joe Reuter
ee1ef74cd5
[Lens] Add median operation (#79453) (#80837) 2020-10-16 18:26:05 +02:00
Joe Reuter
1facf63c7d
[Lens] Custom labels for ranges (#79628) (#80497) 2020-10-14 16:04:09 +02:00
Joe Reuter
246edf8fcc
respect requested sub vis type for xy charts (#80297) (#80461) 2020-10-14 11:43:24 +02:00
Joe Reuter
40b990c8eb
[Lens] Leverage original http request error (#79831) (#80339) 2020-10-13 16:51:22 +02:00
Maja Grubic
cc3b7b2bae
[Refactor] Move AttributeService from Dashboard to Embeddable plugin (#79830) (#80177)
* [Refactor] Move AttributeService from Dashboard to Embeddable plugin

* Fix wrong import

* Fixing typescript errors

* Make Dashboard a required dependency

* Fixing circular dependency

* Fix label namespace

* Updating docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.embeddablestart.md
#	docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.md
#	docs/development/plugins/embeddable/server/kibana-plugin-plugins-embeddable-server.embeddablesetup.md
#	src/plugins/embeddable/public/public.api.md
#	src/plugins/embeddable/server/server.api.md
2020-10-13 15:24:03 +01:00
Marta Bondyra
abb5c7463b
[Lens] fix empty callout for empty/meta fields accordion (#79429) (#79970) 2020-10-09 10:43:55 +02:00
Marco Liberati
67302d46db
[7.x] [Lens] Fix for Percentage and Metric suggestions/visualizations on 0 or empty vlaues (#79309) (#79826)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-07 18:31:32 +02:00
Marta Bondyra
5263295600
[Lens] Don't debounce visualization settings UI (#79625) (#79821)
* perf: don't debounce settings menu

* perf: fix performance for settings
2020-10-07 13:42:53 +02:00
Marta Bondyra
8a197916c4
[Lens] Improve unclear UI for bucket aggregation grouping order (#77331) (#79825) 2020-10-07 13:42:40 +02:00
Joe Reuter
eccf8a84bc
[Lens] Make histogram brushing possible (#79435) (#79823) 2020-10-07 12:02:42 +02:00
Joe Reuter
deb61f6a8c
[Lens] Add search to chart switcher (#77631) (#79709) 2020-10-06 22:39:44 +02:00
Wylie Conlon
8eb546c9fe
[Lens] Break long titles into multiple lines (#79580) (#79693) 2020-10-06 13:57:02 -04:00
Maja Grubic
5d33f62aae
Refactor attribute service (#78414) (#79621)
* Making saveMethod mandatory in attribute service

* Making unwrap method mandatory

* Making book embeddable respect new attribute service

* Remove savedObjectsClient from attribute service

* Add checkForDuplicateTitle method to book embeddable

* Make options mandatory on attribute service

* Changing Lens attribute service

* Somw more typescript fixes

* Fixing attribute service typescript and tests

* Fixing typescript errors

* Unsetting feature flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 14:53:09 +01:00
Marco Liberati
12f4eea96c
[7.x] [Lens] Fix open custom ranges saved issue (#78915) (#79319)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 12:38:53 +02:00
Stratoula Kalafateli
3144c0551b
[Lens] Navigate from discover to lens (#77873) (#79626)
* Create lens action and unregister the visualize one

* remove console

* Implement Discover to Lens, wip, missing tests

* Add unit tests

* fix embed lens to empty dashboard functional tests

* fix suggestions on save

* Fix bug on save button, query and filters should be transferred from discover

* Add functional test for the navigation from Discover to Lens

* PR update after code review

* unregister visualize action only if the action exists

* Change the test to not be flaky

* Move suggestions to editor frame and hide the emptyWorkspace for visualize field

* Update ui actions docs

* Add a retry to remove test flakiness

* Fix bug of infinite loader when removing the y axis dimension

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.actioncontextmapping.md
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.md
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.addtriggeraction.md
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.getaction.md
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.gettriggeractions.md
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.gettriggercompatibleactions.md
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.md
#	docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.registeraction.md
#	src/plugins/ui_actions/public/public.api.md
2020-10-06 13:08:17 +03:00
Wylie Conlon
2ee141508a
[7.x] [Lens] Show runtime fields in field list and improve performance (#79167) (#79340)
* [Lens] Show runtime fields in field list and improve performance (#79167)

* [Lens] Simplify request to determine existing fields

* Remove duplicate values
# Conflicts:
#	x-pack/test/api_integration/apis/lens/existing_fields.ts

* Fix merge issue

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 13:59:32 -04:00
Marta Bondyra
d02e3a9634
[Lens] refactor DimensionContainer and fix flyout bug (#79277) (#79430) 2020-10-05 15:10:15 +02:00
Joe Reuter
a91638c71c
improve lens lazy loading (#79292) (#79416) 2020-10-05 11:36:02 +02:00
Marco Vettorello
cc0034ec86
upgrade @elastic/charts to v23.0.0 (#79226) (#79331)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-02 22:39:06 +02:00
Ryan Keairns
a39449f4f2
Re-style and re-order top menu buttons (#79206) (#79320)
* Re-style and re-order top menu buttons

* Update snapshot due to removed fill prop

* Fix link order for Maps
2020-10-02 13:21:56 -05:00
Marta Bondyra
0ac5e78024
[Lens] remove test warnings about improper HTML structure (#79251) (#79306)
* [Lens] remove test warnings about improper HTML structure
2020-10-02 20:01:17 +02:00
Joe Reuter
6959555e1a
[Lens]Do not enable histogram mode for multiple un-stacked bar series (#78525) (#79269) 2020-10-02 14:57:32 +02:00
Marco Liberati
27c412bc62
[7.x] [Lens] Fix embeddable title and description for reporting and dashboard tooltip (#78767) (#79164)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-02 12:22:38 +02:00
Caroline Horn
3b07e1187a
[Lens] Consistent Drag and Drop styles (#78674) (#79153)
* Remove wrapping div of DragDrop and pass props to child
* Using EuiHighlight
* Basic styles in for all DnD states
* Fixing dimension button styles
* Fix FieldButton to accept `…rest` props
* A few other minor fixes
* Fixed horizontal scroll of error message
* Quick fix for invalid link
2020-10-01 14:47:55 -04:00
Marco Liberati
a41739e150
[7.x] [Lens] Histogram/range operation new copy (#78328) (#79118)
* 💬 New copy revision for histogram/range operation in lens

* 👌 Updated panel copy

* 👌 Change copy based on feedback
2020-10-01 18:40:18 +02:00
Joe Reuter
a93a323f4f
[Lens] Handle missing fields gracefully (#78173) (#79102) 2020-10-01 15:42:43 +02:00
Marta Bondyra
827b4a53ab
[Lens] Don't allow values outside of range for number of top values (#78734) (#79094) 2020-10-01 14:40:43 +02:00
Marta Bondyra
90d9334256
fix: add EuiOutsideClickDetector (#78733) (#79095)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 14:40:31 +02:00
Marta Bondyra
c32c84d679
[Lens] fix wrong message in fields accordion (#78924) (#79074) 2020-10-01 12:55:02 +02:00
Alejandro Fernández Haro
dc658d6f4e
[7.x] [Task names in TaskManager] Rename "telemetry" to "usage" (#78129) (#79069)
* [Task names in TaskManager] Rename "telemetry" to "usage"

* Revert task IDs but leaving renamed titles

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 10:54:23 +01:00
Alejandro Fernández Haro
b910b84718
[7.x] [Loggers] Rename "telemetry" to "usage" (#78130) (#79068)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 10:54:12 +01:00
Wylie Conlon
ba9a18b4b8
[Lens] Stop using scripted metric to collect telemetry (#78687) (#78995) 2020-09-30 14:39:05 -04:00
Wylie Conlon
ade7b73f5e
[Lens] Maintain order of operations in dimension panel (#78864) (#78972) 2020-09-30 13:16:58 -04:00
Joe Reuter
dbb9982405
[Lens] Reduce initial bundle size (#78142) (#78823) 2020-09-30 09:45:29 +02:00
Wylie Conlon
8f456babbe
[Lens] Fieldless operations (#78080) (#78620)
* [Lens] Fieldless operations

* Overhaul types

* Fix invalid state and add tests

* Fix types

* Small cleanup

* Add additional error message

* Reset field selector to empty state when invalid

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-28 12:57:46 -04:00
Caroline Horn
a6eed6e7dc
[Lens] Add a better drag/drop illustration (#78245) (#78425)
Fixes #76021
2020-09-24 11:25:41 -04:00
Alejandro Fernández Haro
0b62537f2f
[7.x] [Usage Collection] [schema] lens (#77929) (#78401)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-24 14:05:08 +01:00
Joe Reuter
6a3ba80309
[7.x] [Lens] show meta field data in Lens (#77210) (#78388) 2020-09-24 13:35:33 +02:00
Joe Reuter
d8a56f8547
[Lens] Add search provider for global search (#77448) (#78312) 2020-09-24 08:53:38 +02:00
Devon Thomson
47ed81fa31
[Time to Visualize] Lens By Value With AttributeService (#77561) (#78358)
Used the attribute service to make lens work properly with by value embeddables.
2020-09-23 19:17:50 -04:00
Marco Liberati
b71228cdea
[7.x] [Lens] Combined histogram/range aggregation for numbers (#76121) (#78287)
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-09-23 19:49:21 +02:00
Alejandro Fernández Haro
d02d08a4ba
[7.x] [Lens] Rename "telemetry" to "stats" (#78125) (#78275) 2020-09-23 15:42:18 +01:00
Marta Bondyra
7fe28c5884
[Lens] adding some functional tests (#77863) (#77932) 2020-09-18 21:37:24 +02:00
Marta Bondyra
668316bb95
[Lens] change name of custom query to filters (#77725) (#77845) 2020-09-18 13:23:34 +02:00
Stratoula Kalafateli
1567be984d
Aligns the y axis settings on horizontal mode (#77585) (#77781) 2020-09-18 08:58:04 +03:00
Wylie Conlon
52d580cb06
[Lens] Remove dynamic names in telemetry fields (#76988) (#77558)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-16 11:07:00 -04:00
Marta Bondyra
cde6be3a11
[Lens] create reusable component for filters and range aggregation (#77453) (#77592) 2020-09-16 13:49:23 +02:00
Stratoula Kalafateli
ab9c23e0fa
[Lens] Settings panel redesign and separate settings per y axis (#76373) (#77580)
* wip, redsign the xy axis general settings

* pie chart settings. fix tests, initial implementation

* Fix Internationalization

* Cleanup

* remove unused translations

* Add test to check that right axis is enabled

* fix test

* remove unecessary translation

* Added icons and cleaned up some of the visuals for grouped buttons

* Fix types

* Axis Settings Popover Reusable Component

* Legend Popover Reusable Component

* Cleanup unused translations

* Fix right axis behavior

* Revert yLeftTitle to yTitle to avoid migration

* PR fixes

* identify which axis is enabled

* Change the logic on enabling the y axes popovers

* Adjust axis popover on horizontal bars

* fix failing test and change the logic of fetching the y axis titles

* Simpify the axis title logic, make the toolbar repsponsive, add TopAxisIcon

* Ui Changes on legends popover

* Cleanup and more unit tests

* use groupId instead of index to take under consideration all possible scenarios

* fix gridlines

* Remove ts-ignore from icons and move toolbar button to shared components

* Workspace toolbar wraps on smaller devices

* Tooltip on Toolbar appears only if the button is disabled

* clean up

* Add missing translations

* fix eslint

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-16 13:22:04 +03:00
Michail Yasonik
1868e6ba9c
[7.x] Stacked headers and navigational search (#72331) (#77407)
Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-09-15 11:37:16 -05:00
Caroline Horn
2d4cdcfa35
[Lens] Move configuration popover to flyout (#76046) (#77487)
* Moving to a Flyout implementation
* Fix up inner layout of flyout
* Fix up form rows
2020-09-15 11:53:05 -04:00
Joe Reuter
90652421aa
[Lens] Stack as percentage (#70703) (#77455) 2020-09-15 13:32:02 +02:00
Devon Thomson
1cb09d4936
Add Lens to Recently Accessed (#77249) (#77382)
added lens to recently accessed on load and save in app.tsx
2020-09-14 15:38:47 -04:00
Marta Bondyra
4bcb2ba1a4
[Lens] fix performance on pie settings slider (#77181) (#77305) 2020-09-14 13:48:20 +02:00
Joe Reuter
c9b2897953
Separate url forwarding logic and legacy services (#76892) (#77302) 2020-09-14 12:47:02 +02:00
Marta Bondyra
6a91490854
[Lens] Filters aggregation (#75635) (#77242) 2020-09-10 23:15:38 +02:00
Wylie Conlon
78e2ed1ac7
[Lens] Show field stats for IP fields and scripted fields (#76457) (#76987)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-08 19:14:39 -04:00
Marta Bondyra
93abd2e818
[Lens] Update grouping editor to indicate the expected result of a grouping change (#76904) (#76955) 2020-09-08 19:41:16 +02:00
Wylie Conlon
fc27aee2d3
[Lens] Drag dimension to replace (#75895) (#76776)
* [Lens] Drag to replace

* Add jest tests for drag and drop

* Fix bug in dragging to empty

* Hide dragged dimension when drag starts

* Make table metrics required

* Update class names

* Implement styles on non-droppable items

* Replace drag and drop image in docs

* Remove extra specificity

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-04 12:15:37 -04:00
Greg Thompson
60c2737155
Upgrade EUI to v28.2.0 (#75700) (#76313)
* eui to v28.0.0

* eui to 28.2.0

* euiselectableoptions type update

* targeted nohoist

* src snapshot updates

* x-pack snapshot updates

* strong -> mark

* upgrade @elastic/charts to v21.0.1

* strong -> mark

* fix charts version merge

* maps -> add_field_tooltip_popover type update

* snapshot update

* Fix gridline visibility

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>

Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>

Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
2020-08-31 13:28:43 -06:00
Wylie Conlon
2ba73acbd7
[Lens] Decouple visualizations from specific operations (#75703) (#76111)
* [Lens] Decouple visualizations from specific operations

* Remove unused mock
2020-08-27 14:08:36 -04:00
Marta Bondyra
c40d295088
[Lens] fix dimension popover design on mobile (#75866) (#75947) 2020-08-26 13:40:21 +02:00
Marta Bondyra
0a1023ce20
[Lens] Fix rollup related bugs (#75314) (#75949)
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-08-26 13:40:06 +02:00
Marta Bondyra
1cae7b3cb7
[Lens] Show 'No data for this field' for empty field in accordion (#73772) (#75687)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-25 11:12:14 +02:00
Devon Thomson
f4b5c30b43
Updated and unskipped lens breadcrumb test after #74523 (#75714) (#75792) 2020-08-24 18:04:43 -04:00
Wylie Conlon
0ec0d7e36e
[Lens] Remove beta labels (#75574) (#75776)
* [Lens] Remove beta labels

* Remove translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-24 14:03:06 -04:00
Brian Seeders
4898c7e5f1
Skip failing lens test 2020-08-21 15:10:45 -04:00
Joe Reuter
4dde848aac
[Lens] Register saved object references (#74523) (#75668) 2020-08-21 20:14:53 +02:00
Devon Thomson
9ba8942c2c
[Dashboard First] Lens Originating App Breadcrumb (#75470) (#75657)
Changed lens breadcrumbs to reflect the Originating App
2020-08-21 12:20:31 -04:00
Devon Thomson
d57460d521
[Dashboard First] Use App Title for Display Instead of App Id (#75457) (#75580)
Created app title fetch method in embeddable_state_transfer. Used it instead of the raw app id in a number of places.
2020-08-21 09:55:41 -04:00
Marta Bondyra
060f627179
[Lens] Use index pattern service instead saved object client (#74654) (#75631) 2020-08-21 14:54:43 +02:00
Matthias Wilhelm
4cbf55c67b
[Discover] Create field_button and add popovers to sidebar (#73226) (#75389)
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-08-19 09:48:35 +02:00
Marta Bondyra
afec96e2c7
[Lens] Fix crash when two layers xychart switches to pie (#75267) (#75282)
* [Lens] fix crash on two layers and add a functional test with two layers switching to pie chart
2020-08-18 18:23:34 +02:00
Greg Thompson
2e5e06bad6
Upgrade EUI to v27.4.0 (#74004) (#75064)
* eui to 27.1.0

* eui to 27.2.0

* buttoniconside type

* euiselectable type

* update onScroll callback and polyfill size references

* findTestSubject ts

* buttoncontent and collapsiblenav src snapshot updates

* update prop retrieval

* xpack snapshots

* jest updates

* type fixes

* more snapshots

* virtual list changes

* more virtualization changes

* merge

* fix functional tests

* data-test-subj for indexPatter-switcher

* storyshots

* eui to 27.3.1

* Fix unit tests

* Fix broken unit test

* Updated snapshots

* Fixed types

* search for value in euiselectable before selection

* select the correct element

* mock virtualized dep

* ts fix

* reinstate storyshot

* ts fix

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 17:55:16 -06:00
Wylie Conlon
a5124c49a0
[Lens] Fix table sorting bug (#74902) (#75047)
* [Lens] Fix table sorting bug

* Fix types
2020-08-14 13:19:47 -04:00
Luke Elmers
3b60fe1136
Make data.search.aggs available on the server. (#74472) (#74990) 2020-08-13 15:21:25 -06:00
Stratoula Kalafateli
5308ba1201
[Lens] Add styling options for x and y axes on the settings popover (#71829) (#74782)
* [Lens] Add styling options for x axis on the settings popover

* ts related changes

* Changes to the popover's design and y-axis implementatin

* fix types and add unit tests

* Add extra translations

* Fix functional test and change the logic of the yTitle

* fixes

* fix showTitle settings bug

* Fix ticklabels bug on y axes

* fix some tests

* Change the user flow on x and y titles on settings popover and enable the gridlines by default

* disable linter warning

* PR Comments

* Add a comment to callback to explain the decision to listen only to open changes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-12 08:55:17 +03:00
Joe Reuter
9a7207f846
[Lens] Clear out all attribute properties before updating (#74483) (#74652) 2020-08-10 16:54:27 +02:00
Anton Dosov
e0efd61e08
Improve state sync error handling (#74264) (#74524)
Fixes #71461 regression since 7.7

New state syncing utils didn't properly handle errors,
Errors happening during URL parsing or writing wasn't handled, so state syncing could stop or in worth case blow out. (see #71461)

There are not much scenarios where missing proper error handling could really impact users, except the one described in #71461:

Kibana users state:storeInSessionStorage
Users often intuitively share hashed dashboard urls directly
When someone opens those urls - there is a blank screen with warning
In 7.6 - dashboard would still load with default state.
Since 7.7 these still could be achieved by removing query params for URL, but it is not obvious for regular users.

This PR makes sure that behaviour is similar to one we had before 7.7.


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-10 10:56:03 +02:00
Marta Bondyra
7dd1ee6667
[Lens] Add functional tests on chart transitions and pie chart (#74083) (#74565) 2020-08-07 09:29:28 +02:00
Devon Thomson
3f52764bb3
[Fix] Lose OriginatingApp Connection on Save After Create new (#74420) (#74569)
Fixed typo created in #72725 which caused the originatingApp connection not to be lost properly after Create new
2020-08-06 15:46:48 -04:00
Joe Reuter
cab674e73c
[Lens] Document UI terminology (#72423) (#74503) 2020-08-06 16:52:43 +02:00
Marta Bondyra
b3ddbc5610
[Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (#70010) (#74481) 2020-08-06 12:13:48 +02:00
Marta Bondyra
4182fbd256
[Lens] fix chart switching when on VisualizationDimensionEditor (#70689) (#74382) 2020-08-06 09:34:13 +02:00
Mikhail Shustov
b2040a5a1b
[7.x] Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091) (#74384)
* Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)

* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
# Conflicts:
#	src/legacy/ui/public/new_platform/new_platform.ts
#	x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx

* remove unnecessary comment
2020-08-05 21:45:29 +02:00
Luke Elmers
87cfa3f620
Migrate timepicker:timeDefaults ui setting to the data plugin. (#73750) (#74315) 2020-08-05 08:20:22 -06:00
Marta Bondyra
2abf2568da
fix: pinned filters not applied (#73825) (#73979) 2020-07-31 21:45:21 +02:00
Liza Katz
25ceed986b
[7.x] [Data] Query Input String manager (#72093) (#73634)
* [Data] Query Input String manager (#72093)

* improve test stability

* query string input manager (needed for search demo)

* docs

* dashboard

* Fix jest

* mock fix

* Allow restoring a saved query

* sync url

* Luke's fix to test

* cleanup

* lens jest tests

* docs

* use queryStringManager.getDefaultQuery
Don't sync query to global state

* Update app.test.tsx

lens mock

* jest fix

* jest

* use new api in the example

* Rename state param to query to match url state

* Apply changes to discover

* Update src/plugins/data/public/query/query_string/index.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Improve query string state manager

* Cleanup dashboard code

* Handle refresh button

* Set initial dashboard state

* visualize state

* remove unused

* docs

* fix example

* fix jest

* fix filter app state in discover

* fix maps test

* jest

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/public/public.api.md

* docs
2020-07-29 13:47:55 +03:00
Devon Thomson
5fc80b4fc6
[Fix] Lose OriginatingApp Connection on Save As (#72725) (#73089)
Reset originatingApp in lens and visualize when return to dashboard on saving is false
2020-07-23 14:04:47 -04:00
Joe Reuter
7d9ebe028b
fix bug (#72809) (#73003) 2020-07-23 11:26:34 +02:00
Joe Reuter
6c7b9148c0
[Lens] Legend config (#70619) (#72821) 2020-07-22 14:13:19 +02:00
Devon Thomson
f8dd610924
Applying tiny fix from 72532 to main branch (#72533) (#72676) 2020-07-21 13:29:52 -04:00
Tim Roes
5cb778c682
Disable indexing of unnecessary Saved Object fields (#70409) (#72409)
* Disable indexing of unnecessary SO fields

* Add doc_values

* Add no doc_values to discover saved object

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 15:00:11 +02:00
Wylie Conlon
b6235ecd3f
[Lens] Fix switching with layers (#71982) (#72326)
* [Lens] Fix chart switching with multiple layers

* Unskip Lens smokescreen test

* Fix types

* Revert <p> change
2020-07-17 15:50:16 -04:00
Wylie Conlon
05dc674e3c
[Lens] Unskip Lens smokescreen test (#71986) (#72083) 2020-07-16 15:24:42 -04:00
Joe Reuter
907e43bf1d
[Lens] Handle failing existence check (#70718) (#72009) 2020-07-16 11:34:31 +02:00
Marta Bondyra
9f8b365ed7
[Lens] XY chart -long legend overflows chart in editor Feature:Lens (#70702) (#71752) 2020-07-15 12:11:54 +02:00
Caroline Horn
f74340f6ab
[Lens] 7.9 design cleanup (#71444) (#71573)
* Fix dimension popover layout and color picker “Auto”

* Created ToolbarButton

* Move disabled help text to tooltip for missing values

* Darker side panel backgrounds

* Adding to .asciidoc about where to put the SASS import

* Moving `SASS` guidelines to STYLEGUIDE.md

* Fix keyboard focus of XY settings popover

* Fix dark mode
2020-07-14 09:31:33 -04:00
Joe Reuter
4e7f4c5ad8
fix overflow (#70723) (#71437) 2020-07-13 16:51:21 +02:00
spalger
e535aa6446 Revert "Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911) (#71355)" (#71382)"
This reverts commit c45fa3dd58.
2020-07-10 20:13:28 -07:00
Brian Seeders
c45fa3dd58
Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911) (#71355)" (#71382)
This reverts commit 243a864359.
2020-07-10 23:07:01 -04:00
Spencer
243a864359
[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911) (#71355)
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
#	src/plugins/embeddable/kibana.json
#	src/plugins/telemetry/kibana.json
#	src/plugins/ui_actions/kibana.json
#	x-pack/plugins/apm/kibana.json
#	x-pack/plugins/upgrade_assistant/kibana.json
2020-07-10 09:37:22 -07:00
Joe Reuter
bee259b1a9
mitigate kql bug (#70712) (#71222) 2020-07-09 17:37:12 +02:00
Joe Reuter
a5518e0da3
[Lens] Fitting functions (#69820) (#70767) 2020-07-06 13:48:11 +02:00
Joe Reuter
2c0651e6d8
[Lens] Add ability to set colors for y-axis series (#70311) (#70719) 2020-07-03 18:37:16 +02:00
Tiago Costa
7759b924fc
[7.x] chore(NA): upgrade to lodash@4 (#69868) (#70683)
* chore(NA): upgrade to lodash@4 (#69868)

* chore(NA): upgrade oss to lodash4

chore(NA): migrate cli, cli_plugin, cli_keystore,  dev, test_utils and apm src script to lodash4

chore(NA): missing file for cli plugin

chore(NA): add src core

chore(NA): es archiver and fixtures

chore(NA): try to fix functional test failure

chore(NA): migrate src/legacy entirely to lodash4 except src/legacy/core_plugins

chore(NA): move legacy core plugins to lodash4

chore(NA): upgrade optimize to lodash4

chore(NA): upgrade to lodash4 on advanced_settings, charts, console and dashboard

chore(NA): migrate to lodash4 on dev_tools, discover, embeddable, es_ui)shared, expressions, home plugins

chore(NA): upgrade data plugin to lodash4

chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4

chore(NA): missing data upgrades to lodash4

Revert "chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4"

This reverts commit 137055c5fed2fc52bb26547e0bc1ad2e3d4fe309.

Revert "Revert "chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4""

This reverts commit f7e73688782998513d9fb6d7e8f0765e9beb28d1.

Revert "chore(NA): missing data upgrades to lodash4"

This reverts commit 92b85bf947a89bfc70cc4052738a6b2128ffb076.

Revert "chore(NA): upgrade data plugin to lodash4"

This reverts commit 88fdb075ee1e26c4ac979b6681d8a2b002df74c6.

chore(NA): upgrade idx_pattern_mgt, input_control_vis, inspector, kbn_legacy, kbn_react, kbn_usage_collections, kbn_utils, management and maps_legacy to lodash4

chore(NA): map src plugin data to lodash3

chore(NA): missing lodash.clonedeep dep

chore(NA): change packages kbn-config-schema deps

chore(NA): update renovate config

chore(NA): upgrade vis_type plugins to lodash4

chore(NA): move vis_type_vislib to lodash3

chore(NA): update visualizations and visualize to lodash4

chore(NA): remove lodash 3 types from src and move test to lodash4

chore(NA): move home, usage_collection and management to lodash 3

Revert "chore(NA): move home, usage_collection and management to lodash 3"

This reverts commit f86e8585f02d21550746569af54215b076a79a3d.

chore(NA): move kibana_legacy, saved_objects saved_objects_management into lodash3

chore(NA): update x-pack test to mock lodash4

Revert "chore(NA): move kibana_legacy, saved_objects saved_objects_management into lodash3"

This reverts commit 2d10fe450533e1b36db21d99cfae3ce996a244e0.

* chore(NA): move x-pack and packages to lodash 4

* chore(NA): remove mention to lodash from main package.json

* chore(NA): remove helper alias for lodash4 and make it the default lodash

* chore(NA): fix last failing types in the repo

* chore(NA): fix public api

* chore(NA): fix types for agg_row.tsx

* chore(NA): fix increment of optimizer modules in the rollup plugin

* chore(NA): migrate `src/core/public/http/fetch.ts` (#5)

* omit undefined query props

* just remove merge usage

* fix types

* chore(NA): fixes for feedback from apm team

* chore(NA): recover old behaviour on apm LoadingIndeicatorContext.tsx

* chore(NA): fixes for feedback from watson

* Platform lodash4 tweaks (#6)

* chore(NA): fix types and behaviour on src/core/server/elasticsearch/errors.ts

* Canvas fixes for lodash upgrade

* [APM] Adds unit test for APM service maps transform (#7)

* Adds a snapshot unit test for getConnections and rearranges some code to make testing easier

* reverts `ArrayList` back to `String[]` in the painless script within `fetch_service_paths_from_trace_ids.ts`

* chore(NA): update yarn.lock

* chore(NA): remove any and use a real type for alerts task runner

Co-authored-by: Gidi Meir Morris <github@gidi.io>

* chore(NA): used named import for triggers_actions_ui file

* chore(NA): fix eslint

* chore(NA): fix types

* Delete most uptime lodash references.

* Simplify. Clean up types.

* [Uptime] Delete most uptime lodash references (#8)

* Delete most uptime lodash references.

* Simplify. Clean up types.

* chore(NA): add eslint rule to avoid using lodash3

* chore(NA): apply changes on feedback from es-ui team

* fix some types (#9)

* Clean up some expressions types.

* chore(NA): missing ts-expect-error statements

* Upgrade lodash 4 vislib (#11)

* replace lodash 3 with lodash 4 on vislib plugin

* Further changes

* further replacement of lodash3 to 4

* further work on upgrading to lodash 4

* final changes to update lodash

* chore(NA): upgrade data plugin to lodash4

chore(NA): upgrade data plugin public to lodash4

chore(NA): fix typecheck task

chore(NA): fix agg_config with hasIn

chore(NA): assign to assignIn and has to hasIn

chore(NA): upgrade data plugin server to lodash4

chore(NA): new signature for core api

fix(NA): match behaviour between lodash3 and lodash4 for set in search_source

* chore(NA): remove lodash3 completely from the repo

* chore(NA): fix x-pack/test/api_integration/apis/metrics_ui/snapshot.ts missing content

* chore(NA): fix lodash usage on apm

* chore(NA): fix typecheck for maps

* Patch lodash template (#12)

* Applying changes from https://github.com/elastic/kibana/pull/64985

* Using isIterateeCall, because it seems less brittle

* Also patching `lodash/template` and `lodash/fp/template`

* Reorganizing some files...

* Revising comment

* Ends up `_` is a function also... I hate JavaScript

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com>
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: kobelb <brandon.kobel@elastic.co>
# Conflicts:
#	renovate.json5
#	x-pack/plugins/apm/public/services/rest/observability_dashboard.ts
#	x-pack/plugins/canvas/common/lib/pivot_object_array.ts
#	x-pack/plugins/canvas/public/components/workpad_templates/workpad_templates.js
#	x-pack/plugins/canvas/server/collectors/custom_element_collector.ts
#	x-pack/plugins/canvas/server/collectors/workpad_collector.ts

* chore(NA): updated kbn-pm dist file
2020-07-03 04:40:17 +01:00
Nick Partridge
0ffa2cb599
Fix discover, tsvb and Lens chart theming issues (#69695) (#70598) 2020-07-02 11:14:18 -05:00
Marta Bondyra
297853643d
[Lens] fix dimension label performance issues (#69978) (#70553) 2020-07-02 11:08:04 +02:00
Joe Reuter
4b06ef95e0
[Lens] Multiple y axes (#69911) (#70400) 2020-07-01 12:33:08 +02:00
Joe Reuter
999926aebb
[Lens] Move chart switcher over (#70182) (#70402) 2020-07-01 12:28:21 +02:00
Joe Reuter
8b86f7ef67
[Lens] Add "no data" popover (#69147) (#70403) 2020-07-01 12:28:05 +02:00
Mikhail Shustov
03e721604f
Use ts-expect-error in platform code (#69883) (#70287)
* ts-ignore --> ts-expect-error

* fix error with mutable array

* fix errors in consumers code

* update SOM

* fix FeatureConfig & Feature compatibility

* do not re-export from code. it breaks built version

* update docs

* add eslint rule for platform team code

* remove test. this is covered by ts-expect-error in unit tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/core/utils/integration_tests/__fixtures__/frozen_object_mutation/tsconfig.json
2020-06-30 10:39:36 +02:00
Pierre Gayvallet
ecd2082e73
[7.x] Move and rename legacy elasticsearch client (#69797) (#70221)
* Move and rename legacy elasticsearch client (#69797)

* move last snapshot to inline

* move legacy files to legacy subfolder

* move request types out of legacy

* export Headers from http instead of elasticsearch

* renaming - first pass

* renaming - second pass

* fix core mocks

* adapt new calls

* update generated doc

* fix IT test mocks

* fix new usages
# Conflicts:
#	src/core/server/saved_objects/service/lib/repository.ts
#	x-pack/plugins/event_log/server/es/context.test.ts
#	x-pack/plugins/oss_telemetry/server/test_utils/index.ts
#	x-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.ts

* fix usages
2020-06-29 23:24:04 +02:00
Wylie Conlon
58fee6c5c2
[Lens] Fix cross cluster bug and optimize existence query (#70132) (#70237)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-29 15:48:43 -04:00
Marta Bondyra
39102c33e4
[Lens] Use accordion menus in field list for available and empty fields (#68871) (#70095)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-27 22:32:09 +02:00