Commit graph

320 commits

Author SHA1 Message Date
Joe Reuter 5cd8b0431b
[Lens] Restart session if fixed now becomes outdated (#88575) (#88942) 2021-01-21 14:05:03 +01:00
Marco Liberati 32345c7f8e
[7.x] [Lens] Fix Median operation visibility in Dimension panel (#88474) (#88868)
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-21 12:49:28 +01:00
Marco Liberati 87ee412c01
[7.x] [Lens] Add more in-editor Advanced documentation (#86821) (#88865)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
2021-01-20 20:07:58 +01:00
Marco Liberati 97aef867ba
[7.x] [Lens] Add a11y test suite (#88623) (#88867)
*  Add a11y test suite for Lens + some fixes

* 🔧 Removed unused ids

* 🐛 Fix component duplication via key prop

* :white_mark_check: Add more a11y tests

* ♻️ Restored back reorder id + fix multi layer duplicate ids

* 🐛 Fix #88806

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-20 20:07:41 +01:00
Joe Reuter d476b42857
[Lens] (Accessibility) Added button to execute drag and drop to workspace (#85960) (#88853) 2021-01-20 18:56:23 +01:00
Marco Liberati 603142e9cf
[7.x] [Lens] Clean full reference operation error state when switching to other operation (#87064) (#88663)
* 🐛 Make sure to check incomplete columns before saved ones

* ⚗️ Try a different approach

* 🐛 Isolate the fullRef to field transition and trigger the removal + tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 19:04:20 +01:00
Marco Liberati b518aaf9d7
[7.x] [Lens] Use first decimal when required for data summaries (#88463) (#88662)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 19:04:06 +01:00
Jonathan Budzenski 1dc3276e74
[7.x] [dev] Replace sass-lint with stylelint (#86177) (#88498)
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dave Snider <dave.snider@gmail.com>

Co-authored-by: Tyler Smalley <tylersmalley@me.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dave Snider <dave.snider@gmail.com>
2021-01-15 14:36:34 -06:00
Joe Reuter 6e41fb8a22
set aria-pressed for function buttons (#87825) (#88203) 2021-01-14 14:45:28 +01:00
Joe Reuter 497892e300
make sure filter object is persistable (#87828) (#88164) 2021-01-13 16:06:25 +01:00
Joe Reuter 7152e02ada
close popover on repeated button click (#87834) (#88163) 2021-01-13 16:06:11 +01:00
Anton Dosov efaebd8974
[Search] Search Sessions with relative time range (#84405) (#88013) 2021-01-12 17:44:56 +01:00
Joe Reuter 5ce8a5d4f4
[Lens] Implement deep linking and embedding (#84416) (#87978) 2021-01-12 13:18:03 +01:00
Marco Liberati 8fd88482d8
[7.x] [Lens] Add specific IP and Range/Interval sorting to datatable (#87006) (#87975)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-12 12:28:32 +01:00
Wylie Conlon 1bb1c030f6
[Lens] Transitions for reference-based operations (#83348) (#87724)
* [Lens] Transition between functions involving references

* Organize transition cases and cover all the basic transitions

* Add functional test

* Change logic for displaying valid transitions

* Show valid transitions more accurately

* Fix transition to only consider valid outputs

* Update test names and style

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-07 17:53:17 -05:00
Lisa Cawley ffbd1890dd
Fix broken link to Lens documentation (#87392) (#87682) 2021-01-07 12:15:46 -08:00
Devon Thomson 28365e322e
[Time to Visualize] Align Lens & Visualize Top nav Buttons & Behaviour (#86922) (#87677)
* Aligned Lens & Visualize Top nav behaviour and look
2021-01-07 14:55:03 -05:00
Mikhail Shustov 5bb0186c15
Remove dynamic mapped types from UiActions (#87075) (#87274)
* Remove dynamic mapped types from UiActions

* Remove import between data <-> embeddables

* remove outdated comments, export action types from discover_enhanced

* fix notice.txt

Co-authored-by: restrry <restrry@gmail.com>

Co-authored-by: Josh Dover <me@joshdover.com>
2021-01-05 13:27:11 +01:00
Marco Liberati c0ef9d531c
[Lens] Add more chart editor tests based on the debug state (#86750) (#87069) 2021-01-05 09:42:18 +01:00
Marco Liberati d41cfa0259
[Lens] Integrate searchSessionId into Lens app (#86297) (#87065) 2021-01-05 09:41:53 +01:00
Wylie Conlon 0d14f5a0c4
[Lens] Fix duplicate suggestions on single-bucket charts (#86996) (#87054) 2020-12-30 13:17:07 -05:00
Joe Reuter b9c61dc4f2
[Lens] Add percentile function (#86490) (#86914) 2020-12-23 23:48:25 +01:00
Joe Reuter e0623903b9
[Lens] Configurable color syncing (#86180) (#86798) 2020-12-23 09:22:09 +01:00
Wylie Conlon c01df953fc
[Lens] Introduce 4 new calculation functions: counter rate, cumulative sum, differences, and moving average (#84384) (#86786)
* [Lens] UI for reference-based functions

* Fix tests

* Add a few unit tests for reference editor

* Respond to review comments

* Update error handling

* Update suggestion logic to work with errors and refs

* Support ParamEditor in references to fix Last Value: refactoring as
needed

* Fix error states

* Update logic for showing references in dimension editor, add tests

* Fix tests

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-22 13:05:55 -05:00
Wylie Conlon 0f77d66489
[Lens] Refactor param editor to use layers (#86499) (#86656)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-21 13:57:14 -05:00
Joe Reuter a4e99754a4
fix time scaling bugs (#86444) (#86643) 2020-12-21 17:51:24 +01:00
Joe Reuter 884246e421
[Lens] Make sure Lens does not reload unnecessarily (#86092) (#86641) 2020-12-21 17:14:26 +01:00
Luke Elmers 620f5326ca
App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (#82791) (#86608)
* Move applyFilter, selectRange, valueClick triggers to data/embeddables.

* Update imports.

* Remove embeddable references to non-existent data plugin dependency.

* remove data mocks from embeddable

* Remove query, filters, timeRange from EmbeddableInput and move to apps.

* Remove data plugin imports from embeddable test samples.

* Remove circular dependencies caused by expressions renderer handlers.

* Update circular deps allowList.

* Remove data dependency on embeddable.

* Revert accidental data plugin change.

* Fix new circular deps issues.

* Update generated docs.

* Fix type errors in vis_type_xy

* Fix inspector data table.
2020-12-20 15:53:54 -07:00
Thomas Watson 777c80d8a0
Upgrade to hapi version 20 (#85406) (#86592) 2020-12-20 10:20:57 +01:00
Marta Bondyra 38c5cde800
[Lens] fix transition date_histogram/last_value -> top values/last_value (#86429) (#86457) 2020-12-18 17:19:10 +01:00
Peter Pisljar 385f72792e
inspector table adapter cleanup (#84232) (#86260) 2020-12-17 14:45:55 +01:00
Marta Bondyra 9e1c76feb5
[Lens] (Accessibility) focus on adding/removing layers (#84900) (#86189) 2020-12-17 10:25:52 +01:00
Marta Bondyra a6210e8bf0
[Lens] add typeToAgg for median (#86078) (#86090) 2020-12-16 13:24:06 +01:00
Marco Liberati 64ab3957f7
[7.x] [Lens] Better disabled messages for Value labels popup (#85592) (#85949)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-16 09:56:37 +01:00
Marco Liberati 91dacb606f
[7.x] [Lens] New sorting feature for the datatable visualization (#84435) (#85987)
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-16 09:56:13 +01:00
Marco Liberati d40ca3388d
[7.x] [Lens] Add datasource fields group help text (#85544) (#85988)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-16 09:55:41 +01:00
Marco Liberati 514f51e9c0
[7.x] [Lens] Fix chart twitching on flyout open (#85430) (#85950)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-16 09:55:17 +01:00
Devon Thomson 815793057c
[Time to Visualize] Transition Embeddable State Transfer to Session Storage (#85688) (#85996)
* Transitioned embeddable state transfer service to use sessionStorage
2020-12-15 15:41:53 -05:00
Tyler Smalley 82225db0a3
test:jest improvements to better support our monorepo (#84848) (#85880)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	docs/developer/contributing/development-functional-tests.asciidoc
#	test/scripts/jenkins_unit.sh
#	test/scripts/jenkins_xpack.sh
#	x-pack/README.md

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 09:11:51 -08:00
Vadim Dalecky 3cc2de0ac7
Row trigger 2 (#83167) (#85766)
* feat: 🎸 add ROW_CLICK_TRIGGER

* feat: 🎸 wire row click event to UI Actions trigger in Lens

* feat: 🎸 add row click trigger to url drilldown

* feat: 🎸 add datatable to row click context

* feat: 🎸 pass in row index in row click trigger context

* feat: 🎸 add columns to row click trigger context

* feat: 🎸 fill values and keys event scope array

* feat: 🎸 generate correct row scope variables

* fix: 🐛 report triggers from lens embeddable

* feat: 🎸 add sample preview for row click trigger

* feat: 🎸 remove url drilldown preview box

* chore: 🤖 remove mock variable generation functions

* feat: 🎸 generate context and global variable lists

* feat: 🎸 preview event variable list

* feat: 🎸 show empty url error on blur

* feat: 🎸 add ability to always show popup for executed actions

* refactor: 💡 rename multiple action execution method

* fix: 🐛 don't add separator befor group on no main items

* feat: 🎸 wire in uiActions service into datatable renderer

* feat: 🎸 check each row if it has compatible row click actions

* feat: 🎸 allow passing data to expression renderer

* feat: 🎸 add isEmbeddable helper

* feat: 🎸 pass embeddable to lens table renderer

* feat: 🎸 hide lens table row actions which are empty

* feat: 🎸 re-render lens embeddable when dynamic actions chagne

* feat: 🎸 hide actions column if there are no row actions

* feat: 🎸 re-render lens embeddable on view mode chagne

* fix: 🐛 fix TypeScript errors

* chore: 🤖 fix TypeScript errors

* docs: ✏️ update auto-generated docs

* feat: 🎸 add hasCompatibleActions to expression layer

* feat: 🎸 remove "data" from expression renderer handlers

* fix: 🐛 fix TypeScript errors

* test: 💍 fix Jest tests

* docs: ✏️ update autogenerated docs

* fix: 🐛 wrap event payload into data

* test: 💍 add "alwaysShowPopup" test

* chore: 🤖 add comment requested in review

https://github.com/elastic/kibana/pull/83167#discussion_r537340216

* test: 💍 add hasCompatibleActions test

* test: 💍 add datatable renderer test

* test: 💍 add Lens embeddable input change tests

* test: 💍 add embeddable row click test

* fix: 🐛 add url validation

* test: 💍 add url drilldown tests

* docs: ✏️ remove url drilldown preview from docs

* docs: ✏️ remove preview from url templating

* docs: ✏️ add row click description

* chore: 🤖 move 36.5 KB bundle balance to url_drilldown

* test: 💍 simplify test case

* style: 💄 change types places

* refactor: 💡 clean up panel variable generation

* test: 💍 add getPanelVariables() tests

* fix: 🐛 generate runtime variables correctly

* fix: 🐛 improve getVariableList() and add tests for it

* feat: 🎸 add translation, improve types
# Conflicts:
#	packages/kbn-optimizer/limits.yml
2020-12-14 17:22:26 +01:00
Joe Reuter d5ac4755ac
unskip tests and make sure submit is not triggered too quickly (#85567) (#85760) 2020-12-14 15:48:26 +01:00
Poff Poffenberger 8076c3b499
Lens save modal should conditionally save to library (#85568) (#85591) 2020-12-10 12:45:11 -06:00
Devon Thomson 682d4d73ce
one liner fix for lens save modal retaining the originating app connection after it has been severed (#85309) (#85586) 2020-12-10 12:18:41 -05:00
Luke Elmers b16834b22d
[7.x] [data.search] Clean up arguments to esaggs. (#84973) (#85578) 2020-12-10 09:33:25 -07:00
Anton Dosov 174a349493
[Search] Fix dashboard embeddables don't refetch on searchSessionId change (#84261) (#85562) 2020-12-10 16:15:52 +01:00
Joe Reuter f5ae464bf9
[Lens] Use eui component instead of custom color stops (#85239) (#85421) 2020-12-10 09:35:44 +01:00
Poff Poffenberger a6e71edbf0
[Time to Visualize] Add visualizations to dashboard from save modal (#83140) (#85345)
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
2020-12-09 10:37:25 -06:00
Joe Reuter de33718a83
simplify popover open state logic (#85379) (#85408) 2020-12-09 16:06:00 +01:00
Pierre Gayvallet 42ee8ba3f6
[GS] add tag and dashboard suggestion results (#85144) (#85382)
* initial draft

* polish

* fix mocks

* add tests

* tests on suggestions

* add comment

* add FTR tests

* factorize getSearchableTypes

* move to bottom
2020-12-09 13:07:07 +01:00
Joe Reuter b7a874c7b0
[Lens] Don't assign dimension until it becomes valid (#84972) (#85244)
Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
2020-12-08 13:22:58 +01:00