Commit graph

242 commits

Author SHA1 Message Date
Justin Kambic
d4d5fe1368
[PipelineViewer] Test PipelineViewer sub-components (#20329)
* Rename config view to PipelineViewer.

* Decouple CollapsibleStatement from if/else using props.children.

* Add tests for PipelineViewer component.

* Test Metric component.

* Test CollapsibleStatement component.

* Test PluginStatement component.

* Test Queue component.

* Test StatementListHeading component.

* Test StatementSection component. Move StatementList component to dedicated file.

* Test StatementList component.

* Test Statement component.

* Run prettier on edited files.
2018-07-09 11:51:52 -04:00
James Gowdy
d44840cd19
[ML] Adding jobs stats bar to top of jobs list (#20527)
* [ML] Adding jobs stats bar to top of jobs list

* unsetting update function

* changing node variable name

* small refactor

* using props copy of `updateJobStats`

* adding proptypes

* adding fixed height
2018-07-09 14:59:10 +01:00
Chris Davies
e34dbd0817
Fix issue w/ running chromium headless over http (#20528)
Remove the referrer header from report requests.
2018-07-06 15:30:10 -04:00
Nathan Reese
61d7b918c3
Upgrade to EUI 1.1.0 (#20411)
* Upgrade to EUI 1.0.1

* upgraded to eui 1.1.0

* fix setInspectorTablePageSize function in functional tests

* better comment about basic table pagination buttons
2018-07-06 12:15:55 -06:00
CJ Cenizal
8b8e5a0a8d
Convert various uses of notifier to toastNotifications. (#20420)
* Add MarkdownSimple component.
* Replace Context use of notifier with toastNotifications.
* Replace field.js use of notifier with toastNotifications.
* Replace State use of notifier with toastNotifications.
* Replace reporting use of notifier with toastNotifications.
* Convert Logstash to use toastNotifications.
* Convert Security to use toastNotifications.
2018-07-06 08:33:04 -07:00
James Gowdy
d9fe439671
[ML] Using kibana's auto-refresh for jobs list (#20496)
* [ML] Using kibana's auto-refresh for jobs list

* better auto refresh management

* fixing typo

* increasing default interval

* variable rename

* kill interval on page change

* updating comment

* adding minimum refresh interval

* correctly clearing the interval
2018-07-06 11:32:49 +01:00
James Gowdy
c6ba696127
[ML] Adding permission checks to jobs list (#20487)
* [ML] Adding permission checks to jobs list

* adding comment

* removing horizontal line

* changes based on review
2018-07-06 08:57:54 +01:00
James Gowdy
9d57acc867
[ML] Allow job cloning via wizards (#20227)
* [ML] [WIP] Allow job cloning via wizards

* updating clone link

* removing-created-by-data-when-editing-job

* removing commented out code

* changes based on review
2018-07-04 16:51:23 +01:00
James Gowdy
c4756b183f
[ML] Adding filter bar to jobs list (#20415)
* [ML] Adding filter bar to jobs list

* fixing page index when filtering

* refreshing job selection after actions have happened

* adding job counts to groups

* catching multi-select start datafeed errors

* style tweaks

* more style tweaks

* changes based on review

* refactoring search logic
2018-07-04 13:57:25 +01:00
Søren Louv-Jansen
90528194da
[APM] ML integration (#19791) 2018-07-04 14:18:19 +02:00
Pete Harverson
ea0395fd1e
[ML] Add endpoints and service for ML filters (#20406)
* [ML] Add endpoints and service for ML filters

* [ML] Replace getFilter(s) with single filters function
2018-07-04 13:00:16 +01:00
CJ Cenizal
e024d3dfa1
Refactor SearchSource interface (#20334)
* Removed the dynamically assigned type, query, filter, sort, highlight, highlightAll, aggs, from, searchAfter, size, source, version, and fields methods.
* The accessor interface now consists of getField and setField methods which throw errors if an unrecognized property name is provided, in addition to getFields, setFields, getOwnField, and getId methods.
* Linked-list interface now consists of setParent and getParent.
* Factory interface now consists of create, createCopy, and createChild.
* Removed the unused unused enable, disable, and addFilterPredicate, and the redundant toString (method only used internally) and extend method (superseded by createChild).
* Internally, renamed the _state property to _data and grouped methods by concern.
2018-07-03 16:53:48 -07:00
Nathan Reese
23d5dd4275
disable flaky reporting tests (#20441) 2018-07-03 16:35:02 -06:00
James Gowdy
93d9baafff
[ML] Rewrite of jobs list using react and eui (#19758)
* [ML] [WIP] New jobs list

* adding JSON tab

* adding datafeed and forecast tabs

* adding action menu functionality

* removing comments

* forcing change in file that is missing

* removing unnecessary change

* rolling back accidental change

* adding job group badges to main list

* adding multi-job action buttons

* adding start/stop actions

* showing start/end modal for multi-jobs

* adding multi-job delete

* changing delete warning

* initial edit job functionality

* adding space for custom url editing

* adding jobs summary endpoints

* fixing job loading for edit flyout

* adding calendars to jobs

* adding group loading endpoint for edit flyout

* adding audit message icons

* icon style change

* adding job messages in expanded job row

* removing log statements

* adding proptypes

* fixing expanded row table cell color

* removing log message

* renaming jobs endpoint provider

* changing case of button label

* renaming closeModal function

* adding missing proptypes

* changes based on review

* adding basic table sorting

* refactoring modal and flyout show/hide functions

* fixing sorting issues

* fixing overflow in groups
2018-07-03 10:36:45 +01:00
Justin Kambic
f763c3eb67
[Pipeline Viewer] Refactor collapsible statement component to wrap props.children (#20252)
* Rename config view to PipelineViewer.

* Decouple CollapsibleStatement from if/else using props.children.

* Modify function to take params instead of single object.
2018-07-02 13:59:42 -04:00
Tim Sullivan
f7070890d4
fix monitoring elasticsearch nodes listing sort and filtering (#20321)
closes https://github.com/elastic/kibana/issues/20132
2018-07-02 10:11:44 -07:00
Felix Stürmer
75309fffd6
Upgrade styled-components to 3.3.3 (#20257)
* Upgrade styled-components to 3.3.3

* Update test style snapshots

The upgrade seems to have affected the order in which the css classes
are serialized in the snapshot. The css rules within these classes look
identical.

* Update Kibana's yarn.lock

* Update kbn-i18n lockfile in anticipation of #20301
2018-07-01 22:58:12 +02:00
Justin Kambic
f4d9e08b45
[PipelineViewer] Replace bare img tags with euiicon (#20330)
* Remove direct references to EUI SVG. Remove bare img tag from DetailDrawer.

* Update DetailDrawer test snapshots.
2018-07-01 15:37:19 -04:00
Bill McConaghy
2cce4ff29f
fixing issues with bad error message for low permission users (#20275)
* fixing issues with bad error message for low permission users

* fixing stats, settings, and mappings error message and removing unused file
2018-06-29 13:49:49 -04:00
Bill McConaghy
d29e612ec0
improving warnings for delete and force merge (#20264)
* improving warnings for delete and force merge

* PR feedback
2018-06-29 12:08:34 -04:00
Bill McConaghy
3af5ef813b
fix sorting for index management (#20266)
* fix sorting for index management

* PR feedback
2018-06-29 12:07:25 -04:00
Bill McConaghy
c5be83bbd6
clearing error message when upload component mounts (#20268)
* clearing error message when upload component mounts

* fixing tests
2018-06-29 12:06:00 -04:00
Stacey Gammon
435eccb3dc
remove unused fn and variable (#20111) 2018-06-28 17:48:31 -04:00
Stacey Gammon
db1aad03bb
Remove _behaviors abstraction in Chromium reporting (#20106)
* remove over abstraction.

* delete unused file
2018-06-28 14:03:19 -04:00
Felix Stürmer
24ac3df4b6
Upgrade redux, redux-thunk and react-redux in x-pack (#20267)
This upgrades x-pack dependencies to the following versions:

* `redux@4.0.0` (to support TypeScript in the upcoming infra-ui migration, `redux-observable@1.0.0` in particular)
* `redux-thunk@2.3.0` (to support `redux@4.0.0`)
* `react-redux@^5.0.7` (to support `redux@4.0.0`)
2018-06-28 15:35:29 +02:00
CJ Cenizal
3ea4c3e0bc
Simplify Courier interface and organize internals (#20060)
**Interface changes**

There are two goals behind the interface changes:

* Make it clearer which courier modules are meant for public consumption by exporting them from the top level.
* Simplify the courier object by removing responsibilities and focusing its responsibility solely on scheduling search requests via the fetch method and timefilter.refreshInterval Angular event.

I did this by taking the following steps:

* Removing redirectWhenMissing, indexPatterns, SearchSource, and SavedObject from the courier object. I also removed some unused methods from its interface.
* redirectWhenMissing is now a service registered on the kibana/url Angular module.
* indexPatterns is now a service registered on the kibana/index_patterns Angular module.
* SearchSourceProvider and SavedObjectProvider are now top-level exports of ui/courier.
* migrateFilter, decorateQuery, buildQueryFromFilters, and luceneStringToDsl are now top-level exports of ui/courier.

**Internal changes**

I also made some internal changes in an effort to organize the code clearly and reduce unnecessary complexity.

* I refactored the async code in CallClient to appear sync with async/await and encapsulated chunks of logic in helper functions. I also used an isAborted flag instead of overwriting the esPromise var with an enum.
* I combined Looper and SearchLooper into a single class and deleted unused functions.
* I reorganized the courier/fetch/request code into SearchRequest, SegmentedSearchRequest, and serializeFetchParams modules.
* Renamed various other methods and variables to improve clarity.
2018-06-27 16:58:19 -07:00
Josh Soref
2b27fb1c5f Fix misspellings (#19981) 2018-06-26 20:17:41 -07:00
Bill McConaghy
61aa89cb64
adding missing data-test-subj and renaming one (#20238) 2018-06-26 20:05:32 -04:00
Justin Kambic
068c02f1c9
[Pipeline Viewer] [Monitoring] Rename config view to PipelineViewer (#20230)
* Rename config view to PipelineViewer.

* Remove unused className.

* Remove unneeded variable.

* Format file with prettier.
2018-06-26 18:59:18 -04:00
Nathan Reese
2341661cd8
Replace timefilter angular service with singleton (#19852)
* use uiSettingsClient instead of angular config service

* replace timefilter service with singleton

* remove all other uses of timefilter service, get timefilter singleton working

* remove Private from brush event

* globalState

* fix timefilter jest test

* clean up rebase artifacts

* lint errors

* another lint error

* fix broken functional test _shared_links

* fix broken mocha test doc.js

* fix service load order breaking status page

* remove Provider from change_time_filter

* another round of mocha test updates

* convert create_brush_handler test to jest

* fix kbnGlobalTimepicker toogle mocha test

* remove _root_search_source - removed in another PR and somehow I added it back during rebase

* better comments around Object.assign and proper js-docs format

* use  so listerners get cleaned up when scope is destroyed

* listen to correct timefilter update event

* update APM to use timefilter singleton

* update angular scope when timefilter changes

* fix APM jest test

* add listenAndDigestAsync to listen.js

* fix apm breadcrumbs jest test

* move diffTime and diffInterval into timefilter

* pass mode to updateFilter to resolve functional test failure

* call registerTimefilterWithGlobalState from APM application

* remove rootScope from kbn_global_timepicker

* use  to subscribe to timefilter in cases where results need to happen in digest async

* spalger review changes

* ensure monitoring timefilter callbacks are executed inside evalAsync

* remove unneeded evalAsync calls around setTime
2018-06-26 10:29:41 -06:00
gchaps
e05e0bc0bc
[COPYEDIT] Updates to text in force merge modal in index management (#20134) 2018-06-26 08:04:24 -07:00
Justin Kambic
94d99d63f3
[Monitoring] [Pipeline Viewer] Remove obsolete code (#20122)
* Remove PipelineViewer component, replace with Config Viewer as index export.

* Remove tests for obsolete component.

* Remove obsolete code.

* Remove obsolete CSS.

* Remove old SVG class for graph edges.

* Remove more graph rendering code.

* Remove obsolete properties from graph classes.

* Remove unused constants.

* Remove obsolete keys from subtitle props.

* Fix broken unit tests.
2018-06-26 10:49:11 -04:00
Bill McConaghy
d8c7970840
simplifying logic for showing extend trial and adjusting tests (#20211)
* simplifying logic for showing extend trial and adjusting tests

* PR feedback
2018-06-25 14:38:44 -04:00
Aleh Zasypkin
18037984da
Upgrade rxjs: 6.1.0 ---> 6.2.1. (#20209) 2018-06-25 20:04:19 +02:00
Bill McConaghy
39ac92a1d1
[console] adding generated spec files for xpack endpoints and adjusting code to… (#19928)
* adding generated spec files for xpack endpoints and adjusting code to handle the same override logic

* accounting for non URL documentation values

* fixing issue with incorrect override file

* adding support for unknown parameters in path (assuming they are ids)

* fixing autocomplete for get_categories ml API

* fixing issue with autocomplete for get_overall_buckets

* fixing issue with get_overall_buckets autocomplete

* fixing get_overall_buckets autocomplete issue for reals

* fixing __flag__ in body autocomplete specs

* fixing issue with ml put_datafeed autocomplete

* removing unnecessary overrides for rollup put_job

* fix issue with UrlPatternMatcher

* fixing tests

* fixing typos

* overriding rollup get due to bug in ES specs
2018-06-25 08:44:35 -04:00
Spencer
7f0308b700
[plugin-helpers] use execa so that errors include stdout with helpful info (#20110) 2018-06-22 13:17:10 -07:00
Shaunak Kashyap
da2da74a08
EUIFication: Grok Debugger (#20027)
* Move <kbn-dev-tools-app> Angular wrapper directive usage into route template

* Move sole directive into new directives folder

* WIP checkin: basic conversion to React components

* Fix sample custom patterns indentation

* Remove custom CSS

* Wrap button in EuiFormRow + define isSimulateDisabled

* Wire up simulate

* Cleanup

* Ace formatting options

* Better styling

* Adding spacing between custom patterns and simulate button

* Fixing form row widths

* Removing form row around button

* Add indentation/newlines in structured output

* Error handling

* Use constants

* Removing no-longer-used code

* Implement syntax highlighting via custom mode

* Making functional tests pass

* Adding trailing comma back

* Removing fixed heights

* Removing unnecessary styles

* Make Event Output form row full width as well

* Wrapping EuiCodeEditors in EuiPanels

* Adding spacer before callout; making spacing around callout consistent

* Clear out custom patterns from request if field is cleared out

* Clear out simulation results before attempting simulation

* Set state with untrimmed value
2018-06-22 11:51:27 -07:00
Stacey Gammon
2c1fcf9604
Typescript-ify screenshot stitcher code in reporting (#20061)
* typescript screenshot stitcher

* Throw an error if the data captured is not of the expected width and height.

* Import babel-core types

* Add babel-core types to x-pack package.json

* Dimensions => Rectangle
2018-06-22 09:18:29 -04:00
Pete Harverson
36d29e4fcc
[ML] Fix link to Single Metric Viewer zoom for sparse data (#20144) 2018-06-22 12:16:17 +01:00
Shaunak Kashyap
29f7e4c12b
Updating EUI to 0.0.55 (#20126) 2018-06-21 16:21:10 -07:00
Tim Sullivan
d0595fdc4b
Separate bulk upload behavior from CollectorSet (#19691)
* Separate bulk upload behavior from CollectorSet

 - takes out a lot of behavior from CollectorSet and moves it to a class called BulkUploader
 - simplifies kibana monitoring init by taking out the indirection that startCollectorSet / createCollectorSet had
 - removes start() method from CollectorSet and calls the collector objects' init() functions from CollectorSet.register()
 - removes cleanup method from collectorSet since that was doing work for bulk uploading

* remove cleanup and fetchAfterInit methods

* test for bulk_uploader class

* improve test for collector_set

* fix reporting

* expose collectorSet if there actually is a collectorSet

* comment for enclosed function

* make collectorSet creation/expose unconditional, bulkUploader more conditional

* fix collector_set tests

* lifecycle events

* stab at collectorSet error logging from the API call

* clean up comments

* clean up comments

* fix BulkUploader mocha test

* check kibanaCollectionEnabled config before registering bulk upload and the plugin status listeners

* no singleton timer object

* just log a warning if bulk uploader start called twice

* normal quotes

* check if bulk is enabled inside of the _fetchAndUpload method

* log for stopping bulk stats

* call bulkUploader.start with the collectorSet object

* call bulkUploader.start with the collectorSet object

* roll back change for module scoped variable

* oops I broke init

* init and logging: if / elseif / elseif

* remove unnecessary check/log

* help log

* remove redundant, use data.filter.map

* use xpackInfo.onLicenseInfoChange not xpackMainPlugin.status.on('green')

* help logging

* fix unit test

* remove handler that stops upload when connection is lost
2018-06-21 13:08:32 -07:00
Justin Kambic
55a43b2805
Fix capitalization typo for className attribute. (#20104) 2018-06-21 10:04:38 -04:00
Pete Harverson
a87c376826
[ML] Fix alignment of text in job wizard remove split button (#20118) 2018-06-21 14:09:09 +01:00
Pete Harverson
c267b4d9e1
[ML] Add missing aria-label attribute to various components (#20117) 2018-06-21 12:21:03 +01:00
Spencer
103d71556c
[xpack_main/status] update the plugin status anytime the license changes (#20018)
Fixes #20017 

Currently the xpack_main plugin only sets its status when the elasticsearch plugin changes status, which is a fine signal that the plugin should recheck for the license info, but not the only time it can be updated. At some point recently a race condition became more likely to be triggered, which is detailed in https://github.com/elastic/kibana/issues/20017#issuecomment-398209354 and causes the xpack_main plugin to set its status to red and never return it to green, even after the license info is successfully fetched from Elasticsearch.

To fix this the `XpackInfo` class now exposes the `onLicenseInfoChange(handler)` method which will call the handler whenever the xpack info changes. This way the xpack_main plugin can reflect the current state of the license info in its status and doesn't have to wait for the elasticsearch plugin to change status again.

To test this I recommend running kibana with `--elasticsearch.healthCheck.delay=500` or even `250`, and then starting Elasticsearch after Kibana has started. Without this change Kibana is very likely to attempt a healthcheck between the time that Elasticsearch is "started" and the x-pack license info is completely loaded, triggering the race condition. With this change you should see the xpack info plugin (and all other xpack plugins) go red with a more informative message, and then after the first request or 30 second polling timer, the plugins should go green again.

![screen shot 2018-06-18 at 3 25 47 pm](https://user-images.githubusercontent.com/1329312/41565769-ff032dc0-730c-11e8-978e-3e28ced18448.png)
2018-06-20 11:47:26 -07:00
Chris Earle
75125b49e8
Remove Duplicated Close button from Flyout (#20055)
This removes the now-duplicated Close button from the `EuiFlyout` now that
EUI automatically adds a close button.
2018-06-20 14:42:35 -04:00
Bill McConaghy
aa4cf42b04
adding data-test-subj to buttons and updating snapshots (#20080)
* adding data-test-subj to buttons and updating snapshots

* PR feedback

* updating snapshots
2018-06-20 14:33:48 -04:00
Tim Roes
2885e871e3
Replace spy panels by Inspector (#16387)
* Add Inspector feature

* So long, and thanks for all the fish, spy panel

* Fix several functional tests

* Fix unit tests

* Fix spy panel button tests

* Replace old spy panel documentation

* Disable test temporarily until we have dashboard triggers

* Enter edit mode for dark theme test

* Fix some more functional tests

* Fix more functional tests

* More test fixing

* Fix more functional tests

* Allow opening the inspector via loader handler

* Refactor InspectorViewChooser, remove unused CSS

* Remove dead code

* Fix data download button style

* Remove redundant code

* Load inspectorViews for dashboard_viewer

* Extract inspector views to custom core_plugin

* Switch API to TypeScript 🎉

* Design changes

* Remove icons from views

* Design changes

* Improve typings of API

* Add typing to all adapters

* Show loading spinner in request selector

* Rewrite InspectorView to TypeScript

* Fix help text for data view

* Remove deprecated React lifecycle methods

* Embed inspector into dashboard panel actions

* Remove temporary inspector trigger

* Remove old CSS

* Fix dashboard trigger for new panel action

* Add tests for InspectorPanel and DataAdapter

* Produce a hierarchical table if the vis is hierarchical

* Remove allowJs option again

* Add missing Apache license headers

* Close inspector on dashboard when navigating away

* Use proper title for dashboard panels

* Fix functional tests

* Skip broken test for now

* Flush view chooser button

* Add request adapter tests

* Skip more tests, broken due to typescript

* Add Request Time description

* Add description for courier request

* Fix tests

* Replace icon by new (not yet released) icon

* Finalize design of inspector

* Remove discover test, that relied on spy panels

* Change API to be properly mockable in tests

* Add aria-live region for request status

* Replace old method in functional tests

* Replace abitrary magic number

* Use object destructuring in vis

* Fix issue with crashing requests view

* Add request time tooltip

* Get request body of correct search source

* Make filter buttons properly keyboard accessible

* Follow Dave's design suggestions

* Remove redundant request from name

* Remove unneeded comments

* WIP raw-formatted values

* Fix filtering issue

* Fix tests and more license headers

* Add data view tests

* Remove search from table

* Fix typos

* Implement review suggestion

* Remove artificial delays for testing

* Fix new panel action structure

* Minor design adjustments

* Fix failing functional test

* Update failing snapshot test

* Implement final wording

* Apply new EUI styling

* Fix closing inspector in tests

* Fix sorting of table

* Align punctuation between tooltips
2018-06-20 11:07:44 +02:00
CJ Cenizal
89e7266853
Remove close buttons from Saved Object relationship and Index Management flyouts. (#20043) 2018-06-19 21:07:18 -07:00
Shaunak Kashyap
64d28b955b
Remove explicit close button (#20044) 2018-06-19 23:43:24 +05:30