* Refactor chart querying.
* Fix monitor chart query.
* Refactor several inline computations to helper functions. Improve schema naming.
* Move unit conversion to client, remove bare conversion values.
* Add API tests for monitor charts.
* Add test for conversion function.
* Add type annotations to latest schema additions.
* Fix typo.
* Refactor based on PR feedback, add comments asked for in PR feedback.
* Rename fields in schema, update tests. Extract monitor charts to functional component and add unit test.
* [Maps] embeddable
* fix embeddable registration
* get embeddable to render
* render map embeddable
* support filter pills on dashboard
* fix layerName error
* update getBoundsForFilters to not record bounds request in inspector
* set isReadOnly
* fix bug where different states are sharing same inspectorAdapters instance
* populate indexPatterns so container has index patterns for type ahead and filter bar
* pass refreshConfig from container to map store
* add functional test verifying index patterns passed to container
* remove data.json files commited by mistake
* add functional test ensuring inspector adaptors are not shared between embeddables
* add functional tests for filters getting passed to embeddable
* remove embeddable dashboard from web logs sample data saved objects
* add slash to edit path
* fix typo
* pass previous query state on reload, add functional tests to verify reload and refresh timer
* remove unnecessary check in getFilters
* review feedback from thomasneirynck
* fix resize bug
* remove animationFrame from resize callback
We have had `insert_final_newline = true` in our `.editorconfig` file since April 2015, but never validated it with eslint. I'm a little tired of extra changes showing up in PRs because some people use editors which respect the `.editorconfig` file and some don't, so I figured we might want to enable the rule in eslint so that the can be autofixed.
Votes requested please :)
* fix(na): avoid transpiled files endup on repo when building xpack.
* docs(NA): added todo in order to remove added code when we run the upgrade to babel@7.
* fix(NA): include missing files from the x-pack build.
* [APM] fix inconsistencies in ESC type migrations
* [APM] audit ESC schema types and removed unused fields
* [APM] removed unused line property type from IStackFrameBase
In https://github.com/elastic/kibana/pull/31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from https://github.com/elastic/kibana/pull/30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.
Fixes#31828
To avoid a timeout we've seen fail 11 times since the end of January by moving the test into an integration test. The test starts up TypeScript, so it's clearly an integration test, and by moving it into an integration test it can have more time to run.
Fixes#31913
There have been 6 failures in this test in the last 60 days, which I believe is caused by a race condition of some sort that prevents us from accessing the file right after it's been written. It might have to do with writeStreams not actually flushing to the filesystem within time, but I haven't been able to prove it. @mikecote is taking a look at seeing if he can do some simple testing to reproduce the situation locally.
In order to avoid further errors this PR updates to use the `fs.copyFile` function that was added in node 8.5, which does the whole copy in a single native operation.
* bump typescript version to 3.3.3333
* fix tests after updating TS version
* suppress type errors until they fixed appropriately
* address comments
* add type def for UnconnectedKibanaLink
* remove fix @ts-ignore
* fix snapshot test. provide displayName
* udpate jest, jest-cli, @types/jest to v24
* fix type error in kibana-i18n package
* return serivce explicitly to fix typings
* add explicit never
* suppress typings errors
* update jest versions in x-pack
* make tests in x-pack more robust and fix incompatibility
* suppress CallCluster mock typings
Mock interface doesn't match CallCluster. Requires
additional work
* x-pack. resolve other typing conflicts
* remove unused types/jest
* fix snapshots
* restore mocks after jest.spyOn
* remove outdated definitions for jest
* cleanup x-pack package.json and update @types/jest
* fix tests merged from master
* updated yarn.lock and log errors for scripts/type_check
* This commit fixes error in TS, which failed on parsing the file.
* suppress type errors from master
* jest-cli is devDep
Closes https://github.com/elastic/kibana/issues/32161
All the elements are loaded in the router, so loading the from the component just duplicates the work.
This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now.
### Stats
Workpad | Previous load time | PR load time
-- | -- | --
Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds
Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds
*Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
* fix client validation for rollup index name
* remove wrapper object in constants file
* move support for "*" illegal character to common constants file
Fixes a regression introduced in #31692. The table interval selection wasn't properly restored from `AppState` because of a mismatch in the expected object structure.
Windows has a maximum path length of 260 characters. We're approaching this limit so this adds a build task to check for any path > 200 characters.
200 + C:/ + path + kibana = total. Rough estimation.