* Change progress bar to spinner
* Add progress bar option for full screen mode
* Update snapshots for router test
* Update snapshots for loading indicator test
* Update header snapshot
* Change progress bar position to fix full screen
* [QA][Code Coverage] Coverage teams lookup
* Fix test per cr.
* Drop unused fn's.
* Add integration test to prove that the sys does indeed
strip the CC prefix and still walks the fs.
* Cleanup "todo" list.
* Use import, like Dima's previous suggestion.
* Add coverage teams only definitions to CODEOWNERS per Lee.
* Add coverage teams for logstash, reporting and security.
* Update description.
* Update names per Lee.
* Drop mutation.
* Fix dupes.
* Add the file check, per Dima
* Add more teams
* Update regex to only match on "build/" and add test.
* More teams
* More teams
* Add print statement of the canonical timestamp,
so we can lookup stuff in gcp during errors.
* CR fixups
During development of https://github.com/elastic/kibana/pull/75553,
some issues came up with the optimistic concurrency control (OCC) we
were using internally within the alertsClient, via the `version`
option/property of the saved object. The referenced PR updates new
fields in the alert from the taskManager task after the alertType
executor runs. In some alertsClient methods, OCC is used to update
the alert which are requested via user requests. And so in some
cases, version conflict errors were coming up when the alert was
updated by task manager, in the middle of one of these methods. Note:
the SIEM function test cases stress test this REALLY well.
In this PR, we wrap all the methods using OCC with a function that
will retry them, a short number of times, with a short delay in
between. If the original method STILL has a conflict error, it
will get thrown after the retry limit. In practice, this eliminated
the version conflict calls that were occurring with the SIEM tests,
once we started updating the saved object in the executor.
For cases where we know only attributes not contributing to AAD are
being updated, a new function is provided that does a partial update
on just those attributes, making partial updates for those attributes
a bit safer. That will be also used by PR #75553.
* Adding bulk upgrade api
* Addressing comments
* Removing todo
* Changing body field
* Adding helper for getting the bulk install route
* Adding request spec
* Pulling in Johns changes
* Removing test for same package upgraded multiple times
* Adding upgrade to setup route
* Adding setup integration test
* Clean up error handling
* Beginning to add tests
* Failing jest mock tests
* Break up tests & modules for easier testing.
Deal with issue described in https://github.com/facebook/jest/issues/1075#issuecomment-221771095
epm/packages/install has functions a, b, c which are independent but a can also call b and c
function a() {
b();
c();
}
The linked FB issue describes the cause and rationale (Jest works on "module" boundary) but TL;DR: it's easier if you split up your files
Some related links I found during this journey
* https://medium.com/@qjli/how-to-mock-specific-module-function-in-jest-715e39a391f4
* https://stackoverflow.com/questions/52650367/jestjs-how-to-test-function-being-called-inside-another-function
* https://stackoverflow.com/questions/50854440/spying-on-an-imported-function-that-calls-another-function-in-jest/50855968#50855968
* Add test confirming update error result will throw
* Keep orig error. Add status code in http handler
* Leave error as-is
* Removing accidental code changes. File rename.
* Missed a function when moving to a new file
* Add missing type imports
* Lift .map lambda into named outer function
* Adding additional test
* Fixing type error
Co-authored-by: John Schulz <john.schulz@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* adds missing buildRuleMessage to debug logs to display rule id, name, etc. in logs
* add buildRuleMessage fn to params
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* df exploration page: handle default isTraining filter in url
* default training query updated to match what the searchBar would produce. fixes evaluate panel dataset label
* clear defaultIsTraining filter from url once applied
* Add KibanaLogic store/mount
* Update usage of setBreadcrumbs/setDocTitle to KibanaLogic
* Update usage of Kibana config context to KibanaLogic
* Update usage of navigateToUrl context to KibanaLogic
* 🔥 Remove unused shallow_usecontext mocks, repurpose file to shallow_useeffect
- The file is now no longer used to mock useContext, only unseEffect, hence the rename
* 🔥 Delete/repurpose mount with context helpers
- Remove mountWithKibanaContext completely
- Change mountWithContext to mountWithIntl, since that's the only context remaining, and move it to its own file
- Change mountWithAsyncContext to just mountAsync and move it to its own file
+ add an option to pair it w/ mountWithIntl for formatted date/number support
* 🔥 Delete KibanaContext and mockKibanaContext
+ minor newline linting/grouping tweaks
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Working on package update functionality
* Correctly installing package
* Moving upgrade component and working upgrade
* Doing permissions check
* Cleaning up imports
* Adding bulk upgrade api
* Addressing comments
* Removing todo
* Changing body field
* Adding helper for getting the bulk install route
* Adding request spec
* Using bulk install endpoint from ingest
* Moving component to a hook
* Addressing feedback
* Add deprecation message to coordinate map and region map
* clean up text
* add default distro link and view in maps link
* move url generation into onClick handler
* create tile map layer descritor
* set metrics and color and scaling
* lazy load createTileMapLayerDescriptor
* tslint fixes
* tslint cleanup for OSS code
* add region map deprecation message
* tslint cleanup
* consolidate logic into LegacyMapDeprecationMessage
* fix jest test
* fix tile-map and region_map in OSS distro
* tslint fixes
* assert urlGenerator exists
* update message text
* ensure legacy-ids get correctly evaluated (#37)
* handle 6.x region map saved objects
* turn off field meta
* fix type
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
* Update tutorial-discovering.asciidoc
Adds alt text to images in doc.
* Update docs/getting-started/tutorial-discovering.asciidoc
* Update docs/getting-started/tutorial-discovering.asciidoc
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
* Update tutorial-define-index.asciidoc
Forgot to update alt text in previous pr. Additionally, it is unclear in the image where the "time field" dropdown is located.
* Update docs/getting-started/tutorial-define-index.asciidoc
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
The PagerDuty Action currently defaults to a dedupKey that's shared between all action executions of the same connector.
To ensure we don't group unrelated executions together this PR avoids setting a default, which means each execution will result in its own incident in PD.
As part of this change we've also made the `dedupKey` a required field whenever a `resolve` or `acknowledge` event_action is chosen. This ensure we don't try to resolve without a dedupKey, which would result in an error in PD.
A migration has been introduced to migrate existing alerts which might not have a `dedupKey` configured.
* First stab at developer-focussed saved objects docs
* Don't introduce spelling mistakes
* Add docs for SO migrations
* Link to HTTP API documentation
* Grammar fixes
* Rendering fixes
* Migrations should be tested, remove nested migration docs for now
* Drop subtitle field in migration, add notes about migration version, behaviour for corrupt documents and emphasize testing
Co-authored-by: Josh Dover <me@joshdover.com>
* first shot of the apm configuration loader
* revert changes to kibana config
* remove test files for now
* remove `?.` usages
* use lazy config init to avoid crashing integration test runner
* loader improvements
* add config value override via cli args
* add tests for utils package
* add prod/dev config handling + loader tests
* add tests for config
* address josh's comments
* nit on doc
* Implement toExpressionAst for tagcloud
* Implement tagcloud vis renderer
* Use resize observer
* Use common no data message
* Update build_pipeline.test
* Update tag cloud tests
* Revert "Use common no data message"
This reverts commit fddf019575.
* Update interpreter functional tests
* Add tests for toExpressionAst fn
* Use throttled chart update
* Update renderer
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* adding alert to service page
* sending on alert per service environment and transaction type
* addressing PR comment
* addressing PR comment
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* First draft of EQL rules in detection engine
* Reorganize functions to separate files
* Start adding eventCategoryOverride option for EQL rules
* Add building block alerts for each event within sequence
* Use eql instead of eql_query for rule type
* Remove unused imports
* Fix tests
* Add basic tests for buildEqlSearchRequest
* Add rulesSchema tests for eql
* Add buildSignalFromSequence test
* Add threat rule fields to buildRuleWithoutOverrides
* Fix buildSignalFromSequence typecheck error
* Add more tests
* Add tests for wrapBuildingBlock and generateSignalId
* Use isEqlRule function and fix import error
* delete frank
* Move sequence interface to types.ts
* Fix import
* Remove EQL execution placeholder, add back language to eql rule type
* allow no indices for eql search
* Fix unit tests for language update
* Fix buildEqlSearchRequest tests
* Replace signal.child with signal.group
* remove unused import
* Move sequence signal group building to separate testable function
* Unbork the merge conflict resolution
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
