* Fix bash/curl API code example not correctly having `\`s at the end of non-body lines
- Doing this requires removing the `dedent()` fn which is messing up backslashes
- Removing dedent requires setting the template literal indentation to 0 and changing the indent level on DOCUMENTS_API_JSON_EXAMPLE
* I unindented DOCUMENTS_API_JSON_EXAMPLE too hard
- the { is no longer lined up with the [ I think??? what am I even doing with my life
* Fix route validation
This param is not always required. Was already fixed for org version but the personal dashboard came later and was not fixed.
Original fix for org:
30d8b1dfa8 (diff-07f094b2a4719e8511f003d8e278a77cd6b808d11b14d1c528705f9b259c328fR373)
* Fix route to account for private github route
Previously had the org route hard-coded
* Move the logic for parsing the query params to template
Because the useEffect call comes after the initial render, the chrome flashes. We originally got around this by hiding the chrome always because in non-github scenarios, this worked fine.
However, because the oauth plugin sends the state in the quert params and uses the same URL, we need to parse that to determine whether this is an org or accoutn route. We now do that logic in the template and set the chrome before calling the useEffect.
We still need to pass both the parsed params and the original quert string because the redirect passes that string to the next view.
* Improve typings
Custom API Source allow indexing several types of data. We didn't
account for all of them.
For example, geolocation can be array of arrays of numbers.
This commit improves typings.
The following commits mostly fix TS errors
that appear after this commit.
* Remove type castings to account for all possible variable types
* Update helper functions to accept new CustomAPIFieldValue
* Fix TS error: convert url to string before using it in EuiLink
* Update mock and tests to match updated typings
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Update plugin README with beta copy & fancier product info
* Update API dev docs plugin description punctuation
* Update README dev section
- Remote reference to native auth - no longer applicable in 7.14
- Add reference to Getting Started guide (Elastic only)
* Run node scripts/build_plugin_list_docs to update https://www.elastic.co/guide/en/kibana/master/plugin-list.html
* Add link to main Kibana README
- which should link out to their contributing docs
* Fix ent-search authentication to show the error connecting screen
Missed this in #103555
* [Misc] updoot handleConnectionError order/spacing to match
- why? because i've lost control of my life, probably
* Fix unsavedChanges false positive when MultiInputRows is present
- The fix for this is to change MultiInputRows from useEffect to useUpdateEffect, which prevents onChange from firing on initial mount/render (triggering updateBoostValue->unsavedChanges)
@see https://github.com/streamich/react-use/blob/master/docs/useUpdateEffect.md
* Fix precision tuner not triggering unsavedChanges
* Fix "Max size" number inputs cutting off the "No limit" placeholder text on Chrome/webkit
- textOnly={false} is required for the input to expand in width
* Fix handleFieldNumberBlur behavior:
- should allow setting a number field back to empty/no limits
- dev note: '' is the blank/empty state, which gets parsed to NaN. Random invalid strings ALSO get parsed to '', which is NaN
* Fix input not clearing invalid non-number strings
For some really odd reason, '' and undefined aren't correctly resetting the input value when a string gets entered into the input. I had to add a space for EUI to actually start clearing it
Note that this change completely prevents users from writing non-numbers into the input at all, but this is probably fine/valid honestly
* EnterpriseSearchRequestHandler: Create new hasJsonResponse param
- in place of try/catch previously added for an empty response
- we should instead attempt to handle all non-JSON responses manually, as they're (currently) the outlier
* Update AS sample engine/onboarding route with hasJsonResponse: false
- as this was the original route that added the try/catch
- should still work without it now
* Update WS source download diagnostic route with hasJsonResponse: false
- this was the original impetus for the non-JSON feature request - WS needs the ability to download JSON files directly
* Update Download Diagnostics filename to match standalone UI
* Fix misc routing issues in Source Settings
- `/api` route is missing Kibana basepaths (affects both dev modes and users who have Kibana canonically set to a non-root URL)
- We shouldn't be using RR's native <Link>, but instead our RR helpers which use Kibana's instance of RR history
* Remove TableFilterUsersDropdown
* Update button to point to users and roles
* Remove modal and group users logic
* Remove route
* Remove i18n translations
* Fix beta notification to use flex instead of absolute positioning
- probably should have done that from the start
* Remove now-unnecessary `betaNotification*` classes/wrappers
* Rename constants
* Refactor to use alternate heading instead of modal
* Fix i18n order
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix an issue from previous PR
In https://github.com/elastic/kibana/pull/104024, the error handling incorrectly used the `message` property on the response, when it should have been the attributes.errors array.
* Use inline error for duplicate name
* Remove `exact` prop on route
This was preventing the rendering of the subroute. Not sure why it was working before
* Replace `EuiFlexGrid` with `EuiFlexGroup`
Again, not sure why this was chosen, but although the EuiFlexGrid component renders fine in the standalone UI, it does not look correct in Kibana. EuiFlexGroup seems to render as intended.
The activity feed tried to render a link to a source for activity items like
"New user joined organization". This couldn't be done and the page crashed.
This PR accounts for this case by rendering an item with no link for such cases.
This was already fixed before in ent-search in https://github.com/elastic/ent-search/pull/2574
But we didn't port the PR, because we thought there is no need to port a part
of Standard auth functionality. Turned out there is.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Enterprise Search] Fix bug in Add Schema modal
This PR fixes a bug where an error passed from the server was not rendering and was causing the UI to hang. The problem is that the `body` property was missed in the error object.
* Use default message when error response for actions.setServerField has no message
* i18n-ize default error message
* Remove TODO
Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Port the changes as is with no modifications
* Fix accessibility errors
* Rename variable
* Fix Stylelint issues and remove unused CSS
* Extract getAsLocalDatetimeString as a util function and use it everywhere
* Update backend schema
Also replace schema.maybe with schema.nullable. Previously assigning
"Leave unassigned" value to subtitle and description caused a server error,
because we were receiving null for these values that server did not expect.
* Update exampleResult mock
* Add tests for DisplaySettingsLogic
* Add tests for ExampleSearchResultGroup
* Add tests for ExampleStandoutResult
* Add tests for SearchResults
* Add missed null fallback type
* [Solution Toolbar] Fixing button border on non-text color versions
* [Alerts] Removed extra wrappers and use EuiPageHeader
* [Logstash] Basic conversion to template
* [Reporting] Adding bottomBorder to page header
* [ML] Fix display of main navigation tabs
* [Stack Management] Fix side nav not updating when going back to landing page
* [Tags] Add spacing after page header
* [License Management] Full width on file uploader
* [Page Template] Fixed `emptyState` default template for pages with side nav
* [Infra] Removing some page header displays in empty states
* [Enterprise Search] Fix some error layouts
* [Index Patterns] Quick fix for empty state
* snaps
* [Page Template] Remove forced padding when `centeredBody`
* small hack for tab padding for ml
* scroll ML page to fix test
* fix test method type signature
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
* Update delete copy to immediate deletion
- David recently changed our dashboard action to invoke an index refresh, which means it should be a synchronous action now
* Run node scripts/i18n_check --fix
* Remove role region on flash messages
- just `aria-live` is enough for screen readers to read it out, and `role` was causing "Flash messages" to get read out loud repeatedly between page navigation even when empty which was annoying and not good
* Further a11y attribute recommendations from @myasonik
This PR fixes an edge case where a race condition mught cause the total_results from a federated content source to come back null from the server. This PR tells the server to expect null in those edge cases to prevent browser errors
* Update Enterprise Search request handler to send back an error connecting header
- vs only distinguishing error connecting issues by 502 status
+ clarify comment where this.handleConnectionError is called - for the most part, auth issues should already be caught by 401s in logic above
* Update HttpLogic to set errorConnecting state based on header
+ update tests etc to match read-only-mode state
* [Tech debt] Gracefully handle invalid HTTP responses
I've noticed this error a few times after Kibana gets shut down (http.response is undefined) so figured I would catch it here
* Fix missing try/catch/flashAPIErrors on engines overview
- This is the only http call I found missing a try/catch across our codebase, so we should be set for all views correctly flashing an API error that receive a 5xx response from ent-search
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Set up new BetaNotification component
* Update shared page template to append new beta notification item to side nav
NOTE: I'm mutating the array because:
- returning a new instance leads to a lot of really annoying type errors
- the side nav's we're getting are entirely static with predictable items & and always come from us anyway
- this is eventually going to get removed, and I'm optimizing for easy-to-remove code
* Add beta notification to error connecting state
- to help users/SDH cases where users cannot connect at all
* Fix type error
- sideNav itself can be undefined but not `sideNav.items`
* Precision is now a required param for search settings
* Made RelevanceTuningLogic aware of precision param
* New PrecisionSlider component
* Add PrecisionSlider to RelevanceTuning
* Fix types in test
* Fix imports for PrecisionSlider
* Slight panel and text adjustments.
* Comment out docs link
* Add commented out test for docs
* Can we just all agree not to talk about this commit
* Restore docs link
* Fix docs link again
* Clean-up step description logic
* Test for documentation link
* Moving the spacer to align titles.
* Missing test for updatePrecision
* Fix CSS for step description
* Remove containing EuiPanel
* Improve screen reader experience
Co-authored-by: Davey Holler <daveyholler@hey.com>
* Set up new BetaNotification component
* Update shared page template to append new beta notification item to side nav
NOTE: I'm mutating the array because:
- returning a new instance leads to a lot of really annoying type errors
- the side nav's we're getting are entirely static with predictable items & and always come from us anyway
- this is eventually going to get removed, and I'm optimizing for easy-to-remove code
* Add beta notification to error connecting state
- to help users/SDH cases where users cannot connect at all
* Do not collect code coverage on test_helpers
Note: some test helpers are no longer being used but might be some day - e.g., shallowWithIntl will be used on the beta badge
* Fix uncovered type line
- since we're not iterating over productNames, no need for it to be an array - it can be written more clearly in string union format
* Fix branch coverage on index.tsx
- Since KibanaLogic is setting `|| {}` fallbacks in any case, I've opted to remove them in this file and let fallbacks be handled there
- Fixed typing to make it clear plugins can be undefined (i.e., disabled/optional, etc) in props + reorganize w/ comments
- KibanaValues requires an Omit to override props types
* Crawler DomainsTable test coverage/improvements
- Fix test failing locally due to timezones by increasing the timezone offset
- Cover missing branch line by adding a domain with no `lastCrawl`
- Remove unnecessary extra beforeEach with dupe re-shallow/mounts
- move getTable helper to its most relevant block (it's not being used in the generic column content checks, only in the actions column suite)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix toasts rerendering/resetting between page navigations + z-index issues
- note: I opted to delete the `<Callouts>` component in favor of just reverting it to the old `<FlashMessages>`, now that FlashMessages is no longer responsible for toasts
* Update engine creation success messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update engine deletion success message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update source engines add/delete success messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update crawler domain delete message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update API key create/update/delete sucess messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update curations delete success message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update results settings success message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update relevance tuning success/reset messages
- to use a toast (+ toast message) instead of a callout
- update copy to match EUI guidelines
* Update document deletion success message
- to use a toast instead of a callout (+ split additional text)
- update copy to match EUI guidelines
* Update role mappings create/update/delete success messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Run i18n_check --fix
- per localization team guidelines - strings that have been changed should get deleted/scheduled to be re-translated
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Port #3904 to Kibana
https://github.com/elastic/ent-search/pull/3904
* DRY out logic interfaces
Should have done this long ago
* Port #3920 to Kibana
https://github.com/elastic/ent-search/pull/3920
* Lint fixes
* Remove error state from form
We already did this for the users flyout. Basically changes the dirty state of the form from an error state to just showing “Required”. i18n had not been translated yet for `ATTRIBUTE_VALUE_ERROR`
* Add loading states
* Remove manual disabling of button
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Remove manual disabling of other button
* Lint fixes
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
