Commit graph

32666 commits

Author SHA1 Message Date
Cauê Marcondes aecd00f3d8
[APM]fixing custom link unit tests (#64045) 2020-04-22 07:34:40 +02:00
John Schulz edac6669f7
[Ingest] EPM & Fleet are enabled when Ingest is enabled (#64103) 2020-04-21 20:41:13 -04:00
Yuliia Naumenko 28313c4890
[Alerting] Fixed bug with no possibility to edit the index name after adding (#64033)
* Fixed bug with no possibility to edit the index name after adding

* fixed test

* fixed test

* fixed selector

* Move the testing to unit tests
2020-04-21 17:00:55 -07:00
Nathan Reese ea4eb3385b
[Maps] Map settings: min and max zoom (#63714)
* [Maps] Map settings: min and max zoom

* eslint

* header and footer

* zoom range UI

* save session state in mapStateJSON

* disable button when flyout is open

* tslint

* update layer_control jest test

* tslint

* move settings button to top map chrome

* move map_settings_panel to NP

* remove merge conflict artifact

* fix import for NP migration

* remove unused CSS class

* fix path from NP move

* review feedback

* load map settings in embeddable
2020-04-21 16:27:00 -06:00
Nathan L Smith f254ee682c
[kbn-storybook] Use raw loader for text files (#64108)
Starting Storybook (with `yarn storybook apm`) was failing to start because it was having trouble loading Angular .html templates.

Use the raw loader in the webpack config for storybook, same as the Webpack config in kbn-optimizer.
2020-04-21 17:12:36 -05:00
Sandra Gonzales adc9b0d757
[EPM] /packages/{package} endpoint to support upgrades (#63629)
* install template after pipeline creation

* return installed pkg if this pkg version is already installed

* remove pipelines after templates are updated

* remove kibana saved objects assets before installing

* update current write indices

* add back removal of merging previous references lost in rebase

* improve some typing names, consolidate, fix bad merges

* update query to use aggregate on _index

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-21 16:39:32 -04:00
Ryland Herrick 592a0ff224
[SIEM] New Platform Saved Objects Registration (#64029)
* WIP: Register saved objects types in NP

This works, but responsibilities are spread around. Refactor incoming.

* Moves new SO definitions into corresponding folders

This way our top-level file still acts as the index, but these are
more/less unconnected if/when we split these out into separate
applications.

* Replace raw SO updates with our ruleStatusSavedObjectsClient

This mainly consolidates the SO type name and the attributes type to a single
file so that we don't have to import both any time we want to work with
RuleStatus SavedObjects.
2020-04-21 15:33:27 -05:00
Paul Tavares ed912751c1
[Endpoint] Hook to handle events needing navigation via Router (#63863)
* new hook providing generic event handler for use with react router
* Refactor of Header Naviagtion to use useNavigateByRouterEventHandler
* Policy list refactor to use useNavigateByRouterEventHandler hook
* Policy list Policy name link to use useNavigateByRouterEventHandler hook
* Host list use of useNavigateByRouteEventHandler
2020-04-21 16:30:09 -04:00
Devon Thomson 5501fb4e5d
Fixed small issue in clone functionality (#64085) 2020-04-21 15:57:50 -04:00
nnamdifrankie 4ca86103b3
[Endpoint]EMT-146: use ingest agent for status info (#63921)
[Endpoint]EMT-146: use ingest agent for status info
2020-04-21 15:51:51 -04:00
Ryland Herrick ff5971ac17
[SIEM] Server NP Followup (#64010)
* Remove unused file

This was moved to a constant in common/constants.

* Remove unused types

Omit is now part of Typescript, and Pick3 is unused.

* Define and export SIEM's plugin contracts

They're empty for now.

* Import config type from config file

Instead of our plugin index, which could only cause circular
dependencies.

* SiemClient API uses getter function instead of direct property access

* Add public mock for SiemClient

* Fix typo in extract-mitre-attacks script

We were backgrounding the process (&) instead of ANDing it with the
linting. Whoops!

* Remove missed instance of old siemClient API

I missed this one when grepping, but typescript and CI saved me.

* Use our client mock in our test suite

This was causing some test failures as I forgot to update the client mock

* Update script following updates to the output's usage

This was changed in https://github.com/elastic/kibana/pull/55883 but the
script was not updated accordingly.
2020-04-21 14:27:10 -05:00
Ryland Herrick 5a55c9a8f6
Register uiSettings on New Platform (#64015)
This now requires us to define a schema for each setting, which is a
little redundant given that we also have to type the useUiSetting calls;
this might be an issue between kibana-react and new UiSettings changes.
2020-04-21 12:47:25 -05:00
Tim Sullivan 0266a5c447
[Reporting] Integration polling config with client code (#63754)
* source new platform for reporting ui config

* fix test types

* fix type check

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-21 10:46:08 -07:00
Ben Skelker b7aab690f4
[Docs]7.7 SIEM doc updates (#63951)
* SIEM section doc updates

* corrections

* more corrections
2020-04-21 20:14:25 +03:00
Steph Milovic 0c14424321
[SIEM] [Cases] Tags suggestions (#63878) 2020-04-21 10:55:42 -06:00
Jen Huang 840808c942
Include datasource UUID in agent config yaml, adjust overflow height of yaml view (#64027) 2020-04-21 09:43:17 -07:00
Lisa Cawley 1a6338a314
[DOCS] Add file size setting for Data Visualizer (#64006) 2020-04-21 09:35:19 -07:00
Devon Thomson b7f2a010c8
[DOCS] Add documentation for clone feature (#64019)
* Added documentation for the clone feature
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
2020-04-21 11:26:53 -04:00
Yara Tercero dbb7923e9b
[SIEM][Detections Engine] - minor updates to monitoring table with unit tests (#64020)
### Summary

Minor updates to the All Rules monitoring table. Includes front end and backend changes:

- Displays dashes in the monitoring table when no values are present
- Displays `lastLookBackDate` only if the rule indexes events into the signals index, otherwise `lastLookBackDate` is set to null
2020-04-21 10:42:43 -04:00
Josh Dover f43d555f14
Migrate logstash frontend to KP (#63417) 2020-04-21 07:39:59 -06:00
Alexey Antonov 2b9c99bd01
Index pattern management - field list - localization functions returning empty strings (#64055)
Closes: #63649
2020-04-21 15:50:38 +03:00
Mikhail Shustov 6ecba2c732
Run local prettier script (#63959)
* convert eslint scripts into TS

* update settings for BWC

* add script updating styles to pretter v2

* use default prettier config

* run npx once, point to the correct head branch, do not add to git

* throw if run script not on a clear branch

* run in a batch, add logging
2020-04-21 14:22:58 +02:00
Christos Nasikas 698717173d
[SIEM][CASE] Server common constants (#63952) 2020-04-21 15:09:42 +03:00
Anton Dosov 3b1d0e0c6b
[State Management] ScopedHistory support for state syncing utils (#62761)
The needed change is to rely on history as source of truth for location instead of window.location.

btw, This makes possible to test state syncing utils integration using createMemoryHistory()

One issue was discovered after this change:
When switching from context to discover url was incorrect. history.location inside state syncing utils didn't get the last update. This happened, because history instance created in discover wasn't used in context app and when all listeners unsubscribed from it - it stopped receiving location updates. To fix this I just reused one history instance in discover, context and their kbnUrlTracker
2020-04-21 13:53:17 +02:00
Gidi Meir Morris 02d55db6cd
[Alerting] Improve validation and errors handling in PagerDuty action (#63954)
Improves the messaging when the Pager Duty action has trouble parsing the timestamp field and adds trimming on the timestamp's field to make us more flexible in handling the parsing and hence more likely to be forgiving of the input by the user.

As the timestamp relies on context variables provided via mustcahe templates, we can't reliably validate this field at alert creation time.
We address by:
1. Trimming the edges, which is required when parsing a date, should help prevent accidental spaces from breaking the parsing.
2. Checking for a mustache template on the client side and if there are none - we validate for a valid timestamp when the action is created.
2020-04-21 12:32:14 +01:00
Jean-Louis Leysens 1deb5d63eb
Move authz lib out of snapshot restore (#63947)
Created the first entry for the new __packages_do_no_import__
folder that will house ESUIs private packages.
2020-04-21 12:31:05 +02:00
Matthias Wilhelm 2f363ba144
Migrate vis_type_table to kibana/new platform (#63105)
* Move vis_type_table to Kibana Platform

* Adapt mocha tests
* Adapt CODEOWNERS

* Adapt SCSS
2020-04-21 09:49:48 +02:00
Diana Derevyankina 46f6f8779e
Enable include/exclude in Terms agg for numeric fields (#59425)
* Enable include/exclude in Terms agg for numeric fields

Closes #4576

* Added a new component that allows adding multiple values

* Added some validation to include/exclude fields

* Removed unnecessary comments and accepted API changes

* Fixed i18n ID issue

* Refactored some code and fixed discard button issue

* Added SimpleNumberList component and value parsing in include_exclude.tsx

* Fixed merge conflict

* Fixed merge conflict

* Refactored some code

* Got rid of lodash isArray, added Number.isFinite where needed and changed symbol of string join and array split

* Added some more test cases to cover migrate_include_exclude_format write method

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-21 09:55:06 +03:00
Joe Reuter 5adccd005b
follow conventions for saved object definitions (#63571) 2020-04-21 08:37:02 +02:00
Ben Skelker d6fdb689e8
[Docs]Adds saved object key setting to load balancing kib instances (#63935)
* adds saved object key setting to load balancing kib instances

* SIEM section doc updates

* Revert "SIEM section doc updates" - wrong PR

This reverts commit fc55d90a6d.

* corrections
2020-04-21 09:26:06 +03:00
Pierre Gayvallet f6f610db47
kbn/config-schema: Consider maybe properties as optional keys in ObjectType (#63838)
* consider optional properties as optional keys in ObjectType

* fix type on security config

* fix ObjectTypeOptions
2020-04-21 07:43:35 +02:00
Jen Huang f76669b17a
Fix page layouts, clean up unused code (#63992) 2020-04-20 16:52:02 -07:00
Frank Hassanabad 2caed9b7be
[SIEM] Adds recursive exact key checks for validation and formatter
## Summary

* Adds exact check to cause failures whenever a schema is using t.exact({}) and that schema has extra keys at any level of the schema hierarchy.
* Fixes the exact check to work with unknown in a safe way and only do recursive checks for keys only when the unknown is an Object.
* Changes the output to use a format error mechanism which pushes all the errors onto one line to be consistent with the response errors. We can change this as a team to whatever we want I just put it to a comma separator as that is what the responses type checks were using downstream.
* Moves the downstream code up higher to be used within SIEM for timeline and detection engine.
* Adds tests in TDD/red light/green light fashion where I fail the extra key checks first and then pass them second.  

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-20 17:43:48 -06:00
Aaron Caldwell 2af0c6d47e
[Maps] Migrate remaining maps client files to NP (except routi… (#63859)
* Move actions over

* Move connected components over

* Move components over

* Move selectors over

* Move embeddables over. Set up legacy presence to keep legacy maps embeddables working

* Move angular and services over. Some additional top-level files

* Some file moves. Move styles over to NP

* Handle feature catalogue entry in NP. Add plugin deps to kibana.json

* Move vis registration to NP

* Clean up linting comments. Add linting comments to route controller. Move common to NP

* Add back in i18n context for embeddable

* Fix jest test paths. Fix TS lint errors

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 16:58:33 -06:00
Nathan Reese 35dab183ab
[Maps] Do not fetch geo_shape from docvalues (#63997) 2020-04-20 15:38:10 -06:00
Kaarina Tungseth e302fd8486
Vega doc changes (#63889)
* Vega doc changes

* Final changes

* Review comments
2020-04-20 15:56:41 -05:00
Chris Cowan e32fd2617a
[Metrics UI] Reorganize file layout for Metrics UI (#60049)
* [Metrics UI] Reorganize pages specific files under pages

- Restructuring pages folder
- Renaming metrics_ui to metrics
- Fixing paths in jest mocks
- Fixing AlertsFlyout path
- Fixing bad file paths from the merge

* Fixing typo compontents to components

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 13:44:19 -07:00
Brent Kimmel 5b11434f3a
Add sub-menus to Resolver node (for 75% zoom) (#63476)
* adding two buttons for 75% zoom view
* adjust palette to match comps
Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co>
2020-04-20 16:28:21 -04:00
Brian Seeders 3ce3da8a65
[FTR] Add test suite metrics tracking/output (#62515) 2020-04-20 16:14:46 -04:00
James Gowdy 53a0752841
[ML] Fixing single metric viewer page padding (#63839)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 19:37:26 +01:00
Matthias Wilhelm d69b1a0e39
[Discover] Allow user to generate a report after saving a modified saved search (#63623)
* Fix missing reset of initial state when saving saved searches

* Fix invalid setting of docTitle

* Add functional test
2020-04-20 20:36:09 +02:00
Joel Griffith 86922e80a8
[Reporting] Config flag to escape formula CSV values (#63645)
* Adds a new xpack.reporting.csv.escapeFormulaValues boolean to auto-escape potentially bad cells

* Treat csvs with formulas differently than those that aren't escaped

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 11:23:16 -07:00
Chris Cowan 96b3fd1fe3
[Metrics UI] Remove remaining field filtering (#63398)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 11:04:57 -07:00
Nathan Reese 635be640d5
[Maps] fix date labels (#63909)
* [Maps] fix date labels

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 10:50:54 -06:00
Wylie Conlon 7e3de56303
[TSVB] Use default Kibana palette for split series (#62241)
* [TSVB] Rainbow palette shares colors with dashboard

* Add migration

* Add charts as NP dependency

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 12:43:21 -04:00
Henry Harding 44a2c2f8f7
Ingest overview page (#63214)
* use fixed table layout

* added markup structure / css for overview page

* add flyout and links to other pages

* add "alpha" messaging at bottom of all pages

* attrs instead of defaultProps on styled components

* use FormattedMessage on alpha messaging component

* remove leftover code

* remove unused import
2020-04-20 12:10:15 -04:00
gchaps d45d78016a
[DOCS] Alerting PagerDuty benefits (#63652)
* [DOCS] Alerting PagerDuty benefits

* [DOCS] Fixes broken link

* [DOCS] Organization changes

* [DOCS] Changes to meet template and incorporate review comments

* [DOCS] Fixed formatting of bulleted list

* [DOCS] Incorporates review comments

* Update docs/user/alerting/action-types/pagerduty.asciidoc

Co-Authored-By: Mike Côté <mikecote@users.noreply.github.com>

* [DOCS] Fixes naming and other formatting issues

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2020-04-20 09:09:49 -07:00
Yara Tercero 7db7597a1d
[SIEM][Detection Engine] - Move All Rules tabs to match other tabs UI (#63920)
### Summary 

Restructure All Rules table tabs to be outside of the table, similar to other tabbed tables in UI.
2020-04-20 12:04:22 -04:00
Uladzislau Lasitsa e8c42095d2
Index pattern management UI -> TypeScript and New Platform Ready (create edit field) (#63836)
* Converted to react. Moved routes to edit_index_pattern

* Added withRouter for navigation. Fixed index_header.

* Fixed comments

* Fixed comments.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-20 19:03:01 +03:00
Melissa Alvarez 784b8beb2f
[ML] DF Analytics Classification exploration: replace table with data grid (#63757)
* update classification result to use datagrid

* consider isTraining in docCount fetch

* fix translations
2020-04-20 11:51:53 -04:00