Commit graph

42079 commits

Author SHA1 Message Date
Marco Liberati dd142b92ae
[Lens] Close dimension panel on escape key (#96783)
*  Close panel on escape key

* 👌 Stabilize callback ref

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 14:29:40 +02:00
Robert Oskamp d5a4a708f9
[ML] Functional tests - stabilize swim lane pagination test (#97214)
This PR stabilizes the swim lane pagination test by adding a retry to the assertion.
2021-04-15 14:15:10 +02:00
Dmitry Tomashevich 198be4cb8c
[TSVB] fix not populating fields list if "Auto apply" is off (#96298)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 15:11:16 +03:00
Felix Stürmer 1a7095365a
[Logs UI] Allow for missing properties on ES shard failure responses (#96768)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 13:28:26 +02:00
Maja Grubic 6501b393a2
[Discover] Runtime Fields Editor integration: Add + Delete operation (#96762)
* [Discover] Updating a functional test

* [Discover] Support for edit operation

* Fix unit tests

* Fix typescript

* Fixing failing functional test

* Fixing wrongly commented line

* Uncomment accidentally commented line

* Reintroducing accidnetally removed unit test

* Trigger data refetch onSave

* Remove refreshAppState variable

* Bundling observers together

* Clean state before refetch

* Update formatting in data grid

* [Discover] Runtime fields editor : add operation

* [Discover] Updating a functional test

* Adding a functional test

* Fixing package.json

* Reset fieldCount after data fetch

* [Discover] Updating a functional test

* Don't allow editing of unmapped fields

* Add functionality

* Fix issues with mobile display

* Allow editing if it's a runtime field

* Add a functional test

* [Discover] Updating a functional test

* Add functional test

* Remove unnecessary debugger statement

* Add more tests

* Add delete functionality

* Include runtimeFields in doc search

* Add another functional test

* [Discover] Updating a functional test

* Fix failing i18n check

* Fix package.json

* Addressing PR comments

* Addressing design input

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 12:03:57 +01:00
Alexey Antonov 5686ec9b24
[TSVB] Fix error handling issue for KQL queries (#97088)
* [TSVB] Fix error handling issue for KQL queries

* remove KQLSyntaxError

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 06:31:48 -04:00
Shahzad c68eab6298
[Exploratory view] Improve/Polish components usage (#96782) 2021-04-15 11:55:57 +02:00
Maja Grubic 2fb8b92ec9
[Discover] Fix redirect from Dashboard (#97098)
* [Discover] Fix redirect from Dashboard

* Updating a unit test
2021-04-15 07:59:25 +01:00
István Zoltán Szabó 579ddd0b2e
[ML] Changes custom rule terminology on the ML UI (#96999)
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-04-15 07:53:34 +02:00
Stratoula Kalafateli c6043f0452
[XY Axis] Fixes problem with series being displayed twice (#96773)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 08:53:08 +03:00
István Zoltán Szabó b24b87a6f3
[ML] Changes text in mean recall tooltip. (#96990) 2021-04-15 07:52:38 +02:00
Nicolas Chaulet b96172e27c
[Fleet] Fleet server onboarding UI (#96867) 2021-04-15 01:22:32 -04:00
Candace Park 1cd11d4deb
[Security Solution][Endpoint][Admin] Fix policy details test warning (#97182) 2021-04-15 00:10:12 -04:00
Tiago Costa 2bb97f234a
chore(NA): moving @kbn/utility-types into bazel (#97151)
* chore(NA): moving @kbn/utility-types into bazel

* chore(NA): solve ts config errors
2021-04-15 02:33:38 +01:00
spalger 82b7082459 skip flaky suite (#97085) 2021-04-14 16:41:05 -07:00
John Schulz de4bcdb9d9
[Fleet] Rename force to revoke agent unenroll APIs (#97041)
## Summary

 - fcbc9d9 Rename `force` param to `revoke` for `/agents/{agent_id}/unenroll` & `/agents/bulk_unenroll`
 - 03b9b90 Add new `force` param

See https://github.com/elastic/kibana/issues/96873 for background

<table>
  <thead>
    <tr>
      <td rowspan="2"></td><td colspan="2">Unenroll Agent</td><td rowspan="2">Revoke API Keys</td>
    </tr>
    <tr>
      <td>Regular</td><td>Hosted</td></td>
    </tr>
  </thead>
  <tr><td colspan="4"><strong>Rename <code>force</code> to <code>revoke</code></strong></td></tr>
  <tr><td>Current <code>force=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>revoke=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Current <code>force=true</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>revoke=true</code></td><td></td><td></td><td></td></tr>
  <tr><td colspan="4"><strong>Change <code>force</code> param </strong></td></tr>
  <tr><td>Proposed <code>force=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>force=true</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>force=true</code> & <code>revoke=true</code></td><td></td><td></td><td></td></tr>
</table>

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### Changes required for consumers
Any call to `/agents/{agent_id}/unenroll` & `/agents/bulk_unenroll` which passes the `force` param should change to `revoke` to maintain the current behavior.
2021-04-14 19:27:06 -04:00
Bhavya RM f92ce3074b
Test user for maps test verifying sample data maps (#96109)
test user for sample maps test & removing geoall_writer_role from add layer
2021-04-14 19:22:18 -04:00
Lee Drengenberg 3270c64271
add images and content for functional UI test debugging tutorial (#96790) 2021-04-14 18:05:13 -05:00
Constance 2a281c99c6
[App Search] Refactor out a shared MultiInputRows component (#96881)
* Add new reusable MultiInputRows component

- basically the CurationQuery component, but with a generic values var & allows passing in custom text for every string

* Update CurationQueries with MultiInputRows

* Update MultiInputRows to support on change behavior

- for upcoming Relevance Tuning usage

* Update Relevance Tuning value boost form to use new component

- relevance_tuning_form.test.tsx fix: was getting test errors with mount(), so I switched to shallow()

* Change submitOnChange to onChange fn

- more flexible - allows for either an onSubmit or onChange, or even potentially both

* Convert MultiInputRowsLogic to keyed Kea logic

- so that we can have multiple instances on the same page - primarily the value boosts use case

* Update LogicMounter helper & tests to handle keyed logic w/ props

* [Misc] LogicMounter helper - fix typing, perf

- Use Kea's types instead of trying to rewrite my own LogicFile
- Add an early return for tests that pass `{}` to values as well for performance

* PR feedback: Change values prop to initialValues

+ bonus - add a fallback for initially empty components
+ add a test to check that the logic was mounted correctly

* PR feedback: Remove useRef/on mount onChange catch for now

- We don't currently need the extra catch for any live components, and it's confusing
2021-04-14 18:11:25 -04:00
Rashmi Kulkarni 3ba640403f
unskip accessibility - dashboard_edit_panel tests (#96710)
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 15:05:12 -07:00
Zacqary Adam Xeper deaa7794d5
[Fleet] Add ability to specify which integration variables should be configurable (#97163) 2021-04-14 17:00:18 -05:00
Tim Sullivan d72a7afbf4
[rfc][skip-ci] Screenshot Mode Service (#93496)
* [Reporting] Screenshot Service RFC

* rewrite summary

* simplify design

* Update 0009_screenshot_mode_service.md

* mention the 3 screenshot report apps

* try not to say this is a high-level service

* clarify that print media css is just ok

* clarify the intent

* drop the `app`

* add the possibility to test screenshot mode through a URL parameter

* keep it more low-level

* keep the discussion high level

* move a sectioin of text
2021-04-14 14:21:28 -07:00
Jason Stoltzfus e9eff7181a
Fixed relevance tuning (#97172) 2021-04-14 16:50:42 -04:00
Scotty Bollinger af9129b584
[Workplace Search] Source row and Group Manager Modal bugfixes (#97166)
* Add spacing to group manager modal

* Add error state to source row

This mimics the design pattern from the overview page
2021-04-14 16:25:59 -04:00
Joe Reuter 9602896f9e
Discover: Limit document table rendering (#96765) 2021-04-14 21:06:28 +02:00
Tiago Costa 0bfa5aaf01
chore(NA): moving @kbn/tinymath into bazel (#97022)
* chore(NA): moving @kbn/tinymath into bazel

* chore(NA): fixed jest tests

* chore(NA): simplified tsconfig file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 14:49:19 -04:00
Scotty Bollinger 3bc2952216
[Workplace Search] Bypass UnsavedChangesPrompt for tab changes in Display Settings (#97062)
* Move redirect logic into logic file

* Add logic to prevent prompt from triggering when changing tabs

The idea here is to set a boolean flag that sends false for unsavedChanges when switching between tabs and then sets it back after a successful tab change

* Keep sidebar nav item active for both tabs

* Add tests
2021-04-14 13:28:00 -04:00
Dima Arnautov 096536647f
[ML] fix vertical overflow (#97127) 2021-04-14 13:11:44 -04:00
Ross Wolf e35ecaa378
[Security] Adds pre-packaged rule updates through the "Prebuilt Security Detection Rules" Fleet integration (#96698)
* Make the prepackaged rules functions async
* Fix type for getPrepackagedRules mock
* Install updates from saved objects & FS
* Mock getLatestPrepackagedRules instead of getPrepackagedRules
* Cleanup ruleAssetSavedObjectsClientFactory.all
* Fix comment for "most recent version"
* Switch to ruleMap.get() for less typescript errors
* Remove unneeded constants
* Fix SO.attributes sig and use custom validation
2021-04-14 12:57:50 -04:00
Marshall Main ff7c5330ad
[Security Solution] Converge detection engine on single schema representation (#96186)
* Replace validation function in signal executor

* Remove more RuleTypeParams usage

* Add security solution rules migration to alerting plugin

* Handle and test null value in threshold.field

* Remove runtime normalization of threshold field

* Remove signalParamsSchema

Co-authored-by: Davis Plumlee <davis.plumlee@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 12:53:46 -04:00
Alexey Antonov 4c33bfd979
Update VisualizationNoResults component (#97092)
* Update VisualizationNoResults component

* update JEST

* fix font size
2021-04-14 12:35:23 -04:00
Greg Thompson d679035664
Upgrade EUI to v32.0.4 (#96459)
* eui to 31.12.0

* type updates

* snapshot updates

* snapshot updates

* euiavatarprops

* eui to 32.0.3

* euicard updates

* update test
2021-04-14 11:27:36 -05:00
Alison Goryachev 813681eb08
[Upgrade Assistant] Redesign overview page (#95346) 2021-04-14 12:21:46 -04:00
Tim Sullivan 1615d5f62b
Reporting: Refactor functional tests with security roles checks (#96856)
* Reporting: Refactor functional tests with security roles checks

* consolidate initEcommerce calls

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 09:20:59 -07:00
Jason Stoltzfus ec6f652cc5
[App Search] Remaining Result Settings work (#96974) 2021-04-14 12:14:57 -04:00
Phillip Burch 4c00710be8
[Metrics UI] Add Log Rate to the metrics tab (#96596)
* Add Log Rate to the metrics tab

* Add custom metrics to Metrics tab

* Remove unused variables

* Review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 10:46:26 -05:00
Zacqary Adam Xeper 7a070e893d
[Fleet] Add preconfiguration to kibana config (#96588) 2021-04-14 10:43:08 -05:00
Scotty Bollinger fe00b68aa2
[Workplace Search] Update ID label to Source Identifier (#96970) 2021-04-14 11:39:56 -04:00
Marta Bondyra 7c2cbd39c4
[Lens] respect custom labels for fields in time series visualizations (#96937) 2021-04-14 17:18:45 +02:00
Robert Oskamp ad628878b1
[ML] security_network module - fix type of defaultIndexPattern (#97096)
This PR fixes the defaultIndexPattern type in the security_network module definition.
2021-04-14 16:43:37 +02:00
Thomas Watson e2eeb44613
Bump hosted-git-info from 2.5.0/3.0.7 to 2.8.9/3.0.8 (#96987) 2021-04-14 10:36:36 -04:00
Alison Goryachev b401cbb3eb
export DomainDeprecationDetails type from public + fix typo (#96885) 2021-04-14 09:51:47 -04:00
Tiago Costa e36650de70
chore(NA): moving @kbn/config-schema into bazel (#96273)
* chore(NA): moving @kbn/config-schema into bazel

* chore(NA): correctly format packages for the new bazel standards

* chore(NA): correctly maps srcs into source_files

* chore(NA): remove config-schema dep from legacy built packages package.jsons

* chore(NA): include kbn/config-schema in the list of bazel packages to be built

* chore(NA): change import to fix typechecking

* chore(NA): remove dependency on new package built by bazel

* chore(NA): be more explicit about incremental setting

* chore(NA): include pretty in the args for ts_project rule

* docs(NA): include package migration completion in the developer getting started

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 14:38:10 +01:00
Scotty Bollinger 366a537d37
[Workplace Search] Add breadcrumbs to Role mappings (#97051)
* Update Workplace Search nav to align with App Search

* Add constants to shared

* [App Search] Use shared constants

* [Workplace Search] Add breadcrumbs to Role mappings

* Enable shouldShowActiveForSubroutes
2021-04-14 08:25:18 -05:00
Scotty Bollinger 1630c14a15
[Workplace Search] Remove shadows from Source overview panels (#97055) 2021-04-14 10:14:12 -03:00
Alexey Antonov bcc1acb1dd
[TSVB][performance] remove visPayloadSchema.validate (#97091)
* [TSVB][performance] remove visPayloadSchema.validate

Part of: #97061

* Update vis.ts
2021-04-14 15:33:41 +03:00
Alexey Antonov 3b7ef07eca
[TSVB] Field validation should not be performed on string indexes. (#97052)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 15:32:44 +03:00
Ahmad Bamieh 69f570f06a
[Usage collection] Usage counters (#96696)
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
2021-04-14 08:21:11 -04:00
Vadim Dalecky e361e21622
UI actions readme (#96925)
* docs: ✏️ improve UI actions plugin readme

* docs: improve trigger description

* docs: remove unnecessary comma

* chore: 🤖 update autogenerated docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 14:12:27 +02:00
Stratoula Kalafateli 23e18b93eb
[TSVB] Enable brush for visualizations created with no index patterns (#96727)
* [TSVB] Enable brush for visualizations created with no index patterns

* Fix comments typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 13:48:00 +03:00