Commit graph

13643 commits

Author SHA1 Message Date
MadameSheema dd9e367ce2
[Security Solution] Cypress reorganization (#88687)
* moves tests to different folders

* cases test files renaming

* renames detection alerts test files

* renames detection rules test files

* renames exceptions test files

* splits inspect test files

* renames timeline templates file tests

* renames timelines file tests

* renames url file tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-20 13:25:24 +01:00
Dmitry 841655c1f7
[FTR] add custom runner and config to run load tests (#88409)
* add custom runner and config for load testing

* add full maven command

* add jenkins script

* run tests against build

* run kibana with no-base-path flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-20 13:23:10 +01:00
Walter Rafelsberger 2ec6f6c6b2
[ML] Column Charts Unit/Functional Tests (#88176)
- Unit and functional tests for the data grid mini histograms.
- canvasElement service.
2021-01-20 13:01:33 +01:00
Cauê Marcondes 7e1549d889
[APM] FTR with Cypress (#88142)
* usgin esarchive to load e2e

* using esarchive to load e2e

* using esarchive to load e2e

* using esarchive to load e2e

* using esarchive to load e2e

* chaning archiver script to copy file to both e2e and api tests

* chaning archiver script to copy file to both e2e and api tests

* removing task folder

* running e2e through script

* using cy.clock to set now

* adding basic test

* adding cypress run script

* adding cypress run script

* fixing some stuff

* excluding new e2e dir

* adding new project for new e2e dir

* adding new project for new e2e dir

* unformatting file

* adding unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-20 12:54:12 +01:00
Shahzad 37cc7af49d
[User Experience] UX use replace history instead of push on first load (#88586)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-20 11:29:44 +01:00
Yara Tercero f718e90a81
[Security Solution][Exceptions] - Remove exceptions table search #88784 (#88784)
## Summary

Temporarily addresses https://github.com/elastic/kibana/issues/88450

A follow PR will address full fix.

### Issue
Exceptions table search not functioning as expected.

### Diagnostic
The exception list SO properties are mapped as keywords, meaning ES does not tokenize them. Need to add a `text` mapping for fields we want to search on in order for search to work as expected. Expectations for exceptions table search being:
- I can search `Endpoint Security` and get results that match `Endpoint` or `Security`
- I can search `"Endpoint Security"` and it will conduct an exact match search

It's too late in the release cycle for mappings updates - a follow up PR will properly fix search.

### Without Search
<img width="1766" alt="Screen Shot 2021-01-19 at 7 52 01 PM" src="https://user-images.githubusercontent.com/10927944/105112279-aed64300-5a90-11eb-95fc-1922eb2055e9.png">

 
### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-01-19 23:04:52 -07:00
Devin W. Hurley 4435006217
don't do a full failure because cross cluster search could be giving us a false negative, also update the text to better reflect this (#88763)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 22:58:11 -07:00
Brandon Kobel 170a2956c8
Updating the License (#88343)
* Updating the Licenses, except for applying eslint, building

* Applying ESLint rules,building @kbn/pm, regenerating api docs
2021-01-19 17:52:56 -08:00
Constance 3168b7d851
[App Search] Analytics - add reusable Layout & Header + basic subroute view components (#88552)
* Add AnalyticsUnavailable component

* Add AnalyticsHeader component

+ update AnalyticsLogic to store allTags prop passed by API

+ convertTagsToSelectOptions util helper

* Add AnalyticsLayout that all subroutes will utilize

- Handles shared concerns of:
  - Loading state & unavailable state
  - Flash messages & log retention callout
  - Reusing the header component
  - Fetching data
  - Reloading data based on filter updates

* Add very basic subroute views that utilize AnalyticsLayout

* Update QueryDetail pages to set breadcrumbs

* Fix QueryDetail breadcrumbs to not 404 on the 'Query' crumb

Redirect to the /analytics overview since we don't actually have a /query_details overview

* [PR feedback] Enforce date range defaults on the client side

- instead of using coincidence to sync our client side default range & server default range

- tags remain ''/undefined as default

* [PR feedback] Add explicit query vs analytics view prop

- to help devs more quickly distinguish at a glance whether a view will fetch analytics data or query data

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 15:20:01 -08:00
ymao1 6d1c010607
[Alerting] Fixing broken Alerts view when no Global All Kibana privilege (#88727)
* Making kibanaFeatures an optional parameter and catching error on plugin start

* Gracefully handle 404 errors when no access to features endpoint

* Adding functional test
2021-01-19 18:14:56 -05:00
Justin Kambic 4af5c117fa
[Uptime] [Overview Page] Only render up/down drawer badges when items > 1 (#88524)
* Only render location status badge when there are actually locations to display.

* Add aria-label to describe location section.

* Update test data to reflect real-world data better. Refactor enzyme tests.

* Refactor component test.

* Fix test names.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 17:51:10 -05:00
Yara Tercero 5f53b649c6
[Security Solution][Endpoint Exceptions] - Fix bug where endpoint exceptions list not created when expected (#88232)
## Summary

Addresses issue issue 87110

**Issue**
When prepackaged rules were created during the Endpoint Security enrollment flow, the endpoint exceptions list was failing to be created. As a result, when a user navigated to the `Endpoint Security` rule to add an exception it would display errors and not allow a user to add exceptions.
2021-01-19 17:36:05 -05:00
Lisa Cawley 1db32352b2
Use doc link service for Maps help (#88631) 2021-01-19 13:52:42 -08:00
Thomas Neirynck 66c0cc22c5
[Maps] EMS baselayer should load cleanly (#88531) 2021-01-19 16:50:07 -05:00
Marshall Main 90f2abd361
[Security Solution][Detections] Await promises to ensure promise rejection does not crash kibana (#88564)
* Await promises to ensure promise rejection does not crash kibana

* Fix test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 16:11:25 -05:00
Devin W. Hurley a75909eecb
[Security Solution] [Detections] Fixes messaging for when an index is missing a timestamp field to sort on (#87489)
* partial failure if unmapped timestamp override field or unmapped @timestamp field

* fixes unit tests

* fix threat match rules integration tests

* unskip integration test for partial failure when not all indices have timestamp override field

* replace ts-expect-error in test with a partial type

* use destructured param and != null for ternary

* fix typo in utils.test.ts

* remove unnecessary optional chaining

* replace logger.debug with logger.error and update test case for threat match integration test to search auditbeat-* instead of empty index causing it to search wrong indicies like .kibana, etc..

* adds unit test to write a success when all shard failure messages are no mapping found for a timestamp field, moves privilege check and timestamp field cap check into utility functions and updates code to be more functional

* need to write an error, not a partial failure, if the rule cannot read ANY of the indices provided

* use isEmpty for checking timestamp override field param and remove let from hasReadIndexPrivileges util function

* replace references to helpers/toPromise | toError to use common/fp_utils, remove unnecessary flow wrappers, no need for checking if timestampField is null since it is typed as string and we do the checking beforehand, add a const bool to clean up logic for getting timestampFieldOverride

* replace usage of flow with pipe to make arguments explicit
2021-01-19 15:54:05 -05:00
Nathan Reese 07849ce42e
Remove circular depencency between maps_legacy and region_map and tile_map plugins (#88265)
* Remove circular depencency between maps_legacy and region_map and tile_map plugins

* update imports in maps plugin

* tslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 13:40:24 -07:00
Michael Olorunnisola 7ba1d91770
[Security_Solution][Resolver] Fix Text Overflow (#88679) 2021-01-19 15:26:28 -05:00
Michael Olorunnisola 0a1af80631
[Security_Solution][Resolver] Fix full screen graph (#88513)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 15:19:57 -05:00
Thomas Neirynck 55d1065c93
[Maps] Always show solution layers (#86053) 2021-01-19 14:07:48 -05:00
Thomas Neirynck dc30e94556
[Maps] Always check license at plugin startup (#87873) 2021-01-19 14:07:30 -05:00
Nathan Reese c272d35b65
[Maps] scale control (#88031)
* set width

* cleanup

* add show scale toggle in map settings

* tslint

* remove unmapped css comment

* move scale for full screen mode so they do not collide

* change default and add unit test for scale_control

* simplify scale

* add tilda to label

* update jest expects

* eslint

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 11:50:55 -07:00
ymao1 60f8b24529
[Actions] Removed double parsing when passing action url for validation (#87928)
* Removed double parsing when passing action url for validation

* Fixing functional test

* PR fixes

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 13:40:49 -05:00
Marco Liberati 74fac0c009
[Lens] Fix Median operation visibility in Dimension panel (#88474)
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 19:03:51 +01:00
Shahzad 211312d6a6
[APM UI] Remove unnecessary package usage (#88646) 2021-01-19 18:20:13 +01:00
Shahzad 7d14229519
[Uptime] Scale waterfall chart to handle large number of requests (#88338) 2021-01-19 17:18:26 +01:00
Constance eb4cb3d1dc
[Enterprise Search] Miscellaneous test cleanups (#88525)
* Update older tests mocking useValues to setMockValues

* Update older logic tests to use newer LogicMounter helper

- NOTE: shared logic files are still using resetContext however, in order to not accidentally override/mock kea + since they should be testing their own mount helpers

* Merge/DRY kea.mock helpers into a single import

* Remove unnecessary kea.mock file imports

- the automock already happens when you import something from the kea.mock file
- in some cases in WS the mock just wasn't needed

* Newline linting

- Do I need a hobby? yes
- Is this my hobby? ...maybe

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 07:49:10 -08:00
Jean-Louis Leysens fbf600d7fc
[ILM] Searchable snapshot default "enabled" on cloud (#88582)
* default searchable snapshot to enabled on cloud when creating a new policy

* added test for searchable snapshot on new policy on cloud
2021-01-19 16:24:40 +01:00
Alejandro Fernández Haro 7c9b11476d
[Application Usage] Functional test to validate the full list of appIds in the schema (#88080)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 14:44:08 +00:00
Tiago Costa 659c157cba
skip flaky suite (#85208) 2021-01-19 13:02:13 +00:00
John Schulz c52339e606
[Fleet][EPM] If proxy url has username & password, add to Node's Agent options (#86807)
## Summary

A user received a `407` response when using a `registryProxyUrl` format like `http://user:pass@host:port`

I believe the issue is we're not including the [`auth` property as described in this issue](https://github.com/TooTallNate/node-https-proxy-agent/issues/12#issuecomment-216098644). 

Add tests to ensure it only adds `auth` if username & password are given.

### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

```
  getProxyAgentOptions
    auth property
      present & correct if given username and password
        ✓ proxy url is http (1 ms)
        ✓ proxy url is https
      missing if not given username and password
        ✓ proxy url is http
        ✓ proxy url is https
```
2021-01-19 07:24:11 -05:00
James Gowdy b00fe2a4e7
[ML] Fix rare page crash when deleting anomaly detection job (#88622) 2021-01-19 11:27:19 +00:00
Marco Liberati 1f4ee91908
[Lens] Use first decimal when required for data summaries (#88463)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 12:20:12 +01:00
MadameSheema df99216bae
improves timeline creation cypress test (#88628) 2021-01-19 10:07:29 +01:00
Cauê Marcondes f7d9212c34
[APM] Query for service metadata always uses transaction documents (#87622)
* using metrics over transaction index

* addressing PR comments

* addressing PR comments

* addressing PR comments

* removing uiFilters from metadata apis

* addressing PR comments

* addressing PR comments

* removing terminateAfter

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-19 09:24:54 +01:00
Joe Portner a43d609b09
Fix changing password in Cloud (#88544) 2021-01-18 19:00:22 -05:00
Mikhail Shustov 6e4c70848d
[Core] Remove public context (#88448)
* remove client side context

* update docs

* fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 21:47:53 +01:00
Scotty Bollinger 5f0e9f4248
[Workplace Search] Migrates Org Settings tree (#88092)
* Initial copy/paste of component tree

Only does linting changes and lodash import

* Replace withRouter HOC with hooks

Use useLocation and no longer pass around history, using the KibanaLogic navigateToUrl method instead

* Migrate LicenseCallout component

* Update paths

Also change name of component to OauthApplication as the default import was named that before

* Remove conditional and passed in flash messages

This is no longer needed with the Kibana syntax. Flash messages are set globally and only render when present.

* Replace removed ConfirmModal

In Kibana, we use the Eui components directly

* Use internal tools for determining license

* Fix a bunch of type issues

* Remove telemetry settings section

We no longer control telemetry in Workplace Search. It is handled by Kibana itself

* Add SettingsSubNav component

* Add route and update nav

* Remove legacy AppView and sidenav

* Clear flash messages globally

* Remove global name change method call

The global org name is not used anywhere outside of this section so we no longer need to update the global organization object as it is re-fetched when this section is entered.

Previously, we displayed the org name in the sidebar but that has been removed in Kibana

* Refactor saveUpdatedConfig

We recently split out the logic from SourceLogic to the new AddSourceLogic and in settings, we were calling the saveSourceConfig method from the SourceLogic (now in AddSourceLogic) file and passing a callback that set the flash messages from that component’s state.

Now, we set the flash messages globally and no longer need to have a saveUpdatedConfig method in the logic file, but can call it directly in the component and the flash messages will be set globally.

* Update logic file to use global flash messages

* Update server routes

* Replace Rails http with kibana http

* Fix subnav

* Update routes to use consistent syntax

We use this method across both Enterprise Search products in Kibana

* Shorten nav item copy

This would be the only place in the sidebar with a nav item breaking to a second line.

* Fix some random typos

* Replace React Router Link with helper

* Add i18n

* Remove redundant clearing of flash messages

This happens automatically now in the global flash messages logic; route changes trigger clearing of messages

* Add unit tests for components

* Add tests for router

* Store oauthApplication in mock for reuse

* Add tests for SettingsLogic

* Fix typo

* Remove unncessary imports

Copied from this PR:
https://github.com/elastic/kibana/pull/88525

* Refactor to use new helpers when mocking

See https://github.com/elastic/kibana/pull/88494

* Update logic test to use error helper

See https://github.com/elastic/kibana/pull/88422

* Fix type issue

* Fix whitespace lint issue

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 14:14:42 -06:00
Vadim Dalecky 89dc4f2e00
test: 💍 enable URL drilldown test (#88580) 2021-01-18 21:05:29 +01:00
Devon Thomson af7a577b09
[Time to Visualize] Enable by Default (#88390)
* Enable Time to Visualize by Default
2021-01-18 13:51:32 -05:00
Scotty Bollinger 33084df3ad
[Workplace Search] Add tests for Custom Source Display Settings (#88547)
* Add type

Our code allows for an array but the type did not.

* Add exampleResult mock

* Add test-subj attrs

* Remove FIXMEs for linter errors

The linter was complaining when these were initially migrated, stating that a11y required all mouse events to have focus and blur events. This commit uses the hover events for those. EuiColorPicker was added in error and removing them does not disrupt the linter.

* Add tests for components

* Add test for router

Also updates routes to use consistent syntax and remove the render prop

* Use helper instead of history.push

* Remove redundant resetDisplaySettingsState method

Since all this does is wrap the clearFlashMessages function, we can just call it directly. Also use the new clearFlashMessages helper instead of using FlashMessageLogic directly insideof toggleFieldEditorModal

* Add tests for DisplaySettings container

* Fix a typo and associated tests

Also adds ‘subtitleField’ that is needed in a future test

* Add constants from PR to test

https://github.com/elastic/kibana/pull/88477

* Add tests for DisplaySettingsLogic

* Remove unused imports and use new mocks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 11:28:37 -06:00
Marco Liberati 898385c2e2
[Lens] Clean full reference operation error state when switching to other operation (#87064)
* 🐛 Make sure to check incomplete columns before saved ones

* ⚗️ Try a different approach

* 🐛 Isolate the fullRef to field transition and trigger the removal + tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 16:58:23 +01:00
Kerry Gallagher 53f4b21a81
[Logs UI] Add sorting capabilities to categories page (#88051)
* Add sorting capabilities to categories page

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
2021-01-18 14:12:29 +00:00
Anton Dosov b8d43139f3
[Search Sessions] fix flaky relative time range test (#88359) 2021-01-18 15:05:47 +01:00
Robert Oskamp f0d20097a1 [ML] Disable a11y tests 2021-01-18 13:53:27 +01:00
Christos Nasikas f7fdda5db7
[Security Solution][Case] Fix patch cases integration test with alerts (#88311)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 09:59:26 +02:00
Frank Hassanabad 2abbd808c7
[Security Solutions][Detection Engine] Removes duplicate API calls (#88420)
## Summary

This removes some duplicate API calls to reduce pressure on the backend and speed up querying times within the application for the front end. This fixes some of the issues of https://github.com/elastic/kibana/issues/82327, but there are several performance improvements that are going to be needed to help reduce the slowness when you have a system under a lot of pressure.

So far this removes duplication for these API calls when you are on the manage detection rules page:

```ts
api/detection_engine/rules/_find
api/detection_engine/rules/_find_statuses
api/detection_engine/tags
```

<img width="2465" alt="Screen Shot 2021-01-14 at 3 53 21 PM" src="https://user-images.githubusercontent.com/1151048/104662295-c031e080-5687-11eb-92d7-18b9ad355646.png">

* This hides the tags and searches while the page is loading to avoid duplicate calls when the pre-packaged rules counts come back
* This untangles the refetchRules from the refetchPrePackagedRulesStatus as two separate calls to avoid issues we have with re-rendering and re-calling the backend.
 
### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-01-17 09:18:34 -07:00
Liza Katz 7a87c33afc
Fix log msg (#88370)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-17 00:05:06 +02:00
Tim Sullivan abffb19889
[Test] Add tag cloud visualization to dashboard in functional test for reporting (#87600)
* add tag cloud to dashboard in kibana archive

* add pdf snapshot testing to downloaded pdfs

* update png baseline image

* remove pdf snapshot testing

* rename mislabeled variable

* fix test comparison

* remove unnecessary pdf utf8 checks

* Update screenshots.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-15 22:05:14 -07:00
Yuliia Naumenko 5c112b8b5a
[Alerting] Migrate Event Log plugin to TS project references (#81557)
* [Alerting] Migrate Event Log plugin to TS project references

* fixed faling typechecks

* fixed path to spaces plugin ts file

* fixed missing include

* added fix for mapping.json

* replaced package.json get version with kibanaVersion from plugin initial context

* fixed build

* fixed typechecks

* fixed tests
2021-01-15 19:07:45 -08:00