* Adding readonly badge to the discover application
* Dashboard get a badge
* Visualize gets a badge
* Timelion gets a badge
* Canvas gets a badge
* Maps gets a badge
* Infra gets a badge
* Graph gets a badge
* Dev Tools gets a badge
* Index Patterns get badges
* Advanced Settings get badges
* Infra and i18n are super chill friends
* Using proper i18n prefix for xpack
* Adding badges to the uptime application
* APM gets a badge!
* Adding functional tests for the discover read-only badge
* Functional tests for everyone!
* Removing unused import
* Fixing chrome service mock
* Switching from ChromeBadge | null to ChromeBadge | undefined
* Fixing canvas badge assertst
* Fixing Logs ui capabilities
* More ChromeBrand | null to ChromeBrand | undefined related changes
* Using named badges
* Revert "Using named badges"
This reverts commit c0e341bee1.
* i18n'ing the uptime read-only badges
* Adding ChromeService tests for badges
* Starting to add tests for the legacy badge API
* Changing capitalization of "Read Only" to "Read only"
* Adjusting styles
* Adding $setupBadgeAutoClear tests
* Changing the badge tooltip
* Fixing timelion i18n prefix
* Changing where Canvas sets the breadcrumbs
* Using a read-only badge with an icon
* Update x-pack/plugins/canvas/public/angular/controllers/canvas.js
Co-Authored-By: kobelb <brandon.kobel@gmail.com>
* Update src/legacy/core_plugins/timelion/public/app.js
Co-Authored-By: kobelb <brandon.kobel@gmail.com>
* Changing discover's read-only verbiage
* Removing tests for code that moved to an untested part of Kibana
* Fixing issues introduced with the rebase
* Fixing priv ileges snapshot
* Adding back dropped docs
* Fixing plugin plugin doc
* Ensuring iconType is set as well
* Updating badge api, angular components moved
* graph to Graph
* Fixing linter
* Switching from aria-label to data-test-badge-label for testing
The tabIndex allows screenreaders to work properly
* Fixing eslint error
* Fixing more issues introduced by the merge from master
* APM updates badge in React hook
* Applying changes suggested by Aleh
* chore(NA): first efforts to enable cache-loader relative paths and disable babel-register cache. chore(NA): allow to use cache-loader results everywhere as a persistent cache.
* chore(NA): last change to support cache loader across envs.
* fix(NA): cache-loader config generator function scope.
* refact(NA): static cache config for dll compiler.
* chore(NA): support for force writable cache flag. use built assets for cache on distributable.
* chore(NA): update cache-loader to last version. fix(NA): logic bug with force writable cache flag.
* chore(NA): move optimize cache to built_assets.
* chore(NA): relative paths for sourcemap configurations.
* chore(NA): remove redudant check for process.env var.
* refact(NA): simplify double negated expression.
* chore(NA): remove webpack prefix from devtoolModuleFilenameTemplate.
* chore(NA): rename cache write force flag to KBN_CACHE_LOADER_WRITABLE.
* chore(NA): readd babel register cache.
* chore(NA): change .cache to .ui_bundles_cache
* chore(NA): change .ui_bundles_cache to cache/ui_bundles
* chore(NA): update gitignore with .babel_register_cache.json
- Adds support for histogram and date_histogram aggregations for the data frame pivot wizard for group-by fields.
- Adds options to the list of group-by aggregation to let the user edit the interval where applicable.
- Adds unit tests and enzyme snapshots test files to files touched by this PR.
* EUIficate number interval
* Add type for EditorConfig
* Update functional tests
* Add placeholder
* Update placeholder
* Use FormattedMessage instead of i18n
* Set validity in the effect only
* Refactoring: add showValidation prop and remove isInvalid
* Update prop
* fix(code/frontend): should not collapse folder after click a breadcrumb
* fix(code/frontend): should highlight file when jump from typeahead
* separate to a independent test case
* Exclude usage stats when `exclude_usage` flag is specified
* Entirely excluding the usage key altogether
* Adding API integration test
* Fixing param name in comment + adding more info to comment
* Fix API test copy-pasta
* Fixing test assertion syntax
* [Maps] ignore global query layer setting
* do not include index pattern id in query bar indexPatterns when applyGlobalQuery is disabled
* update how embeddable factory extracts indexPatterns so only queryable index patterns are included in list
* support applyGlobalQuery for heatmap and getBounds
* add functional tests to join layer
* show filter section when layer has join
* move checkbox to layer settings panel
* text review
* set checkbox to false when disabled
* do not trigger refetch when global query and global filter changes and applyGlobalQuery is disabled
* rename applyGlobalQuery to getApplyGlobalQuery
* throw error in map embeddable factory if layerListJSON can not be parsed
* remove extra space
* update zoom range slider label and remove nested EuiFormRow
* Modifying the font sizes to match the design mocks and improve the visual hierarchy in the directory view.
* Reducing the margin between directory list items.
* WIP. Trying some things.
* Introduce useUrlParams hook to modify path.
* WIP code on setting/reading date range from url params.
* Create constants file for app defaults.
* Add functions for parsing supported URL parameters.
* Add index entry and update useUrlParams hook.
* Remove defaults and update application to store persisted state in the URL.
* More temp code.
* Support URL params and fix filters.
* Update Monitor page to accept URL parameters.
* Rename a test folder and add tests for new helper functions.
* Add functional test for filter query.
* Add missing prop to test component.
* Update breadcrumb functions to accept search parameters.
* Update app to support forwarding of search params in in-app links.
* Write snapshot for status bar test.
* Fix memory leak.
* Filter annotations by the last series timestamp
* Move filter logic to get_annotations.js
* Move annotation handlers to a separate file
* Make some optimizations
* Optimize getLastSeriesTimestamp()
* Reorganize helpers
* Block requests to ui_metric API if telemetry is disabled
- Export trackUiMetric helper method from ui_metric app.
- Remove createUiMetricUri helper.
- Add support for an array of metric types.
- Update README.
* Throw error if trackUiMetric is called with a string containing a colon.
* [Code] Skip all jest tests for code
* run the x-pack-intake job 40 times
* more regex
* Revert "run the x-pack-intake job 40 times"
This reverts commit 9057cf8a2e.
(cherry picked from commit 4a154fb998)
* Remove skip for testing on server. Unable to repro locally
* run kibana-ciGroup2 40 times per build
* Temporarily skip 'geo map' check
* Left out 'Rendering Test: ' in filter string
* Revert "run kibana-ciGroup2 40 times per build"
This reverts commit 103a5c9c6e.
* Review feedback. Remove 'Flaky' test ref
Attempts to make KQL syntax errors more sensical to the average user.
I initially tried to use a similar solution to the one we used for detecting usage of old lucene syntax. In other words, I tried to create rules in the grammar that would match strings containing common mistakes the user might make and throw custom error messages for each situation. This proved to be more difficult for detecting errors in the regular language. While the Lucene rules could be completely separated from the main grammar, the KQL error rules had to be mixed into the main grammar which made it much more complex and had a lot of unintended side effects.
So instead I decided to lean more heavily on PEG's built in error reporting. Giving certain rules human readable names allows the parser to use those names in the error reporting instead of auto generating a long list of possible characters that might be expected based on the matching rules. Since the PEG errors contain location information I was also able to add ascii art that points the user to exactly where the error occurred in their query string. While this approach is not quite as nice as bespoke error messages that tell the user exactly what is wrong in plain English, it's much more maintainable and I think it still results in much better error messages compared to what we have today.
I've also removed the old original kuery grammar (for queries like is(response, 200)). We were only using it to display an error if I user was still using the old syntax. This version of kuery hasn't existed since 6.3 and we've had error messages telling users this since then. I think it's safe to remove the legacy parser at this point, which greatly reduces the complexity of our error reporting.
