Commit graph

30183 commits

Author SHA1 Message Date
Paul Tavares e2230d5d86
[Endpoint] FIX: Increase tests sleep default duration back to 100ms (#55492)
Revert `sleep()` default duration, in the saga tests, back to 100ms in order to prevent intermittent failures during CI runs.

Fixes #55464
Fixes #55465
2020-01-22 11:55:41 -05:00
Larry Gregory 5d501411e1
Role Mappings - change default 'realm' field option to 'realm.… (#55555) 2020-01-22 11:18:22 -05:00
Yuliia Naumenko 5b641b706b
[Alerting] Exposed actionGroups in alertTypeRegistry API (#55495)
* Exposed actionGroups in alertTypeRegistry API

* Fixed functional tests
2020-01-22 08:16:51 -08:00
Dmitry Lemeshko ff2bfe9146
[code search] removing test config and page object (#55273)
* [code search] delete PO and test config

* remove import

* remove from export

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 17:05:44 +01:00
patrykkopycinski 320b608315
[SIEM] Implement 7.6 Aggregated Feedback (#55347) 2020-01-22 16:52:55 +01:00
Daniil Suleiman bda48391a8
Remove the VisEditorTypesRegistryProvider (#55370)
* Remove the VisEditorTypesRegistryProvider

* Update the doc

* Resolve conflicts in legacy.ts
2020-01-22 18:45:41 +03:00
Thomas Neirynck a8674e6663
[Maps] Do not clear non-ordinal fields when modifying field-settings in tooltips or sort-order (#55483) 2020-01-22 10:37:28 -05:00
Victor Martinez 7436eb6c58 [build] Override org.label-schema Docker labels (#53817)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 09:06:15 -06:00
Joe Reuter 4515cb1e55
Fix missing labels on certain axes and label filter configurations (#47563) 2020-01-22 15:59:56 +01:00
Joe Reuter 7c40a24fcc
Tutorial migration (#54910) 2020-01-22 15:31:11 +01:00
Alison Goryachev 7b145bffa0
[Watcher] Add support for additional watch action statuses (#55092) 2020-01-22 08:35:18 -05:00
Walter Rafelsberger 07d1dac0da
[ML] Fix entity controls update. (#55524)
Fixes an issue where the options in the internal state of the EntityControl component wouldn't update after a prop change. This had the effect that after a job change via the job selector, the entity control dropdown would stay empty.
2020-01-22 14:28:28 +01:00
James Gowdy d47d20e758
[ML] Fixing ML's watcher integration (#55439) 2020-01-22 13:09:58 +00:00
Pete Harverson b8b1c0283d
[ML] Fixes permissions checks for data visualizer create job links (#55431)
* [ML] Fixes permissions checks for data visualizer create job links

* [ML] Edits to permissions check following review

* [ML] Revert unintentional additions
2020-01-22 13:07:07 +00:00
Jean-Louis Leysens b8d35105c7
[SearchProfiler] Move out of legacy (#55331)
* Initial move of searchprofiler into new platform directory, lots of things need testing

* Whitespace, clean up types and remove unused files

* First iteration of end-to-end plugin working

- Updated license check to only check for presence of basic license (not search profiler as a feature
- Updated the payload: removed types from validation
- Also added README in public regarding the location of styles

* Added extractProfilerErrorMessage function to interface with new error reporting from profiler endpoint

* Fix paths to test_utils

* Update I18n for search profiler

* Fix react hooks ordering bug with license status updates and fix test (wait for first license object before rendering)

* Added index.ts file to common in searchprofiler route
Marked types and values as internal
Removed unnecessary "async" from function
Update import to not use "src" alias

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 13:58:18 +01:00
Jean-Louis Leysens d23d8f0afd
Restore 200 OK + response payload for save and delete endpoints (#55535) 2020-01-22 13:52:53 +01:00
Devin W. Hurley e828a12954
[SIEM] [Detection Engine] Log time gaps as failures for now (#55515)
* log a failure to failure history if time gap is detected. stop-gap solution until a feature is fully fleshed out to report this and future messaging / monitoring.

* write date the gap warning occurred in the last_failure_at field, along with the status_date field.
2020-01-22 07:50:32 -05:00
Mikhail Shustov 3e69ea5f01
[NP] KibanaRequest provides request abortion event (#55061)
* add aborted$ observable to KibanaRequest

* complete observable on request end

* update docs

* update test suit names

* always finish subscription

* address comments
2020-01-22 13:34:35 +01:00
Shahzad c6f9eff9f6
[Uptime] Ping List Disable expand row if no body present (#54898)
* update ping list

* update snap

* updated body

* update snaps

* fix i18n

* updated translation

* updated tests
2020-01-22 10:55:04 +01:00
Daniil Suleiman ed04b17e0e
Move test utils inside the input_control_vis (#55169)
* Move test utils to an appropriate folder

* Change imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 12:41:33 +03:00
Sébastien Loix 1f10da865a
[Mappings editor] Add missing relations parameter (#55003) 2020-01-22 15:02:39 +05:30
Ben Skelker 34333aa1fd
fixes typos (#55521) 2020-01-22 10:29:54 +02:00
Dima Arnautov 5e711e423a
[ML] Fix counters and percentages for array fields on the Data visualizer page (#55209)
* [ML] update data visualizer endpoint to check doc counts

* [ML] fix mock for cardinality tests

* [ML] use actual field name for agg filtering instead of safeFieldName

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 07:08:58 +01:00
Frank Hassanabad b5c6c9a3e3
[SIEM][Detection Engine] Tags being turned into null
## Summary

Test:

1.) Add a tag to a new rule
2.) Activate the rule
3.) Ensure the tag does not go away

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 21:56:35 -07:00
The SpaceCake Project 31e6a3b75a
rules part deux (#55507)
cuts and metadata additions
2020-01-21 22:59:33 -05:00
Lisa Cawley ccbb2863e7
[DOCS] Add tip for using elasticsearch-certutil http command (#55357) 2020-01-21 18:54:54 -08:00
Frank Hassanabad 8f0c413ef5
[SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (#55488)
## Summary

* This fixes the schema accepting values the UI cannot handle at this point with severity. It's best to just set it to a small fixed enumeration of values.
* From feedback from people the values should have more defaults and be more consistent in the schema so gave defaults for `from`, `to`, and `interval`.
* Removed dead query examples that cannot happen because immutable cannot be set by end users anymore
* Changes the version and other sections to be integer only and not allow floats
* Added unit tests

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 19:02:28 -07:00
Xavier Mouligneau 5344702246
[SIEM] Detections create prepackage rules (#55403)
* update extra action on rule detail to match design

* remove experimental label

* allow pre-package to be deleted + do not allow wrong user to create pre-packages rules

* Additional look back minimum value to 1

* fix flow with edit rule

* add success toaster when rule is created or updated

* Fix Timeline selector loading

* review ben doc + change detectin engine to detection even in url

* Succeeded text size consistency in rule details page

* fix description of threats

* fix test

* fix type

* fix internatinalization

* adding pre-packaged rules

* fix bug + enhance ux

* unified icon

* fix i18n

* fix bugs

* review I

* review II

* add border back
2020-01-21 20:31:11 -05:00
Tim Sullivan c531eb477b
[Reporting] Convert CSV Export libs to Typescript (#55117)
* [Reporting] Convert CSV Export libs to Typescript

* fix jest tests

* more ts conversion

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 17:39:03 -07:00
Nathan Reese 04374e665c
[Maps] show field type icons in data driven styling field select (#55166)
* [Maps] show field icons in data driven styling field select

* only show origin group label when there is more then one origin

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 18:52:13 -05:00
Patrick Mueller b78c1b1042
Adds event log for actions and alerting (#45081)
initial code for event log

see issue https://github.com/elastic/kibana/issues/45083
2020-01-21 18:00:08 -05:00
Frank Hassanabad db1a64da76
[SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating
## Summary

This fixes halting, infinite creation of signals, and cyclic issues with signals when they are reflected on their own index. Without this fix, you could get a user who looks back at a signals index as both their input and output index and forever generates new signals forever and ever and ever until the heath death of the universe. 

* Changes the data structure to support parent and ancestors
* Adds a check for the parent and ancestors
* Adds README.md and in-depth testing of cyclic concepts
* Adds README.md and in-depth testing of depth levels of signal concepts
* Added unit tests for both use cases
* Removed extra console.log statement found in the code base

Follow the two README.md's included for testing and explanation of how it works.

See `test_cases/signals_on_signals/depth_test`
See `test_cases/signals_on_signals/halting_test`

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 15:29:43 -07:00
Frank Hassanabad 31d3821598
[SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud
## Summary

* Adds needed `/` to the beginning of cloud requests from Kibana -> ES

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 15:28:49 -07:00
Thomas Neirynck 391c348a97
remove incorrect config (#55427) 2020-01-21 16:45:40 -05:00
Matt Bargar 884560806c
Retain pinned filters when loading and clearing saved queries (#54307)
When we originally implemented Saved Queries we had them overwrite pinned filters on load and on clear. This caused the issue in #53258. If you have a saved query loaded in Discover for example and you navigate to a different app and then back to Discover, that saved query will get get reloaded since app state is retained when navigating back and forth between apps. If you created a pinned filter in between visits to Discover, it will get removed when the saved query is reloaded.

This issue made me reconsider our previous decision. I think pinned filters should not be affected by loading or clearing a saved query, since they are pinned they should only be removed if the user explicitly asks for it. This solves the reported issue and I also think it makes the UI more intuitive.
2020-01-21 16:33:53 -05:00
Pedro Jaramillo 7eb934e80c
Resolver zoom, pan, and center controls (#55221)
* Resolver zoom, pan, and center controls

* add tests, fix north panning

* fix type issue

* update west and east panning to behave like google maps
2020-01-21 16:00:52 -05:00
Brian Seeders 0cd1733c8a
Skip failing endpoint saga tests 2020-01-21 15:54:05 -05:00
Eli Perelman 2aa87738a7
[skip-ci] Update migration guide to add rendering service example (#54744)
* Update migration guide to add rendering service example

* Address review nits

* Address nits

* Add chromeless apps to TOC
2020-01-21 14:48:16 -06:00
Kaarina Tungseth 0ac60494d6
[DOCS] Updates to heat map page (#55097) 2020-01-21 14:01:28 -06:00
Paul Tavares 5a5bade8be
[Endpoint] Fix saga to start only after store is created and stopped on app unmount (#55245)
- added `stop()`/`start()` methods to the Saga Middleware creator factory
- adjust tests based on changes
- changed application `renderApp` to stop sagas when react app is unmounted
2020-01-21 14:21:33 -05:00
Felix Stürmer 85edc66125
[Logs UI] Use the correct icons and labels in the feature cont… (#55292)
This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming.

fixes #55283
2020-01-21 19:42:22 +01:00
Justin Kambic 16b5fd7e04
[Uptime] Handle locations with names but no geo data (#55234)
* Handle locations with names but no geo data.

* Fix broken types, add a comment explaining some weird ts-related code.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 13:41:36 -05:00
Thomas Neirynck 740d4d1afa
[File upload] Enforce file-type check in file dialog (#55063) 2020-01-21 13:23:49 -05:00
patrykkopycinski fc21c49c35
[SIEM] Fix Detections page breadcrumbs (#55173) 2020-01-21 19:20:53 +01:00
Michail Yasonik da54657b91
Grouped Kibana nav (#53545)
Adds concept of `category` to nav links, grouping them by this in the side nav
2020-01-21 12:48:07 -05:00
James Gowdy 01fe8afb98
[ML] Fixing categorization wizard example results (#54924)
* [ML] Fixing categorization wizard example results

* moving validation results to class

* cleaning up category analyzer types

* small tweaks

* removing commented out code

* fixing string ids

* small refactor

* improving validation messages

* fixing types

* updating message text

* fixing typo

* adding privileges error

* updating privilege message

* changes based on review

* removing old warning message

* fixing translations

* renaming enum
2020-01-21 17:35:47 +00:00
Joe Portner 5aa85dc751
Update Monitoring plugin's Elasticsearch configuration (#55119)
* Fix Monitoring plugin Elasticsearch SSL config

Plugin now allows "keystore" and "truststore" values in its
config schema as the documentation currently states.
Plugin also now reads PEM and PKCS12 files off of the filesystem
before attempting to create an Elasticsearch client.

* Add missing Elasticsearch config deprecations

Several Elasticsearch config deprecations were overlooked for
monitoring-specific Elasticsearch settings.
2020-01-21 12:35:02 -05:00
Liza Katz f26596145e
Clean up search service (#53766)
* deprecate msearch

* Missing export

* adjust tests, revert loading method of esaggs/boot

* getInjectedMetadata

* Fix jest tests

* update default strategy abort test

* notice update

* Allow running discover errors test independently

* Remove batchSearches

* Detect painless script error

* don't show notifications for aborted requests

* Fix jest tests

* Restore loader indicator

* Decreace loading count on error

* update search test

* Trigger digest after fetching fresh index patterns

* Revert isEqual

* accurate revert

* Return full error details to client from search endpoint

* Re-throw AbortError from http when user aborts request.

* fix typo

* typo

* Adjust routes jest test

* Restore msearch using a separate es connection

* typescript fixes

* set http service mock

* Move es client to dat aplugin, for follow up PR

* Add karma mock

* krma mock

* fix tests

* ts

* Pass in version dynamically

* add headers to esClient host

* Restored fetch soon test
Use tap for loadingCount side effects

* Cleanup search params

* Cleanup search params test

* Revert "Cleanup search params"

This reverts commit ca9dea01d5.

* Revert "Cleanup search params test"

This reverts commit 30b9478612.

* Revert code to use old es client until  #44302 is resolved

* Revert changes to getPainlessError

* Fix jest test

* Refactor esClient to trigger loadingIndicator

* fixing tests

* use esClient from searchService

* git remove comment

* fix jest

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 18:49:57 +02:00
Nick Partridge ce2930ec51
De-angularize vis tooltips (#54954)
* Remove angular dependencey from vis/tooltip
* Move tooltip logic into vislib
* Remove and fix all ngMock refs in vislib tests
* Add numeral to renovate config
* Add vis_type_vislib to codeowners
* Move vis_legend into vislib and fix errors
* vis_type_vislib/public imports to be only top-level
2020-01-21 10:46:56 -06:00
Josh Dover b0af1bf95c
Clear core loading indicator just before UI is rendered (#55242)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 09:19:08 -07:00