Commit graph

44628 commits

Author SHA1 Message Date
ymao1
e2aacdc186
[Alerting] Allow rule types to extract/inject saved object references on rule CRU (#101896)
* Adding function hooks into rule type definition and call extract fn on rule create

* Adding hooks for extracting and injecting saved object references. Adding extractReferences to create and update workflow

* Adding type template for extracted params

* Adding type template for extracted params

* Adding type template for extracted params

* Adding type template for extracted params

* Calling injectReferences function if defined. Finishing unit tests for create and update

* Adding tests for get

* Adding tests for find

* Cleanup

* Fixing types check

* Fixing functional tests

* Fixing functional tests

* Fixing tests

* Updating README

* Throwing boom error instead of normal error

* Adding framework level prefix to extracted saved object reference names

* Fixing types

* Fixing types

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 17:09:02 -04:00
Nathan L Smith
88ac1f9761
Jest and Storybook fixes (#104991) 2021-07-20 16:07:50 -05:00
Luca Belluccini
5bd4762561
[DOC] APM settings fix (#106296) 2021-07-20 13:32:49 -07:00
Spencer
ec160d5c47
[kbn/dev-utils] pull in extract() helper (#106277)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-07-20 13:13:48 -07:00
Dominique Clarke
20a947058d
[Uptime] handle unequal steps between check group changes for step details page in Uptime (#106289) 2021-07-20 15:51:19 -04:00
Lisa Cawley
a6a248fed6
[ML] Edits rare anomaly detection job summaries (#105694)
Co-authored-by: Pete Harverson <peteharverson@users.noreply.github.com>
2021-07-20 12:13:23 -07:00
Devon Thomson
300644f589
[Dashboard] Allow Reporting after Discarding Unsaved Changes (#106026)
Allowed dashboard diffing to happen in view mode to  fix dashboard unsaved changes not updating after discard changes
2021-07-20 15:40:55 -03:00
Kevin Logan
2a54db715a
[Security Solution] Ransomware supported migration expanded for upgrade corner case (#106280)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 14:37:32 -04:00
Constance
bc4928fd0b
[Enterprise Search] Create reusable EntSearchLogStream component (#105804)
* Set up Kibana dependencies required by LogStream component

- notably, `infra` and `data` - @see https://github.com/elastic/kibana/blob/master/x-pack/plugins/infra/public/components/log_stream/log_stream.stories.mdx#prerequisites

- tsconfig.json note - I believe I missed kibana_react from when we previously started requiring it for KibanaPageTemplate. Because LogStream requires it for KibanaContextProvider anyway I decided to add as a reference just in case

* Set up log source configuration for ent search logs

@see https://github.com/elastic/kibana/blob/master/x-pack/plugins/infra/public/components/log_stream/log_stream.stories.mdx#with-a-source-configuration

or, monitoring plugin also has example usage

* Set up providers required by the LogStream component

@see https://github.com/elastic/kibana/blob/master/x-pack/plugins/infra/public/components/log_stream/log_stream.stories.mdx#prerequisites

Note: there's some overlap in KibanaContextProvider with KibanaLogic that may be worth investigating/DRYing out in the future

* Create reusable EntSearchLogStream component

- light wrapper over LogStream with certain prepopulated defaults

+ Update LogStreamProps from infra team to be exported publicly for reuse (eslint will error otherwise)

* Fix bad type export

- thanks @afgomez!!

* Fix failing security_only nav_links test

- which was caused by `spaces` being required by infra but optional for our plugin. I moved `spaces` to required by `enterprise_search for clarity.

- I'm still not sure I actually fixed the nav_links test correctly. I have almost no memory of adding those lines 12 months ago 🙈

* Fix spaces typing

- remove `?` notation now that it's a required and non-optional plugin
+ reorder required plugins slightly

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 13:58:57 -04:00
Andrew Kroh
a1f097e034
[Fleet] Update list of Fleet users that issue API keys (#106036)
Include the user that Cloud uses to run the Fleet server in the list of
trusted users. And include the elastic/fleet-server service account.

Part of the `agent.id` validation is the check that the user that issued
the API key is trusted before trusting the metadata attached to the API key.

In the long run I think it would make sense to have Fleet automatically
manage this list of trusted users based on the users being used to operate
Fleet servers.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 13:55:41 -04:00
Pete Hampton
34e098390c
Fix up undefined handling in EP Meta telem task (#106269)
* Fix up undefined handling in EP Meta telem task

* Check for null and undef.

* inverse the ternary op.
2021-07-20 18:36:21 +01:00
Chris Roberson
1f798aac3f
[Alerting] Change execution of alerts from async to sync (#97311)
* added ability to run ephemeral tasks

* fixed typing

* added typing on plugin

* WIP

* Fix type issues

* Hook up the ephemeral task into the task runner for actions

* Tasks can now run independently of one another

* Use deferred language

* Refactor taskParams slightly

* Use Promise.all

* Remove deferred logic

* Add config options to limit the amount of tasks executing at once

* Add ephemeral task monitoring

* WIP

* Add single test so far

* Ensure we log after actions have executed

* Remove confusing * 1

* Add logic to ensure we fallback to default enqueueing if the total actions is above the config

* Add additional test

* Fix tests a bit, ensure we log the alerting:actions-execute right away and the tests should listen for alerts:execute

* Better tests

* If the queue is at capacity, attempt to execute the ephemeral task as a regular action

* Ensure we run ephemeral tasks before to avoid them getting stuck in the queue

* Do not handle the promise anymore

* Remove unnecessary code

* Properly handle errors from ephemeral task lifecycle

* moved acitons domain out of alerting and into actions plugin

* Remove some tests

* Fix TS and test issues

* Fix type issues

* Fix more type issues

* Fix more type issues

* Fix jest tests

* Fix more jest tests

* Off by default

* Fix jest tests

* Update config for this suite too

* Start of telemetry code

* Fix types and add missing files

* Fix telemetry schema

* Fix types

* Fix more types

* moved load event emission to pollingcycle and added health stats on Ephemeral tasks

* Add more telemetry data based on new health metrics for the ephemeral queue

* Fix tests and types

* Add separate request capacity for ephemeral queue

* Fix telemetry schema and add tests for usage collection

* track polled tasks by persistence and use in capacity estimation instead of executions

* fixed typing

* Bump default capacity

* added delay metric to ephemeral stats

* Fix bad merge

* Fix tests

* Fix tests

* Fix types

* Skip failing tests

* Exclude ephemeral stats from capacity estimation tests

* PR feedback

* More PR feedback

* PR feedback

* Fix merge conflict

* Try fixing CI

* Fix broken lock file from merge

* Match master

* Add this back

* PR feedback

* Change to queue and add test

* Disable ephemeral queue in tests

* Updated desc

* Comment out ephemeral-specific tests tha require the entire test suite to support ephemeral tasks

* Add clarifying comment

Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 13:24:24 -04:00
Oliver Gupte
710c17fab6
[APM] Fix missing input vars for Fleet UI (#105384) (#106195)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 13:13:15 -04:00
Aleh Zasypkin
ca17b2dbb6
Provide sensible defaults for xpack.security.session.{lifespan|idleTimeout}. (#106061) 2021-07-20 18:30:36 +02:00
Justin Kambic
ff84ac932c
[Synthetics] Fix mobile synthetics image clipping (#106128)
* Change hardcoded image size value to prevent clipping of mobile synthetics screenshots.

* Compute max values for `ref`-style screenshots to improve display ux.
2021-07-20 12:06:26 -04:00
Sergi Massaneda
a8fc9b462c
[RAC] [TGrid] Field browser implemented in EuiDataGrid toolbar (#105207)
* tGid header using EuiDataGrid

* useFetchIndex migrated and column_headers refactor

* removed useless mock

* add badges translations

* i18n translations keys fixed

* code format

* filter default columns not present in field browser

* reset button to initial columns

* cleaning

* dependencies moved

* fix functional test with missing data service

* remove unused code (unrelated)

* fieldBrowser integration with security solutions timeline

* lint and translations cleaned

* timeline toolbar removed for merge & some test fixes

* type fix

* type fixes

* timeline static default colums

* limit size temporary increase

* limit size temporary increase

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 17:52:52 +02:00
Yuliia Naumenko
d91c6d0cfb
[Alerting UI]Changed rules table to support visual indication for disabled and muted alerts (#104190)
* [Alerting UI]Changed rules table to support visual indication for disabled or muted alerts

* changed columns styles due to the mockup

* added tests

* fixed quotas

* fixed popover

* fixed due to the lates UI updates

* fixed errors

* moved enabled to a separate component

* fixed tests

* fixed due to comments

* Update x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.scss

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

* removed test code

* fixed tests

* fixed due to comments

* fixed due to comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2021-07-20 08:41:15 -07:00
Cauê Marcondes
05c29efab5
[APM] source map bundle_filepath is not cleaned (#105973)
* cleaning basepath url

* cleaning url

* cleaning url

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 11:31:07 -04:00
Spencer
5b12cbcdb8
[kbn/optimizer] store references to bazel target for all package files (#106171)
* [kbn/optimizer] store references to bazel target for all package files

* update jest snapshots

* remove unnecessary fixtures

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-07-20 08:29:05 -07:00
Liza Katz
620eaf2f6a
[bug] don't convert KbnServerErrors again (#106220)
* don't convert KbnServerErrors again

* Add test

* fixy fix
2021-07-20 16:33:02 +02:00
Pete Harverson
34c17afdd5
[ML] Transforms: Fixes overflow of data grid into side navigation (#106091)
* [ML] Transforms: Fixes overflow of data grid into side navigation

* [ML] Remove unnecessary whitespace

* [ML] Remove wrapping div on app
2021-07-20 15:18:21 +01:00
Yaroslav Kuznietsov
992f444397
Textarea argument refactored. (#106232) 2021-07-20 17:17:16 +03:00
Yaroslav Kuznietsov
730caa501f
[Canvas] String ui argument refactor. (#105742)
* Refactored `string` argument ui.

* Moved to useCallback.

* Removed `_.get`.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 17:17:02 +03:00
Alexey Antonov
b58054cf26
[TSVB] fix No longer possible to define intervals like >=1m or >=12h (#105954)
* [TSVB] fix No longer possible to define intervals like >=1m or >=12h

Closes: #105854

* add tests, remove extra logic

* add functional test, update help text

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 09:20:04 -04:00
Diana Derevyankina
ca87cd7a73
[TSVB] Add more functional tests for Table (#105060)
* [TSVB] Add more functional tests for Table

* Update filter ratio setting numerator denominator function

* Refactor set filter ratio numerator and denominator functions in visual_builder_page.ts

* Update setFilterRatioOption function
2021-07-20 16:13:18 +03:00
Scotty Bollinger
4e99580788
Fix Users copy to account for built-in users (#106166) 2021-07-20 08:06:10 -05:00
Angela Chuang
85f726c3d8
[Security Solution] Alert flyout overview (#105602)
* init flyout overview

* styling

* remove reason block

* rm unused i18n key

* show data by event category

* rename styled component

* update snapshot

* update overview tab on alert flyout

* styling

* fix up

* update snapshot and remove unused i18n
2021-07-20 07:52:05 -04:00
Bryan Clement
dd159f1c9e
[Osquery] 7.14 bug squash (#105387) 2021-07-20 13:21:39 +02:00
Kerry Gallagher
32206b9284
Fix top controls responsive layout (#106107) 2021-07-20 12:01:42 +01:00
Stratoula Kalafateli
8b2ceaed44
[Vislib XY axis] Adds a deprecation notice in the UI and a docs section (#105055)
* [Vislib XY axis] Adds a deprecation notice in the UI and a docs section

* Remove cyclic dependency

* Fix link

* Add functional test

* fix functional tests

* Apply PR comments

* Update docs/user/dashboard/aggregation-based.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Apply PR changes

* minor

* Change the implementation

* Use title calse in Advanced Settings

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
2021-07-20 13:33:10 +03:00
Thom Heymann
1f5be1e1e1
Space management page UX improvements (#100448)
* Updated spaces management page

* Fixed test failures

* updated snapshot

* Added suggestions form code review

* Fixed unit test

* Review suggestion #2

* WIP

* Fix build errors

* fix type

* remove test for popup that doesnt exist anymore

* fix test

* fix a11y issues

* fix a11y issue

* Removed unused css

* Fix functional test

* Added suggestions from code review

* Fix typescript errors

* Added suggestions from code review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 09:33:39 +01:00
Jean-Louis Leysens
2fb1a47137
[Reporting] Unskip flaky test when downloading CSV with "no data" (#105252)
* unskipped test and added additional checks when using time picker

* rather wait for the timepicker to close

* set up test for flaky test runner

* Additional .only

* Remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 10:30:54 +02:00
renovate[bot]
1e30148f59
Update dependency @elastic/charts to v33 (master) (#105633) 2021-07-20 03:33:22 -04:00
mgiota
41289fadc3
[Observability RAC] Improve alerts table columns (#105446)
* right align duration on alerts observability table

* reason column takes up the remaining width

* add horizontal scrollbar to the table

* add actions label temp solution

* use abbreviated format for duration

* Internationalization for actions

* remove horizontal scroll and bring back initial width

* remove unused import

* remove data as dependency

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 07:44:52 +02:00
Aleh Zasypkin
237256a4ba
Introduce preboot lifecycle stage (#103636) 2021-07-20 06:52:23 +02:00
Davis Plumlee
a34a15ea3d
[Security Solution] Invalid kql query timeline refresh bug (#105525)
* poc test

* adds disable for refresh button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-20 00:37:42 -04:00
Tiago Costa
591c11988d
skip flaky suite (#106121) 2021-07-20 00:09:05 +01:00
Paul Tavares
879b1a40dc
[Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (#106118)
* comment out UI display of pending isolation statuses and associated tests
* Change un-isolate form to use `EuiForm` and `EuiFormRow`
* Fix: move component `displayName` to file that has that component's src
2021-07-19 16:54:13 -04:00
Brandon Morelli
fc49ae12e6
docs: APM RUM Source map API (#105332) 2021-07-19 13:29:18 -07:00
Ece Özalp
7e4c73ad2e
[CTI] Adds indicator match rule improvements (#97310)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-19 15:36:22 -04:00
Kevin Logan
15285bf03b
[Security Solution] update text for Isolation action submissions (#105956) 2021-07-19 15:24:25 -04:00
Pete Hampton
75c573a368
EP Meta Telemetry Perf (#104396)
* Add comments for other developers.

* Move OS infomation into meta key.

* Refmt endpoint metrics.

* Add helper funcs to batch sending.

* Add test to ensure opt in status.

* Add helpers test.

* Finish reshaping the document based on feedback.

* Add better type safety. Add policy package version to output.

* Fix sender implementation for aggregating EP datastreams.

* Fix type issues.

* Fix cadence inference + miss default agent id.

* Dynamically control search ranges for metrics + policy responses.

* Set back to 24h.

* Add comment for ignoring the default policy id.

* explicitly type the sub agg search query.

* Improve type safety.

* Add additional type safety + try/catch the last block.

* Remove unneeded optional chaining.

* Destructure host metrics.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-19 20:19:05 +01:00
Chris Cowan
cb7187f71f
[Metrics UI] Drop partial buckets from ALL Metrics UI queries (#104784)
* [Metrics UI] Change dropLastBucket to dropPartialBuckets

- Change offset calculation to millisecond percission
- Change dropLastBucket to dropPartialBuckets
- Impliment partial bucket filter
- Adding partial bucket filter to metric threshold alerts

* Cleaning up getElasticsearchMetricQuery

* Change timestamp to from_as_string to align to how date_histgram works

* Fixing tests to be more realistic

* fixing types; removing extra imports

* Fixing new mock data to work with previews

* Removing value checks since they don't really provide much value

* Removing test for refactored functinality

* Change value to match millisecond resolution

* Fixing values for new partial bucket scheme

* removing unused var

* Fixing lookback since drops more than last buckets

* Changing results count

* fixing more tests

* Removing empty describe

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-19 12:11:50 -07:00
DeDe Morton
e4a8363087
Remove beta admonitions for Fleet docs (#106010) 2021-07-19 11:51:36 -07:00
Felix Stürmer
44f7a99e6f
[Observability RAC] Remove indexing of rule evaluation documents (#104970) 2021-07-19 19:56:06 +02:00
Josh Dover
595056060a
Parameterize migration test for kibana version (#105417) 2021-07-19 13:41:01 -04:00
Chris Roberson
887a149076
[Alerting] Allow rule to execute if the value is 0 and that mets the condition (#105626)
* Allow rule to execute if the value is 0 and that mets the condition

* PR feedback

* Fix type issue

* PR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-19 12:54:44 -04:00
Quynh Nguyen
3b921cea56
[ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (#106007)
* [ML] Fix flaky saved search

* [ML] Re-enable tests

* [ML] Make data viz the only tests for flaky test suite runner

* [ML] Make ML only

* [ML] Remove describe.only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-19 12:49:03 -04:00
Kevin Logan
7101c42bec
[Security Solution] UX fixes for Policy page and Case Host Isolation comment (#106027)
* [Security Solution] UX fixes for Policy page and Case Host Isolation comment
2021-07-19 12:46:21 -04:00
Esteban Beltran
ebc02741b3
[Security Solution]Memory protection configuration card for policies integration. (#101365) 2021-07-19 12:42:11 -04:00