* fix the implementation
* add unit tests
* add API unit tests
* fix public interface
* address review comments
* name convertItem to localizeItem
* use fetch instead of core.http and add tests
When building a PR locally, I ran into an issue where the server kept crashing. I ran `yarn kbn clean`, and saw this message in my terminal:
>warn This command is only necessary for the rare circumstance where you need to recover a consistent state when problems arise. If you need to run this command often, >please let us know by filling out this form: https://ela.st/yarn-kbn-clean
I think it makes sense to add this information to the docs so that if users are reading it, they know that this command is not typically necessary.
* [Maps] spatial filter by all geo fields
* replace geoFields with geoFieldNames
* update mapSpatialFilter to be able to reconize multi field filters
* add check for geoFieldNames
* i18n fixes and fix GeometryFilterForm jest test
* tslint
* tslint
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
* Fixed color rules behaviour on empty metrics data.
Refactored function `getLastValue`, which was providing unexpected result on empty arrays. It was returning string, instead of null/undefined value.
Created two useful functions, which are providing possibility to handle empty result and get default value, which is expected.
* Tests added.
Tests for getLastValue refactored.
Tests for getLastValueOrDefault and getLastValueOrZero written.
* Removed console.log
* Added default value for empty operator.
Added default value for empty operator, which will compare statistics to empty array.
Added conditional render of colorRuleValue field, if operator doesn't require some specified value to be chosen ( as default, in this case ).
* Added empty data handling.
Added empty value var and way of displaying in widgets.
Added way of handling empty results and prevented comparing null, empty array and numeric rules.
* Prettier fixes.
* Added the same logic of displaying data to gauge.
Added displaying of empty data to gauge module.
Fixed label color styles (before, it was ignoring, because of setting colorValue out of default scope while reactcss(...) call).
* Added empty data handling in Top N chart.
* Removed getLastValueOrZero.
Removed getLastValueOrZero and replaced by getLastValueOrEmpty.
* Added isEmptyValue function.
Added isEmptyValue function, which is able to check equality. It provides a possibility to encapsulate the logic of empty value and flexible changing of its' behavior.
* Fixed and refactor.
Fixed hidden value input, if no operator selected.
Removed useless DEFAULT_VALUE and getLastValueOrDefault.
* Color rules Tests.
Changed from js to ts last_value_utils. Updated tests for color_rules component.
* Replaces isEqual rule with eq.
* Migrations added.
* Fixed types, EMPTY_VALUE, empty method.
Removed type definition for methods in last_value_utils.ts.
Changed EMPTY_VALUE from array to null. Removed default value.
Added logic for handling empty value handling and comparison methods.
* Fixed comparing null and numeric rules.
* Changed migrations.
* Added test for migrations.
* Migration fix.
* Updated code, based on nits and fixed reasons of pipeline errors.
* Moved actions, connected to operators to the separate file. Reduced duplication of code.
* Type names changed.
* Test for operators_utils added.
* Fixed based on nits.
* Added vis_type_timeseries to tsconfig references.
* Changed version and added migrations.
* Small fix in migrations.
* Fixes based on review.
* Revert "Fixes based on review."
This reverts commit 35af7b2b6a.
* Fixes based on review.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Expressions] Use table column ID instead of name when set
* Update ID matching to match by name sometimes
* Add an extra case to prevent insertion of duplicate column
* Simplify logic and add test for output ID
* Respond to review comments
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add new width definition for waterfall sidebar item. Add delay to tooltip.
* Add default value for style if/when undefined.
* Create shared style for eui breakpoints to use by both waterfall tooltip types.
* Add a comment.
* Use viewport units instead of breakpoints.
* Rename a style.
* Add top margin to prevent tooltip from missing target item. Rename a style.
* Adjust custom `margin-top`.
* Add index to tooltip content.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
* Reenabled _mb suffixed stack monitoring func tests
These tests were disabled temporarily in #98238 because of intermittent failures in master.
* use test_user instead of basic_monitoring_user
* remove security service
* remove logout and cleanup
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: neptunian <sandra.gonzales@elastic.co>
Co-authored-by: Jason Rhodes <jason.rhodes@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* do not send telemetry if isScreenshotMode
* Implement PR feedback:
* added another Jest test
* move Boolean() to make the opt-in value always boolean
* remove unused import and convert to import type
* fix type issues
* update jest snapshot
* Expanded test coverage
- added plugin functional test
- added jest test to check TelemetrySender behaviour
- exported the localStorage/window value that flags screenshot
mode
* fix test plugin name in package.json and make sure to opt out of telemetry when the test finishes
* added missing type file to plugin_functional test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# src/plugins/telemetry/kibana.json
E2E tests are failing because they include the ID field returned by the
package list endpoint. This just updates our request schema to accept an
ID, though we don't persist or deal with the ID anywhere.
Closes#100897
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
* quick fix for 7.13 lens migration not being run on by value panels
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Created common TSVB migrations. Registered them in serverside embeddable factory so that by value panels receive them
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
* Move inspector adapter integration into search source
* docs and ts
* Move other bucket to search source
* test ts + delete unused tabilfy function
* hierarchical param in aggconfig.
ts improvements
more inspector tests
* fix jest
* separate inspect
more tests
* jest
* inspector
* Error handling and more tests
* put the fun in functional tests
* delete client side legacy msearch code
* ts
* override to sync search in search source
* delete more legacy code
* ts
* delete moarrrr
* deflate bfetch chunks
* update tests
use only zlib
* ts
* extract getInflatedResponse
* tests
* Use fflate in attempt to reduce package size
* use node streams, fflate and hex encoding.
* DISABLE_SEARCH_COMPRESSION UI Settings
Use base64 and async compression
* i18n
* Code review
Use custom header for compression
Promisify once
* use custom headers
* Update jest
* fix tests
* code review, baby!
* integration
* tests
* limit
* limit
* limit
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# packages/kbn-optimizer/limits.yml
* Use named arguments in migrationsv2 actions
* Addresses some optional review feedback
Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
