Commit graph

30028 commits

Author SHA1 Message Date
Nathan L Smith e60289f611
[APM] Storybook support (#54970)
Add Storybook with help from changes in #43529.

    We still need to do some work around having mocks for hooks and HTTP requests but the basics are there.
2020-01-16 09:27:07 -06:00
Joe Portner 0d19b38f18
Document mutual TLS authentication (PKI) between Kibana and Elasticsearch (#54940) 2020-01-16 09:46:45 -05:00
Joe Reuter c8c03e4e85
Fix double fetch errors (#54701) 2020-01-16 15:41:29 +01:00
Pete Harverson 3419b06ee3
[ML] Fixes empty table header cell and duplicate ID accessibility issues (#54917)
* [ML] Fixes empty table header cell and duplicate ID accessibility issues

* [ML] Fix anomalies table columns test
2020-01-16 14:19:34 +00:00
Peter Pisljar 3b8398fb1f
making visualization expression function and renderer np_ready (#51966) 2020-01-16 08:52:36 -05:00
Vadim Dalecky 5c19c82d4a
bfetch (2) (#53711)
* feat: 🎸 implement ItemBuffer

* test: 💍 add tests for ItemBuffer

* feat: 🎸 add TimedItemBuffer

* test: 💍 add TimedItemBuffer tests

* feat: 🎸 add createBatchedFunction

* chore: 🤖 save wip on higher level batching

* test: 💍 add createBatchedFunction tests

* feat: 🎸 implement createStreamingBatchedFunction() method

* refactor: 💡 rename "data" key to "result"

* feat: 🎸 return error in "error" key in legacy protocol

* feat: 🎸 add server-side to Expressions plugin

* refactor: 💡 move interpreter server-side registries to NP

* feat: 🎸 implement bfetch.addBatchProcessingRoute

* feat: 🎸 improve streaming and batching func to pass request

* feat: 🎸 initial setup of new expressions batching endpoint

* feat: 🎸 expose bfetch.batchedFunction() function

* feat: 🎸 add of() function

of() function awaits a promise and converts it to a 3-tuple representing
its state.

* refactor: 💡 move normalizeError() to /common

* feat: 🎸 improve createStreamingBatchedFunction() function

* refactor: 💡 move GET /api/interpreter/fns to the New Platform

* feat: 🎸 move batched_fetch to the New Platform

* feat: 🎸 implement legacy interpreter batching on server in NP

* feat: 🎸 switch legacy interpreter server functions to NP

* chore: 🤖 remove unused import

* fix: 🐛 correct expressions mocks

* test: 💍 fix batching tests after refactor

* test: 💍 stub bfetch plugin explorer

* test: 💍 add routing and app structure to bfetch_explorer

* test: 💍 add server-side to bfetch_explorer

* test: 💍 create <DoubleInteger> component in bfetch_explorer

* test: 💍 improve bfetch_explorer

* test: 💍 add <CountUntil> demo to bfetch_explorer

* test: 💍 by default redirect to first bfetch_explorer example

* test: 💍 add error example to bfetch_explorer

* docs: ✏️ improve bfetch docs

* docs: ✏️ improve bfetch server-side docs

* chore: 🤖 address self-review comments

* fix: 🐛 use new core ES data client, remove unuseed import

* fix: 🐛 remove unused interface import

* Update examples/bfetch_explorer/public/components/count_until/index.tsx

Co-Authored-By: Lukas Olson <olson.lukas@gmail.com>

* Update examples/bfetch_explorer/public/components/double_integers/index.tsx

Co-Authored-By: Lukas Olson <olson.lukas@gmail.com>

* Update src/plugins/bfetch/common/buffer/item_buffer.ts

Co-Authored-By: Lukas Olson <olson.lukas@gmail.com>

* Update src/plugins/kibana_utils/common/of.ts

Co-Authored-By: Lukas Olson <olson.lukas@gmail.com>

* docs: ✏️ add batchedFunction params to README

* refactor: 💡 rename onflush to onFlush

* feat: 🎸 make maxItemAge optional in TimedItemBuffer

* refactor: 💡 remove promise from fetchStreaming

* test: 💍 add bfetch_explorer functional tests

* test: 💍 rename test plugin to kbn_tp_bfetch_explorer

* fix: 🐛 use stream instead of removed promise

* fix: 🐛 use correct tsconfig.json in bfetch test plugin

* feat: 🎸 add kbn_tp_bfetch_explorer server-side files to tsconfi

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 05:33:52 -08:00
Jean-Louis Leysens 2acb42662c
Upgrade io-ts after fix was merged and update use of some types (#55013)
* Upgrade io-ts after fix was merged and update use of some types

* Stricter checking against object keys
2020-01-16 13:57:37 +01:00
Daniil Suleiman b06977f43f
Convert tests to jest in vis_type_timeseries/server folder (#54896)
* Move vis_data/series tests to jest

* Move tests in request_processors/series to jest

* Move tests in vis_data to jest

* Convert other tests to jest
2020-01-16 15:38:26 +03:00
MadameSheema 8a07023343
[SIEM] Improves toggle column Cypress tests execution time (#54475)
* refactor

* replaces 'clearTimeline' for 'createNewTimeline'

* fixes typecheck issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 12:31:46 +01:00
Shahzad 6d3c284d11
[Uptime] Fix/embedded map console warning (#54926)
* update it

* type

* refresh app when it is out of focus

* updated

* unused code
2020-01-16 12:14:38 +01:00
Angela Chuang c2f3c977eb
[SIEM] Dns histogram enhancement (#54902)
* update DNS histogram

* fix indent

* hide dropdown if only one option provided

* update DNS histogram

* fix types
2020-01-16 18:46:22 +08:00
MadameSheema ea9351aaaa
[SIEM] Improves data providers Cypress tests execution (#54462)
* refactor

* replaces 'clearTimeline' for 'createNewTimeline'

* removes unused data-test-subj

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 11:10:49 +01:00
Gidi Meir Morris 8458e47614
removes usage of the _id field in Task manager (#54765)
As of Elasticsearch 8.0.0 it will no longer be possible to use the _id field on documents.
This PR removes the usage that Task Manager makes of this field and switches to pinned queries to achieve a similar effect.
2020-01-16 09:55:51 +00:00
MadameSheema 81a7f89448
[SIEM] Improves flyout button Cypress tests time execution (#54463)
* refactor

* replaces 'clearTimeline' for 'createNewTimeline'

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 10:11:44 +01:00
MadameSheema 043573e264
[SIEM] Improves inspect Cypress tests time execution (#54443)
* groups test by context

* renames 'openHostsAndStatsTables' to 'openStatsAndTables'

* replaces map method for forEach

* adds timeout for modal-inspect-close

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 09:57:36 +01:00
Sébastien Loix 41f72032e2
[Mappings editor] Fix clear searchbox (#54880) 2020-01-16 12:46:54 +05:30
Thomas Neirynck 0f924f5475
[Maps] Remove the tile_map plugin dependency (#54947) 2020-01-15 21:42:57 -05:00
Tiago Costa 8f07b6346a
chore(NA): remove signal preffix from trap in precommit hook script (#54863) 2020-01-16 02:10:17 +00:00
Thomas Neirynck 03570c2cf9
add 7.6 branch to backportrc (#54975) 2020-01-15 18:21:39 -05:00
Mike Côté 67a8194d6c
Fix codeowners for alerting services team (#53889)
* Fix codeowners

* Fix localization and telemetry folders as well

* Fix task manager path

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 18:06:24 -05:00
Nathan Reese a127477c94
[skip-ci] Update Maps getting started docs for 7.6 UI changes (#54816)
* update choropleth getting started instructions

* finish ES layers getting started
2020-01-15 17:08:33 -05:00
Nick Partridge bd7d5eb9f6
Shim vis_type_vislib (#53536)
* shim of kbn_vislib_vis_types (now vis_type_vislib)
* Move vislib into vis_type_vislib plugin
* Convert remaining plugin files to typescript
* Rename vis to vis_type_vislib
2020-01-15 15:48:19 -06:00
Thomas Neirynck 8ee7ed9a06
[Maps] Coerce property value to string to match mapbox-gl spec (#54928) 2020-01-15 16:43:16 -05:00
Melissa Alvarez 6b35b97e96
do not render the tablist element if there are no sub menus (#54838) 2020-01-15 16:04:27 -05:00
Steph Milovic 5ba24b8f54
[SIEM] [Case] Service Now Kibana Action (#53890) 2020-01-15 13:50:38 -07:00
Vadim Dalecky 22369c9992
📕 Storybook for everyone (take 2) (#43529)
* chore: 🤖 add Infra sample Storybook story

* chore: 🤖 add @kbn/storybook package

* chore: 🤖 add sample SIEM stories

* chore: 🤖 add Canvas new Storybook config

* fix: 🐛 fix TypeScript errors

* chore: 🤖 add @kbn/babel-preset to package.json

* chore: 🤖 move dependencies to devDependencies

* chore: 🤖 make Storybook dependencies non-dev

* chore: 🤖 upgrade Storybook dependencies

* chore: 🤖 add packages to webpack

* fix: 🐛 fix TypeScript type check

* chore: 🤖 disable ESLint warnings

* chore: 🤖 remove Storybook info plugin

* chore: 🤖 upate yarn.lock

* chore: 🤖 add Storbook to Embeddables

* feat: 🎸 add --clean flag to Storybook CLI

* coalesce yarn.lock versions

* update kbn/pm dist

* This reverts commit 97d8ff9f53 and 49b07cd007.

* chore: 🤖 use fs instead of mkdirp

* chore: 🤖 use debug for message logging

* chore: 🤖 update yarn.lock

* feat: 🎸 add link to kbn-storybook package

* docs: ✏️ add Storybook readme

* chore: 🤖 remove packages that failed DLL build

* style: 💄 add ESLint comma

* chore: 🤖 apply changes from #52209

* fix: 🐛 make Canvas Storybook build again

* chore: 🤖 move Canvas stories to global Storybook

* chore: 🤖 move more Canvas components to global Storybook

* chore: 🤖 move more Canvas stories to global Storybook

* chore: 🤖 move <ItemGrid> and <KeyboardShortcutsDoc> to NP SB

* chore: 🤖 move shape picker Canvas stories to global Storybook

* chore: 🤖 move Canvas sidebar stories to global Storybook

* fix: 🐛 split imports to not import path.resolve in Storybook

* chore: 🤖 move tag and PDF panel Canvas stories to global SB

* chore: 🤖 move Canvas share website flyout stories to global SB

* fix: 🐛 clean up <ShareWebsiteFlyout> imports

* chore: 🤖 add back Canvas withInfo decorator

* chore: 🤖 look for Canvas stories everywhere in /canvas folder

* test: 💍 mock correct files in Storyshots

* test: 💍 update Canvas Storyshot snapshots

* chore: 🤖 move more Canvas components to global Storybook

* chore: 🤖 move more Canvas components to global Storybook

* test: 💍 update Canvas Storyshots

* chore: 🤖 rebuild @kbn/pm

* chore: 🤖 refresh @kbn/pm dist/index.js artifact

* chore: 🤖 update yarn.lock

* chore: 🤖 update @kbn/pm artifact

* feat: 🎸 address review comments

* fix: 🐛 remove circular import

* chore: 🤖 update yarn.lock

* test: 💍 disable a test suite

* test: 💍 update Canvas storyshots

* chore: 🤖 remvoe build step from @kbn/storybook

* chore: 🤖 enable disabled functional test suite

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 12:30:59 -08:00
Joel Griffith 5b2e315e5a
Getting flaky tests back in shape for reporting (#46076)
* Rebasing from master, updating test utils and getting report pdf/png generation

* Removing legacy functions, packages and updating README/Licenses

* Dropping duplicitive test

* Better URL check for lens reporting

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 11:28:39 -08:00
Davis Plumlee cab5925c59
Resolver nonlinear zoom (#54936) 2020-01-15 12:17:17 -07:00
Elizabet Oliveira ed3c8991db
Color blind palette (#54918) 2020-01-15 18:55:33 +00:00
Peter Pisljar 297aa7bd23
visualize embeddable to visualizations plugin (#54840) 2020-01-15 13:53:56 -05:00
Robert Austin 63ad7a9cb2
Resolver test plugin not using mount context. (#54933)
Mount context was deprecated. Use core.getStartServices() instead.
2020-01-15 13:10:03 -05:00
Jean-Louis Leysens 781ef7a2c0 [Mappings Editor] Remove Joi (#54913) 2020-01-15 12:42:02 -05:00
Peter Pisljar 5d4cb4767e
variable support for interpreter (#54788) 2020-01-15 12:38:24 -05:00
patrykkopycinski b758b78e1e
[SIEM] Add support for IP details flow target in url (#54546) 2020-01-15 18:31:54 +01:00
igoristic 884fe91c1e
Added new index pattern (#54681)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 11:44:22 -05:00
Shahzad f2695c4d25
[Uptime] Ping list, margin before expand arrow (#54905)
* added margin

* Update x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx

Co-Authored-By: Katrin Freihofner <katrin.freihofner@elastic.co>

Co-authored-by: Katrin Freihofner <katrin.freihofner@elastic.co>
2020-01-15 17:14:54 +01:00
Liza Katz dd16aaf5a8
Add tests for index patterns without time field on dashboard (#54760)
* Add tests for index patterns without time field on dashboard

* add null check

* Hide timefilter in editor only if timeFieldName is explicitly

* eslint

* test to ts

* Code review

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 18:03:51 +02:00
Jean-Louis Leysens 19d0c5a085
[Console] Text Objects (#52402)
* WiP

* Initial commit for localStorage -> SavedObjects, untested [skip ci]

* Restore text_object model and mappings

* Fix use of mappings

* WIP on anonymous saved objects and user ids

* refactor: remove saved objects entirely and rescope changes to only introducing text objects

* Update use of .findAll after changes

* Where did that come from?

* Slight refactor to generic names
Removed unused files (mappings.json, README.md)
Documented object storage client interface
Failure to restore previous state does not block editor
Updated copy

* Rename exported variable

* Document TextObject interface

* Rename EuiLoadingContent10 -> EditorContentSpinner

* Update src/legacy/core_plugins/console/public/np_ready/application/components/something_went_wrong_callout.tsx

Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>

* Update src/legacy/core_plugins/console/public/np_ready/application/components/something_went_wrong_callout.tsx

Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>

* Update src/legacy/core_plugins/console/public/np_ready/application/components/top_nav_menu.tsx

Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>

* Update src/legacy/core_plugins/console/public/np_ready/application/components/top_nav_menu.tsx

Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>

* Update src/legacy/core_plugins/console/public/np_ready/application/containers/editor/legacy/console_editor/editor.test.tsx

Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>

* Added FunctionComponent imports

* Implement preventing editting console text if init failed

* Simply console boot states for now

* This reverts commit 07b7bfb73f.

* Fix eslint issue
Update copy

Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 15:53:20 +01:00
Melissa Alvarez 5fc691f775
Ensure result field columns can be deselected and re-selected (#54766) 2020-01-15 09:19:37 -05:00
Maja Grubic 7ca858ee8d
[Dashboard][Lens] Small code fixes (#54625)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-15 14:02:46 +00:00
Cauê Marcondes 1a6239289c
[APM] Traces with identical transactions names are combined, even though they are from different services (#54247)
* Adding services aggregation

* Adding services aggregation

* Adding services aggregation

* removing counter from ui

* adding size to service aggregation

* sorting on server

* changing to composite aggregation

* changing aggregation name
2020-01-15 13:58:10 +00:00
Rudolf Meijering d10d6286ee
[skip-ci] Core conventions (#52397)
* Table of contents for conventions

* Add Core Conventions

* Add Tests and mocks section

* Update src/core/CORE_CONVENTIONS.md

Typo

Co-Authored-By: Josh Dover <me@joshdover.com>

* Add pro's/con's for alternatives to private fields support

Co-authored-by: Josh Dover <me@joshdover.com>
2020-01-15 14:29:50 +01:00
Dima Arnautov d082c03e9d
[ML] Calculate model memory limit API integration tests (#54557)
* [ML] calculate model memory limit api integration tests

* [ML] extra test cases
2020-01-15 13:42:35 +01:00
CJ Cenizal 33713cbdc0
Skip flakey index template component integration tests. (#54878) 2020-01-15 02:28:38 -08:00
Matt Bargar f77b36206a Add label and icon to nested fields in the doc table (#54199)
* Apply label and icon to nested fields in the doc table

* Include nested fields in the index pattern so we can identify them in the Discover UI

* use color recommended by design

* Fix unit tests

* Update api integration test

* Fix test comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Tim Roes <mail@timroes.de>
2020-01-15 10:56:36 +01:00
Joe Reuter b9a0f958bc
Reverse dependency of home plugin and apm/ml/cloud (#52883) 2020-01-15 10:10:12 +01:00
Frank Hassanabad 9c43e3ad93
[SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules
## Summary

* Updates pre-packaged rules
* Adds rule_id duplicate check into the linter
* Updates the scripts for converting saved objects to rules
* Adds a script for re-generating the `index.ts` for the rules

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-15 00:55:55 -07:00
spalger 94a409964b update invalid snapshot 2020-01-14 23:26:20 -07:00
Patrick Mueller d3a3cefc73
add readme note about alerting / manage_api_key cluster privilege (#54639)
partially resolves https://github.com/elastic/kibana/issues/54525
2020-01-14 23:47:55 -05:00
Andrew Goldstein 56ff721867
[SIEM] New Overview Page (#54783)
## [SIEM] Overview Page "1.5"

A redesigned SIEM Overview page that includes `Recent timelines`, a `Security news` feed, visualizations, and rolled-up event counts

![overview-day](https://user-images.githubusercontent.com/4459398/72396016-90f53600-36f8-11ea-9b41-6d54d09de589.png)

![overview-night](https://user-images.githubusercontent.com/4459398/72394575-fb57a780-36f3-11ea-868e-8fcd2c5c4543.png)

### Overview enhancements
- Added the global Search bar and Date picker to the Overview page
- New `Recent timelines` widget affords quick access to favorite and recently modified timelines
- New `Security news` widget
- New Kibana advanced settings (toggle switch) for enabling or disabling the news widget and configuring the news URL
![news-settings](https://user-images.githubusercontent.com/4459398/72362776-fd4c4700-36b0-11ea-805b-3c7353f2c1cd.png)
- New `Events count by dataset` widget
- Updated the `Host Events` and `Network Events` widgets to integrate with the Search bar and date picker input
- Enhanced the `Host Events` and `Network Events` widgets to use an accordion paradigm that summarizes stats by source (e.g. `Auditbeat`, `Endgame`)
- Enhanced the `Host Events` and `Network Events` widgets to visualize relative percentages of events collected as progress bars
- New `Alerts count by category` widget
- New `Signals count by MITRE ATT&CK™ category` widget
- New `View events`, `View alerts`, and `View signals` navigation buttons for their respective visualizations


### FTUE enhancements
- FTUE "no data" view design refresh
![ftue](https://user-images.githubusercontent.com/4459398/72361771-43a0a680-36af-11ea-969f-5872ac4a01a1.png)
- When the FTUE "no data" page is displayed, hide all global navigation links (i.e. `Hosts`, `Network`, `Detection engine`), such that only `Overview` appears in the global nav
- App Help popover design refresh
![help](https://user-images.githubusercontent.com/4459398/72362132-d80b0900-36af-11ea-9b58-1fd3b923b7c8.png)
- Removed the `Beta` badge and `Security Information & Event Management with the Elastic Stack` from the Overview header

- Tested in Chrome `79.0.3945.117`, Firefox `72.0.1`, and Safari `13.0.4`

## Known issues

- The `siem:newsFeedUrl` advanced setting is defaulted to `https://feeds.elastic.co/kibana`
- The `Signals count by MITRE ATT&CK™ category` visualization does not display all categories
- The `Signals count by MITRE ATT&CK™ category` visualization may require a different index pattern
- `EuiButtonGroup` throwing a `Can't perform a React state update on an unmounted component` warning when switching from the Overview tab

https://github.com/elastic/siem-team/issues/484
2020-01-14 21:03:57 -07:00