* Check sort:options for Discover default sort order
I went back and forth on a lot of different solutions for this.
Initially I thought it would make sense to just allow users to set a
default saved search in Discover. There were some problems with that
approach though. It would change the default workflow in Discover.
Instead of starting with an unsaved search, users would be editing a
saved search by default. I could see this leading to a lot of
unintentional changes to the default. The settings from the default
saved search also wouldn't carry over to new searches, which I think
would be desirable most of the time.
I also considered adding a new advanced setting for specifying a default
sort field/direction. This kind of setting would make more sense at the
index pattern level though. One field may not be valid across all index
patterns.
So I ended up going with the simplest solution. It solves the issue
identified by the author of the linked issue and nothing more. If a sort
order is specified in the existing sort:options advanced setting, we'll
use that direction when sorting on the index pattern's timestamp field
by default.
Fixes https://github.com/elastic/kibana/issues/5164
* Create a new advanced setting instead of re-using sort:options
* Just pass a default order
* Use correct aria-label react attribute
* Label TSVB auto apply button, fix#12900
* Create possibility to conditionally disable input-focus directive
* Disable auto focus when creating a new viz, fix#12888
* Fix styling of label in TSVB
* Disable auto focus in visualizations, fix#11856
* Fix disable of auto focus
* Disable auto focus of index selection in vis wizard
ui-select-match's expression was expecting an IndexPattern object, but
the indexPatternList passed to ui-select-choices contained SavedObject
instances due to the [SavedObjectsClient refactor][1]. This wasn't a
problem most of the time because switching index patterns caused the
entire directive to get destroyed and re-created. However, when the
directive didn't get re-created (for example, when clicking the already
selected pattern) it would result in a blank select box.
Fixes https://github.com/elastic/kibana/issues/13080
[1]: https://github.com/elastic/kibana/pull/12719
* Clamp the centroid to stay within the box boundaries
If a document has two or more geo fields, then the centroid calculation
will place the centroid in between the two geo fields. This can cause
the centroid to be in the middle of nowhere so clamp it to keep it
closer to where it should be.
* Add geocentroid and clamping tests
* Re-enable filter editor suggestions
* Use search instead of include
* Escape query
* Show spinner
* Use include rather than search
* Add additional regex and explanation for parameters
* Add suggestions API test
* Make sure test actually runs
* Use send instead of query
* Fix suggestions API test
* [angular/$http] remove use of .success() and .error() callbacks
* [angular/$route] remove `!` hash prefix
* [angular] upgrade
* [angular/$timeout] prevent unhandled exception "canceled" logging
* [ui/fancy_form] refactor FormController for compatibility
* [ngModelController] ensure method calls keep context
* [ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit"
* [confirmModalPromise] fix test for rejected promise
* [watchMulti] specifically check watchers array for length
* [typeahead] check for property rather than own keys
* [ui/compat] add initAfterBindingsWorkaround
* [ui/fancyForms] fix _getInvalidModels()
* [fancyForm] add tests that check nested form error counting
* [ui/fancyForms] ensure that submit is blocked properly
* [ui/fancyForms] escalate soft errors on failed submit
* [ui/fancyForms] bind handlers to this in constructor
* [uiBootstrap/tooltip] describe the new error handling
* [ui/confirmModalPromise] use more sinon assertions
* [$http] resp => data before old .success() and .error() handlers
* [indices/createWizard] apply callAfterBindings workarounds
(cherry picked from commit 2eae80cd0c)
* keep current cursor or top line in view when resizing to avoid losing user context
* rename variable to more descriptive name
* move state from editor to smart_resize
* [visualize/aggConfig] do not rely on the view to reset params
* [vis/editor/aggParams] check for agg and type before accessing
(cherry picked from commit f7721fe420)
* Refactor keycode exporting in ui_framework
* Replace all uses of ENTER_KEY and SPACE_KEY
* Use ESCAPE instead of ESC universally
* Rename keycodes -> keyCodes
* Replace keyCodes in advanced_row
* Make KuiTable headers keyboard-accessible in UI Framework.
* Use flexbox to consistently apply spacing between table header cell text and sort icon.
* Add aria-label attributes to KuiTableHeaderCell, KuiTableHeaderCheckBoxCell, and KuiTableRowCheckBoxCell.
* Update Jest snapshots.
* Update Dashboard listing table with new markup.
* Update Saved Objects tables with new markup.
* Update Settings table with new markup.
* Update Visualize listing table with new markup.
* Remove padding-right for cells containing checkboxes.
* Update sortableColumn directive with new markup.
* upgrade leaflet modules to 1.x latest
* fix css for leaflet controls
* update draw options so it is easier to see polygon when drawing
* fix chrome touch issues with closing polygon in leaflet draw
* use canvas renderer
* use leaflet-responsive-popup to avoid tooltip cutoff
* remove radius configuration from leaflet heatmap
* make blur a factor of radius. Set maxZoom to map zoom since new values are calculated per precision
* use _.get to avoid error, cannot read property of undefined
* add cluster size slider
* experiments with image differences
* onload not onLoad
* use canvas dimensions
* compare map canvas to stored PNG of map canvas
* remove pixelmatch from project dependecies
* fix broken test - rounding error
* add expected image tests for geohash layers shaded circles and geohash grids
* bump z-index of vis-spy
* update functional test expected data
* update to leaflet 1.2.0
* revert to leaflet 1.0.3 and update expected data set for map functional tests
* test geohash_layer heatmap in unit test
* update region_map functional test since it can not longer pluck map vectors from DOM
* update documentation
* add markdown functional test
* update markdown vis to use markdown-it
* migrate markdown angular filter to markdown-it
* place other uses of marked and remove dependency
* update breaking changes documenation and set linkify to true
* Create Index Pattern Creation wizard.
- Create a directive for each step in the wizard.
- Reorganize files into conventional folder structure.
- Rename files with more conventional and consistent naming patterns.
- Display indices, partial matches, exact matches.
- Add loading, empty, and success states.
- Add option to include system indices.
* Temp: comment out and mock getIndices functionality.
* Hook up data seaching
* Add for/id connections for form inputs and labels
* Automatically append a wildcard
* Highlight the index pattern in the results
* Ensure we only remove the last character if it's a `*`
* Auto hide index pattern id controls
* Ensure this link is tabbable
* Move the advanced fields down
* Use toggle button
* This shouldn't ever be required
* Revert "This shouldn't ever be required"
This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612.
* Update based on comments in PR
* Ffew more changes
* Port changes from Tyler's PR, https://github.com/elastic/kibana/pull/13353
* Remove unnecessary file
* Fix broken functional tests
* Copy changes
* Fix functional tests
* Remove loading from the main select, and move to an additional select
* Show help text when loading
* Fix sorting
* Fixing broken functional tests
* Couple changes from PR review
* Ensure input field does not show a red border until touched
* More descriptive and consistent copy
* Shortcut to build asciidocs
The command to build the Kibana docs using the elastic/docs repo can be
easy to forget, so this script is an easy to way to do it right every
time.
* Configurable docs repo location
For folks that clone the elastic docs repo to a different location than
as a sibling of kibana.
Fixes#12227
It seems the order of aggs is important now. I don't know the underlying cause here, I just saved a good and bad version of tilemap visualizations and compared the saved objects to figure out what changed.
* Fix broken refresh shortcut for non OS X
On non OS X systems, the e.metaKey is most likely the windows key.
Hotkeys with the windows key are usually used as global (non application
internal) hotkeys. Also the documentation states, that Ctrl + Enter
should also work. With this commit it doesn't matter whether you press
the Meta or the Ctrl key + Enter.
* Make timelion datepicker more accessible
* Add meaningful labels to each interval shortcut, and
* Add a proper label to the custom input text field
* Make save options keyboard accessible, fix#12246, fix#12487
* Make sort button of saved-object-finder accessible, fix#12486
* Label timelion options correctly, fix#12907
* Make timelion legends keyboard accessible, fix#11844
* Make timelion autocompletion properly accessible
Fixes#11533, fixes#11525, fixes#12908
* Make timelion charts and actions accessible, fix#12909
* Add some more inline comments
* Fix HTML styles according to styleguide
* Replace sr-only by kuiScreenReaderOnly
* Make timelion autocompletion work with ARIA 1.1
* Make table pagination controls keyboard-accessible. Update KuiLink so it can be used on a button element.
* Add additional properties to link mixin to make kuiLink look the same for both buttons and anchor tags.
* Fix tests.
* Remove extraneous path info from SCSS import snippet.
* Add GuideCode to demo page. Put stateless function params on multiple lines.
* Log an error if you try to create a component with a blank name.