Commit graph

41640 commits

Author SHA1 Message Date
Matthew Kime 306a42c03c
Index pattern management - use new es client instead of legacy (#95293)
* use new es client instead of legacy

* use resolve api on client
2021-03-25 14:59:14 -05:00
Spencer dd10c8b5f2
[kbn/test] switch to @elastic/elasticsearch (#95443)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-03-25 14:57:32 -05:00
restrry 3bb9220db9 add about section for link in github issue template 2021-03-25 20:29:21 +01:00
Lukas Olson a10c4188b7
Re-enable skipped test (discover with async scripted fields) (#94653)
* Re-enable skipped test

* remove comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 12:24:36 -07:00
Mikhail Shustov 6eb31178ed
blank_issues_enabled: false. it seems contact_links not supported otherwise (#95423) 2021-03-25 20:20:01 +01:00
Ece Özalp d70d02ee83
Add a11y test coverage to Rule Creation Flow for Detections tab (#94377)
[Security Solution] Add a11y test coverage to Detections rule creation flow (#80060)
2021-03-25 15:05:23 -04:00
Nathan Reese c5e3e78de8
[Maps] do not track total hits for elasticsearch search requests (#91754)
* [Maps] do not track total hits for elasticsearch search requests

* set track_total_hits for es_search_source tooltip fetch

* tslint

* searchSource doc updates, set track_total_hits in MVT requests

* revert changes made to searchsourcefields docs

* tslint

* review feedback

* tslint

* remove Hits (Total) from functional tests

* remove sleep in functional test

* tslint

* fix method name

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 13:00:16 -06:00
Kerry Gallagher 6b6404954e
[Logs / Metrics UI] Separate logs / metrics source configuration awareness (#95334)
* Remove metrics awareness of logs fields
2021-03-25 18:59:18 +00:00
Alison Goryachev 43e3d558fd
[Snapshot + Restore] Add callout when restoring snapshot (#95104) 2021-03-25 14:41:58 -04:00
Matthias Wilhelm fad3b74f2f
[Discover] Unskip functional test of saved queries (#94705) 2021-03-25 19:33:16 +01:00
MadameSheema 6a571486fc
[Security Solution][Detections] Improves indicator match Cypress tests (#94913)
* updates the data used in the test

* adds matches test

* adds enrichment test

* improves speed and adds missing files

* fixes type check issue

* adds 'data-test-subj' for the json view tab

* refactor

* fixes typecheck issue

* updates tests with latest master changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 19:25:49 +01:00
Jonathan Budzenski 02fce98254 skip flaky test. #89389 2021-03-25 12:51:05 -05:00
Devon Thomson 50bdbfc18e
[Dashboard] Fix Title BWC (#95355)
* allow saving blank string to panel title
2021-03-25 13:47:15 -04:00
Jonathan Buttner 07f32d03b3
[Cases] Adding feature flag for sub cases (#95122)
* Adding feature flag for sub cases

* Disabling case as a connector in security solution

* Fix connector test

* Switching feature flag to global variable

* Removing this.config use

* Fixing circular import and renaming flag
2021-03-25 13:36:25 -04:00
Constance b9ef084130
[App Search] API Logs - set up basic view & routing (#95369)
* Add basic API Logs view

* Update engine router + nav link
2021-03-25 09:19:39 -07:00
Scotty Bollinger 50d7cea812
[Workplace Search] Add UI logic for GitHub Configure Step (#95254)
* Fix typo

This was mis-copied from ent-search

* No longer store preContentSourceId in query param

In ent-search, we had the Rails server redirect with this param. Now, it is contained in the server response as JSON and is persisted in the logic file

* Pass query params to SourceAdded component

The entire state is stored in query params now and must be passed when doing a manual redirect

* Redirect to config view if config needed

* Don’t redirect if the config has already been completed

This was really tricky and could use a refactor in the future, perhaps. The issue is that the persisted query params will contain the `preContentSourceId` even after the config has been completed. This caused the UI to attempt to navigate back to the config screen after it had been completed. This sets a prop once that has been completed and bypasses the redirect.

* Use correct key to determine if config needed

* Update tests
2021-03-25 11:12:53 -05:00
Tiago Costa c042968b33
chore(NA): upgrade bazel rules nodejs to v3.2.3 (#95413) 2021-03-25 12:08:34 -04:00
Nathan Reese 373a108cfe
[Maps] upgrade server to use new elasticsearch-js client (#95314)
* [Maps] upgrade server to use new elasticsearch-js client

* update functional test expect
2021-03-25 10:06:56 -06:00
Mikhail Shustov 6d6ef0092a
Revert "do not allow creating Question issue (#95396)" (#95427)
This reverts commit 9a64354db2.
2021-03-25 16:56:51 +01:00
Mikhail Shustov 9a64354db2
do not allow creating Question issue (#95396) 2021-03-25 16:23:25 +01:00
Dima Arnautov a8b04d7c54
[ML] Extract job selection resolver (#95394) 2021-03-25 11:21:10 -04:00
Shahzad e0534e42ae
Expose xy chart types component (#95275) 2021-03-25 15:27:30 +01:00
Casper Hübertz e894ee973f
[Observability] Change icon ref (#95367) 2021-03-25 14:29:51 +01:00
Nicolas Chaulet 00c53c56b8
[Fleet] Replace INTERNAL_POLICY_REASSIGN by POLICY_REASSIGN (#94116) 2021-03-25 09:15:59 -04:00
igoristic 80e53d5fe6
[Monitoring] Remove license check for alerting (#94874)
* Removed license check for alerting

* Fixed tests and CR feedback

* Fixed test
2021-03-25 09:02:51 -04:00
Patrick Mueller 9d47330ccf
[alerting] add user facing doc on event log ILM policy (#92736)
resolves https://github.com/elastic/kibana/issues/82435

Just provided a brief description, name of the policy, mentioned
we create it but never modify it, provided the default values, and mentioned
it could be updated by customers for their environment.  Not sure we want to
provide more info than that.
2021-03-25 08:30:46 -04:00
Peter Pisljar 1e87cef3e0
handling references for kibana_context and get_index_pattern expression functions (#95224) 2021-03-25 12:34:38 +01:00
Tomas Della Vedova 238791b942
ES client : use the new type definitions (#83808)
* Use client from branch

* Get type checking working in core

* Fix types in other plugins

* Update client types + remove type errors from core

* migrate Task Manager Elasticsearch typing from legacy library to client library

* use SortOrder instead o string in alerts

* Update client types + fix core type issues

* fix maps ts errors

* Update Lens types

* Convert Search Profiler body from a string to an object to conform to SearchRequest type.

* Fix SOT types

* Fix/mute Security/Spaces plugins type errors.

* Fix bootstrap types

* Fix painless_lab

* corrected es typing in Event Log

* Use new types from client for inferred search responses

* Latest type defs

* Integrate latest type defs for APM/UX

* fix core errors

* fix telemetry errors

* fix canvas errors

* fix data_enhanced errors

* fix event_log errors

* mute lens errors

* fix or mute maps errors

* fix reporting errors

* fix security errors

* mute errors in task_manager

* fix errors in telemetry_collection_xpack

* fix errors in data plugins

* fix errors in alerts

* mute errors in index_management

* fix task_manager errors

* mute or fix lens errors

* fix upgrade_assistant errors

* fix or mute errors in index_lifecycle_management

* fix discover errors

* fix core tests

* ML changes

* fix core type errors

* mute error in kbn-es-archiver

* fix error in data plugin

* fix error in telemetry plugin

* fix error in discover

* fix discover errors

* fix errors in task_manager

* fix security errors

* fix wrong conflict resolution

* address errors with upstream code

* update deps to the last commit

* remove outdated comments

* fix core errors

* fix errors after update

* adding more expect errors to ML

* pull the lastest changes

* fix core errors

* fix errors in infra plugin

* fix errors in uptime plugin

* fix errors in ml

* fix errors in xpack telemetry

* fix or mute errors in transform

* fix errors in upgrade assistant

* fix or mute fleet errors

* start fixing apm errors

* fix errors in osquery

* fix telemetry tests

* core cleanup

* fix asMutableArray imports

* cleanup

* data_enhanced cleanup

* cleanup events_log

* cleaup

* fix error in kbn-es-archiver

* fix errors in kbn-es-archiver

* fix errors in kbn-es-archiver

* fix ES typings for Hit

* fix SO

* fix actions plugin

* fix fleet

* fix maps

* fix stack_alerts

* fix eslint problems

* fix event_log unit tests

* fix failures in data_enhanced tests

* fix test failure in kbn-es-archiver

* fix test failures in index_pattern_management

* fixing ML test

* remove outdated comment in kbn-es-archiver

* fix error type in ml

* fix eslint errors in osquery plugin

* fix runtime error in infra plugin

* revert changes to event_log cluser exist check

* fix eslint error in osquery

* fixing ML endpoint argument types

* fx types

* Update api-extractor docs

* attempt fix for ese test

* Fix lint error

* Fix types for ts refs

* Fix data_enhanced unit test

* fix lens types

* generate docs

* Fix a number of type issues in monitoring and ml

* fix triggers_actions_ui

* Fix ILM functional test

* Put search.d.ts typings back

* fix data plugin

* Update typings in typings/elasticsearch

* Update snapshots

* mute errors in task_manager

* mute fleet errors

* lens. remove unnecessary ts-expect-errors

* fix errors in stack_alerts

* mute errors in osquery

* fix errors in security_solution

* fix errors in lists

* fix errors in cases

* mute errors in search_examples

* use KibanaClient to enforce promise-based API

* fix errors in test/ folder

* update comment

* fix errors in x-pack/test folder

* fix errors in ml plugin

* fix optional fields in ml api_integartoon tests

* fix another casting problem in ml tests

* fix another ml test failure

* fix fleet problem after conflict resolution

* rollback changes in security_solution. trying to fix test

* Update type for discover rows

* uncomment runtime_mappings as its outdated

* address comments from Wylie

* remove eslint error due to any

* mute error due to incompatibility

* Apply suggestions from code review

Co-authored-by: John Schulz <github.com@jfsiii.org>

* fix type error in lens tests

* Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts

Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>

* Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts

Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>

* update deps

* fix errors in core types

* fix errors for the new elastic/elasticsearch version

* remove unused type

* remove unnecessary manual type cast and put optional chaining back

* ML: mute Datafeed is missing indices_options

* Apply suggestions from code review

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>

* use canary pacakge instead of git commit

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Co-authored-by: restrry <restrry@gmail.com>
Co-authored-by: James Gowdy <jgowdy@elastic.co>
Co-authored-by: John Schulz <github.com@jfsiii.org>
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
2021-03-25 04:47:16 -04:00
Shahzad 9724051f92
[Observability] add loading state in use fetcher (#95292) 2021-03-25 09:06:58 +01:00
Shahzad b88f02ffb4
[Uptime] unskip overview test (#95290) 2021-03-25 09:05:26 +01:00
Shahzad 69bb5979ce
[Uptime] Support agent data streams (#91469)
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 09:04:40 +01:00
Matthias Wilhelm 6b5023a681
[Discover] Deangularize controller part 1 (#93896)
* Refactor minimumVisibleRows

* Extract setupVisualization function

* Extract getDimensions function

* Inline breadcrumb and help menu function exec to discover.tsx

* Extract getStateDefault 

* Remove unnecessary code

* Improve performance by React.memo
2021-03-25 07:34:01 +01:00
Tiago Costa 070ca4bb10
skip flaky suite (#89318 , #89319) 2021-03-25 04:06:44 +00:00
Tiago Costa a7ac120b69
fix(NA): support inspect flags on ensure_node_preserve_symlinks script (#95344)
* fix(NA): support inspect flags on ensure_node_preserve_symlinks script

* chore(NA): fix wording on function test runner schema file

* chore(NA): update execargv array in case of --inspect port
2021-03-24 23:54:39 -04:00
Luke Elmers 49078c82bc
[core.savedObjects] Add helper for using find with pit and search_after. (#92981) 2021-03-24 19:59:13 -04:00
Spencer 9d472bceaf
[dev/cli/timings] report on time to dev server listening (#95120)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-03-24 18:45:24 -04:00
Spencer 7b35b28edc
[ci] try reducing Jest concurrency to mitigate random timeouts (#95348)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-03-24 16:32:52 -04:00
Liza Katz 7f740831cb
Revert "use index patterns and search services for autocomplete (#92861)" (#95335)
This reverts commit 2ef7f3bd0c.
2021-03-24 22:16:38 +02:00
Nathan Reese c7aba55f7b
[Maps] do not call MapEmbeddable updateInput after embeddable is destroyed (#95337) 2021-03-24 14:02:31 -06:00
Constance 983c3a0139
[App Search] Log retention role fix (#95227)
* LogRetentionCallout - add ability check to API call

- on non-admin users, we're otherwise getting a forbidden error

- remove now-unnecessary canManageLogSettings wrapping check around the link CTA, since the entire callout is now essentially gated behind the check

* LogRententionTooltip - add ability check to API call

- on non-admin users, we're otherwise getting a forbidden error

- tests now require a ...values spread for myRole

* [MISC] Refactor previous isLogRetentionUpdating check in favor of a Kea breakpoint

- both dedupe calls for the commented use case, but breakpoint feels simpler & more Kea-y

* PR feedback: Increase breakpoint speed
2021-03-24 15:37:02 -04:00
Matthias Wilhelm 2da269fe93
[Discover][EuiDataGrid] Fix generating reports (#93748) 2021-03-24 20:09:11 +01:00
Quynh Nguyen 07a041ab3a
[ML] Fix Transform runtime mapping editor so mappings can be removed (#95108)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-24 13:28:31 -05:00
gchaps f3908f7754
[DOCS] Forward port of information (#95340) 2021-03-24 11:05:04 -07:00
Constance ec3926433c
[App Search] Various engines fixes (#95127)
* [Misc] Update trash icon color

- should be danger/red to match other tables in Kibana

* Engine table - fix incorrect conditional around when users can delete engines

- The check for that should be around Dev/Editor/Analyst roles, not around whether the account has a platinum license

- Tests - DRY out reset mock
- ideally would be in a beforeEach, but mount/beforeAll perf makes that difficult

* Create engine button - wrap with canManageEngines check

- prevents Dev/Editor/Analyst roles from hitting a 404 page

- test cleanup - use describe blocks to convey conditional branching, combine 2 tests into 1

* Empty engines prompt - add canManageEngines check

+ switch from FormattedMessage to i18n (this view was created a long time ago before we settled on generally preferring i18n)

+ provide a more helpful body text when the user cannot create engines

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/engines_overview.test.tsx

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
2021-03-24 13:23:07 -04:00
Alison Goryachev d0c09463d0
[Upgrade Assistant] Reorganize folder structure (#94843) 2021-03-24 12:39:39 -04:00
Sonja Krause-Harder 2e5b5debb5
[Fleet] Add force option to DELETE package endpoint. (#95051)
* Add force option to DELETE package endpoint.

* Add integration test.

* Adjust openapi spec.

* Run EPM tests before fleet setup tests.

* Run package delete tests first in EPM tests
2021-03-24 17:04:49 +01:00
Spencer 0551472cd9
[jest] switch to jest-environment-jsdom (#95125)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-24 08:47:10 -07:00
Nathan L Smith de3a7d6f0d
Use es instead of legacyEs in APM API integration test (#95303)
References #83910.
2021-03-24 10:45:51 -05:00
John Schulz 3639aa4422
[Fleet] Bulk reassign response should include all given ids (#95024)
## Summary
`/agents/bulk_reassign` should return a response with a result for each agent given; including invalid or missing ids. It currently filters out missing or invalid before updating. This PR leaves them in and includes their error results in the response. 

[Added/updated tests](https://github.com/elastic/kibana/pull/95024/files#diff-7ec94bee3e2bae79e5d98b8c17c17b26fad14736143ffa144f3e035773d4cad1R113-R128) to confirm

### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-24 11:44:22 -04:00
Constance 759a52c74d
[App Search] Add describe('listeners') blocks to older logic tests (#95215)
* Add describe('listener') blocks to older logic tests

* [Misc] LogRetentionLogic - move 2 it() blocks not within a describe() to its parent listener
2021-03-24 08:36:23 -07:00