Commit graph

35897 commits

Author SHA1 Message Date
spalger f078672c54 skip flaky suite (#76223) 2020-08-27 23:01:53 -07:00
Oliver Gupte b1cb8b8c7f
[APM] Transaction duration anomaly alerting integration (#75719)
* Closes #72636. Adds alerting integration for APM transaction duration anomalies.

* Code review feedback

* Display alert summary with the selected anomaly severity label instead of the anomaly score.

* - refactored ALL_OPTION and NOT_DEFINED_OPTION to be shared from common/environment_filter_values
- utilize getEnvironmentLabel in the alerting trigger components and added support for the 'All' label

* refactor get_all_environments to minimize exports and be more consistent and clean

* - Reorg the alerts menu for different alert types (threshold/anomaly)
- default environment alert settings to the selected filter

* - Filters default transaction type to only those supported in the APM anomaly detection jobs
- Removes Service name and transaction type from the set of expressions in the alerting setup

* - remove bell icon from alerts menu

* Adds target service back into the anomaly alert setup as a ready-only expression

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 21:19:36 -07:00
Lisa Cawley 1b75690b73
[Transforms] Avoid using "Are you sure" (#75932) 2020-08-27 18:56:31 -07:00
Yara Tercero 69599e0b49
[Security Solution][Exceptions] - Fix bug of alerts not updating after closure from exceptions modal (#76145)
## Summary

Fixes bug found in 7.9.

**Current behavior:** 
  - Go to alerts page
  - Select action to add exception item
  - Select checkbox to close all alerts matching exception
  - Click `Add exception`
  - Note that the alerts table does not update until after you refresh or toggle between `Closed` and `Open` 

**New behavior:** 
  - Go to alerts page
  - Select action to add exception item
  - Select checkbox to close all alerts matching exception
  - Click `Add exception`
  - Note that the alerts table updates
2020-08-27 20:00:42 -04:00
Spencer 64311d306f
[plugin-helpers] improve 3rd party KP plugin support (#75019)
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-08-27 14:56:48 -07:00
Spencer 89ae03221b
[docs/getting-started] link to yarn v1 specifically (#76169)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-08-27 14:19:41 -07:00
Michael Olorunnisola 280fb8b3ed
[Security_Solution][Resolver] Resolver loading and error state (#75600) 2020-08-27 14:42:21 -06:00
Chris Cressman 905c76242d
Fixes App Search documentation links (#76133)
Two links to App Search docs are pointing to outdated versions.

Update the URLs.
2020-08-27 16:11:18 -04:00
Mike Côté 50193eaabb
Fix alerts unable to create / update when the name has trailing whitepace(s) (#76079)
* Trim alert name in API key name

* Add API integration tests
2020-08-27 16:00:03 -04:00
Robert Austin 31507f82b6
[Resolver] Fix useSelector usage (#76129)
In some cases we have selectors returning thunks. The thunks need to be
called inside `useSelector` in order for a rerender to be reliably
triggered.

`useSelector` triggers a re-render if its return value changes. By calling the thunk inside of the selector passed to `useSelector`, we will trigger re-renders when needed.
2020-08-27 15:43:52 -04:00
Scotty Bollinger ca94923900
[Enterprise Search] Migrate util and components from ent-search (#76051)
* Migrate useDidUpdateEffect hook

Migrates https://github.com/elastic/ent-search/blob/master/app/javascript/shared/utils/useDidUpdateEffect.ts with test added.

* Migrate TruncateContent component

* Migrate TableHeader component

* Remove unused deps

* Fix test name

* Remove custom type in favor of DependencyList

* Add stylesheet for truncated content

* Actually import stylesheet

🤦🏼‍♂️

* Replace legacy mixin

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 14:34:28 -05:00
Rashmi Kulkarni e2e9d96df6
accessibility test for Painless lab (#75688)
* accessibility test for painless lab

* skipped a test due to aria-violation

* skipped tests due to aria-violation and added datatestsubj

* removed the unwanted import

* incorporate review comments

* feedback incorporated

* review comments incorporated

* removed unwanted expect
2020-08-27 12:15:47 -07:00
Constance a7b0f7a102
[Enterprise Search] Add reusable FlashMessages helper (#75901)
* Set up basic shared FlashMessages & FlashMessagesLogic

* Add top-level FlashMessagesProvider and history listener

- This ensures that:
  - Our FlashMessagesLogic is a global state that persists throughout the entire app and only unmounts when the app itself does (allowing for persistent messages if needed)
  - history.listen enables the same behavior as previously, where flash messages would be cleared between page views

* Set up queued messages that appear on page nav/load

* [AS] Add FlashMessages component to Engines Overview

+ add Kea/Redux context/state to mountWithContext (in order for tests to pass)

* Fix missing type exports, replace previous IFlashMessagesProps

* [WS] Remove flashMessages state in OverviewLogic

- in favor of either connecting it or using FlashMessagesLogic directly in the future

* PR feedback: DRY out EUI callout color type def

* PR Feedback: make flashMessages method names more explicit

* PR Feedback: Shorter FlashMessagesLogic type names

* PR feedback: Typing

Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>

Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
2020-08-27 12:03:20 -07:00
Quynh Nguyen 1bd8f41275
[ML] Add indicator if there are stopped partitions in categorization job wizard (#75709) 2020-08-27 13:50:15 -05:00
Joe Portner c31acce649
Fix more broken usages of bulkCreate (#76005) 2020-08-27 13:54:09 -04:00
Lisa Cawley 165752b05f
[DOCS] Add monitoring.ui.logs.index (#75830) 2020-08-27 10:39:44 -07:00
Brent Kimmel ebfba81ba5
[Security Solution][Resolver] break/wrap for process detail (#76095)
* [Security Solution][Resolver]break/wrap for process detail

* add an enzyme test to check for the breakers
2020-08-27 13:25:01 -04:00
Tiago Costa 2010ec6ac4
fix(NA): keystore read path on serve (#75659)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 18:22:53 +01:00
Nathan Reese 12f4f6d74a
[Maps] fix read only badge is no longer shown in nav for users with read-only permission (#76091) 2020-08-27 10:53:16 -06:00
Joe Portner 51fd423689
[Docs] Fix typo in docs for server.xsrf.disableProtection (#76102) 2020-08-27 12:42:24 -04:00
Bhavya RM d556c79481
Test user assignment to maps tests - 2 (#75890)
and removing unused data from fullscreen maps.js
2020-08-27 12:03:53 -04:00
Matthew Kime 3541e779c6
Index pattern class cleanup - remove _.apply and any instance (#76004)
Index pattern class cleanup - remove _.apply and `any` instance
2020-08-27 10:57:37 -05:00
Tim Sullivan 69a8d06129
[Reporting/Download CSV] Get the file name from savedSearch data (#76031)
* [Reporting/Download CSV] provide title even if panel \titles are hidden in the dashboard

* add functional test

* Update embeddable_panel.tsx

* Update download_csv.ts
2020-08-27 08:40:56 -07:00
Brandon Kobel bf25e16a8b
Skip creating SpacesClient when not needed in auth interceptor (#75706)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 08:23:07 -07:00
Zacqary Adam Xeper b98e2e4f3d
[Metrics UI] Replace uses of any introduced by Lodash 4 (#75507)
Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 10:06:55 -05:00
Joe Portner 8671db1559
[Docs] Add server.xsrf.disableProtection to settings docs (#76022) 2020-08-27 10:44:59 -04:00
Nathan Reese b2939618f4
do not advance beneathMbLayerId if bottomMbLayer could not be found for a layer (#76007)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 08:15:37 -06:00
Larry Gregory 54bbd6a910
Adds authenticaton_type as expected property on ES authentication response (#75808)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 10:09:20 -04:00
Justin Kambic d457d53001
[Uptime] Translate bare strings (#75918)
* Translate a bare string.

* Remove unneeded translation.
2020-08-27 09:02:32 -04:00
Jason Stoltzfus f065191a75
[Enterprise Search] Added an App Search route for listing Credentials (#75487)
In addition to a route for listing Credentials, this also adds a
utility function which helps create API routes which simply proxy
the App Search API.

The reasoning for this is as follows;
1. Creating new routes takes less effort and cognitive load if we
can simply just create proxy routes that use the APIs as is.
2. It keeps the App Search API as the source of truth. All logic is
implemented in the underlying API.
3. It makes unit testing routes much simpler. We do not need to verify
any connectivity to the underlying App Search API, because that is
already tested as part of the utility.
2020-08-27 08:44:41 -04:00
Yulia Čech b802af8002
[ILM] Fix json in request flyout (#75971)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 14:15:59 +02:00
Sébastien Loix ec1516064c
[Form lib] Correctly add field to form on component mount (#75796)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 14:02:03 +02:00
Diana Derevyankina 8e2cb5684e
KQL support in filter ratio in TSVB (#75033)
* KQL support in filter ratio in TSVB

Closes #67503

* Fix filter_ratio and filter_ratios tests

* fix JEST

* Refactor some code in filter_ratio, filter_ratios, filter_ratios.test

* Edit query value in filter_ratio and filter_ratios.test

* Refacor some code in filter_ratio.js and visualization_migrations.ts

* Remove duplications in vis_schema and refactor filter_ratio

* Refactor filter_ratio.js

* Update default query with getDefaultQuery()

* Fix filter_ratio and histogram_support tests

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 13:35:04 +03:00
Mikhail Shustov 37ec1e1053
Update to TS v4 (#73924)
* bump ts to v4

* MOAR RAM

* fix type errors for OSS

* first pass on x-pack errors

* second pass on x-pack type errors

* 3rd pass on x-pack type-errors

* mute errors if complex cases

* don't delete if spread suffices

* mute other complex cases

* make User fields optional

* fix optional types

* fix tests

* fix typings for time_range

* fix type errors in x-pack/tests

* rebuild kbn-pm

* remove leftovers from master update

* fix alert tests

* [Telemetry Checker] TS4 Fixes

* bump to 4.0.1-rc

* fix new errors in master

* bump typescript-eslint to version supporting TS v4 syntax

* fix merge commit errors

* update to the stable TS version 4.0.2

* bump ts-eslint to version supporting ts v4

* fix typo

* fix type errors after merge

* update ts in another new package.json

* TEMP: remove me

* Revert "TEMP: remove me"

This reverts commit dc0fc3bae6.

* [Telemetry] Update snapshot for new TS4 SyntaxKind

* bump prettier to support TS v4 syntax

* fix prettier rules

* last style change

* fix new type errors

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
2020-08-27 10:28:02 +02:00
Dima Arnautov e488c087fc
[ML] fix tooltip content for scheduled events (#75973)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 09:03:36 +02:00
Shahzad a358c5768e
[Uptime] One click simple monitor down alert (#73835)
* WIP

* added anomaly alert

* update types

* update types

* update

* types

* types

* update ML part

* update ML part

* update ML part

* unnecessary change

* icon for disable

* update test

* update api

* update labels

* resolve conflicts

* fix types

* fix editing alert

* fix types

* added actions column

* added code to add alert

* update anomaly message

* added anomaly alert test

* update

* update type

* fix ml legacy scoped client

* update

* WIP

* fix conflict

* added aria label

* Added deleteion loading

* fix type

* update

* update tests

* update

* update type

* fix types

* WIP

* added enabled alerts section

* add data

* update

* update tests

* fix test

* update i18n

* update i18n

* update i18n

* fix

* update message

* update

* update

* update

* revert

* update types

* added component

* update test

* incorporate PR feedback

* fix focus

* update drawer

* handle edge case

* improve btn text

* improve btn text

* use switch instead of icons

* update snapshot

* use compressed form

* fix type

* update snapshot

* update snapshot

* update test

* update test

* PR feedback

* fix test and type

* remove delete action

* remove unnecessary function

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-27 07:02:28 +02:00
Brent Kimmel 42942327e5
[Security Solution][Resolver] Word-break long titles in related event… (#75926)
* [Security Solution][Resolver] Word-break long titles in related event description lists

* word-break long titles at non-word boundaries

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-26 21:06:38 -04:00
Rashmi Kulkarni c08bf7f3ca
using test_user with minimum privileges for canvas functional ui tests (#75917)
* incorporating test_user wth specific roles for the canvas functional ui tests

* additional checks - removed comments

* changes to incorporate code comments

* lint check

* incorporate code reviews

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-26 17:21:16 -07:00
spalger 4289f9d8b1 skip all tests that rely on es authentication type 2020-08-26 16:15:09 -07:00
Yara Tercero 043382d686
[Security Solution][Exceptions] - Improve UX for missing exception list associated with rule (#76012)
## Summary

**Current behavior:**
  - **Scenario 1:** User is in the exceptions viewer flow, they select to edit an exception item, but the list the item is associated with has since been deleted (let's say by another user) - a user is able to open modal to edit exception item and on save, an error toaster shows but no information is given to the user to indicate the issue.
  - **Scenario 2:** User exports rules from space 'X' and imports into space 'Y'. The exception lists associated with their newly imported rules do not exist in space 'Y' - a user goes to add an exception item and gets a modal with an error, unable to add any exceptions. 
  - **Workaround:** current workaround exists only via API - user would need to remove the exception list from their rule via API

**New behavior:**
  - **Scenario 1:** User is still able to oped edit modal, but on save they see an error explaining that the associated exception list does not exist and prompts them to remove the exception list --> now they're able to add exceptions to their rule
  - **Scenario 2:** User navigates to exceptions after importing their rule, tries to add  exception, modal pops up with error informing them that they need to remove association to missing exception list, button prompts them to do so --> now can continue adding exceptions to rule
2020-08-26 18:46:15 -04:00
Wylie Conlon 8364d8d67a
[Lens] Decouple visualizations from specific operations (#75703)
* [Lens] Decouple visualizations from specific operations

* Remove unused mock
2020-08-26 18:27:40 -04:00
Devin W. Hurley 979d1dbca8
[Security Solution] [Detections] Updates rules routes to validate "from" param on rules (#76000)
* updates validation on 'from' param to prevent malformed datemath strings from being accepted

* fix imports

* copy paste is not my friend

* missed type check somehow

* forgot to mock common utils

* updates bodies for request validation tests
2020-08-26 18:18:39 -04:00
Tyler Smalley 595dfdb023
Disables Chromedriver version detection (#75984)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-08-26 14:37:55 -07:00
Pierre Gayvallet d2d7b0decf
Legacy ES plugin pre-removal cleanup (#75779)
* delete integration tests

* remove legacy version healthcheck / waitUntilReady

* remove handleESError

* remove createCluster

* no longer depends on kibana plugin

* fix kbn_server

* remove deprecated comment and dead code

* revert code removal, apparently was used (?)

* Revert "revert code removal, apparently was used (?)"

This reverts commit 69481850
2020-08-26 23:33:15 +02:00
Scotty Bollinger 35b8d50ccd
[Enterprise Search] Adds app logic file to Workplace Search (#76009)
* Add new Workplace Search initial data properties

* Add app logic

* Refactor index to match App Search

Adds the easier-to-read ComponentConfigured and ComponentUnconfigured FCs with a ternary in the root compoenent

* Remove ‘Logic’ from interface names

* Extract initial data from WS into interface

This allows for breaking apart the app-specific data and also having an interface to extend in the app_logic file

* Destructuring FTW
2020-08-26 16:21:11 -05:00
Devon Thomson fd39f094cc
Duplicate title warning wording (#75908)
Changed wording on duplicate title warning.
2020-08-26 17:19:30 -04:00
Davis Plumlee deb71ecbb7
[Security Solution][Exceptions Modal] Switches modal header (#76016) 2020-08-26 17:13:38 -04:00
Joe Portner 6627d7d9af
Sharing saved-objects phase 1.5 (#75444)
Added UI for sharing saved objects, and updated UI for importing and copying too
2020-08-26 16:52:29 -04:00
Paul Tavares 9873df8ee0
[SECURITY_SOLUTION][ENDPOINT] Trusted Apps List API (#75476)
* Trusted Apps initial setup for route registration

* Added types for TrustedApp entries

* trusted apps list API returns results

* use methods and const from latest PR merge to lists

* a quick generator for trusted apps entries

* support cli options for trusted app data loader

* Add mocked `createTrustedAppsList()` method to `ExceptionListClientMock`

* tests fro trusted apps route handlers

* tests for trusted apps schema

* Correct name of mock method

* Fix service to ensure return value of `getExceptionList` service throws if service not available

* Fix types

* Refactor TrustedApp type + code review feedback
2020-08-26 16:02:37 -04:00
Catherine Liu 532f2d70e8
[Home] Elastic home page redesign (#70571)
Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
2020-08-26 13:00:00 -07:00