Commit graph

26034 commits

Author SHA1 Message Date
Vadim Dalecky
f18e7439d9
「AppArch」Interpreter 👉 New Platform (#39329)
* feat: 🎸 set-up NP data plugin

* refactor: 💡 move interpreter functions registry to NP

* refactor: 💡 move interpreter renderer registry to NP plugin

* refactor: 💡 move interpreter typesRegistry to NP

* refactor: 💡 move interpreter types to NP

* chore: 🤖 import typeRegistry from NP and change TS type folder

* refactor: 💡 move interpreter expression types to NP

* refactor: 💡 move rest of interpreter common folder to NP plugin

* fix: 🐛 fix TypeScript errors

* test: 💍 improve typings and test mocks

* refactor: 💡 make Interpreter internal registry impl private

* test: 💍 inline NP backdoor mock creation in test suites

* chore: 🤖 change @kbn/interpreter import paths to try fix errors

* fix: 🐛 improve core Plugin interfaces

* feat: 🎸 add stop() lifecycle to NP data plugins

* refactor: 💡 move interpreter into expressions service data NP

* refactor: 💡 inline Registry @kbn/interpreter class

* refactor: 💡 remove dependency on @kbn/interpreter in data pub

* refactor: 💡 move interpreter common dir into expressions dir

* fix: 🐛 use TS types in kibana_context

* feat: 🎸 add types suggested in PR review

* feat: 🎸 add semantic interpreter registration functions

* refactor: 💡 use require for all @kbn/interpreter imports

* test: 💍 add Karma test mocks, thx @spalger 🙏

* docs: ✏️ update Core docs

* test: 💍 add Sinon stubs for registries

* chore: 🤖 change import syntax in hopes CI will work

* chore: 🤖 set App Architecture as owners of data plugin

* docs: ✏️ add README

* chore: 🤖 change import in hopes to fix optimizer

* fix: 🐛 make stop() plugin life-cycle optional

* docs: ✏️ update Core API docs

* test: 💍 remove unnecessary Jest mock

* chore: 🤖 don't import from deeply inside a plugin

* refactor: 💡 try different interpreter import

* fix: 🐛 fix Karma mocking

* fix: 🐛 fix TypeScript type imports

* test: 💍 fix broken test
2019-07-02 09:07:07 +02:00
Yulong
12ba1f1894
[Code] add an api to show status of repo file and language servers (#39566)
* [Code] add an api to show status of repo file and language servers
add a test for status api
add a field to indicate whether current file is covered by ctags or not
show status ui
2019-07-02 12:51:22 +08:00
Mengwei Ding
ad77e901b2
[Code] replace illegal characters for creating indices (#40054) 2019-07-01 19:02:54 -07:00
Clint Andrew Hall
f41528f817
Enable Canvas URL Parameters (#40061)
* Enable Canvas URL Parameters

* Update to use time interval strings

* Addressing feedback
2019-07-01 20:24:54 -05:00
Tiago Costa
f7a223d34c
chore(NA): move json type definitions to x-pack root type definitions (#37249) 2019-07-02 02:23:38 +01:00
Justin Kambic
48f5d4ceff [Uptime] Add monitor summaries (#38895)
The main purpose of this PR is to allow the Uptime app's Overview page to leverage a new format for Heartbeat data that we've been referring to as States. The purpose here is to make it easy to query how many monitors there are right now, what their status is, etc., as well as add support for grouping monitors by location. This allows us to reference documents for a single host that many heartbeat instances are creating.
2019-07-01 19:13:52 -05:00
Poff Poffenberger
20672eb691
Fix for Canvas expression editor height on Safari (#39961) 2019-07-01 18:41:20 -05:00
CJ Cenizal
8036c1f818
Accept triple quoted input in Search Profiler. (#39984) 2019-07-01 16:32:08 -07:00
CJ Cenizal
139f053034
Remove unnecessary spacers and wrapping divs from Index Management confirmation modals. (#39971) 2019-07-01 15:26:42 -07:00
Aleh Zasypkin
743f631bd6 Switch Kerberos authentication provider to a dedicated _kerberos grant. Introduce Tokens for common access/refresh token tasks. (#39366)
* Switch Kerberos authentication provider to a dedicated `_kerberos` grant. Introduce `Tokens` for common access/refresh token tasks.

* Review#1: improve/fix code comments, properly log the case when token invalidation failed.
2019-07-01 14:49:03 -07:00
Jen Huang
f60b5364da
[SR] Adjust app permissions (#39966)
* Adjust SR app permissions for new features

* Fix app state and reducer typings

* Fix i18n key

* Fix typos

* Make logic more clear
2019-07-01 14:41:17 -07:00
CJ Cenizal
5753888bda
Fix i18n pluralization bugs in "Remove Lifecycle Policy" modal and "Freeze" action of context menu (#39979)
* Fix i18n pluralization bugs in 'Remove Lifecycle Policy' confirmation modal of ILM.
* Fix i18n pluralization bugs in freeze action of Index Management actions context menu.
2019-07-01 14:21:23 -07:00
CJ Cenizal
b0faa7dd43
Separate Console History panel from editor with a drop-shadow, and add a Close button. (#39972) 2019-07-01 14:02:15 -07:00
Jen Huang
917c0bbff8
[SR] Add link to index settings docs (#40083)
* Add link to index settings docs
2019-07-01 13:44:36 -07:00
Spencer
cec4f5bdca
return 1 when precommit_hook or local version fail (#40075) 2019-07-01 13:14:03 -07:00
Nathan Reese
9e3ac6d6e0
[Maps] Custom labels for metric aggregations (#39914)
* [Maps] custom labels for metrics

* fix onRemove

* set metric propertyLabel to custom label when provided

* add metrics label around MetricsEditor for geo grid source

* do not use label in terms join metric expression

* fix requerying of the data when custom label changes

* remove extra space

* add comment to LeftInnerJoin.getSourceId

* use FormRow.labelAppend instead of absolute positioning for delete aggregation button

* fix i18n translations
2019-07-01 14:06:23 -06:00
Nathan Reese
1a5f96c470
[Maps] set data-render-complete on map container when layers are loaded (#39746)
* [Maps] set data-render-complete when layers are loaded

* ignore layers that are not visible

* use timeout to give time for render to complete

* move check for layer visibility out of isDataLoaded and into areLayersLoaded selector

* prepend private functions with _ in name

* rename isRenderTimeoutComplete to isInitialLoadRenderTimeoutComplete

* update AbstractLayer.isDataLoaded default implemenation to check source data request to TileLayer source requests are checked

* TileLayer cleanup

* rename for clarity
2019-07-01 13:58:36 -06:00
Angela Chuang
0bc47ddd37
[SIEM] update translation (#40038)
* update translation

* rename translation

* rename translation

* fix lint error
2019-07-02 03:36:00 +08:00
Steph Milovic
fbd066d3c7
[SIEM] Tab headers openable in a new tab (#39702)
[SIEM] Tab headers openable in a new tab
2019-07-01 13:21:11 -06:00
Nathan Reese
7f4c07b3c0
[Maps] remove beta labeling from application and docs (#39871)
* [Maps] remove beta labeling from application and docs

* clean up i18n
2019-07-01 12:48:29 -06:00
Andrew Cholakian
9949107a79
[Uptime] Summary based monitors Page (#39751)
This implements the overview page changes described in elastic/uptime#41 and https://docs.google.com/document/d/1jlyOam08gC3oq0W8dim0BF-5QYEOXFqSg48nMwbirmg/edit

One change that was necessary was omitting the swimlane visualization. After speaking to the ML team it was discovered that incorporating this component isn't possible yet, as it requires cross-plugin code sharing. In its stead we have re-used the monitor checks over time graph. We may want to keep this, as the graph used here is superior for multiple IP use cases.
2019-07-01 12:57:15 -05:00
dave.snider@gmail.com
53273ecff4
EUI@12.2.0 (#40039)
* EUI@12.2.0

* update EuiFormRow to hold a single child, removes comments only
2019-07-01 13:33:22 -04:00
Larry Gregory
544ef71ba1
Spaces API - default disabledFeatures to empty array (#40017)
* default disabledFeatures to empty array

* update PUT spaces tests
2019-07-01 13:15:01 -04:00
Thomas Neirynck
e1b1c56eef
[Maps] add multiple feature selection in tooltips (#39629) 2019-07-01 12:53:39 -04:00
Patrick Mueller
c4749b7068
Changes x-pack action executor to return result. (#39820)
* Changes x-pack action executor to return result.

Previously, the result was never captured.  It's now captured, and
returned if it's JSONable.  If not JSONable a `{succcess: true}`
object is returned with a 200 response (used to be 204).

Also added logging for action execution calls, in lieu of having an
action history available.

Drive-by:

- `services.log` was set to the unbound Hapi server.log method, so
  places where it was set were changed to bind it to the server.
2019-07-01 12:50:36 -04:00
Joel Griffith
7b67613128
[Reporting]: Check if CSV cells (including headers) start with known formula characters (#37930)
* Re-working csv injection issue into master

* Config flag for checking if CSV's contain formulas

* Fixing snapshots
2019-07-01 09:49:59 -07:00
Larry Gregory
3e8687c3e3
Saved Objects - make import/export stream based (#39674)
* transform ndjson within route handlers for SO import/export APIs

* convert export saved objects to return a stream

* fix stream creation
2019-07-01 11:48:06 -04:00
Alison Goryachev
8807427c9c
fix license management actions (#39898) 2019-07-01 11:46:22 -04:00
Sonja Krause-Harder
7f7144eb75
[Infra UI] Add temporary workaround for too small max-width. (#39890)
* Add temporary workaround for too small max-width.

* Follow naming guidelines.
2019-07-01 17:29:00 +02:00
Tiago Costa
302ac70c12
Exclude contextual module references from cleaning dll task (#38733)
* fix(NA): exclude contextual module references from cleaning dll tasks

* test(NA): fix tests for nodejs modules webpack dll build task.

* chore(NA): add test for non accessible files.

* chore(NA): apply requested changed on the PR review.

* test(NA): fix for test cases

* fix(na): circular call on isFileAccessible implementation.
2019-07-01 16:14:30 +01:00
Walter Rafelsberger
acfbe096c4
[ML] Data Frames: Fixes transform list paging and sorting. (#40009)
- Fix to retain the selected page when the transform list updates with new data
- Fix to sort column based on custom render() functions.
2019-07-01 16:42:56 +02:00
Corey Robertson
5c53e6f8cc
Track customElement and full screen and autoplay usage (#39735)
* Track customElement and full screen and autoplay usage

* Rename action
2019-07-01 09:46:25 -04:00
Carlos Pérez-Aradros Herce
c6c751832d
Add NATS logo to the Add Data UI (#39905)
* Add NATS logo to the Add Data UI
2019-07-01 15:15:50 +02:00
Liza Katz
1824d99b71
Moved modal and transition directives to ML (#39976)
* Moved modal and transition directives to ML

* Moved paginated selectable list to ML

* Moved paginated selectable list test

* Fixed i18n
2019-07-01 16:13:59 +03:00
Liza Katz
531e2b0f59
Query Filter \ Filter Manager: de-angularize and move to data plugin (#37311)
* Embeddable and Visualize to use type definitions from kbn-es-query package

* moved state watching to new filter manager and removed query filter dependency on rootScope

* Deleted unused pinFilter

* Extracted merge fitlers function

* Changed mappedFilters name

* Move state management to new filter management as well. query filter is now just a wrapper.

* Code works correctly with new setup of query filter

* improved typing

* Moved mapping into new filter manager

* removed promise dependency from query filter

* Extracted filter state manager from query filter

* Moved addFiltersAndChangeTimeFilter logic into new filter manager

* Fixed addFiltersAndChangeTimeFilter implementation

* Moved all logic to new filter manager - query filter is just a wrapper now!

* Connected query_filter observable management to new filter manager as well

* Usage example in discover

* filter state management tests + fire less events from filter state manager

* Tests for filter manager and filter state manager

* Moved new filter manager to data plugin

* Got rid of FilterManagerProvider and turned it into a getFilterGenerator function that works with the new FilterManager.
Need to merge this code with FilterManager.

* Added tests that make sure that filter manager listens to filter state manager

* fix typo

* Fixed action add filter test

* Fixed increasePredecessorCount test

* Fixed increaseSuccessorCount test

* Fixed setPredecessorCount test

* Fixed setQueryParameters test

* Fixed setSuccessorCount test

* Fixed doc table filter actions test

* Fixed filter generator tests

* rename argument

* Moved push filters into vis filters (only place where its used)

* Filter type fix, test fix

* Removed irrelevant filter tests (for deleted methods)
    Added state to filters

* Fixed most of get filters errors by sleeping (TODO!)

* Added destroy methods
Improved merge logic
Improved remove filter tests to use add filter (to avoid having for filter state manager to catch up)

* Fixed discover functional tests
Added default empty filter state in filter generator
Some more browser test adjustments

* Allow filter $state to be empty

* Fixed types

* Code review with @splager
- subscribeWithScope
- query filter to return angular promises
- remove unneeded Promise.resolve

* Separate class\type defenitions from plugin instance setup in shim plugin definition
This helps avoiding circular dependency issues that were obsereved in filter-manager branch (due to code starting to use the data plugin).

* typescript fun

* Fixed merge

* updated some get filter tests to work with add filter, and therefore moved them to add_filters.js

* Remove shouldFetch and add comment explaning the observable.

* Minor code style fixes

* Code review fixes and changes

* Moved Karma tests to jest

* Fixed merge

* Fixed some type errors

* Improved watchFilterState logic

* Removed addFiltersAndChangeTimeFilter test for now, as I'm having TS difficulties

* filters can also be null

* Further watch state fine tuning

* Get data instance inside provider to avoid circular deps

* mock chrome

* Removed change to range filter

* Deleted unnecessary injects

* dedup setFilters as well

* deleted unused subscription

* Added tests for setFilters de-dupe

* Update src/legacy/core_plugins/data/public/filter/filter_manager/filter_state_manager.ts

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* Update src/legacy/core_plugins/data/public/filter/filter_manager/filter_manager.ts

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* Code review minor fixes
2019-07-01 15:57:57 +03:00
Walter Rafelsberger
4426094048
[ML] Data frames: Updated progress reporting. (#39920)
- Adds a column mode to the data frame transforms list to indicate if the transform is batch or continuous.
- For continuous data frames an animated horizontal loading indicator is shown in the Progress column instead of a progress bar with percentage.
- In expanded rows, for Job details the section checkpointing was added.
- In the transform wizard's creation step, for continuous transforms the progress bar is not shown. In a follow up we could add more useful stats there, like what's shown in the transform list's job details.
2019-07-01 13:59:28 +02:00
Walter Rafelsberger
7e88f47c92
[ML] Data Frames: Fixes crash of the source table for complex field values. (#39878)
The data frame wizard's source index preview table would crash with some field values more complex than strings. This PR fixes it by adding the following "special treatment" for these values:

Arrays of strings will be concatenated to a comma separated string in table rows.
Arrays of objects will be rendered as a badge with the label array and a tooltip that says that the full value is available in the expanded row.
In the expanded row, every value that's not a string will be rendered using JSON.stringify().
2019-07-01 13:25:35 +02:00
WangQianliang
19311fb5a2
[Code] refactor file and repository reducer (#39422)
* chore(code/frontend): refactor file and repository reducer

* chore(code/frontend): add types in actions and reducers
2019-07-01 18:51:08 +08:00
Joe Reuter
9d7ab49b36 Check whether vis type exists (#39803)
* check whether vis type exists

* check wether vis type exists for experimental check

* only show object if vis type is valid
2019-07-01 12:04:44 +02:00
Liza Katz
2181e6ee5c
delete unused table_info (#39978) 2019-07-01 12:13:34 +03:00
Liza Katz
09950ea27d
Moved fancy forms into vis editor (#39977) 2019-07-01 12:12:17 +03:00
Liza Katz
3f7d01b82f
Moved pager and pager control directives to doc_table (#39975)
* Moved pager and pager contrlol directives to doc_table

* translation fix
2019-07-01 12:12:03 +03:00
James Gowdy
3d380d199c
[ML] Adding licensing and space limits to privileges checks (#39749)
* [ML] Adding licensing limits to privileges checks

* renaming enum key

* adding ml enabled in space check

* fixing tests

* adding new tests

* adding space tests

* updating types

* fixing type failure

* renaming platinum

* renaming privileges to capabilities
2019-07-01 09:45:41 +01:00
Dario Gieselaar
d4cd8d205d
Execute locally configured pre-commit hooks (#39784)
* Execute locally configured pre-commit hooks

This change enables users to add and execute locally configured pre-commit hookly configured pre-commit hooks. Previously this was not possible because kibana bootstrap installs its own pre-commit in the `.hooks` folder.

To add a locally configured pre-commit hook, simply create a `.pre-commit` file in the root folder. Kibana's pre-commit hook will check if this file exists and if it does, execute it.

* Address review feedback

* remove GIT_PARAMS, because https://git-scm.com/docs/githooks#_pre_commit
2019-07-01 09:22:15 +02:00
CJ Cenizal
c2a14e75f3 EUIfy Watcher (#35301) 2019-06-29 07:05:55 -04:00
Liza Katz
6165e19ef2
Removed unnecessary use of kbn-top-nav in dev tools app (wrapping tabs) (#39785) 2019-06-29 12:19:08 +03:00
Frank Hassanabad
2bf06185da
[SIEM] Adds Machine Learning table anomalies, a pop over UI for anomalies, and machine learning details score (#39483)
## Summary

[SIEM] Adds Machine Learning table anomalies, a pop over UI for anomalies, and machine learning details score. Works on both the hosts page and the network page as well as the details sections of both those pages.

Table
<img width="760" alt="Screen Shot 2019-06-28 at 11 09 39 AM" src="https://user-images.githubusercontent.com/1151048/60359902-96c33e00-9997-11e9-8a0a-92fb8e7d808a.png">

Popover
<img width="764" alt="Screen Shot 2019-06-28 at 11 09 50 AM" src="https://user-images.githubusercontent.com/1151048/60359909-9cb91f00-9997-11e9-96e0-f51ec33cee6f.png">

Details with Popover:
<img width="800" alt="Screen Shot 2019-06-28 at 11 12 14 AM" src="https://user-images.githubusercontent.com/1151048/60359955-bce8de00-9997-11e9-8154-6165b21f25f7.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2019-06-29 01:20:15 -06:00
Catherine Liu
af56c9b732
[Canvas] Feat: Fit Workpad to Window (#39864)
* Added fit to window zoom option

Added reset zoom option

Added divider between zoom and reset options

* Fixed zoom in/out from fit to window scale

* PR feedback

* Fixed fit to window with elements way off the workpad

* Ensure zoom level array is always in ascending order

* Updated storyshot
2019-06-28 16:17:55 -07:00
renovate[bot]
d142171366 Update dependency eslint-plugin-import to v2.18.0 (#39934)
* Update dependency eslint-plugin-import to v2.18.0

* fix new import order violations
2019-06-28 15:51:50 -07:00
spalger
0922772b70 skip flaky test (#39927) 2019-06-28 15:46:43 -07:00