Commit graph

36517 commits

Author SHA1 Message Date
Patryk Kopyciński f3b35c552e
Bump react-beautiful-dnd (#78028)
* Bump react-beautiful-dnd

* fix types

* fix types
2020-09-23 08:34:52 +02:00
Frank Hassanabad d79fbb3f5c
[Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (#78004)
## Summary

Fixes: https://github.com/elastic/kibana/issues/77254

Bubbles up error messages from ES queries that have _shards.failures in them. For example if you have errors in your exceptions list you will need to see them bubbled up.

Steps to reproduce:
Go to a detections rule and add an invalid value within the exceptions such as this one below:
<img width="1523" alt="Screen Shot 2020-09-21 at 7 52 59 AM" src="https://user-images.githubusercontent.com/1151048/93817197-d1a53780-fc15-11ea-8cf2-4dd7fd5a3c13.png">

Notice that rsa.internal.level value is not a numeric but a text string. You should now see this error message where before you could not:
<img width="1503" alt="Screen Shot 2020-09-21 at 7 52 44 AM" src="https://user-images.githubusercontent.com/1151048/93817231-e1bd1700-fc15-11ea-9038-99668233191a.png">

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2020-09-22 19:18:50 -06:00
Matthew Kime 9450248ebe
Index pattern - refactor constructor (#77791)
* index pattern - refactor constructor
2020-09-22 20:01:36 -05:00
Larry Gregory 2476451790
Add xpack.security.sameSiteCookies to docker allow list (#78192) 2020-09-22 20:12:31 -04:00
Matthew Kime 533309dc2c
Remove [key: string]: any; from IIndexPattern (#77968)
* Remove [key: string]: any; from IIndexPattern
2020-09-22 18:03:22 -05:00
CJ Cenizal 07b7b06c11
Remove requirement for manage_index_templates privilege for Index Management (#77377) 2020-09-22 14:47:11 -07:00
Jen Huang 48b81a62f7
[Ingest Manager] Agent bulk actions UI (#77690)
* Add temporary client-side license service/hook

* Initial pass at bulk actions UI (UI behavior only)

* Initial pass at implementing reassign agent policy by agent IDs

* Allow bulk reassign agent policy by kuery

* Return total inactive agents in list agents API to better handle bulk action selection UI that may or may not include active agents

* Add isGoldPlus method to license service

* Add `normalizeKuery` function

* Add `.findAllSOs` method and refactor bulk reassign to use that

* Initial pass at backend work for bulk unenroll

* Covert unenroll provider to unenroll modal and adjust UI to include force option

* Move license protection to handler level, fix misc bugs

* Add comments about `data` field response in create agent action(s)

* Clean up license service

* Fix i18n

* Add tests for bulk. unenroll

* Add tests for reassign and bulk reassign

* Fix typing

* Adjust single actions icon and text to be consistent

* Fix i18n

* PR feedback

* Increment api key test assertion to account for adding another agent policy to es archiver data

* Fix test

* Fix duplicate declaration after merging

* Add comments to SO find all function

* Batch invalidate API keys requests
2020-09-22 14:23:54 -07:00
Zacqary Adam Xeper a0f03ddbd1
[Metrics UI] Add inventory view timeline (#77804)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-22 16:21:09 -05:00
Tim Sullivan 0f8bbf11f4
Reporting/Docs: Updates for setting to enable CSV Download (#78101)
* Reporting/Docs - update documentation about setting to enable CSV Download

* break up long setting name to fix table scrolling
2020-09-22 14:12:52 -07:00
Nathan L Smith ac00887acd
Update to latest rum-react (#78193)
* Update to latest rum-react

The latest version fixes a problem where you would get a bunch of warnings that you couldn't turn off if you used `render` instead of component with a route. This was causing us to use `component` in some places where `render` should be used.

The latest version fixes this problem so we change back to `render`
where appropriate.

Also make our `ApmRoute` a `Route` instead of `any`.
2020-09-22 15:41:28 -05:00
Rashmi Kulkarni da1b319419
Accessibility - Dashboard Edit Panel tests (#78181)
* accessibility tests for dashboard panel

* added back the skipped test as it is still required to pass through th ea11ySnapshot

* wip dashboard panel tests

* wip- accessibility

* wip -accessibility

* wip accessibility

* accessibility tests for dashboard edit panel

* accessibility tests

* removed the unused variables

* dashboard_edit_panel tests

* added a comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-22 13:36:52 -07:00
Paul Tavares e8f3529828
[SECURITY_SOLUTION][ENDPOINT] Create Trusted Apps API changes to process user input (#78079)
* Convert new trusted app data to expected format for artifact
* Renamed condition field `process.path` to `process.path.text`
* determine hash type based on length of hash value
* Convert `process.hash.[sha1|md5|sha256]` to `process.hash.*` for return on list api
* Add test for conversion of ExceptionItem to TrustedApp Item
2020-09-22 16:17:35 -04:00
Tim Sullivan a537f9af50
[Reporting] Clean Up TypeScript Definitions (#76566)
* [Reporting] Simplify Export Type Definitions, use defaults for generics, refactor

* ReportApiJSON interface for common

* rename JobSummary to JobStatusBucket for clarity

* revert unneeded create mock changes

* clean up the diff

* revert changes to worker.js

* rewrite comment

* rename type to jobtype in JobStatusBucket

* allow type inference

* JobSummarySet

* remove odd comment

* Reflect that browser timezone may be undefined in the BaseParams

* comment about optional browserTimezone

* revert unecessary es archive change

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-22 12:33:59 -07:00
Constance 42026cbbf5
[Enterprise Search] Move http out of React Context and to Kea Logic; prefer directly mounting (#78167)
* Remove HttpProvider in favor of mounting HttpLogic directly w/ props

- removes need for initializeHttp call
- ensures http value is loaded into HttpLogic as soon as possible / should never load in as null, reducing # of rerenders/checks

see: https://kea.js.org/docs/guide/advanced#mounting-and-unmounting

* Update simplest components using http for sendTelemetry

* Update simplest tests for components using HttpLogic + default Kea mocks

- Kea mock import should now contain mock default values which can be overridden

* Update moderately complex tests using HttpLogic

send_telemetry:
- refactor to use shallow (w/ useEffect mocked) vs mount
- check mockHttpValues directly

engine_table:
- refactor to use mount w/ an I18nProvider rather than mountWithContext helper (which we'll likely need to overhaul in the future)
- assert mockHttpValues directly

* Update EngineOverview to HttpLogic + refactors

EngineOverview:
- Change use of FormattedMessage to i18n.translate (simpler, no provider required)

Tests:
- Create mock values/actions for FlashMessages, since EngineOverview calls it
- Create combined mockAllValues obj for easier overriding
- Create setMockValues helper for easier test overriding (credit to @scottybollinger for the idea!)
- Update engine_overview tests to setMockValues instead of passing context to mountWithAsyncContext
- Fix mountWithAsyncContext to accept an undefined obj

* Remove http from KibanaContext

- it should now only live in HttpLogic 🔥

* Remove FlashMessagesProvider in favor of mounting logic directly w/ props

- send history as prop
- refactor out now-unnecessary listenToHistory (we can just do it directly in afterMount without worrying about duplicate react rerenders)
- add mount helper

Tests:
- refactor history.listen mock to mockHistory (so that set_message_helpers can use it as well)
- use mountFlashMessagesLogic + create an even shorter mount() helper (credit to @JasonStoltz for the idea!)
- refactor out DEFAULT_VALUES since we're not really using it anywhere else in the file, and it's not super applicable to this store
- update history listener tests to account for logic occurring immediately on mount
2020-09-22 12:33:37 -07:00
Quynh Nguyen 426df45c6f
[ML] Edit text for deleting calendars & add functional tests for Calendars and Filter Lists (#77566)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-22 13:43:35 -05:00
Tyler Smalley f412971d5a skip flaky suite (#77969) 2020-09-22 10:50:39 -07:00
Tim Sullivan b7cc6d3f2f
[Reporting/PDF] Switch layout to no border (#78036) 2020-09-22 10:34:25 -07:00
Felix Stürmer e0aeebc149
[Logs UI] Correctly filter for log rate anomaly examples with missing dataset (#76775)
This fixes #76493 by querying for the "unknown" (i.e. empty) dataset using an exists clause. This should be in line with how ML anomaly detection treats missing partition values.
2020-09-22 19:32:50 +02:00
Jonathan Buttner 311805a57d
[Ingest Manager] Adding bulk packages upgrade api (#77827)
* Adding bulk upgrade api

* Addressing comments

* Removing todo

* Changing body field

* Adding helper for getting the bulk install route

* Adding request spec

* Pulling in Johns changes

* Removing test for same package upgraded multiple times

* Pulling in John's error handling changes

* Fixing type error
2020-09-22 12:50:44 -04:00
Luca Belluccini 0238206ace
[DOC] Clarify supported realms when accessing remote monitoring clusters (#77938)
Co-authored-by: lcawl <lcawley@elastic.co>
2020-09-22 09:44:30 -07:00
Joe Portner d666038c8f
Change saved objects client find to allow partial authorization (#77699) 2020-09-22 12:40:38 -04:00
Shahzad 7544a33901
[CSM] Use stacked chart for page views (#78042) 2020-09-22 18:00:19 +02:00
Constance 99f652479a
[Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (#78091)
* Display error connecting prompt on Overview page instead of blank page

* Fix App Search and Workplace Search to not crash during error connecting
- due to obj type errors
2020-09-22 08:33:06 -07:00
Nathan L Smith 037eac5590
Remove service map beta badge (#78039)
Fixes #60529.
2020-09-22 10:14:31 -05:00
Alejandro Fernández Haro a49b990115
[Enterprise Search] Rename "telemetry" to "stats" (#78124) 2020-09-22 15:17:40 +01:00
Patrick Mueller 3f5243eefa
[Alerting] optimize calculation of unmuted alert instances (#78021)
This PR optimizes the calculation of instances which should be executed, by optimizing the way the muted instances are removed from the collection of triggered instances.
2020-09-22 10:15:27 -04:00
Jean-Louis Leysens ef86fbc780
call .destroy on ace when react component unmounts (#78132) 2020-09-22 15:31:07 +02:00
Nicolas Chaulet 6d819b7a1d
[Ingest Manager] Fix agent action acknowledgement (#78089) 2020-09-22 08:46:00 -04:00
Alejandro Fernández Haro d7107e4c67
[Upgrade Assistant] Rename "telemetry" to "stats" (#78127) 2020-09-22 13:41:23 +01:00
Patryk Kopyciński c03c7b3cf4
[Security Solution] Refactor Hosts Kpi to use Search Strategy (#77606) 2020-09-22 12:45:51 +02:00
Søren Louv-Jansen c63ee1b31e
Bump backport to 5.6.0 (#78097) 2020-09-22 12:36:10 +02:00
Gidi Meir Morris 41a7f1a1c2
[Actions] adds a Test Connector tab in the Connectors list (#77365)
Adds a tab in the _Edit Alert_ flyout which allows the user to _test_ their connector by executing it using an example action. The execution relies on the connector being updated, so is only enabled when there are no saved changes in the Connector form itself.
2020-09-22 11:18:33 +01:00
Shahzad d3dd50520b
[Uptime] Improve ping chart axis (#77992) 2020-09-22 11:06:34 +02:00
Diana Derevyankina ed7a630710
[TSVB] Fields dropdowns are not populated if one of the indices is missing (#77363)
* Fields dropdowns are not populated if one of the indices is missing

* Fix tests and accept api changes

* Add indexPatternsService to get default index pattern

* Replace simple error message string with i18n translation

* Remove unnecessary displaying error code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-22 11:13:18 +03:00
Anton Dosov 8cf508fb6b
[UiActions] Remove duplicate apply filter action (#77485)
Removing unused action
2020-09-22 09:40:46 +02:00
Dario Gieselaar 7053ad1a47
[APM] Use transaction metrics for transaction error rate (#78009)
Closes #77716.
2020-09-22 09:16:58 +02:00
Christos Nasikas 13bd34e2da
[ES-ARCHIVER] Fix bug when query flag is empty (#77983) 2020-09-22 10:12:24 +03:00
DeDe Morton 4dc0c128ce
Edit UI text strings in Integrations and Fleet tabs (#75837)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-21 19:31:57 -07:00
Spencer 4d115d5014
[baseline capture] switch to large workers (#78109)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-09-21 19:09:54 -07:00
Kevin Logan b778e9c0a9
[SECURITY_SOLUTION] list UI is backwards compatible (#77956) 2020-09-21 21:26:39 -04:00
Alison Goryachev 05df9efc91
[Mappings editor] Add support for point field type (#77543) 2020-09-21 20:45:30 -04:00
spalger 8d7aae0c21 Revert "Accessibility dashboard edit panel tests (#77829)"
This reverts commit e15b4c43d4.
2020-09-21 16:55:08 -07:00
Constance ea8791b387
[Enterprise Search] Set up Workplace Search header action menu, create reusable renderHeaderActions (#78050)
* Create reusable renderHeaderActions

- I put it in the same file as renderApp, since both functions behave similarly (one renders in the main Kibana app/body, the other renders in Kibana's header)

- slightly opinionated: renamed renderActionMenu to renderHeaderActions from Kibana's examples

* Add example renderHeaderActions usage

* Add example WorkplaceSearchHeaderActions component

- not sure if this should be where it lives or is exported from, feel free to change @scottybollinger

* Update WorkplaceSearchHeaderActions with realistic functionality

- pass required externalUrl helper as arg/prop
- TODO: Consider refactoring KibanaContext to a Kea store so that we can share it across our renderApp and renderHeaderActions

* Fix type errors
2020-09-21 16:44:37 -07:00
Rashmi Kulkarni e15b4c43d4
Accessibility dashboard edit panel tests (#77829)
* accessibility tests for dashboard panel

* added back the skipped test as it is still required to pass through th ea11ySnapshot

* wip dashboard panel tests

* wip- accessibility

* wip -accessibility

* wip accessibility

* accessibility tests for dashboard edit panel

* accessibility tests

* removed the unused variables

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-21 15:45:39 -07:00
spalger 0f6c35c1c3 skip suite blocking es promotion (#72102) 2020-09-21 15:27:10 -07:00
Søren Louv-Jansen a5def2f7b9
[APM] Remove max validation for transaction_max_spans (#77987) 2020-09-22 00:24:51 +02:00
Oliver Gupte f015beae13
[APM] Replace custom map with link to Client Side Monitoring (#77458)
* Closes #48538 by removing the average duration by country custom geo map.

* adds link to client side monitoring below the rum charts

* removes unused translations

* Removes RUM-specific chart for Avg Duration By Browser

* Replace link under charts with CallOut above charts with link to Client Side Monitoring

* removes api integration tests for  avg_duration_by_browser and usused i18n translations

* updates to copy in the CSM callout
2020-09-21 14:57:20 -07:00
spalger c5dbac1d7d skip flaky suite (#77957) 2020-09-21 13:50:13 -07:00
Oliver Gupte fa3ee11dac
[APM] Fix service maps ML link zoom value (#77841)
* Closes #76372 by removing the `zoom` query param from the ml time series explorer link

* updated test snapshot for updated ML link href

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-21 13:49:54 -07:00
John Schulz 06d14363ee
[Ingest Manager] Ensure at least default Error handling on all routes (#77975)
* res.customError -> defaultIngestErrorHandler

* Missed a variable rename in prior commit

* copying an invalid policy will 404; not 500

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-21 16:42:05 -04:00