Commit graph

18813 commits

Author SHA1 Message Date
Brandon Kobel
f3e0f74283
Upgrading grunt-contrib-watch (#22818) (#25435) 2018-11-08 17:04:16 -08:00
Joe Fleming
177dde9108 fix: get correct plugins path (#25448)
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
2018-11-08 17:38:25 -07:00
liza-mae
dca4772e84
Update clickOptionalAddNewButton method used in createIndexPattern (#25414) (#25427) 2018-11-08 16:51:37 -07:00
Søren Louv-Jansen
57f5c673e4
[APM] Fix gap in timeline and fallback when traceroot is missing (#25346) (#25422)
* Fix gap in timeline

* Show fallback when traceroot is unavailable

* Fix test

* Fix rendering issues with styled-components

* Remove `parentTransactionSkew `

* Minor test fixes
2018-11-09 00:22:58 +01:00
gchaps
c997e7888e [DOCS] Updates information regarding usage of sample data indices (#25424) 2018-11-08 14:54:11 -08:00
Matthew Kime
747344ae3f
EAH - add typescript to a couple of ui/public/utils files (#23946) (#25409)
* typescriptin a few ui/public

* remove mistaken commits

* typescript numeric

* ts migrateLegacyQuery

* object or string type

* no need for file extension on import statement

* revert mistaken commit

* type fix - only object

* snake case!
2018-11-08 16:52:26 -06:00
Lisa Cawley
c029885f5f
[DOCS] Clarify security requirements for monitoring (#24881) (#25419) 2018-11-08 14:17:35 -08:00
gchaps
a40ff5207e [DOCS] Adds early draft of Canvas docs (#25395)
* [DOCS] Adds early draft of Canvas docs

* [DOCS] Added images and beta label to Canvas docs
2018-11-08 13:42:42 -08:00
liza-mae
8ed79eb660
[6.x] Wait for global loading indicator when creating index pattern (#25329) (#25348)
* Wait for global loading indicator when creating index pattern (#25329)

* revert and test again

* add back - test again
2018-11-08 14:26:32 -07:00
Søren Louv-Jansen
16f05143ef
[APM] Fix missing transaction message (#25353) (#25411) 2018-11-08 22:13:30 +01:00
nicknak
29e37f01fd
Auto open browser on server startup (#24843) (#25390)
* Adds dev dependency on opn for opening browsers and other things.

* Adds a --open option to cli to open browser window.

* Removes unused variable in index.

* Adds opn types to dev dependencies from definitely typed.

* Adds open to the cliArgs type to allow for consistency.

* Updates snapshots that require valid cliArgs types.

* Moves opn to direct dependency since its used in cli.

* [cli] move --open handling to cluster manager

* Adds support for running --open with --no-base-path
2018-11-08 16:00:02 -05:00
Chandler Prall
0f56480e11
Update EUI to v5.0.0 (#25316) (#25408)
* update EUI to v5.0.0

* update snapshots

* revert snapshot change

* revert snapshot change (2)
2018-11-08 12:54:52 -07:00
Lee Drengenberg
d012b6a015
Fix context test timing (#24949) (#25289)
* Add sleeps so tests will pass

* removed a space in a comment

* replaced some sleeps with waiting for loading indicator

* Removed context page object calls from filter_bar and doc_table services
2018-11-08 13:06:52 -06:00
Lisa Cawley
772cec876a [DOCS] Adds data visualizer restriction (#25399) 2018-11-08 09:33:00 -08:00
Lisa Cawley
970307c89c
[6.x] [DOCS] Fixes typo in create role API (#25314) (#25336) 2018-11-08 09:14:13 -08:00
Spencer
8d139d508e
Fix File Upload fatal (#25361) (#25393)
## Summary (fixes #25342)

There is a fatal when using the File Upload control in the image upload control.  While the fatal appears to originate within the File Upload control, it is actually [coming from](https://github.com/clintandrewhall/kibana/blob/file-upload/x-pack/plugins/canvas/public/components/loading/index.js#L15) `Loading`, which attempts to use `react-redux` to change the `backgroundColor` of the loading indicator based on the page.

I couldn't find an instance where we use this Loading indicator outside of a redux context, so I've opted to simply use the control directly.  @rashidkpc agreed this would be a good fix for the moment.

In addition, I fixed a props error coming from the data-url field that made it read-only, so I fixed that, too, as well as a formatting issue with the Set button.

## Test Plan

Added a `setTimeout` call to simulate load.  Toggled between data url and literal URL.

![screen shot 2018-11-07 at 6 47 32 pm](https://user-images.githubusercontent.com/297604/48171133-20ff4a80-e2c0-11e8-9b9f-71818801744a.png)

- Before
![screen shot 2018-11-07 at 7 11 48 pm](https://user-images.githubusercontent.com/297604/48171320-09749180-e2c1-11e8-8a2a-f87d564944c1.png)
- After
![screen shot 2018-11-07 at 6 57 17 pm](https://user-images.githubusercontent.com/297604/48171134-20ff4a80-e2c0-11e8-9bec-f129cfbfaa18.png)
- Fixed Warning
![screen shot 2018-11-07 at 7 11 57 pm](https://user-images.githubusercontent.com/297604/48171334-142f2680-e2c1-11e8-8ab6-ee06e6231e6b.png)

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2018-11-08 08:30:19 -08:00
Joe Fleming
57cffd692e Fix: Asset preservation (#25359)
* fix: proptype error

* fix: correct proptype checking

* fix: add assets placeholder to initial state

* chore: add history formatting function

* fix: load workpad assets when ids change

this causes the correct assets to be used
2018-11-08 09:21:10 -07:00
Brandon Kobel
84e1ba3943
Only loading the default index pattern when it's required (#25175) (#25324) 2018-11-08 06:46:17 -08:00
Carlos Pérez-Aradros Herce
28ef6ae534 Relax hosts validation in Beats central management (#25376)
Current regexp was disallowing schema part of the URL (https://), so
https hosts couldn't be configured.

I opted for fully relaxing the reg exp here, as Beat will check it
anyway, and report errors in case it's wrong.
2018-11-08 07:47:56 -05:00
Matt Apperson
01d3fd648d [BeatsCM] Allow for config based override of default user role (#25364)
* Allow for config based override of default user role

* [beats-cm] convert xpack.beats.defaultUserRole to array of roles

* [beats-cm] keep this context in #checkLicense
2018-11-08 07:22:35 -05:00
Matt Apperson
c49c8aa07c [BeatsCM] text update (#25297)
* progress

* add missing text changes

* text tweak

* Update x-pack/plugins/beats_management/public/components/table/assignment_schema.ts
2018-11-08 07:22:08 -05:00
Tyler Smalley
f8587ee209
[migrations] Disable replicas (#25274) (#25357)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-11-07 19:40:27 -08:00
Tyler Smalley
5691b6952e
[build] Uses node-archive to zip/tar packages (#25335) (#25356)
Started digging into an issue where compressing library didn't include empty
directories, which tar/zip should. After investigating the issue I feel it's
best to use a more established project.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-11-07 18:26:26 -08:00
Lukas Olson
88daed8c81 Fix Canvas autocomplete to suggest all functions (#25351)
* fix: getFunctionDefinitions to load after the registry has been populated

* fix: use getBrowserRegistries instead of registry itself
2018-11-07 19:03:11 -07:00
Spencer
f754cf8019
[6.x] [canvas/gulp-scripts] replace script path in argv with gulp path (#25352) (#25354)
Backports the following commits to 6.x:
 - [canvas/gulp-scripts] replace script path in argv with gulp path  (#25352)
2018-11-07 16:40:29 -08:00
Jen Huang
0b449f34d8
[Rollups] Fix day of month only showing ordinals (#25322) (#25343)
* Fix day of month only showing ordinals
2018-11-07 16:17:05 -08:00
Tyler Smalley
3e74a2c80b
[migration] Retry attempts for ES service unavailable (#25255) (#25338)
Resolves a race condition where ES is technically up, but the Kibana
index is not.

Closes #25027

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-11-07 16:15:06 -08:00
Lisa Cawley
a988f198ae
[DOCS] Adds screenshot for Data Visualizer (#25182) (#25305) 2018-11-07 14:01:56 -08:00
joe fleming
9b10b04cb6 fix: restore canvas error dialog 2018-11-07 14:39:12 -07:00
Andrew Cholakian
8b43fae3d1
Remove extra period for heartbeat add data (#25221) (#25299) 2018-11-07 15:14:42 -06:00
Pete Harverson
785477219a
[ML] Fixes file data viz file size check and format as bytes (#25295) (#25311)
* [ML] Fixes file data viz file size check and format as bytes

* [ML] Fix typo in file size error callout
2018-11-07 20:24:02 +00:00
Walter Rafelsberger
d42fb3cacf
[ML] Restore missing job timepicker modal. (#25288) (#25302)
* [ML] Restore missing job timepicker modal.
* [ML] Added a karma/mocha test to verify dependencies are loaded correctly for new_job_controller.
* [ML] Use consistent import style.
2018-11-07 21:21:30 +01:00
Spencer
90588acbae [canvas] move yarn scripts to node scripts (#25258)
* [canvas] move yarn scripts to node scripts

* [canvas/eslint] allow scripts to access devDeps

* [canvas/eslint] remove packageDir override

* [x-pack] move babel-register to deps for canvas

* [canvas] rename scripts from : to _

* [canvas] update readme with correct script paths

* [canvas] remove yarn.lock file

* Remove redundant require

(cherry picked from commit cfaa1783c3)
2018-11-07 10:55:09 -08:00
Jen Huang
e161dc724b
Move call to standard index pattern fields for wildcard from client to server (#25270) (#25308) 2018-11-07 10:44:13 -08:00
Brandon Kobel
6ef31d3531
Updating request to ^2.88 (#25236) (#25304) 2018-11-07 10:25:34 -08:00
Felix Stürmer
ca57dcf2b7
[Infra UI] Remove duplicate "Overview" in detail page title (#25283) (#25292)
This removes the duplicate word "Overview" from the title of the container details page.
2018-11-07 18:18:51 +01:00
Peter Pisljar
bfd422294e
remove vis dependency from request handlers (#24119) (#25287) 2018-11-07 18:09:04 +01:00
Joe Fleming
113891cca1 Fix: Canvas babel build (#25184)
Closes https://github.com/elastic/kibana/issues/25154

Canvas' threading code uses babel-register for the runtime, much like Kibana does, so we can execute code that uses newer syntax (mostly es modules at this point...). The default configuration of babel-register ignores `node_modules`, and since x-pack is built into `node_modules`, this worked fine in dev mode and not at all in the build.

There was also an issue where Kibana's build step removes all bablerc files, which meant Canvas' threaded runtime also wasn't getting any of the settings.

This PR pulls in the configuration from Kibana, which has an exception for transpiling x-pack code, and allows the runtime to operate correctly in the build.

Huge thanks to @jbudz for helping me sort out the issue!

@spalger ~~know more about babel than I do, if we can just use `@kbn/babel-preset/node_preset` directly instead, that seems less likely to break going forward. I meant to try it but ran out of time yesterday to make another build.~~ Works! PR updated.
2018-11-07 10:00:25 -07:00
Spencer
313b908944 [canvas] unify eslint config in .eslintrc.js (#25260)
Simply remove the remaining eslint config files from canvas and merge with other canvas related overrides in `.eslintrc.js`
2018-11-07 09:34:09 -07:00
Matt Bargar
759a2b64f3
Add hacky workaround for getDerivedStateFromProps change in react 16.4 (#25142) (#25245) 2018-11-07 11:18:43 -05:00
Chris Roberson
7d511a7cea
Use the newly added remote_cluster field for ccr (#25248) (#25293) 2018-11-07 11:15:55 -05:00
Jason Rhodes
51b1f4febf
Fixes bug with rison decode on Kibana links (#25214) (#25284)
* Fixes bug with rison decode vs encode

* Adds and updates tests for kibana link component
2018-11-07 11:01:28 -05:00
Felix Stürmer
f55b39d195
[6.x] [Infra UI] Work around IE11 flexbox alignment problems (#25224) (#25281)
Backports the following commits to 6.x:
 - [Infra UI] Work around IE11 flexbox alignment problems  (#25224)
2018-11-07 14:51:16 +01:00
Søren Louv-Jansen
9b04e556be
[APM] Additional clock skew fixes (#25097) (#25277)
* Refactor service colors

* Calculate duration from full waterfall

* Ensure timeline label is not truncated

* Adjust child if it starts after parent has ended

* Add mark for traceRootDuration instead of xMax

* Fix tests
2018-11-07 13:32:34 +01:00
Aleh Zasypkin
9dbc08b32f
[6.x] Implement new platform plugin discovery. (#25275) 2018-11-07 12:44:15 +01:00
Pete Harverson
0863fb3bdf
[ML] Add user privilege check to Jobs List group selector control (#25225) (#25276) 2018-11-07 11:38:48 +00:00
Melissa Alvarez
d68e9a7b8e
[ML] JobList search bar: Show useful error on invalid query (#25153) (#25227)
* Show error on invalid query

* Additional undefined check for query

* Cleanup undefined check
2018-11-07 10:00:17 +00:00
Marco Vettorello
35e61520e0
Fix missing TSVB markdown variables (#25132) (#25231)
* Move fieldsFetch logic into the vis editor

* Add annotations index pattern change detection

* Fix async update of state. Add functional test

* Add missing data archive

* Force fetch when component mount the first time

* Fix parameters naming

* Refactoring indexPatterns to fetch

* Add observables and pipe data updates to markdown panel config

* Fix jest test
2018-11-07 10:48:33 +01:00
Søren Louv-Jansen
b2e62cd9a4
[APM] Show message for missing transaction sample (#25141) (#25261) 2018-11-07 10:27:51 +01:00
Tiago Costa
86dd567e60
Make canvas common lib ready for dependencies static analysis (#24756) (#25273)
* refact(NA): make canvas common lib ready for static analysis.

* refact(NA): change export named to export all on canvas commmon lib datatable.

* tes(NA): fix isValid http url function name.

* refact(NA): rename parse to parseDataUrl
2018-11-07 05:24:52 +00:00