Commit graph

40106 commits

Author SHA1 Message Date
Dario Gieselaar f9de593a6d
decorate_snapshot_ui: make sure snapshots are saved (#89694) 2021-02-03 12:19:07 +01:00
Jean-Louis Leysens 6dd6c99818
[ILM] Surfacing policy error state (#89701)
* added policy top-level callout for error state

* added form errors context. errors are sorted by their field path into phases

* added data test subject attributes and prevent setErrors from getting called if component is not mounted

* update copy

* refactored errors context and optimised setting of context value. Also added test for various form error notifications across the collapsed phases

* add test for non-phase specific policy validation error

* Remove unused import

* refactor how errors are listened to, use the new "onError" callback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-03 12:14:00 +01:00
Joe Reuter f4ebdf3a79
[Lens] Export nested types (#89868) 2021-02-03 12:03:55 +01:00
Peter Pisljar 8f70c52180
cleaning up tabify to return Datatable (#89857) 2021-02-03 11:47:24 +01:00
Angela Chuang 22a903a9e3
[Security Solution] Saving is not working if hitting "favorites button" beforehand (#88642)
* fix favorites for templates

* fix integration test

* fix integration test

* fix event details request

* handle data when searchstrategy is still running

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-03 08:47:11 +00:00
Stratoula Kalafateli d8f7997c83
Remove navigation from Discover to Visualize (#89132)
* Remove navigation from Discover to Visualize

* Remove unused translation

* Remove oss check from functional test

* Fix functional test

* Skip test for OSS

* Fix

* Should not remove the uiSettings getter and setter

* Move the isOss flag inside the test

* Cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-03 10:15:53 +02:00
István Zoltán Szabó d560b1ccc8
[DOCS] Uses doc link service in discover (#88835)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: lcawl <lcawley@elastic.co>
2021-02-03 08:53:57 +01:00
Matthias Wilhelm ebf93e2027
[Discover] Unskip brushing histogram functional test (#89400) 2021-02-03 08:42:41 +01:00
Alexey Antonov af454d61bf
Timelion reads raw field list from saved object, should grab from index pattern api (#89988)
* Timelion reads raw field list from saved object, should grab from index pattern api

Closes: #84387

* fix PR comment
2021-02-03 10:29:50 +03:00
John Dorlus 14cf1875b5
[Upgrade Assistant] Fixes to Upgrade Assistant Tests and Page Objects To Stop CI Failures (#89942)
* Updated test to use no hard coded waits which could be contributing to CI failures. Expect functions should be in the test file itself so I changed the page objects for page actions and extracted out the expect calls to the test files.

* Added retry within the test file to retry the assertion if it doesn't pass on the first attempt. Simplified the toggle function to just click the toggle.

* Fixed type check issue.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-03 02:26:30 -05:00
Matthias Wilhelm 06bc99d825
[Discover] Fix 'auto' collapsing of documents (#89712) 2021-02-03 06:56:09 +01:00
Nicolas Chaulet 20654388a4
[Fleet] Fix performance issue in agent status endpoint (#90066)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 20:23:56 -05:00
Tyler Smalley 75d9e0a071 skip flaky suite (#89073) 2021-02-02 15:57:56 -08:00
Chris Cowan cf846bdddf
[Metrics UI][Logs UI] Completely remove GraphQL and Apollo (#89036) 2021-02-02 16:56:40 -07:00
Spencer 9246f398ea
[esArchiver] upgrade to new ES client (#89874)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 16:55:41 -07:00
Kevin Qualters 3da4c6bb2c
[Secutiy Solution] Timeline kpis (#89210)
* Stub kpi component

* search strategy scheleton timeline KPI

* search strategy scheleton timeline KPI

* Add timeline kpis component and search strategy container

* Use getEmptyValue in timeline kpis

* Prevent request from being made for blank timeline properly

* Add kpi search strategy api integration test

* Add jest tests for timeline kpis

* Clear mocks in afterAll

* Decouple some tests from EUI structure

* Combine some selector calls, change types to be more appropriate

* Simplify hook logic

* Set loading and response on blank timeline

* Only render kpi component when query is active tab

* Use TimelineTabs enum for query tab string

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 18:30:45 -05:00
Nathan Reese 980112de1e
[Maps] migrate mvt routes to use data.search service instead of directly calling elasticsearch (#89904)
* [Maps] migrate mvt routes to use data.search service instead of directly calling elasticsearch

* pass search session id to mvt requests

* move grid tile tests to integration tests

* replace getTile unit test with integration test

* add comment about request param

* revert total meta change

* tslint fixes

* update jest tests
2021-02-02 15:51:00 -07:00
Spencer 531194baba
[ci/docsLink] hide link when 200 says "There aren't any differences!" (#90079)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-02-02 15:21:19 -07:00
Sandra Gonzales 240a7c3f02
make history drawer positioned absolute (#89630)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 16:55:23 -05:00
Brian Seeders 2f05b513e7
[CI] Remove TeamCity code (#90041) 2021-02-02 16:31:48 -05:00
Brian Seeders 0cc57d085a
[CI] Only delay ciGroup processes when using tasks (#90038) 2021-02-02 16:27:43 -05:00
Frank Hassanabad de216e652c
[Security Solutions][Detection Engine] Adds e2e and unit tests for PR #89947 (#89973)
## Summary

Adds e2e and unit tests for PR:
https://github.com/elastic/kibana/pull/89947

* Adds e2e tests for create_index
* Adds e2e tests for get_privileges
* Adds unit test for use_privilege_user
* Adds exhaustive switch for the roles in the e2e tests
* Adds some typescript barrel rolls for the .json scripts to make TypeScript a bit more readable when doing imports 
* Fixes some of the types that were not matched up with the recent privilege endpoint

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-02-02 14:26:13 -07:00
Jonathan Budzenski 76d6606a21
[build] Build docker contexts by default (#89934)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 15:02:13 -06:00
Alejandro Fernández Haro 43faa76f67
[APM] transactions.kubernetes.pod can be undefined (#90044) 2021-02-02 20:43:20 +00:00
Tim Sullivan 10e1f1cb79
Search Sessions: Improve Flaky Functional Test (#89370)
* Search Sessions: Unskip Flaky Functional Test

* typo

* keep skip for now

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 13:33:47 -07:00
Chris Roberson 5f64e672c8
[Monitoring] Avoid spamming toast messages (#89930)
* Toast should only show once

* Handle any errors here gracefully

* Set this early to avoid failing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 15:33:25 -05:00
Tim Sullivan 0370f6b5d4
[SearchSource] Deserialize query string options for serverside ES Query (#90050)
* [SearchSource] Deserialize query string options for serverside ES Query

* fix test
2021-02-02 13:32:37 -07:00
Devin W. Hurley 198c6fb664
[Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities (#89927)
* remove allow_no_indices param, adds a check if response has empty indices property then write error status with index patterns provided to rule

* fix tests

* fix tests and update with comments

* update integration tests

* adds integration test for when an index pattern doesn't exist the rule should fail and when one index pattern does exist but another does not, the rule should succeed
2021-02-02 14:07:22 -05:00
Chris Roberson be41a9f706
Skip test for cloud (#89450)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 13:12:04 -05:00
Jen Huang 19effe2157
[Fleet] Fix duplicate data streams being shown in UI (#89812)
* Add API integration tests for data streams list, including one that is expected to fail due to reliance on number of backing indices

* Use ES data streams API as source of truth for list of data streams, and only query against backing indices afterwards

* Get package name from data stream meta info

* Increate retry timeout

* Move initial info requests inside Promise.all

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 10:11:15 -08:00
Joe Portner 7191c4d2b8
Bump package dependencies (#90034) 2021-02-02 13:05:26 -05:00
Constance 977fc6c464
[App Search] DRY helper for encoding/decoding routes that can have special characters in params (#89811)
* Add encodePathParam helper + update components that need it

- Primarily document URLs & analytics queries (which uses generateEnginePath)

* Add useDecodedParams helper + update components that need it

- Documents titles & Analytics queries

* [Misc] Change popout icon to eye

- Feedback from Davey - the pages don't open in a new window, so shouldn't use the popout icon
- Not strictly related but since we're touching these links anyway, I'm shoving it in (sorry)

* Remove document detail decode test

- now handled/tested by useDecodedParams helper

* Add new generateEncodedPath helper

- Should be used in place of generatePath

* Update all instances of generatePath to generateEncodedPath

for consistency across the App Search codebase

* Fix failing tests due to extra encodeURI() done by generatePath

* Add missing branch test for analytics query titles

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 09:41:02 -08:00
Nathan L Smith 4940a1cbd9
TypeScript project references for Observability plugin (#89320)
References #80508. References #81003.
2021-02-02 11:38:20 -06:00
Tim Sullivan ad67ee551e
[SearchSource] Combine sort and parent fields when serializing (#89808)
* [SearchSource] Combine sort and parent fields when serializing

* fix docs

* add link to issue
;

* fix destructive recursion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 10:15:13 -07:00
igoristic 802ac60fee
Made imports static (#89935) 2021-02-02 12:04:53 -05:00
Nathan Reese d601090ec8
[ml] migrate file_data_visualizer/import route to file_upload plugin (#89640)
* migrate file_upload plugin to maps_file_upload

* update plugins list

* migrate ml import endpoint

* migrate ml telemetry to file_upload plugin

* add fileUpload plugin to ml

* add TS project

* update ML to use file_upload endpoint

* move types to file_upload plugin

* ignore error

* clean up

* i18n clean-up

* remove schemas from ml

* remove usageCollection from ml

* node scripts/build_plugin_list_docs

* update telemety collector

* revert changes to ingestPipeline schema

* change name of TELEMETRY_DOC_ID to unique value

* remove ImportFile from ml/server/routes/apidoc.json

* fix typo in x=pack/tsconfig.json

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 09:55:09 -07:00
Matthias Wilhelm 047dd29747
[Discover] Adapt default column behavior (#89826) 2021-02-02 17:32:37 +01:00
Nathan L Smith f317316fd4
Round start and end values (#89030)
When getting the start and end times, use the d3 time scale `ticks` function to round the start and end times.

Example from a query:

Before:

```json
{
          "range": {
            "@timestamp": {
              "gte": 1611262874814,
              "lte": 1611263774814,
              "format": "epoch_millis"
            }
          }
        },
```

After:

```json
{
          "range": {
            "@timestamp": {
              "gte": 1611263040000,
              "lte": 1611263880000,
              "format": "epoch_millis"
            }
          }
        },
```

The `ticks` function makes it so the amount of rounding is proportional to the size of the time range, so shorter time ranges will be rounded less.

Also fix a bug where invalid ranges in the query string were not handled correctly.

Fixes #84530.
2021-02-02 10:17:48 -06:00
Mike Côté 33bf590386
Rename getProxyAgents to getCustomAgents (#89813)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 11:13:55 -05:00
Jean-Louis Leysens 3f97a04c63
[Form lib] UseField onError listener (#89895)
* added callback for listening to field onerror events

* added onError component integration test

* address tslint issues

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 16:47:13 +01:00
Dario Gieselaar 8ef8f3b490
[APM] use latency sum instead of avg for impact (#89990)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 16:18:55 +01:00
Pierre Gayvallet 762abea14e
migrate more core-owned plugins to tsproject ref (#89975)
* migrate more plugins to tsproject ref

* revert changes for xpack_legacy

* fix IT
2021-02-02 16:16:25 +01:00
Felix Stürmer 7fa30ba33e
[Logs UI] Load <LogStream> entries via async searches (#86899)
This PR replaces the usage of plain HTTP routes to load the log stream entries with async search strategy calls.
2021-02-02 15:42:27 +01:00
Dario Gieselaar 2a4d39aae4
[APM] Abort browser requests when appropriate (#89557)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 14:44:43 +01:00
ymao1 f3d7d37294
[Alerting] Allow user to select existing connector of same type when fixing broken connector (#89062)
* Adding dropdown for selecting different connector of same type

* Updating design

* Cleanup and i18n

* Adding functiional test

* Fixing unit test

* Fixing functional test

* Updating design

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 07:58:02 -05:00
Daniil e73b3778ed
[Data Table] Use shared CSV export mechanism (#89702)
* Move formatting columns into response handler

* Use shared csv export

* Cleanup files

* Fix type

* Fix translation

* Filter out non-dimension values
2021-02-02 11:55:26 +02:00
Tiago Costa b24f06cff2
chore(NA): improve logic check when installing Bazel tools (#89634)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 09:51:55 +00:00
Tiago Costa a9e6c39d7f
chore(NA): support yarn install using bazel managed directories for dependencies (#89883)
* chore(NA): allow yarn dependencies to be installed when using bazel to manage yarn deps

* chore(NA): remove unused flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 09:49:50 +00:00
Rudolf Meijering 7fbec26594
Debug log the latest saved object migrations per type (#89722)
* Debug log the latest saved object migrations per type

* Fix broken test
2021-02-02 10:42:38 +01:00
Rudolf Meijering 69f4c9d541
Fix documentMigrator for snapshot releases (#89936) 2021-02-02 10:40:17 +01:00