Commit graph

17078 commits

Author SHA1 Message Date
Davis Plumlee
fcd515f942
[Security Solution][Exceptions] Adds error catch to Exceptions toString method (#105928) 2021-07-16 16:51:46 -04:00
Devin W. Hurley
dadeb78b44
[RAC] [RBAC] add space ids array to each alert document (#105173)
* kind of working solution... need to fix types.. would be great if all of this could go in the authorization class but I don't think we have access to the spaceids when we generate the kibana security action strings?

* update mapping type as array:true for space_ids field, fixes types, updates jest tests, adds integration tests

* undo changes in alerting authz class

* update snapshot for apm api integration test for rules writing alerts

* fix apm integration tests

* omit version and sequence from expected outcome

* re-add space id after this code was moved in master

* add another default space id to test

* fixes bug to remove duplicate spaceids

* add space ids filter to elasticsearch query, updates detection role

* update snapshot

* update type docs for alerts client

* remove dead code

* fix type error

* renames space ids field on alert documents from kibana.rac.alert.space_ids to kibana.space_ids

* fixes kb-rule-data-utils package

* update snapshots

* remove references to kibana.rac.alert.space_ids and replace with kibana.space_ids in rule registry integration tests and apm integration tests

* fix apm functional test snapshots

* undo index name changes I made in apm integration test configs

* update typedocs references to upstream, not local repo
2021-07-16 16:05:46 -04:00
Michael Olorunnisola
9c5d5c1137
[Security Solution][RAC] Implement hover actions (#105500) 2021-07-16 12:53:41 -07:00
Dominique Clarke
743c8c2a14
[Uptime] migrate to observability rules registry (#100699)
* uptime - migrate to observability rules registry

* Modify Uptime alert types to work with server rule registry.

* Export `RuleType` type for consumption by client plugins.

* Add platinum as an option for `minimumLicenseRequired` field of `RuleTypeBase`.

* Simplify alert bootstrapping, inherit `RuleType` for alert factories.

* update rule field map

* adjust rule registery to be created within setup instead of mount

* adjust plugin setup to account for rule registry changes

* export types from rule registry

* move alert action message translations to common

* update rule field map

* update monitor status public alert model

* update tls public alert model

* update monitor status alert server model

* update tls alert sever model

* update server plugin file to scope alerts indices to synthetics

* add initContext to server Plugin class

* adjust public plugin to register alerts when core start is availabile

* update mappings

* update asset names

* adjust dependencies for alert initialization

* adjust duration anomaly server alert model

* adjust duration anomaly and monitor status public alert model to account for undefined types

* add duration_anomaly tests

* add anomaly severity

* adjust types

* update uptime server plugin

* remove test_helpers

* add getMonitorRouteFromMonitorId helper

* export AlertTypeWithExecutor from rule_registry

* adjust types

* mock time zone

* update types

* update types for legacy tls alert

* update mappings

* update monitor status check tls types

* update tls types and indexed fields

* update duration anomaly types and indexed fields

* update mappings

* delete unnecessary file

* adjust types

* adjust ruleDataClient initialization

* index anomaly bucket span

* update types

* adjust registration of legacy tls alert type

* adjust types

* update index alias name

* update anomaly detection rule mappings

* adjust import for certificate alert

* adjust rbac settings

* adjust content

* adjust uptime server plugin

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 15:34:15 -04:00
Nathan L Smith
ce5a798fdd
Fix ENVIRONMENT_ALL links to exploratory view (#105704)
Leave the environment out of the URL for the exploratory view when "All" is selected in the environment dropdown.

Move the analyze data button to its own component.

Add tests and stories for the the APM service template and analyze data button.

Fixes #105467.
2021-07-16 14:26:33 -05:00
Cauê Marcondes
219e1e5ab2
[APM][Fleet-Migration] API error when opening settings Schema tab with apm_read_user (#105990) 2021-07-16 15:03:01 -04:00
Shahzad
966f81e4ea
[User Experience App] Fix ux app env filter (#105918) 2021-07-16 19:28:37 +02:00
Pete Hampton
ca0b362754
Revert "Remove security example from telemetry management panel. (#105722)" (#105974)
This reverts commit 6ae078f3c6.
2021-07-16 13:23:25 -04:00
James Gowdy
8f4111e204
[ML] Fixing rare wizard detector state (#105966) 2021-07-16 17:50:54 +01:00
Corey Robertson
076634cca1
[Canvas] Fixes messed up form layout on custom interval form (#101967)
* Fixes messed up form layout on custom interval form

* update storyshots

* Fix snapshot

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 12:38:50 -04:00
Mark Hopkin
3aa8e9759f
fix: add missing aria labels to agent details page (#105962) 2021-07-16 12:36:37 -04:00
Wylie Conlon
8ad443aa6c
[Sample data] Use Lens in flights dashboard (#104780)
* [Sample data] Use Lens in flights sample data

* Fix test issues

* Fix functional tests

* Fix a11y test names

* Fix tests again

* Fix test

* Update from comments

* Fix sizing from feedback

* Fix typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 12:01:05 -04:00
Cauê Marcondes
26c3362892
[APM] Add support to upload source map as string or file (#105443)
* adding support to upload a sourcemap

* addressing PR comments

* addressing PR comments
2021-07-16 11:54:05 -04:00
Domenico Andreoli
4630965882
Explain that integration-test also runs tests (#105933)
Document integration-test wrt. CCS Cypress tests
2021-07-16 17:26:44 +02:00
Dario Gieselaar
9fcfeba464
[UX] make route match optional in EnvironmentFilter (#105780)
Closes #105757.
2021-07-16 10:52:40 -04:00
Christiane (Tina) Heiligers
59846c3e8e
Adds FS integration tests to CI (#105794)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 07:43:03 -07:00
Peter Pisljar
4ce446766d
filterManager PersistableStateService implementation (#104897) 2021-07-16 16:20:51 +02:00
Gloria Hornero
9f2d9d4d54
Fixes "servers.elasticsearch.auth" must be a string error (#105095)
* fixes integration with stack testing upgrade framework

* fixes the provider name flexibility

* fixes type check error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 16:19:30 +02:00
Matthew Kime
2dd3693dbe
[rollup index patterns] don't show fields not present in field caps response (#105533)
* remove fields not present in field caps response
2021-07-16 09:07:31 -05:00
Ashokaditya
21d447d707
[Security Solution][Endpoint] Fix unhandled promise rejections in endpoint host middleware (#105593)
* handle promise rejections

fixes elastic/security-team/issues/1407

* traverse array only once

* unskip test

* correctly mock activity log loading test

* review changes

:)

* unique ids only

* add comment to ignored line

review changes

* undo

* mock action_log api

* use mocked api

* mock endpoint meta data for tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 15:59:34 +02:00
Pete Hampton
6ae078f3c6
Remove security example from telemetry management panel. (#105722)
* Remove security example from telemetry management panel.

* Fix types.

* Update component snapshot.

* Fix translations.

* Remove code to test for sec solution enabled.

* Fix type.

* Remove management section setting from security solution.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 14:56:06 +01:00
Liza Katz
71385b6944
[Search Sessions] Hide search sessions menu after interaction (#105610)
* Hide search sessions menu after interaction

* simpler code using cores openModal

* fix ts and closing delete dialog

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 14:12:06 +02:00
Marco Liberati
2e5e4ca57f
[Lens][Visualize][Inspector][Reporting] Unified check for CSV cells for known formula characters (and value escaping more in general) (#105221)
*  Unify escaping logic for csv export

* 📝 Update api doc

*  Fix test with new escape logic

* 👌 First batch of feedback

* 💬 Fix typo

* 👌 Memoize function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-16 10:55:49 +02:00
Søren Louv-Jansen
2cf1bd540c
[APM] Enable metric-powered ui (#104929)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
2021-07-16 04:30:11 -04:00
John Schulz
f220ee63af
[Fleet] Reordered & more consistent summaries in API docs (#105824)
## Summary

Some changes to the order & summaries in the OpenAPI docs.

 * Removed `Fleet - ` and `EPM - ` text from the summaries. It saves space and I don't think the extra text helped the user
 * Replaced `Enrollment` prefix with `Enrollment API Key`
 * Used plural (`policies`, `agents`) for operations that return a list
 * Rearranged the order of the routes to group the routes vs using an alphabetic sort. 
   * Not sure if it's priority/domain but it feels better to me
   * `/setup` is the first route; not last.  
   * installing integrations and adding agents are "above the fold"

<details><summary>screenshots from one viewer - before (left) vs PR (right)</summary>
<img align="top" width="40%" alt="Screen Shot 2021-07-15 at 1 53 48 PM" src="https://user-images.githubusercontent.com/57655/125836353-1b3c10e2-6c1d-4a7a-99c7-04d49a37cbac.png"><img align="top" width="40%" alt="Screen Shot 2021-07-15 at 1 53 57 PM" src="https://user-images.githubusercontent.com/57655/125836358-6f0647c3-4209-43a3-8fc7-7b33ad97d543.png">
</details>
2021-07-15 20:23:14 -04:00
Quynh Nguyen
dced8bb1aa
[ML] Add functional tests for Anomaly Detection annotations (#105527)
* [ML] Add functional tests for annotations

* [ML] Update jest tests

* [ML] Fix regression caused by #104994

* [ML] Rename for clarity, clean up

* [ML] Fix rename typo, adds more log steps

* [ML] Update getVisibleText

* [ML] Move job & datafeed config to before
2021-07-15 19:33:21 -04:00
Justin Kambic
7c09bb5c5f
Fix broken doc links in Uptime app. (#105482)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 18:28:18 -04:00
John Schulz
c9e11e0fb2
/agents returns Agent[] not AgentPolicy[] (#105814)
Fix the typo in https://github.com/elastic/kibana/pull/105679 which indicates `/agents` returns a list of agent policy objects instead of the correct list of agents.

diff from `/paths/agents.yaml`
```diff
-                  $ref: ../components/schemas/agent_policy.yaml
+                  $ref: ../components/schemas/agent.yaml
```

<details><summary>screenshot - before</summary>
<img width="1293" alt="Screen Shot 2021-07-15 at 12 39 14 PM" src="https://user-images.githubusercontent.com/57655/125829619-ddbd74f4-8806-45c4-af94-4b7645e2dc9b.png">
</details>

<details><summary>screenshot - after</summary>
<img width="1302" alt="Screen Shot 2021-07-15 at 12 39 33 PM" src="https://user-images.githubusercontent.com/57655/125829622-2715d071-14ee-4a2d-9ff5-96ece4eea682.png">
</details>
2021-07-15 16:54:44 -04:00
Justin Kambic
cba23c17b4
Define color for XHR timings in waterfall chart. (#105817) 2021-07-15 16:18:39 -04:00
Quynh Nguyen
78d6fc553d
[ML] Fix Anomaly Explorer annotations misaligned (#105696)
* Move swimlane annotation out of container, add new axis width prop

* [ML] Fix alignment if some annotations overflow

* [ML] Move utils function to inside anomaly_timeline_service

* [ML] Fix y chart overflow

* [ML] Enforce stricter check on isOverallSwimlaneData

* [ML] Update logic to check if only one label
2021-07-15 15:03:05 -05:00
Ece Özalp
5128613213
[CTI] Adds validation to Indicator index pattern (#105649)
* [CTI] Adds validation to Indicator index pattern
2021-07-15 15:31:06 -04:00
Wylie Conlon
1e68fb253c
[Lens] Fix overall_min, overall_max and overall_average functions (#105276)
* [Lens] Fix overall metrics

* Style comments
2021-07-15 15:30:21 -04:00
Ece Özalp
db8c86a2a1
[CTI] Adds integration test coverage to CTI Overview (#104785)
* [CTI] Adds integration test coverage to CTI Overview

* remove unnecessary line

* increases coverage

* updates tests"

* removes comments & unusued files

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 15:01:09 -04:00
Ryland Herrick
6e566b30c1
[Security Solution][CTI] Enrichment Details Final Copy/UI (#105701)
* Convert enrichment icon from the security logo to an (i)

Feedback was that the security logo was confusing.

* Move tooltip icon to the right of our content

Placing it on the left was meant to call out these fields as distinct
from others, but placing it on the right is more in line with EUI
guidelines.

This also updates the relative spacing of these elements to account for
this new position.

* Allows header to span multiple lines if content would wrap

Without this, both the tooltip icon and the inspect button could be
hidden if the indicator matched a field with a particularly long value
(e.g. a file hash).

* Update copy with latest from product

I took a guess at extending the verbiage for some of the more detailed
descriptions, since product has not yet provided those.

* Final copy updates

Each panel now includes the CTI CTA as well.
2021-07-15 14:38:58 -04:00
Kate Farrar
2079d61544
[Metrics UI] Inventory layout issues - interval language to tooltip (#105687)
inventory view - moved interval label language to a tooltip to make more room for waffle map controls responsively
2021-07-15 12:29:00 -06:00
Kate Farrar
eb3f4c0215
[Observability] Obs Overview cleanup & Metrics section layout fix (#104577)
* updating overview page layout to accommodate side bar nav, fixing metrics table responsive issues, style updates
2021-07-15 11:56:53 -06:00
Jonathan Budzenski
9e9dfe22ed skip flaky suite. #105784 2021-07-15 12:17:34 -05:00
Quynh Nguyen
98fc711117
[ML] Fix regression caused by #104994 (#105666)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-15 12:14:51 -05:00
Wylie Conlon
f90e6669e1
[Lens] Fix pie chart with 0 decimal places for percent (#105672) 2021-07-15 11:23:35 -04:00
Melissa Alvarez
75e6b8721b
check metric function as well as label to determine geo (#105671) 2021-07-15 10:35:33 -04:00
John Schulz
00cee5f775
[Fleet] Improve OpenAPI accuracy and validity (#105679)
* Improve schema from object to $ref

* Add description and response schema for /agent-status endpoint

* Remove code related to removed /install/:os endpoint

* Add response schemas for enrollment-api-key operations

* Add response schemas for /agents/:agentId

* Fix two security scheme names

* Change format for reference selectors

* Replace Ingest Manager with Fleet in OpenAPI spec

* Replace instances of Ingest Manager with Fleet

* Update instructions to create bundled specs
2021-07-15 10:28:24 -04:00
Lisa Cawley
4f83eae47f
[ML] Rare anomaly detection job wizard card text (#105635) 2021-07-15 07:23:45 -07:00
Angela Chuang
b6ff81d83e
[Security Solution] Fix landing page on rule deletion (#105572)
* fix landing url on rule delete

* add cypress test

* fix cypress
2021-07-15 15:18:10 +01:00
Tiago Costa
1a47c05f9e
skip flaky suite (#93188) 2021-07-15 14:49:20 +01:00
Shahzad
84d4652b14
[User Experience App] Fixed searching filter values (#105582) 2021-07-15 15:42:00 +02:00
Alison Goryachev
8ccf88e3e1
[Snapshots + Restore] Fix no snapshots prompt 2021-07-15 08:50:17 -04:00
Anton Dosov
5fcdb9d137
[Search Sessions] Don’t try to delete errored searches (#105434) 2021-07-15 12:59:39 +02:00
Yulia Čech
7dcb136c68
[Remote Clusters] Fixed remote clusters details flyout for long strings (#105592) 2021-07-15 12:22:48 +02:00
Robert Oskamp
79c4126cca
[ML] Functional tests - re-activate a11y tests (#105198)
This PR re-activates the ML a11y test suite `with data loaded`.
2021-07-15 12:14:43 +02:00
Dario Gieselaar
821aeb1ff4
[APM] Typed client-side routing (#104274)
* [APM] @kbn/typed-router-config

* [APM] typed route config

* Breadcrumbs, wildcards

* Migrate settings, home

* Migrate part of service detail page

* Migrate remaining routes, tests

* Set maxWorkers for precommit script to 4

* Add jest types to tsconfigs

* Make sure transaction distribution data is fetched

* Fix typescript errors

* Remove usage of react-router's useParams

* Add route() utility function

* Don't use ApmServiceContext for alert flyouts

* Don't add onClick handler for breadcrumb

* Clarify ts-ignore

* Remove unused things

* Update documentation

* Use useServiceName() in ServiceMap component
2021-07-15 11:30:59 +02:00