kibana/x-pack/plugins/enterprise_search/public
Scotty Bollinger 0f3e4f415f
[Workplace Search] Fix Chrome issues with GitHub sources (#105680)
* Fix route validation

This param is not always required. Was already fixed for org version but the personal dashboard came later and was not fixed.

Original fix for org:
30d8b1dfa8 (diff-07f094b2a4719e8511f003d8e278a77cd6b808d11b14d1c528705f9b259c328fR373)

* Fix route to account for private github route

Previously had the org route hard-coded

* Move the logic for parsing the query params to template

Because the useEffect call comes after the initial render, the chrome flashes. We originally got around this by hiding the chrome always because in non-github scenarios, this worked fine.

However, because the oauth plugin sends the state in the quert params and uses the same URL, we need to parse that to determine whether this is an org or accoutn route. We now do that logic in the template and set the chrome before calling the useEffect.

We still need to pass both the parsed params and the original quert string because the redirect passes that string to the next view.
2021-07-14 19:44:49 -04:00
..
applications [Workplace Search] Fix Chrome issues with GitHub sources (#105680) 2021-07-14 19:44:49 -04:00
index.ts
plugin.ts