kibana/x-pack/plugins/apm/CONTRIBUTING.md
Oliver Gupte 16ba937bae
[APM] Client new platform migration (#64046)
* migrate files from legacy path to new plugin path

* update file paths to reflect migrated files

* move minimal legacy client files back to legacy path in order to run kibana

* Completes the full cutover to the new kibana platform removing all shims and legacy adapters.

* Adds APM to ignored list for casing check.

* - moves public/utils/pickKeys.ts to common/utils/pick_keys.ts
- exposes getTraceUrl as a plugin static export of apm/public and updates import in infra
- fixes FeaturesPluginSetup import in apm/public app
- renames get_apm_index_pattern_titles -> get_apm_index_pattern_title
- getApmIndexPatternTitle is now a synchronous getter function
- removes unused comments and xpack.apm.apmForESDescription i18n translations

* Moves automatic index pattern saved object creation from
plugin start to when the Home screen first renders

* removed unnecessary legacy css imports

* fixed ci issues by:
- moving readOnly badge, and help extension setup to occure only
  when apm app is mounted
- registering saved object types
- also moved createStaticIndexPattern from a react useEffect on the
  APM home screen to when the app is mounted
2020-04-30 13:08:50 -07:00

592 B

Definition of Done for APM UI

  • Flag and create issues of things that are left out
    • Should be added to agenda before-hand and discussed
  • Before/after images or gif of UI changes
  • Release labels
    • Must have release labels for bugs and bigger features
  • CI passing
  • Designer sign-off for UI related changes
  • PM approval for bigger, user-facing features
  • Merge to master (this closed the issue)
  • Backported to appropriate versions
  • Add to Observability Weekly Updates