maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
kibana/x-pack/plugins
History
Andrew Goldstein 3f2913b5b8
[Security Solution] Full screen Timeline CSS fixes (#72559) 
## [Security Solution] Full screen Timeline CSS fixes

Fixes CSS issues related to the [Full screen timeline, Collapse event](https://github.com/elastic/kibana/pull/71786) feature:

- Sometimes, Timeline's left padding is missing in Full screen mode
- The `Attach to new case` and `Attach to existing case...` actions should be centered in Full screen mode
- The Timeline flyout button is not opaque when the alerts table is in Full screen mode

### Sometimes, Timeline's left padding is missing in Full screen mode

To reproduce:

1) Drag anything to the Timeline
2) Click the `Full screen` button

**Expected result**
- [x] The timeline has left padding in full screen mode

**Actual result**
- [x] Sometimes, the left padding of the Timeline is missing, per the screenshot below:

![timeline-full-screen-before](https://user-images.githubusercontent.com/4459398/87998223-8acf8000-cab4-11ea-91a1-6b5644856b44.png)

### Fix: screenshot

![timeline-full-screen-after](https://user-images.githubusercontent.com/4459398/87998363-e3068200-cab4-11ea-8484-41d87ba4c97e.png)

### The `Attach to new case` and `Attach to existing case...` actions should be centered in full screen mode

1) Create a new timeline with the following KQL query: `agent.type : endpoint`
2) Click the `Analyze event` button on any enabled event to view Resolver

**Expected result**
- [x] The `Attach to new case` and `Attach to existing case...` actions should be centered between the horizontal lines

**Actual result**
- [x] The `Attach to new case` and `Attach to existing case...` actions are **NOT** centered, per the screenshot below:

![attach-to-case-before](https://user-images.githubusercontent.com/4459398/87998636-b9018f80-cab5-11ea-87e8-a54355386519.png)

### Fix: screenshot

![attach-to-case-after](https://user-images.githubusercontent.com/4459398/87998553-82c41000-cab5-11ea-9e33-fcffce11e4b4.png)

### The Timeline flyout button is not opaque when the alerts table is in Full screen mode

To reproduce:

1) Navigate to Security > Detections
2) Click on the `Full screen` button

**Expected result**
- [x] The Timeline flyout button is opaque when the alerts table is in Full screen mode

**Actual result**
- [x] The Timeline flyout button is **NOT** opaque when the alerts table is in Full screen mode, per the screenshot below:

![flyout-button-before](https://user-images.githubusercontent.com/4459398/87998761-0d0c7400-cab6-11ea-9cd3-0c091e0291c9.png)

## Fix: screenshot (light theme)

![flyout-button-after-light](https://user-images.githubusercontent.com/4459398/87998784-231a3480-cab6-11ea-8fc9-17c28cf25202.png)

## Fix: screenshot (dark theme)

![flyout-button-after-dark](https://user-images.githubusercontent.com/4459398/87998824-45ac4d80-cab6-11ea-96ef-6242b8494f84.png)

### Desk testing

Desk tested in :
- Chrome `84.0.4147.89`
- Firefox `78.0.2`
- Safari `13.1.2`
2020-07-21 13:46:05 -06:00
..
actions Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation. (#71579) 2020-07-15 11:01:34 -07:00
alerting_builtins
alerts
apm [APM] Disable flaky rum e2e’s (#72614) 2020-07-21 15:56:43 +02:00
audit_trail
beats_management Add @elastic/safer-lodash-set as an alternative to lodash.set (#67452) 2020-07-15 10:29:57 +02:00
canvas Optimize Functions and Renderers for Webpack builds (#72683) 2020-07-21 15:29:15 -04:00
case
cloud
code
console_extensions
cross_cluster_replication Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
dashboard_enhanced
dashboard_mode
data_enhanced [Search] Add telemetry for data plugin search service (#70677) 2020-07-15 11:49:34 +03:00
discover_enhanced
embeddable_enhanced Add a few asciidoc readmes (#72082) 2020-07-17 11:08:57 -04:00
encrypted_saved_objects
enterprise_search
event_log [eventLog] search for actions/alerts as hidden saved objects (#70395) 2020-07-16 09:10:51 -04:00
features
file_upload
global_search
global_search_providers
graph register graph usage (#72041) 2020-07-17 17:16:28 +02:00
grokdebugger
index_lifecycle_management Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
index_management Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
infra [Metrics UI] Fix Alert Preview Error design (#71005) 2020-07-20 13:18:43 -05:00
ingest_manager Move manifest packageConfig mocks into security_solution plugin (#72527) 2020-07-21 12:22:53 -04:00
ingest_pipelines Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
lens Applying tiny fix from 72532 to main branch (#72533) 2020-07-21 09:56:13 -04:00
license_management Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
licensing
lists [SIEM][Detection Engine][Lists] Adds list permissions (#72335) 2020-07-20 11:00:59 -06:00
logstash
maps Add inspector for VEGA (#70941) 2020-07-21 14:45:51 +03:00
maps_legacy_licensing
ml [ML] Handling data recognizer saved object errors (#72447) 2020-07-21 14:28:10 +01:00
monitoring [Monitoring] Fix the messaging around needing TLS enabled (#72310) 2020-07-21 09:12:50 -04:00
observability [Observability] Remove app logos (#72259) 2020-07-20 10:25:39 +02:00
oss_telemetry
painless_lab
remote_clusters Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
reporting Migrate and cleanup legacy scss (#69369) 2020-07-20 10:43:12 +02:00
rollup Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
searchprofiler
security Register navLink actions for declared applications (#72109) 2020-07-17 05:38:55 -04:00
security_solution [Security Solution] Full screen Timeline CSS fixes (#72559) 2020-07-21 13:46:05 -06:00
snapshot_restore Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
spaces
task_manager [Task Manager] Batches the update operations in Task Manager (#71470) 2020-07-21 14:08:29 +01:00
telemetry_collection_xpack add policy details and update SO limit requests (#71789) 2020-07-15 09:36:48 -04:00
transform [ML] Transforms/Analytics actions: Fix different button styles (#71626) 2020-07-15 21:51:57 +02:00
translations Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
triggers_actions_ui [Alerting][Connectors] Increase the size of the logos (#72419) 2020-07-20 18:35:42 +03:00
ui_actions_enhanced
upgrade_assistant Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00
uptime Add @elastic/safer-lodash-set as an alternative to lodash.set (#67452) 2020-07-15 10:29:57 +02:00
watcher Add doc titles to ES UI apps (#71045) 2020-07-21 07:04:40 -07:00