maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
pulumi/CONTRIBUTING.md
Matt Ellis 992b048dbf Adopt golangci-lint and address issues 
We run the same suite of changes that we did on gometalinter. This
ended up catching a few new issues, some of which were addressed and
some of which were baselined.
2018-11-08 14:11:47 -08:00

3.9 KiB
Raw Blame History

Contributing to Pulumi

First, thanks for contributing to Pulumi and helping make it better. We appreciate the help! If you're looking for an issue to start with, we've tagged some issues with the help-wanted tag but feel free to pick up any issue that looks interesting to you or fix a bug you stumble across in the course of using Pulumi. No matter the size, we welcome all improvements.

For larger features, we'd appreciate it if you open a new issue before doing a ton of work to discuss the feature before you start writing a lot of code.

Hacking on Pulumi

To hack on Pulumi, you'll need to get a development environment set up. You'll want to install the following on your machine:

Getting dependencies on macOS

You can easily get all required dependencies with brew

brew install node pipenv python@3 typescript dep yarn pandoc

Make build system

We use make as our build system, so you'll want to install that as well, if you don't have it already. We have extremely limited support for doing development on Windows (the bare minimum for us to get Windows validation of pulumi) so if you're on windows, we recommend that you use the Windows Subsystem for Linux. We'd like to make this better so feel free to pitch in if you can.

For historical reasons (which we'd like to address) our build system requires that the folder /opt/pulumi exists and is writable by the current user. If you'd like, you can override this location by setting PULUMI_ROOT in your environment. The build is known to fail if this doesn't exist, so you'll need to create it first.

Across our projects, we try to use a regular set of make targets. The ones you'll care most about are:

  1. make, which builds Pulumi and runs a quick set of tests
  2. make all which builds Pulumi and runs the quick tests and a larger set of tests.

We make heavy use of integration level testing where we invoke pulumi to create and then delete cloud resources. This requires you to have a Pulumi account (so sign up for free today if you haven't already) and login with pulumi login.

This repository does not actually create any real cloud resources as part of testing, but still uses Pulumi.com to store information abot some synthetic resources it creates during testing. Other repositories may require additional setup before running tests (most often this is just setting a few environment variables that tell the tests some information about how to use the cloud provider we are testing). Please see the CONTRIBUTING.md file in the repository, which will explain what additional configuration needs to be done before running tests.

Pulumi integration tests make use of the Go test runner. When using Go 1.10 or above, we recommend setting the GOCACHE environment variable to off to avoid erroneously caching test results.

Submitting a Pull Request

For contributors we use the standard fork based workflow. Fork this repository, create a topic branch, and start hacking away. When you're ready, make sure you've run the tests (make travis_pull_request will run the exact flow we run in CI) and open your PR.

Getting Help

We're sure there are rough edges and we appreciate you helping out. If you want to talk with other folks hacking on Pulumi (or members of the Pulumi team!) come hang out #contribute channel in the Pulumi Community Slack.