Add GH issue IDs to all the suppress/disables that I left behind as they were a bit too challenging to solve with this giant PR
This commit is contained in:
parent
d0c207bc9c
commit
96cc7727bc
|
@ -93,7 +93,7 @@ CharRowCellReference::const_iterator CharRowCellReference::begin() const
|
|||
// - end iterator of the glyph data
|
||||
#pragma warning(push)
|
||||
#pragma warning(disable : 26481)
|
||||
// TODO: eliminate using pointers raw as begin/end markers in this class
|
||||
// TODO GH 2672: eliminate using pointers raw as begin/end markers in this class
|
||||
CharRowCellReference::const_iterator CharRowCellReference::end() const
|
||||
{
|
||||
if (_cellData().DbcsAttr().IsGlyphStored())
|
||||
|
|
|
@ -120,6 +120,7 @@ OutputCellIterator::OutputCellIterator(const std::wstring_view utf16Text, const
|
|||
#pragma warning(suppress : 26490)
|
||||
// Suppresses reinterpret_cast. We're only doing this because Windows doesn't understand the type difference between wchar_t and DWORD.
|
||||
// It is not worth trying to separate that out further or risking performance over this particular warning here.
|
||||
// TODO GH 2673 - Investigate real wchar_t flag in Windows and resolve this audit issue
|
||||
OutputCellIterator::OutputCellIterator(const std::basic_string_view<WORD> legacyAttrs, const bool /*unused*/) noexcept :
|
||||
_mode(Mode::LegacyAttr),
|
||||
_currentView(s_GenerateViewLegacyAttr(legacyAttrs.at(0))),
|
||||
|
|
|
@ -1003,7 +1003,7 @@ const TextBuffer::TextAndColor TextBuffer::GetTextForClipboard(const bool lineSe
|
|||
}
|
||||
}
|
||||
#pragma warning(suppress : 26444)
|
||||
// TODO: figure out why there's custom construction/destruction happening here
|
||||
// TODO GH 2675: figure out why there's custom construction/destruction happening here
|
||||
it++;
|
||||
}
|
||||
|
||||
|
|
|
@ -29,6 +29,7 @@ constexpr short DEFAULT_HISTORY_SIZE = 9001;
|
|||
|
||||
#pragma warning(push)
|
||||
#pragma warning(disable : 26426)
|
||||
// TODO GH 2674, don't disable this warning, move to std::wstring_view or something like that.
|
||||
const std::wstring DEFAULT_FONT_FACE{ L"Consolas" };
|
||||
constexpr int DEFAULT_FONT_SIZE = 12;
|
||||
|
||||
|
|
|
@ -6,6 +6,7 @@
|
|||
#include "inc/GlyphWidth.hpp"
|
||||
|
||||
#pragma warning(suppress : 26426)
|
||||
// TODO GH 2676 - remove warning suppression and decide what to do re: singleton instance of CodepointWidthDetector
|
||||
static CodepointWidthDetector widthDetector;
|
||||
|
||||
// Function Description:
|
||||
|
|
Loading…
Reference in a new issue