b009d06bc3
## Summary of the Pull Request Fixes #5205, by replacing another use of `MapVirtualKeyW` with `ToUnicodeEx`. The latter just seems to be much more consistent at translating key combinations in general. In this particular case though it fixes the issue, because there's no differentiation in `MapVirtualKeyW` for whether it failed to return a character (`'\0'`) or succeeded in turning `^@` into `'\0'`. `ToUnicodeEx` on the other hand returns the success state separately from the translated character. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #5205 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #5205 ## Detailed Description of the Pull Request / Additional comments This PR changes the behavior of the `Ctrl+Alt+Key` handling slightly: ⚠️ `ToUnicodeEx` returns unshifted characters. ⚠️ For instance `Ctrl+Alt+a` is now turned into `^[^a`. Due to how ASCII works this is essentially the same though because `'A' & 0b11111` and `'a' & 0b11111` are the same. ## Validation Steps Performed * Run `showkey -a` * Ensured `Ctrl+Alt+Space` as well as `Ctrl+Alt+Shift+2` are turned into `^[^@` * Ensured other, random `Ctrl+Alt+Key` combination behave identical to the current master |
||
|---|---|---|
| .. | ||
| apis.txt | ||
| chinese.txt | ||
| colors.txt | ||
| dictionary.txt | ||
| fonts.txt | ||
| japanese.txt | ||
| math.txt | ||
| microsoft.txt | ||
| names.txt | ||
| README.md | ||
Dictionaries are lists of words to accept unconditionally
While check spelling will complain about an expected word which is no longer present, you can include things here even if they are not otherwise present in the repository.
E.g., you could include a list of system APIs here, or potential contributors (so that if a future commit includes their name, it'll be accepted).
Files
| File | Description |
|---|---|
| Dictionary | Primary US English dictionary |
| Chinese | Chinese words |
| Japanese | Japanese words |
| Microsoft | Microsoft brand items |
| Fonts | Font names |
| Names | Names of people |
| Colors | Names of color |