## Summary of the Pull Request <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #4013 * [x] I work here. * [x] Existing tests should be OK. Real changes, just adding a lib to use. * [x] Couldn't find any existing docs about intsafe. * [x] Am core contributor. ## Detailed Description of the Pull Request / Additional comments * [x] Can we remove min/max completely or rename it in the two projects where it had to be reintroduced? This is now moved into #4152 * [x] How many usages of the old safe math are there? **79** * [x] If not a ton, can we migrate them here or in a follow on PR? This is now moved into #4153 Files with old safe math: - TerminalControl: TSFInputControl.cpp - TerminalCore: TerminalDispatch.cpp - TerminalCore: TerminalSelection.cpp - Host: directio.cpp - RendererGdi: invalidate.cpp - RendererGdi: math.cpp - RendererGdi: paint.cpp - RendererVt: paint.cpp - TerminalAdapter: adaptDispatch.cpp - Types: viewport.cpp - Types: WindowUiaProviderBase.cpp ## Validation Steps Performed
18 lines
1.1 KiB
Markdown
18 lines
1.1 KiB
Markdown
### Notes for Future Maintainers
|
|
|
|
This was originally imported by @miniksa in January 2020.
|
|
|
|
The provenance information (where it came from and which commit) is stored in the file `cgmanifest.json` in the same directory as this readme.
|
|
Please update the provenance information in that file when ingesting an updated version of the dependent library.
|
|
That provenance file is automatically read and inventoried by Microsoft systems to ensure compliance with appropiate governance standards.
|
|
|
|
## What should be done to update this in the future?
|
|
|
|
1. Go to chromium/chromium repository on GitHub.
|
|
2. Take the entire contents of the base/numerics directory wholesale and drop it in the base/numerics directory here.
|
|
3. Don't change anything about it.
|
|
4. Validate that the license in the root of the repository didn't change and update it if so. It is sitting in the same directory as this readme.
|
|
If it changed dramatically, ensure that it is still compatible with our license scheme. Also update the NOTICE file in the root of our repository to declare the third-party usage.
|
|
5. Submit the pull.
|
|
|