maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia/TerminalApp
History
Don-Vito 5b2fd70940
7996: Always on Top setting does not persist (#8125) 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes https://github.com/microsoft/terminal/issues/7996
* [x] CLA signed.
* [ ] Documentation updated - irrelevant
* [ ] Schema updated - irrelevant
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
Currently the value of AlwaysOnTop is read by the AppHost from AppLogic that takes this value from the root TerminalPage. However at this stage neither AppLogic nor TerminalPage are initialized, and thus the return value is always false.

This PR introduces a "GetInitialAlwaysOnTop" method to AppLogic that returns a value that is configured in the settings.
In addition, the TerminalPage creation was fixed to read the configuration value upon creation (and not just after settings reload).

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
* Only manual testing
* Starting the system with both initial value set to true and false
* Verifying that dynamic toggling on / off is not affected
2020-11-02 18:51:29 +00:00
..
dll Remove all our path antics; force native projects to bin/, obj/ (#8062) 2020-10-27 15:00:41 -07:00
Resources/en-US Display a warning for when we fail to write to the settings file (#7950) 2020-10-23 00:21:07 +00:00
App.base.h Apply a GDI region to the top level Island window to allow dragging with a single Island (#929) 2019-06-25 13:06:11 -07:00
App.cpp Make Terminal look great in High Contrast (#6833) 2020-07-08 12:08:08 -07:00
App.h Break everything out of App except Xaml platform init (#3465) 2019-11-07 13:10:58 -08:00
App.idl Fix intellisense errors by moving TerminalApp projects around (#6897) 2020-08-20 22:44:37 +00:00
App.xaml Replace the HRGN-based titlebar cutout with an overlay window (#5485) 2020-04-24 15:22:40 -07:00
AppActionHandlers.cpp Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
AppCommandlineArgs.cpp 7124: Add focus and maximizedFocus launch modes (#7873) 2020-10-14 22:19:51 +00:00
AppCommandlineArgs.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppKeyBindings.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppKeyBindings.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppKeyBindings.idl Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
AppLogic.cpp 7996: Always on Top setting does not persist (#8125) 2020-11-02 18:51:29 +00:00
AppLogic.h 7996: Always on Top setting does not persist (#8125) 2020-11-02 18:51:29 +00:00
AppLogic.idl 7996: Always on Top setting does not persist (#8125) 2020-11-02 18:51:29 +00:00
ColorHelper.cpp Fix a few minor typos from #3789 (#5740) 2020-05-04 16:47:29 -05:00
ColorHelper.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.cpp Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.idl Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.xaml Show color slider in Tab color picker (#7963) 2020-10-23 20:18:06 +00:00
Commandline.cpp Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
Commandline.h Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
CommandPalette.cpp Updating comments in CommandPalette.cpp (#8019) 2020-10-23 08:27:25 +00:00
CommandPalette.h Enable PgUp/PgDown and Home/End in the command palette (#7835) 2020-10-22 04:40:57 +00:00
CommandPalette.idl Display ATS tabs in MRU order (#7952) 2020-10-21 19:37:28 +00:00
CommandPalette.xaml Swap the command palette modes for the prefix > (#7935) 2020-10-15 15:58:35 -07:00
DebugTapConnection.cpp Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
DebugTapConnection.h Add explicit identifier to some constructors (#5652) 2020-04-29 16:50:47 -07:00
EmptyStringVisibilityConverter.cpp Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
EmptyStringVisibilityConverter.h Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
EmptyStringVisibilityConverter.idl Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
HasNestedCommandsVisibilityConverter.cpp Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
HasNestedCommandsVisibilityConverter.h Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
HasNestedCommandsVisibilityConverter.idl Add some polish to nested commands in the command palette (#7299) 2020-08-18 19:32:17 +00:00
IconPathConverter.cpp Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
IconPathConverter.h Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
IconPathConverter.idl Introduce IconConverter (#7830) 2020-10-08 11:29:04 -07:00
IDirectKeyListener.idl Pass the scancode in our tunneled DirectKey event (#7298) 2020-08-14 23:44:39 +00:00
init.cpp Hook up the WIL fallback error tracer in Terminal (#7864) 2020-10-09 22:20:12 +00:00
Jumplist.cpp Store and expose hidden profiles (#8070) 2020-10-28 16:22:26 +00:00
Jumplist.h Move jumplist creation to background thread (#7978) 2020-10-22 17:17:26 -07:00
MinMaxCloseControl.cpp Get rid of the padding above the tab row when maximized (#5881) 2020-05-21 22:26:37 +00:00
MinMaxCloseControl.h Propagate window style changes to the titlebar and minmax (#3025) 2019-10-02 10:27:07 -07:00
MinMaxCloseControl.idl Fix intellisense errors by moving TerminalApp projects around (#6897) 2020-08-20 22:44:37 +00:00
MinMaxCloseControl.xaml Animate Hover state change of CaptionButtons (#6303) 2020-06-02 18:50:18 +00:00
packages.config Update C++/WinRT to 2.0.201017.1 (#8061) 2020-10-27 20:15:30 +00:00
Pane.cpp Fix exiting a zoomed pane (#7973) 2020-10-21 21:33:56 +00:00
Pane.h Add a setting to configure the audible bell (#7793) 2020-10-15 15:27:27 -07:00
Pane.LayoutSizeNode.cpp Snap to character grid when resizing window (#3181) 2020-01-08 13:19:23 -08:00
pch.cpp Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
pch.h Add an animation to pane entrance/exit (#7364) 2020-10-09 23:06:40 +00:00
ShortcutActionDispatch.cpp Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
ShortcutActionDispatch.h Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
ShortcutActionDispatch.idl Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
Tab.cpp Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
Tab.h Add openTabRenamer action (#7462) 2020-10-28 19:36:30 +00:00
Tab.idl Fix exiting a zoomed pane (#7973) 2020-10-21 21:33:56 +00:00
TabRowControl.cpp Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.h Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.xaml Inform user that holding alt opens a new pane (#7866) 2020-10-12 17:14:02 -07:00
TerminalAppLib.vcxproj Remove all our path antics; force native projects to bin/, obj/ (#8062) 2020-10-27 15:00:41 -07:00
TerminalAppLib.vcxproj.filters From orbit, nuke the Telnet connection and all supporting infra. (#7840) 2020-10-09 18:59:58 +00:00
TerminalPage.cpp 7996: Always on Top setting does not persist (#8125) 2020-11-02 18:51:29 +00:00
TerminalPage.h Double middle click on taskbar preview closes application (#7871) 2020-10-29 16:32:12 +00:00
TerminalPage.idl Add support for "Always on top" mode (#6903) 2020-07-14 21:02:18 +00:00
TerminalPage.xaml Double middle click on taskbar preview closes application (#7871) 2020-10-29 16:32:12 +00:00
TerminalSettings.cpp Make Global and Profile settings inheritable (#7923) 2020-10-27 17:35:09 +00:00
TerminalSettings.h Introduce TerminalSettingsModel project (#7667) 2020-10-06 09:56:59 -07:00
TerminalSettings.idl Move ICore/ControlSettings to TerminalControl project (#7167) 2020-08-07 14:46:52 +00:00
TitlebarControl.cpp Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
TitlebarControl.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
TitlebarControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TitlebarControl.xaml Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00