maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia/TerminalApp
History
jtippet 4faa104f6a
Update colors of our custom NewTab button to match MUX's TabView (#6812) 
Update colors of our custom NewTab button to match MUX's TabView button

MUX has a NewTab button, but Terminal uses a homemade lookalike.  The
version in Terminal doesn't use the same brush color resources as MUX's
button, so it looks very slightly different.  This PR updates Terminal's
button to use the exact same colors that MUX uses.  I literally copied
these brush names out of MUX source code.

## References
This is the color version of the layout fix #6766 
This is a prerequisite for fixing #5360

## Detailed Description of the Pull Request / Additional comments
The real reason that this matters is that once you flip on
`ApplicationHighContrastAdjustment::None`, the existing colors will not
work at all.  The existing brushes are themed to black foreground on a
black background when High Contrast (HC) Black theme is enabled.  The
only thing that's saving you is
`ApplicationHighContrastAdjustment::Auto` is automatically backplating
the glyphs on the buttons, which (by design) hides the fact that the
colors are poor.  The backplates are those ugly squares inside the
buttons on the HC themes.

Before I can push a PR that disables automatic backplating (set
`ApplicationHighContrastAdjustment` to `None`), we'll need to select
better brushes that work in HC mode.  MUX has already selected brushes
that work great in all modes, so it just makes sense to use their
brushes.

The one very subtle difference here is that, for non-HC themes, the
glyph's foreground has a bit more contrast when the button is in
hovered/pressed states.  Again this slight difference hardly matters
now, but using the correct brushes will become critical when we try to
remove the HC backplating.

Closes #6812
2020-07-07 13:40:01 -07:00
..
lib Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
Resources/en-US Add tooltip text to Color Buttons (#6498) 2020-07-01 19:58:53 +00:00
ActionAndArgs.cpp Add a ShortcutAction for toggling retro terminal effect (#6691) 2020-07-01 23:17:43 +00:00
ActionAndArgs.h Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
ActionArgs.cpp Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
ActionArgs.h Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
ActionArgs.idl Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
App.base.h Apply a GDI region to the top level Island window to allow dragging with a single Island (#929) 2019-06-25 13:06:11 -07:00
App.cpp Add startup task, setting to launch application on login (#4908) 2020-06-01 20:24:43 +00:00
App.h Break everything out of App except Xaml platform init (#3465) 2019-11-07 13:10:58 -08:00
App.idl ci: spelling: update to 0.0.15a; update whitelist (#5413) 2020-04-21 14:07:04 -07:00
App.xaml Replace the HRGN-based titlebar cutout with an overlay window (#5485) 2020-04-24 15:22:40 -07:00
AppActionHandlers.cpp Add a ShortcutAction for toggling retro terminal effect (#6691) 2020-07-01 23:17:43 +00:00
AppCommandlineArgs.cpp Add support for --title to the wt.exe commandline args (#6296) 2020-06-02 18:52:08 +00:00
AppCommandlineArgs.h Add support for --title to the wt.exe commandline args (#6296) 2020-06-02 18:52:08 +00:00
AppKeyBindings.cpp Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
AppKeyBindings.h Add warning messages for bad keybindings (#4746) 2020-03-05 21:06:58 +00:00
AppKeyBindings.idl Encapsulate dispatching ShortcutActions in it's own class (#3658) 2019-11-27 15:51:38 -06:00
AppKeyBindingsSerialization.cpp Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
AppLogic.cpp Add settings to warn about large or multiline pastes (#6631) 2020-07-01 19:43:28 +00:00
AppLogic.h Add settings to warn about large or multiline pastes (#6631) 2020-07-01 19:43:28 +00:00
AppLogic.idl Add settings to warn about large or multiline pastes (#6631) 2020-07-01 19:43:28 +00:00
AzureCloudShellGenerator.cpp Implement ConnectionState and closeOnExit=graceful/always/never (#3623) 2019-11-25 14:22:29 -08:00
AzureCloudShellGenerator.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
CascadiaSettings.cpp Add some trace logging concerning which schemes are in use (#6803) 2020-07-07 17:01:42 +00:00
CascadiaSettings.h Add some trace logging concerning which schemes are in use (#6803) 2020-07-07 17:01:42 +00:00
CascadiaSettingsSerialization.cpp Replace manual get/set code in GlobalAppSettings with GETSET_PROPERTY (#5931) 2020-06-03 22:51:46 +00:00
ColorHelper.cpp Fix a few minor typos from #3789 (#5740) 2020-05-04 16:47:29 -05:00
ColorHelper.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.cpp Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.idl Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
ColorPickupFlyout.xaml Add tooltip text to Color Buttons (#6498) 2020-07-01 19:58:53 +00:00
ColorScheme.cpp Switch the Cascadia projects to til::color where it's easily possible to do so (#5847) 2020-05-15 22:43:00 +00:00
ColorScheme.h Switch the Cascadia projects to til::color where it's easily possible to do so (#5847) 2020-05-15 22:43:00 +00:00
Command.cpp Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
Command.h Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
Command.idl Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
Commandline.cpp Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
Commandline.h Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
CommandPalette.cpp Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
CommandPalette.h Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
CommandPalette.idl Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
CommandPalette.xaml Add support for the Command Palette (#6635) 2020-06-26 20:38:02 +00:00
DebugTapConnection.cpp Add a "debug tap" that lets you see the VT behind a connection (#5127) 2020-03-26 15:33:47 -07:00
DebugTapConnection.h Add explicit identifier to some constructors (#5652) 2020-04-29 16:50:47 -07:00
DefaultProfileUtils.cpp Patch the default profile and version into the settings template (#5232) 2020-04-07 11:35:05 -07:00
DefaultProfileUtils.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
defaults-universal.json Allow Ctrl+Alt <> AltGr aliasing to be disabled (#6212) 2020-06-05 16:11:41 +00:00
defaults.json Hardcode the paths to Windows PowerShell and CMD (#6684) 2020-06-26 17:33:38 +00:00
FixVisualStudioBug.targets Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
GlobalAppSettings.cpp Add settings to warn about large or multiline pastes (#6631) 2020-07-01 19:43:28 +00:00
GlobalAppSettings.h Add settings to warn about large or multiline pastes (#6631) 2020-07-01 19:43:28 +00:00
IDirectKeyListener.idl Pass <Alt> to the application (#6461) 2020-06-11 15:41:16 -07:00
IDynamicProfileGenerator.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
init.cpp Introduce a WinRT utils library and "checked resources" (#3350) 2019-11-01 15:47:05 -07:00
JsonUtils.cpp Switch the Cascadia projects to til::color where it's easily possible to do so (#5847) 2020-05-15 22:43:00 +00:00
JsonUtils.h Switch the Cascadia projects to til::color where it's easily possible to do so (#5847) 2020-05-15 22:43:00 +00:00
JsonUtilsNew.h Introduce JsonUtilsNew as documented in #5875 (#6355) 2020-06-18 00:27:42 +00:00
KeyChordSerialization.cpp Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
KeyChordSerialization.h Support remapping keybindings (#748) 2019-05-21 09:26:04 -05:00
LegacyProfileGeneratorNamespaces.h Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
MinMaxCloseControl.cpp Get rid of the padding above the tab row when maximized (#5881) 2020-05-21 22:26:37 +00:00
MinMaxCloseControl.h Propagate window style changes to the titlebar and minmax (#3025) 2019-10-02 10:27:07 -07:00
MinMaxCloseControl.idl Propagate window style changes to the titlebar and minmax (#3025) 2019-10-02 10:27:07 -07:00
MinMaxCloseControl.xaml Animate Hover state change of CaptionButtons (#6303) 2020-06-02 18:50:18 +00:00
packages.config Move to Microsoft.UI.Xaml 2.4.0 (#5778) 2020-06-05 17:07:03 +00:00
Pane.cpp Process actions sync. on startup; don't dupe nonexistent profile (#5090) 2020-03-25 17:03:32 -07:00
Pane.h Add explicit identifier to some constructors (#5652) 2020-04-29 16:50:47 -07:00
Pane.LayoutSizeNode.cpp Snap to character grid when resizing window (#3181) 2020-01-08 13:19:23 -08:00
pch.cpp Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
pch.h Refactor TerminalApp and Add Tests for Xaml Content (#1164) 2019-07-15 14:27:56 -05:00
PowershellCoreProfileGenerator.cpp Patch the default profile and version into the settings template (#5232) 2020-04-07 11:35:05 -07:00
PowershellCoreProfileGenerator.h Patch the default profile and version into the settings template (#5232) 2020-04-07 11:35:05 -07:00
Profile.cpp Add some trace logging concerning which schemes are in use (#6803) 2020-07-07 17:01:42 +00:00
Profile.h Add some trace logging concerning which schemes are in use (#6803) 2020-07-07 17:01:42 +00:00
ShortcutActionDispatch.cpp Add a ShortcutAction for toggling retro terminal effect (#6691) 2020-07-01 23:17:43 +00:00
ShortcutActionDispatch.h Add a ShortcutAction for toggling retro terminal effect (#6691) 2020-07-01 23:17:43 +00:00
ShortcutActionDispatch.idl Add a ShortcutAction for toggling retro terminal effect (#6691) 2020-07-01 23:17:43 +00:00
Tab.cpp Add setTabColor and openTabColorPicker actions (#6567) 2020-06-25 13:06:21 +00:00
Tab.h Add setTabColor and openTabColorPicker actions (#6567) 2020-06-25 13:06:21 +00:00
Tab.idl Convert Tab to a WinRT type (#4350) 2020-02-04 21:51:11 +00:00
TabRowControl.cpp Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.h Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.xaml Update colors of our custom NewTab button to match MUX's TabView (#6812) 2020-07-07 13:40:01 -07:00
TelnetGenerator.h Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
TerminalApp.def Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
TerminalApp.vcxproj Move to Microsoft.UI.Xaml 2.4.0 (#5778) 2020-06-05 17:07:03 +00:00
TerminalPage.cpp Add some trace logging concerning which schemes are in use (#6803) 2020-07-07 17:01:42 +00:00
TerminalPage.h Add a ShortcutAction for toggling retro terminal effect (#6691) 2020-07-01 23:17:43 +00:00
TerminalPage.idl Add settings to warn about large or multiline pastes (#6631) 2020-07-01 19:43:28 +00:00
TerminalPage.xaml Add settings to warn about large or multiline pastes (#6631) 2020-07-01 19:43:28 +00:00
TerminalWarnings.h Add explicit identifier to some constructors (#5652) 2020-04-29 16:50:47 -07:00
TitlebarControl.cpp Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
TitlebarControl.h Add support for setting a tab's color at runtime w/ context menu (#3789) 2020-05-04 20:57:12 +00:00
TitlebarControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TitlebarControl.xaml Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
userDefaults.json Add copyFormatting setting to all settings json files (#5404) 2020-04-20 23:49:12 +00:00
Utils.cpp Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
Utils.h Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
WslDistroGenerator.cpp Optimize booleans (#6548) 2020-06-22 21:51:34 +00:00
WslDistroGenerator.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00