maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia/TerminalApp
History
Mike Griese 8211ed9fa6
Fix unbinding keys in v0.10 (#4988) 
## Summary of the Pull Request

We (the royal "we") broke key unbinding in #4746. We didn't run the local tests after this, which actually would have caught this. The comment even suggests what we should have done here. We need to make sure that when we bail, it's because there's a parsing function that returned nothing. `null`, `"unbound"`, etc actually don't even have a parsing function at all, so they should just keep on keepin' on.

## References

Source of this regression: #4746

## PR Checklist
* [x] Closes #3729
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

This is a great example of why your unittests should run in CI always

## Validation Steps Performed
* **ran the tests**
* tested the following unbindings:

```json
        { "command": null, "keys": [ "ctrl+shift+t" ] },
        { "command": "unbound", "keys": [ "ctrl+shift+t" ] },
        { "command": "null", "keys": [ "ctrl+shift+t" ] },

```
and they each individually worked.
2020-03-18 12:52:43 -05:00
..
lib Polish AutomationProperties and UIA Tree Navigation (#4805) 2020-03-05 22:32:46 +00:00
Resources Polish AutomationProperties and UIA Tree Navigation (#4805) 2020-03-05 22:32:46 +00:00
ActionAndArgs.cpp Add support for arbitrary args in keybindings (#3391) 2019-11-14 16:23:40 -06:00
ActionAndArgs.h Add support for arbitrary args in keybindings (#3391) 2019-11-14 16:23:40 -06:00
ActionArgs.cpp Add support for new panes with specifc profiles and other settings overrides (#3825) 2019-12-09 13:02:29 +00:00
ActionArgs.h Add a splitPane option to duplicate current profile (#4683) 2020-03-06 23:15:45 +00:00
ActionArgs.idl Add a splitPane option to duplicate current profile (#4683) 2020-03-06 23:15:45 +00:00
App.base.h Apply a GDI region to the top level Island window to allow dragging with a single Island (#929) 2019-06-25 13:06:11 -07:00
App.cpp Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
App.h Break everything out of App except Xaml platform init (#3465) 2019-11-07 13:10:58 -08:00
App.idl Break everything out of App except Xaml platform init (#3465) 2019-11-07 13:10:58 -08:00
App.xaml Round and style buttons on close all tabs dialog (#4401) 2020-01-30 15:51:43 -08:00
AppActionHandlers.cpp Add a splitPane option to duplicate current profile (#4683) 2020-03-06 23:15:45 +00:00
AppCommandlineArgs.cpp Kill NEEDS_LOC and move cmdline descriptions into resources (#4402) 2020-01-31 01:13:38 +00:00
AppCommandlineArgs.h Configure CLI11 to stuff all unknown positionals into the cmdli… (#4388) 2020-01-29 13:01:05 -08:00
AppKeyBindings.cpp Encapsulate dispatching ShortcutActions in it's own class (#3658) 2019-11-27 15:51:38 -06:00
AppKeyBindings.h Add warning messages for bad keybindings (#4746) 2020-03-05 21:06:58 +00:00
AppKeyBindings.idl Encapsulate dispatching ShortcutActions in it's own class (#3658) 2019-11-27 15:51:38 -06:00
AppKeyBindingsSerialization.cpp Fix unbinding keys in v0.10 (#4988) 2020-03-18 12:52:43 -05:00
AppLogic.cpp Correct for the size of the tabs when calculating our initial window size (#4825) 2020-03-11 20:29:36 +00:00
AppLogic.h Prevent tab reordering while elevated (#4874) 2020-03-11 15:52:09 +00:00
AppLogic.idl Prevent tab reordering while elevated (#4874) 2020-03-11 15:52:09 +00:00
AzureCloudShellGenerator.cpp Implement ConnectionState and closeOnExit=graceful/always/never (#3623) 2019-11-25 14:22:29 -08:00
AzureCloudShellGenerator.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
CascadiaSettings.cpp Add warning messages for bad keybindings (#4746) 2020-03-05 21:06:58 +00:00
CascadiaSettings.h Add warning messages for bad keybindings (#4746) 2020-03-05 21:06:58 +00:00
CascadiaSettingsSerialization.cpp When patching profiles in, copy the user's indentation (#4555) 2020-02-13 00:09:49 +00:00
ColorScheme.cpp Add cursorColor to color scheme (#4651) 2020-03-17 20:11:03 +00:00
ColorScheme.h Add cursorColor to color scheme (#4651) 2020-03-17 20:11:03 +00:00
Commandline.cpp Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
Commandline.h Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
DefaultProfileUtils.cpp Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
DefaultProfileUtils.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
defaults-universal.json Added shift+ins to defaults.json (#4467) 2020-02-05 10:01:41 -08:00
defaults.json Add cursorColor to color scheme (#4651) 2020-03-17 20:11:03 +00:00
FixVisualStudioBug.targets Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
GlobalAppSettings.cpp Add warning messages for bad keybindings (#4746) 2020-03-05 21:06:58 +00:00
GlobalAppSettings.h Add warning messages for bad keybindings (#4746) 2020-03-05 21:06:58 +00:00
IDynamicProfileGenerator.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
IF7Listener.idl Tunnel F7 keypresses directly into special handlers in TermControl (#4807) 2020-03-05 20:35:46 +00:00
init.cpp Introduce a WinRT utils library and "checked resources" (#3350) 2019-11-01 15:47:05 -07:00
JsonUtils.cpp Add Cascading User + Default Settings (#2515) 2019-09-16 12:57:10 -07:00
JsonUtils.h Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
KeyChordSerialization.cpp Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
KeyChordSerialization.h Support remapping keybindings (#748) 2019-05-21 09:26:04 -05:00
LegacyProfileGeneratorNamespaces.h Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
MinMaxCloseControl.cpp Unify and clean up the common build properties (#3429) 2019-11-05 14:29:11 -08:00
MinMaxCloseControl.h Propagate window style changes to the titlebar and minmax (#3025) 2019-10-02 10:27:07 -07:00
MinMaxCloseControl.idl Propagate window style changes to the titlebar and minmax (#3025) 2019-10-02 10:27:07 -07:00
MinMaxCloseControl.xaml Polish AutomationProperties and UIA Tree Navigation (#4805) 2020-03-05 22:32:46 +00:00
packages.config update to the latest MUX prerelease (#4024) 2019-12-19 18:16:07 +00:00
Pane.cpp Make panes use xaml star sizing (#4953) 2020-03-17 17:44:45 +00:00
Pane.h Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
Pane.LayoutSizeNode.cpp Snap to character grid when resizing window (#3181) 2020-01-08 13:19:23 -08:00
pch.cpp Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
pch.h Refactor TerminalApp and Add Tests for Xaml Content (#1164) 2019-07-15 14:27:56 -05:00
PowershellCoreProfileGenerator.cpp Collect all known PowerShell Core installations for dynamic profiles (#4273) 2020-01-31 04:17:21 +00:00
PowershellCoreProfileGenerator.h Collect all known PowerShell Core installations for dynamic profiles (#4273) 2020-01-31 04:17:21 +00:00
Profile.cpp Add cursorColor to color scheme (#4651) 2020-03-17 20:11:03 +00:00
Profile.h Add cursorColor to color scheme (#4651) 2020-03-17 20:11:03 +00:00
ShortcutActionDispatch.cpp Search - add search box control and implement search experience (#3590) 2019-12-17 15:52:37 +00:00
ShortcutActionDispatch.h Search - add search box control and implement search experience (#3590) 2019-12-17 15:52:37 +00:00
ShortcutActionDispatch.idl Search - add search box control and implement search experience (#3590) 2019-12-17 15:52:37 +00:00
Tab.cpp Fix scrollbar doesn't update viewport after window resize (#3344) 2020-02-10 23:15:30 +00:00
Tab.h Convert Tab to a WinRT type (#4350) 2020-02-04 21:51:11 +00:00
Tab.idl Convert Tab to a WinRT type (#4350) 2020-02-04 21:51:11 +00:00
TabRowControl.cpp Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.h Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TabRowControl.xaml Polish AutomationProperties and UIA Tree Navigation (#4805) 2020-03-05 22:32:46 +00:00
TelnetGenerator.h Create Telnet connection type and default loopback profile for… (#3858) 2019-12-09 11:07:08 -08:00
TerminalApp.def Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
TerminalApp.vcxproj Convert Tab to a WinRT type (#4350) 2020-02-04 21:51:11 +00:00
TerminalPage.cpp Add support for "reflow"ing the Terminal buffer (#4741) 2020-03-12 17:43:37 -07:00
TerminalPage.h Add a splitPane option to duplicate current profile (#4683) 2020-03-06 23:15:45 +00:00
TerminalPage.idl Add support for commandline args to wt.exe (#4023) 2020-01-27 15:34:12 +00:00
TerminalPage.xaml Enable dragging with the entire titlebar (#1948) 2019-07-18 17:21:33 -05:00
TerminalWarnings.h Add warning messages for bad keybindings (#4746) 2020-03-05 21:06:58 +00:00
TitlebarControl.cpp Unify and clean up the common build properties (#3429) 2019-11-05 14:29:11 -08:00
TitlebarControl.h Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TitlebarControl.idl Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
TitlebarControl.xaml Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
userDefaults.json Update stock user defaults to the list+defaults style (#4556) 2020-02-13 00:12:18 +00:00
Utils.cpp Fix a bunch of spelling errors across the project (#4295) 2020-02-10 20:40:01 +00:00
Utils.h Upgrade to Microsoft.UI.Xaml 2.2 (#3027) 2019-10-14 22:41:43 -07:00
WslDistroGenerator.cpp Force WslDistroGenerator to timeout after 10s and return Profiles (#4905) 2020-03-16 18:14:25 +00:00
WslDistroGenerator.h Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00