terminal/src/renderer
Michael Ratanapintha e6e316977d Clean up some misuses of INVALID_HANDLE_VALUE (fixes #427) (#1105)
Almost all functions in the Windows API that open or create objects and return HANDLEs to them return null on failure; only a few (mostly to do with the file system) return INVALID_HANDLE_VALUE on failure. This PR scrubs the repo of a few, but not necessarily all, cases where INVALID_HANDLE_VALUE was mistakenly used or tested against instead of null. In particular, it fixes 2 cases reported in issue #427 where the return value of CreateThread() was compared against INVALID_HANDLE_VALUE against null, causing the error handling code to run at the wrong time.

There are a lot of other uses of INVALID_HANDLE_VALUE I found that looked questionable, but which I left alone. Most of these were used to initialize HANDLE-typed variables and as a sentinel to see if those variables remained unset to a "real" value.

Fixes #427
2019-06-04 13:23:42 -07:00
..
base Fix #936: misuse of uninitialized objects causes AppVerifier breaks on Windows Terminal startup (#1015) 2019-05-28 16:56:36 +00:00
dx Use a ComPtr to avoid leaking font. (#1063) 2019-05-30 15:54:46 +00:00
gdi Clean up some misuses of INVALID_HANDLE_VALUE (fixes #427) (#1105) 2019-06-04 13:23:42 -07:00
inc Fix it's versus its typo. (#911) 2019-05-21 06:15:44 +00:00
vt Fix a bunch of static analysis issues (#553) 2019-05-23 10:35:30 -07:00
wddmcon inbox: Synchronize the font between the WDDMCon Renderer and the SCREEN_INFORMATION (#1089) 2019-05-31 17:59:07 -07:00
dirs Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00