terminal/src
Michael Kitzan a47a53c893 GetGuid noexcept Fix (#3806)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Fixed the noexcept specifier on `GetGuid`, and corrected `FindProfile` and `FindGuid` so they don't throw. Also, adjusted `SettingsTests` to reflect these changes.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #3763
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Tests added/passed updated a test group in `SettingsTests`
* [ ] Requires documentation to be updated
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3763

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
The `noexcept` specifier on `GetGuid` was not removed when `Profile` was [updated](https://github.com/microsoft/terminal/issues/3763#issuecomment-559497094) to `std::optional<GUID>`. This PR fixes that and modifies two helper functions `FindProfile` and `FindGuid` in `CascadiaSettings` to work correctly if `GetGuid` does throw. 

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Updated the `TestHelperFunctions` test group in `SettingsTests` and made sure the tests pass.
2019-12-03 19:05:41 +00:00
..
buffer Integrate inbox changes up to 68d3b53286dd 2019-12-02 17:24:26 -08:00
cascadia GetGuid noexcept Fix (#3806) 2019-12-03 19:05:41 +00:00
host Integrate inbox changes up to 68d3b53286dd 2019-12-02 17:24:26 -08:00
inc Upgrade UiaProviders to WRL::ComPtr (#3051) 2019-11-21 16:08:37 -08:00
interactivity Integrate inbox changes up to 68d3b53286dd 2019-12-02 17:24:26 -08:00
internal Unify and clean up the common build properties (#3429) 2019-11-05 14:29:11 -08:00
propsheet Integrate inbox changes up to 68d3b53286dd 2019-12-02 17:24:26 -08:00
propslib Unify and clean up the common build properties (#3429) 2019-11-05 14:29:11 -08:00
renderer Introduce a Universal package for Windows Terminal (#3236) 2019-11-25 16:30:45 -08:00
server Revert locking changes (#3488) 2019-11-08 13:44:52 -08:00
terminal Integrate inbox changes up to 68d3b53286dd 2019-12-02 17:24:26 -08:00
testlist inbox: Merge accumulated build fixes from RS_ONECORE_DEP_ACIOSS (#1002) 2019-05-24 12:28:30 -07:00
tools Unify and clean up the common build properties (#3429) 2019-11-05 14:29:11 -08:00
tsf Unify and clean up the common build properties (#3429) 2019-11-05 14:29:11 -08:00
types Upgrade UiaProviders to WRL::ComPtr (#3051) 2019-11-21 16:08:37 -08:00
winconpty Force the use of the static pseudoconsole functions in TConn (#3582) 2019-11-15 17:02:38 -08:00
common.build.post.props Tree-shake the library link list (#3631) 2019-11-20 09:44:23 -08:00
common.build.pre.props Replace ConhostConnection with ConptyConnection (#3461) 2019-11-06 15:09:01 -08:00
common.build.tests.props Refactor TerminalApp and Add Tests for Xaml Content (#1164) 2019-07-15 14:27:56 -05:00
ConsolePerf.regions.xml Tab to spaces (#578) 2019-05-13 18:06:36 -07:00
ConsolePerf.wprp Tab to spaces (#578) 2019-05-13 18:06:36 -07:00
cppwinrt.build.post.props Unify and clean up the common build properties (#3429) 2019-11-05 14:29:11 -08:00
cppwinrt.build.pre.props Introduce a Universal package for Windows Terminal (#3236) 2019-11-25 16:30:45 -08:00
dirs Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
project.inc Sync with latest inbox changes 2019-10-17 15:11:07 -07:00
project.unittest.inc inbox: merge refactoring payload from FI 2019-06-11 17:01:26 -07:00
StaticAnalysis.ruleset Combined changes to make the build work again (see inside) (#2945) 2019-09-30 10:39:55 -07:00
unit.tests.x64.runsettings Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
unit.tests.x86.runsettings Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
wap-common.build.post.props Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
wap-common.build.pre.props Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00