terminal/src/cascadia
Mike Griese c30ef6d30b
Don't explode name-only profiles (#2789)
* Add a test for #2782

* Attempt to do something weird with _GenerateStub

  I was thinking maybe we have the stubs have a GUID included. I like that less though I think. That would mean that DPGs would always have the GUID generated for them, even if the DPG doesn't specify a GUID. I guess that's fine though. No DPG's _aren't_ generating names now so this shouldn't change anything.

* Add some more notes on why this was a bad idea

* Actually fix the issue at hand

  If the profile doesn't have a guid, it's a name-only profile.
  During validation, we'll generate a GUID for the profile, but
  validation occurs after this. We should ignore these types of
  profiles.
  If a dynamic profile was generated _without_ a GUID, we also
  don't want it serialized here. The first check in
  Profile::ShouldBeLayered checks that the profile hasa guid. For a
  dynamic profile without a GUID, that'll _never_ be true, so it
  would be impossible to be layered.

* Revert "Add some more notes on why this was a bad idea"

This reverts commit 85b8b8a53c.

* Revert "Attempt to do something weird with _GenerateStub"

This reverts commit f204b98177.

* Little test fixes

* Update src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
2019-09-17 10:20:52 -07:00
..
CascadiaPackage Add Cascading User + Default Settings (#2515) 2019-09-16 12:57:10 -07:00
inc Don't copy text if there's no selection (#2446) 2019-08-16 15:43:51 -07:00
LocalTests_TerminalApp Don't explode name-only profiles (#2789) 2019-09-17 10:20:52 -07:00
TerminalApp Don't explode name-only profiles (#2789) 2019-09-17 10:20:52 -07:00
TerminalConnection Add some logging around startup, connection start timing (#2544) 2019-09-05 15:38:42 -05:00
TerminalControl Set Proper Background Color in HTML Copy (#2762) 2019-09-16 10:32:04 -07:00
TerminalCore Don't treat the Windows keys as input (#2514) 2019-08-23 10:56:26 -07:00
TerminalSettings Added CopyOnSelect as a Global Setting (#2152) 2019-08-20 16:42:17 +00:00
UnitTests_TerminalCore Added CopyOnSelect as a Global Setting (#2152) 2019-08-20 16:42:17 +00:00
ut_app Add Dynamic Profile Generators (#2603) 2019-09-16 13:34:27 -07:00
WindowsTerminal Add some logging around startup, connection start timing (#2544) 2019-09-05 15:38:42 -05:00