* Add a test for #2782 * Attempt to do something weird with _GenerateStub I was thinking maybe we have the stubs have a GUID included. I like that less though I think. That would mean that DPGs would always have the GUID generated for them, even if the DPG doesn't specify a GUID. I guess that's fine though. No DPG's _aren't_ generating names now so this shouldn't change anything. * Add some more notes on why this was a bad idea * Actually fix the issue at hand If the profile doesn't have a guid, it's a name-only profile. During validation, we'll generate a GUID for the profile, but validation occurs after this. We should ignore these types of profiles. If a dynamic profile was generated _without_ a GUID, we also don't want it serialized here. The first check in Profile::ShouldBeLayered checks that the profile hasa guid. For a dynamic profile without a GUID, that'll _never_ be true, so it would be impossible to be layered. * Revert "Add some more notes on why this was a bad idea" This reverts commit |
||
---|---|---|
.. | ||
CascadiaPackage | ||
inc | ||
LocalTests_TerminalApp | ||
TerminalApp | ||
TerminalConnection | ||
TerminalControl | ||
TerminalCore | ||
TerminalSettings | ||
UnitTests_TerminalCore | ||
ut_app | ||
WindowsTerminal |