maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia
History
Leonard Hecker d465a47bc5
Fix layering of sc() keybindings with vk() ones (#10917) 
The quake mode keybinding is bound to a scancode. This made it
impossible to override it with a vkey-based one like "win+\`".
This commit fixes the issue by making sure that a `KeyChord` always has a vkey,
and leveraging this fact inside ActionMap, which now ignores the scan-code.

## PR Checklist
* [x] Closes #10875
* [x] I work here
* [x] Tests added/passed

## Validation Steps Performed

* quake mode and other keybinding still work ✔️
* Repro settings from #10875 work correctly ✔️
2021-08-11 23:09:25 +00:00
..
CascadiaPackage Update Cascadia Code to 2106.17 (#10455) 2021-06-18 20:47:19 +00:00
inc Only access ControlInteractivity through the projection (#10051) 2021-07-19 11:59:30 -05:00
LocalTests_SettingsModel Fix layering of sc() keybindings with vk() ones (#10917) 2021-08-11 23:09:25 +00:00
LocalTests_TerminalApp Clamp the focusTab action to the number of available tabs (#10651) 2021-07-22 13:48:36 +00:00
PublicTerminalCore Fix output stuttering using a ticket lock (#10653) 2021-07-14 23:41:22 +00:00
Remoting Add logging, test for #10875 (#10907) 2021-08-11 15:20:15 +00:00
ShellExtension Set working directory when invoked from shell extension (#10546) 2021-07-09 18:53:52 +00:00
TerminalApp Adding/fixing Alt+Space handling (#10799) 2021-08-10 19:53:07 +00:00
TerminalAzBridge Switch Connections to use ValueSets to initialize them (#10184) 2021-07-20 15:02:17 +00:00
TerminalConnection [DefApp] Move from Monarch multi instance servers to Peasant single instance servers (#10823) 2021-08-05 17:05:21 +00:00
TerminalControl Fix layering of sc() keybindings with vk() ones (#10917) 2021-08-11 23:09:25 +00:00
TerminalCore Adding/fixing Alt+Space handling (#10799) 2021-08-10 19:53:07 +00:00
TerminalSettingsEditor Update SUI tooltips from 'checked' to 'enabled' (#10885) 2021-08-09 17:29:04 +00:00
TerminalSettingsModel Fix layering of sc() keybindings with vk() ones (#10917) 2021-08-11 23:09:25 +00:00
UnitTests_Control Allow ThrottledFunc to work on different types of dispatcher (#10187) 2021-08-09 15:21:59 +00:00
UnitTests_Remoting Fix building with v143 toolchain (#10727) 2021-07-20 19:00:49 +02:00
UnitTests_TerminalCore Adding/fixing Alt+Space handling (#10799) 2021-08-10 19:53:07 +00:00
ut_app Restore embedded manifests to say 18362 (#10370) 2021-06-09 16:23:26 +00:00
WindowsTerminal Fix layering of sc() keybindings with vk() ones (#10917) 2021-08-11 23:09:25 +00:00
WindowsTerminal_UIATests Enable /Zc:preprocessor (#10593) 2021-07-13 23:00:11 +00:00
WindowsTerminalUniversal Update Xaml Toolkit App Host to 6.1.3 (#10640) 2021-07-12 22:58:02 +00:00
WinRTUtils Allow ThrottledFunc to work on different types of dispatcher (#10187) 2021-08-09 15:21:59 +00:00
WpfTerminalControl wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
WpfTerminalTestNetCore wpf: make sure to pack api-ms-win-core-synch-l1-2-0 (#10587) 2021-07-08 10:31:59 -05:00
wt Upgrade Windows SDK to 19041 (#10118) 2021-05-20 16:04:25 +00:00
CascadiaResources.build.items Update Cascadia Code to 2106.17 (#10455) 2021-06-18 20:47:19 +00:00