maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src/cascadia/WindowsTerminal
History
Leonard Hecker d465a47bc5
Fix layering of sc() keybindings with vk() ones (#10917) 
The quake mode keybinding is bound to a scancode. This made it
impossible to override it with a vkey-based one like "win+\`".
This commit fixes the issue by making sure that a `KeyChord` always has a vkey,
and leveraging this fact inside ActionMap, which now ignores the scan-code.

## PR Checklist
* [x] Closes #10875
* [x] I work here
* [x] Tests added/passed

## Validation Steps Performed

* quake mode and other keybinding still work ✔️
* Repro settings from #10875 work correctly ✔️
2021-08-11 23:09:25 +00:00
..
AppHost.cpp Add logging, test for #10875 (#10907) 2021-08-11 15:20:15 +00:00
AppHost.h Introduce vk() and sc() key chord specifiers (#10666) 2021-07-20 22:34:51 +00:00
BaseWindow.h Add tray icon when quake window is minimized (#10179) 2021-07-08 08:25:43 -07:00
CustomWindowMessages.h Add tray icon when quake window is minimized (#10179) 2021-07-08 08:25:43 -07:00
icon.cpp Add tray icon when quake window is minimized (#10179) 2021-07-08 08:25:43 -07:00
icon.h Add tray icon when quake window is minimized (#10179) 2021-07-08 08:25:43 -07:00
IslandWindow.cpp Fix layering of sc() keybindings with vk() ones (#10917) 2021-08-11 23:09:25 +00:00
IslandWindow.h Add logging, test for #10875 (#10907) 2021-08-11 15:20:15 +00:00
main.cpp Adding/fixing Alt+Space handling (#10799) 2021-08-10 19:53:07 +00:00
NonClientIslandWindow.cpp Account for the window frame when calculating initial position (#10902) 2021-08-09 18:27:20 +00:00
NonClientIslandWindow.h Account for the window frame when calculating initial position (#10902) 2021-08-09 18:27:20 +00:00
packages.config Update Xaml Toolkit App Host to 6.1.3 (#10640) 2021-07-12 22:58:02 +00:00
pch.cpp Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
pch.h Add tray icon when quake window is minimized (#10179) 2021-07-08 08:25:43 -07:00
resource.h Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00
VirtualDesktopUtils.cpp Add desktop param to globalSummon; set _quake = toCurrent (#9954) 2021-04-28 17:25:48 -05:00
VirtualDesktopUtils.h Add desktop param to globalSummon; set _quake = toCurrent (#9954) 2021-04-28 17:25:48 -05:00
WindowsTerminal.def Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
WindowsTerminal.manifest Restore embedded manifests to say 18362 (#10370) 2021-06-09 16:23:26 +00:00
WindowsTerminal.rc Update WT's icon at runtime to match high-contrast as applicable (#7971) 2020-10-28 00:39:38 +00:00
WindowsTerminal.vcxproj Update Xaml Toolkit App Host to 6.1.3 (#10640) 2021-07-12 22:58:02 +00:00