e9a3fe5578
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds a simple helper function to look up the GUID associated with a profile name. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3680 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed. Yes, new test group in `SettingsTests`! * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3680 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Very simple function, for-each through profiles checking for a match. Returns the associated GUID if found, else returns the null GUID. This function is marked as `noexcept` to comply with assumption made by other `CascadiaSettings` functions that [`Profiles::GetGuid`](https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/Profile.cpp#L141) does not throw, despite it throwing. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed The new function is simple and can be visually validated, but added tests regardless. A new test group was added in `SettingsTests` called `TestHelperFunctions` to validate the new function `FindGuid` and older function `FindProfile`. This test group could be used to validate more helper functions in `CascadiaSettings` as they're added. The new test group passes after running `te.exe TerminalApp.LocalTests.dll`. -------------------------------------------- * Added FindGuid helper function * Style change * Tests for FindGuid and FindProfile * Fixed code format? * Code format guess No feedback from the Azure pipeline * optional<GUID> fix * Updated function desc |
||
---|---|---|
.. | ||
lib | ||
Resources/en-US | ||
ActionAndArgs.cpp | ||
ActionAndArgs.h | ||
ActionArgs.cpp | ||
ActionArgs.h | ||
ActionArgs.idl | ||
App.base.h | ||
App.cpp | ||
App.h | ||
App.idl | ||
App.xaml | ||
AppActionHandlers.cpp | ||
AppKeyBindings.cpp | ||
AppKeyBindings.h | ||
AppKeyBindings.idl | ||
AppKeyBindingsSerialization.cpp | ||
AppLogic.cpp | ||
AppLogic.h | ||
AppLogic.idl | ||
AzureCloudShellGenerator.cpp | ||
AzureCloudShellGenerator.h | ||
CascadiaSettings.cpp | ||
CascadiaSettings.h | ||
CascadiaSettingsSerialization.cpp | ||
ColorScheme.cpp | ||
ColorScheme.h | ||
DefaultProfileUtils.cpp | ||
DefaultProfileUtils.h | ||
defaults.json | ||
FixVisualStudioBug.targets | ||
GlobalAppSettings.cpp | ||
GlobalAppSettings.h | ||
IDynamicProfileGenerator.h | ||
init.cpp | ||
JsonUtils.cpp | ||
JsonUtils.h | ||
KeyChordSerialization.cpp | ||
KeyChordSerialization.h | ||
LegacyProfileGeneratorNamespaces.h | ||
MinMaxCloseControl.cpp | ||
MinMaxCloseControl.h | ||
MinMaxCloseControl.idl | ||
MinMaxCloseControl.xaml | ||
packages.config | ||
Pane.cpp | ||
Pane.h | ||
pch.cpp | ||
pch.h | ||
PowershellCoreProfileGenerator.cpp | ||
PowershellCoreProfileGenerator.h | ||
Profile.cpp | ||
Profile.h | ||
ShortcutActionDispatch.cpp | ||
ShortcutActionDispatch.h | ||
ShortcutActionDispatch.idl | ||
Tab.cpp | ||
Tab.h | ||
TabRowControl.cpp | ||
TabRowControl.h | ||
TabRowControl.idl | ||
TabRowControl.xaml | ||
TerminalApp.def | ||
TerminalApp.vcxproj | ||
TerminalPage.cpp | ||
TerminalPage.h | ||
TerminalPage.idl | ||
TerminalPage.xaml | ||
TerminalWarnings.h | ||
TitlebarControl.cpp | ||
TitlebarControl.h | ||
TitlebarControl.idl | ||
TitlebarControl.xaml | ||
userDefaults.json | ||
Utils.cpp | ||
Utils.h | ||
WslDistroGenerator.cpp | ||
WslDistroGenerator.h |