maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Don't re-encode markdown styles http uris

Browse source 
Fixes #60742

These uris should already be encoded. Don't try encoding them again which may cause the uri to become invalid
This commit is contained in:
Matt Bierner 2018-10-17 18:49:18 -07:00
parent 481e001d0b
commit 1b812bade4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
extensions/markdown-language-features/src/features/previewContentProvider.ts
View file

@ -104,7 +104,7 @@ export class MarkdownContentProvider {
// Use href if it is already an URL
const hrefUri = vscode.Uri.parse(href);
if (['http', 'https'].indexOf(hrefUri.scheme) >= 0) {
return hrefUri.toString();
return hrefUri.toString(true);
}
// Use href as file URI if it is absolute
@ -131,7 +131,7 @@ export class MarkdownContentProvider {
private computeCustomStyleSheetIncludes(resource: vscode.Uri, config: MarkdownPreviewConfiguration): string {
if (Array.isArray(config.styles)) {
return config.styles.map(style => {
return `<link rel="stylesheet" class="code-user-style" data-source="${style.replace(/"/g, '&quot;')}" href="${this.fixHref(resource, style)}" type="text/css" media="screen">`;
return `<link rel="stylesheet" class="code-user-style" data-source="${style.replace(/"/g, '&quot;')}" href="${this.fixHref(resource, style).replace(/"/g, '&quot;')}" type="text/css" media="screen">`;
}).join('\n');
}
return '';