fix #2400 Check that the user is internet-connected before loading the getting started page
This commit is contained in:
parent
77d07b0156
commit
46234232d9
|
@ -32,7 +32,7 @@ export abstract class AbstractGettingStarted implements IWorkbenchContribution {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private handleWelcome(): void {
|
protected handleWelcome(): void {
|
||||||
let firstStartup = !this.storageService.get(AbstractGettingStarted.hideWelcomeSettingskey);
|
let firstStartup = !this.storageService.get(AbstractGettingStarted.hideWelcomeSettingskey);
|
||||||
|
|
||||||
if (firstStartup && this.welcomePageURL) {
|
if (firstStartup && this.welcomePageURL) {
|
||||||
|
|
|
@ -14,4 +14,11 @@ export class ElectronGettingStarted extends AbstractGettingStarted implements IW
|
||||||
protected openExternal(url: string) {
|
protected openExternal(url: string) {
|
||||||
shell.openExternal(url);
|
shell.openExternal(url);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
protected handleWelcome(): void {
|
||||||
|
//make sure the user is online, otherwise refer to the next run to show the welcome page
|
||||||
|
if(navigator.onLine) {
|
||||||
|
super.handleWelcome();
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
Loading…
Reference in a new issue