maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Hide outputs with visibility instead of display

Browse source 
This improves perceived performance when outputs are hidden by folding
This commit is contained in:
Matt Bierner 2021-04-01 12:13:42 -07:00
parent 470e37c3d8
commit a816fcfb6b
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
View file

@ -679,7 +679,7 @@ function webviewPreloads() {
} }
// don't hide until after this step so that the height is right // don't hide until after this step so that the height is right
cellOutputContainer.style.display = data.initiallyHidden ? 'none' : 'block'; cellOutputContainer.style.visibility = data.initiallyHidden ? 'hidden' : 'visible';
}); });
break; break;
case 'view-scroll': case 'view-scroll':
@ -692,7 +692,7 @@ function webviewPreloads() {
if (widget) { if (widget) {
widget.style.top = request.top + 'px'; widget.style.top = request.top + 'px';
if (request.forceDisplay) { if (request.forceDisplay) {
widget.parentElement!.style.display = 'block'; widget.parentElement!.style.visibility = 'visible';
} }
} }
} }
@ -702,11 +702,6 @@ function webviewPreloads() {
if (widget) { if (widget) {
widget.style.top = `${cell.top}px`; widget.style.top = `${cell.top}px`;
} }
const markdownPreview = document.getElementById(`${cell.id}`);
if (markdownPreview) {
markdownPreview.style.display = 'block';
}
} }
break; break;
@ -737,7 +732,7 @@ function webviewPreloads() {
enqueueOutputAction(event.data, ({ outputId }) => { enqueueOutputAction(event.data, ({ outputId }) => {
const container = document.getElementById(outputId)?.parentElement; const container = document.getElementById(outputId)?.parentElement;
if (container) { if (container) {
container.style.display = 'none'; container.style.visibility = 'hidden';
} }
}); });
break; break;
@ -745,7 +740,7 @@ function webviewPreloads() {
enqueueOutputAction(event.data, ({ outputId, top }) => { enqueueOutputAction(event.data, ({ outputId, top }) => {
const output = document.getElementById(outputId); const output = document.getElementById(outputId);
if (output) { if (output) {
output.parentElement!.style.display = 'block'; output.parentElement!.style.visibility = 'visible';
output.style.top = top + 'px'; output.style.top = top + 'px';
dimensionUpdater.update(outputId, { dimensionUpdater.update(outputId, {