iterate over suggestions only once, #95324

This commit is contained in:
Johannes Rieken 2020-04-17 09:05:58 +02:00
parent 8f1b2e5657
commit d1dfa5e91b

View file

@ -535,9 +535,12 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider
useFuzzyWordRangeLogic: this.client.apiVersion.lt(API.v390),
};
const items = entries
.filter(entry => !shouldExcludeCompletionEntry(entry, completionConfiguration))
.map(entry => new MyCompletionItem(position, document, entry, completionContext, metadata));
const items: vscode.CompletionItem[] = [];
for (let entry of entries) {
if (!shouldExcludeCompletionEntry(entry, completionConfiguration)) {
items.push(new MyCompletionItem(position, document, entry, completionContext, metadata));
}
}
return new vscode.CompletionList(items, isIncomplete);
}