Commit graph

77515 commits

Author SHA1 Message Date
Benjamin Pasero 041e4d9b1f fix smoke tests with stable build (fix #117420) 2021-02-23 19:04:51 +01:00
Rachel Macfarlane 763bfde29a Remove proposed API check for registerAuthenticationProvider, fixes #117427 2021-02-23 09:52:41 -08:00
Rachel Macfarlane ece247a4f7 Don't clear accounts badge on cancel, fixes #117357 2021-02-23 09:48:39 -08:00
Connor Peet 85cff833c2
testing: fix potential leak of projection instance
Refs https://github.com/microsoft/vscode/issues/116775
2021-02-23 08:57:50 -08:00
Connor Peet edc4abbc53
testing: fix MainThreadTesting disposable fishiness
Fixes https://github.com/microsoft/vscode/issues/117380
2021-02-23 08:57:50 -08:00
Alex Ross d5a62bbe06 Fix Ports view context menu when no item focused
Fixes #117393
2021-02-23 17:50:13 +01:00
Alex Ross 2d6cc94a7c Remove + action from Ports view title
Fixes #117402
2021-02-23 17:45:20 +01:00
Alex Ross c1488d86c5 Better row aria label in Ports view
Fixes #117404
2021-02-23 17:41:03 +01:00
rebornix cb3a048f5a leak of not used monaco editor in cell template 2021-02-23 08:31:54 -08:00
rebornix 28a40e373c fix #117300. 2021-02-23 08:15:09 -08:00
Eric Amodio c257135247 Removes extra command 2021-02-23 11:07:38 -05:00
Alex Ross e8351c2c2a Add better narration for + row in port table
Fixes #117405
2021-02-23 17:01:38 +01:00
Alex Ross c1fb9152a1 Better grouping on Ports context menu
Fixes #117410
2021-02-23 16:48:32 +01:00
Daniel Imms dda96b69bf Remove debug logs
Fixes #117365
2021-02-23 04:24:19 -08:00
Alex Ross 9c8882d8b7 Improve fix for #117246 2021-02-23 11:39:23 +01:00
Alex Ross 9ecd3fc302 Fix case with notification about un-forwarded port
Fixes #117246
2021-02-23 11:29:37 +01:00
Martin Aeschlimann ded52df565 enforce segments in contributed icon names (for #114942) 2021-02-23 11:01:53 +01:00
Benjamin Pasero 9d1e8fa608 window - log crash reason too 2021-02-23 10:40:58 +01:00
isidor 4ee5bfc4b1 untitle hint: add telemetry from 2021-02-23 09:49:05 +01:00
Alexandru Dima 13caeee492
Document context keys 2021-02-23 09:02:49 +01:00
Benjamin Pasero 91f4ebc32d
Remove code added to diagnose test only (#117244)
* remove test changes for #117032

* reduce test
2021-02-23 08:59:31 +01:00
Johannes Rieken 7222dfcffb exempt AuthenticationProvider from provider-naming rule 2021-02-23 08:38:37 +01:00
Eric Amodio 39b45dd9c0 Bumps version of github-browser 2021-02-23 02:28:27 -05:00
Benjamin Pasero e4364e5f5d fix #117254 2021-02-23 08:27:52 +01:00
Sandeep Somavarapu d2b24cd57b check if configuration is disposed 2021-02-23 07:46:33 +01:00
Rob Lourens bd74308b5a Revert "Merge pull request #117069 from microsoft/roblou/refactorKernel"
This reverts commit c159b34535, reversing
changes made to ba3bd11ac7.
2021-02-22 19:22:52 -08:00
Jackson Kearl 4673316a39 Fix #117284: Get started content becomes hidden on click 2021-02-22 19:16:59 -08:00
Jackson Kearl 6312db1e01 Fix #115041: Path to untitled file from search editor is wrong 2021-02-22 19:01:26 -08:00
Jackson Kearl d54923b7f8 Add manual override for getting started treatment opt-in 2021-02-22 18:43:55 -08:00
Matt Bierner b1831abf66 Fix folding of custom rendered markdown cells
Fixes #117262

Instead of looking at the folding state we should instead use `inputCollapsed`  property for folding
2021-02-22 18:41:53 -08:00
Matt Bierner b3a33306fb Add markdown emoji for testing in notebooks 2021-02-22 18:10:27 -08:00
Matt Bierner b22f8f1169 Fix virtual file system resource loading inside webviews
82af67ebce introduced a bug related to loading resources from virtual file systems (such as `git`) inside webviews. The root cause is that a `VSBuffer` was moved into an object for ipc, and this caused it to not be serialized and restored properly
2021-02-22 18:00:17 -08:00
Jackson Kearl 69c0ce82f8 Add logging to better understrand getting started experiment rollout. 2021-02-22 17:47:23 -08:00
Rob Lourens c159b34535
Merge pull request #117069 from microsoft/roblou/refactorKernel
Move kernel/execution code out of NotebookEditorWidget for testability
2021-02-22 17:00:10 -08:00
rebornix ba3bd11ac7 fix kernel cache and add unit test for kernel reg. 2021-02-22 16:56:31 -08:00
Rob Lourens 1fd9f9eb28 Update test for api 2021-02-22 16:39:37 -08:00
Connor Peet eff172b7dd
testing: better documentation in .d.ts 2021-02-22 16:38:28 -08:00
Connor Peet 9cd0f2e8a4
testing: fixes if no document hierarchy is provided 2021-02-22 16:38:27 -08:00
deepak1556 e4a082af7f chore: bump electron@11.3.0
Fixes https://github.com/microsoft/vscode/issues/112693
Fixes https://github.com/microsoft/vscode/issues/116260
2021-02-22 16:26:18 -08:00
Rob Lourens 4ae248a013 Remove leftover "runnable" 2021-02-22 16:16:23 -08:00
Rob Lourens ce45b0d004 Infer cell "runnable" from notebook kernel state
Fix #106747
2021-02-22 16:15:26 -08:00
Rob Lourens 65711c63da Begin eliminating cell runnable metadata
#106747
2021-02-22 16:13:38 -08:00
Rob Lourens b9f20c79cb Move kernel/execution code out of NotebookEditorWidget for testability 2021-02-22 16:13:38 -08:00
Matt Bierner 6a9f8ac758 Rename markdown math extension to notebook-markdown-extensions
We will use this to experiment with different types of extensions, not just math
2021-02-22 16:07:48 -08:00
Rachel Macfarlane 6a6b9a5cc8 Possible fix for #115918 2021-02-22 15:44:38 -08:00
Eric Amodio a1f638e838 Changes welcome views lifecycle to Restored
This considerably reduces the time for welcome views to show up on views
2021-02-22 18:39:14 -05:00
Peng Lyu 08eac1a22d
Merge pull request #117204 from microsoft/rebornix/nb-selections
Notebook selections/CellRange
2021-02-22 16:25:10 -07:00
Rachel Macfarlane 67ded11020 Add authentication provider registration to stable API, closes #88309 2021-02-22 15:14:32 -08:00
Matt Bierner b6377b8e71 Handle promise cancelled for codeActionModel
Fixes #114031

This handles the case where an external caller is waiting on the actions, but the model is disposed. In this case, we should return an empty code action set instead of throwing an exception
2021-02-22 15:03:13 -08:00
Daniel Imms 2b44e04c10
Merge pull request #117292 from microsoft/tyriar/combined_id
Encode pty host id into terminal id
2021-02-22 14:55:39 -08:00