Matt Bierner
474d4951d8
Switch to dompurify for sanitizing markdown content ( #131950 )
...
* Switch to dompurify for sanitizing markdown content
Switches us from using `insane` to instead use `dompurify`, which seems to be better maintained and also has some nice features, such as built-in trusted types support
I've tried to port over our existing sanitizer settings as best as possible, but there's not always a 1:1 mapping between how insane works and how dompurify does. I'd like to get this change in early in the iteration to catch potential regressions
* Remove logging and renaming param
* Move dompurify to browser layer
* Fixing tests and how we check valid attributes
* Allow innerhtml in specific files
* Use isEqualNode instead of checking innerHTML directly
innerHTML can return different results on different browsers. Use `isEqualNode` instead
* Reapply fix for trusted types
* Enable ALLOW_UNKNOWN_PROTOCOLS
I beleive this is required since we allow links to commands and loading images over remote
* in -> of
* Fix check of protocol
* Enable two more safe tags
2021-09-03 12:17:02 -07:00
Logan Ramos
82a3d2645f
Skip tabs test
2021-09-03 14:56:52 -04:00
rebornix
94f8309414
separate internal notebook editor api
2021-09-03 11:39:37 -07:00
rebornix
96be44fe33
Common notebook editor delegate
2021-09-03 11:39:37 -07:00
Tyler Leonhardt
155460920b
only run language detection of extension-less files if it has plaintext mode (ref #132173 )
2021-09-03 11:33:16 -07:00
Logan Ramos
5d7f4d3461
Add todo and remove test.only
2021-09-03 14:29:28 -04:00
SteVen Batten
4e37c907d2
temp fix for #132238
2021-09-03 10:55:49 -07:00
Logan Ramos
22ca6611bd
Add get tabs tests
2021-09-03 13:47:01 -04:00
rebornix
330ef435e2
remove side by side editor input.
2021-09-03 10:05:27 -07:00
Benjamin Pasero
f8eb737b82
loader - configure path to be node_modules.asar ( #130302 )
2021-09-03 18:44:49 +02:00
Logan Ramos
fc1a1e8f13
Up distro
2021-09-03 09:26:16 -04:00
Johannes Rieken
70e30bc64e
disable flaky/failing smoketest, https://github.com/microsoft/vscode/issues/132233
2021-09-03 11:38:14 +02:00
Benjamin Pasero
bf0a66f7f2
🆙 distro
2021-09-03 11:33:50 +02:00
Benjamin Pasero
3a4e16cac1
tests - skip release notes
2021-09-03 11:32:11 +02:00
Benjamin Pasero
66f523d9b0
web - iOS tweaks for playground
2021-09-03 11:19:19 +02:00
Johannes Rieken
796afd5237
fix https://github.com/microsoft/vscode/issues/132113
2021-09-03 10:50:45 +02:00
Johannes Rieken
d1353440df
use latest version of references view, https://github.com/microsoft/vscode/issues/15533
2021-09-03 10:45:11 +02:00
Benjamin Pasero
f6de4ed250
web - fix welcome banner icon
2021-09-03 09:58:07 +02:00
Benjamin Pasero
a3acef919f
smoke - ignore any failure from capturing screenshot
2021-09-03 09:31:01 +02:00
Benjamin Pasero
3084de82e9
editors - deprecate typed openEditor and add IEditorGroupService.sideGroup ( #127747 )
2021-09-03 09:05:19 +02:00
Benjamin Pasero
6b9d5150dc
editors - reduce deprecated method usages ( #127747 )
2021-09-03 08:14:14 +02:00
Benjamin Pasero
2d50df638c
editors - less use of EditorInput, more use of IEditorInput
2021-09-03 07:52:55 +02:00
Benjamin Pasero
aeb2840610
editors - tweak side by side matches method when editors are the same
2021-09-03 07:36:09 +02:00
Benjamin Pasero
c54650cb45
editors - implement new text editor service and adopt ( #126960 )
2021-09-03 07:17:17 +02:00
Matt Bierner
aec6ee09fa
Remove eslint disablement in file
...
" -> '
2021-09-02 16:58:01 -07:00
rebornix
b3e806de3e
📓 remove dup
2021-09-02 16:12:24 -07:00
rebornix
f73e32d809
remove unused typings.
2021-09-02 16:12:24 -07:00
meganrogge
c765e70cf9
fix #132150
2021-09-02 15:39:55 -07:00
rebornix
68f08eef13
readonly properties.
2021-09-02 14:58:18 -07:00
rebornix
ee8dee737b
notebook editor widget eventing.
2021-09-02 14:53:07 -07:00
rebornix
a9a8b21215
for loop on notebook editor widget.
2021-09-02 14:39:12 -07:00
rebornix
e5b11d6ae6
notebookEditor.onDidChangeViewCells
2021-09-02 14:31:08 -07:00
rebornix
1fff1ef8ec
hide notebookEditorWidget.viewModel
2021-09-02 14:31:08 -07:00
rebornix
714279b5a5
use for loop for view cells.
2021-09-02 14:31:07 -07:00
rebornix
b98b6fdea6
fix testNotebookEditor.
2021-09-02 14:31:07 -07:00
Matt Bierner
0e52275271
Introduce WebviewOptions.forms
...
Fixes #132157
2021-09-02 13:24:49 -07:00
Rob Lourens
bad6e9309b
Don't override saveBeforeStart default value
...
See microsoft/vscode-jupyter#6898
2021-09-02 13:01:06 -07:00
meganrogge
71830d5896
don't use webgl on safari for now
2021-09-02 12:37:29 -07:00
Jean Pierre
b6abf68272
Fixes #130110 ( #131211 )
2021-09-02 12:19:38 -07:00
Logan Ramos
fe53ae0c9f
Add side by side editor to tab api proposal
2021-09-02 15:17:58 -04:00
Dirk Baeumer
8f7396616f
Correct syntax for indexing action
2021-09-02 20:47:18 +02:00
Dirk Baeumer
08b69512e6
Run indexing on release tags
2021-09-02 20:44:48 +02:00
meganrogge
4ba2acf430
fix #132024
2021-09-02 11:26:45 -07:00
Tyler James Leonhardt
50934523b3
sort by asc so that you look at the oldest opened issues first
2021-09-02 11:24:53 -07:00
Logan Ramos
36532d50bf
Fix #131692
2021-09-02 14:20:47 -04:00
Rob Lourens
58c83f27fa
💄
2021-09-02 11:05:13 -07:00
Rob Lourens
cdc8e53cf3
Add DebugSessionOptions suppressSaveBeforeStart
...
See microsoft/vscode-jupyter#6898
2021-09-02 11:05:13 -07:00
Connor Peet
a6e25d3604
fix test
2021-09-02 10:53:42 -07:00
Raymond Zhao
d474449fc2
Remove redundant check for #130407
2021-09-02 10:32:03 -07:00
Raymond Zhao
6dba2221f1
Fix API DT linter errors
2021-09-02 10:23:34 -07:00
