Commit graph

158 commits

Author SHA1 Message Date
Rob Lourens ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
al c93c73137e Add CLI flag to be able to disable smooth scroll in webviews 2018-12-20 01:44:00 +03:00
Benjamin Pasero 3e78e05f79 electron 3.0.x - --no-untrusted-code-mitigations does not seem to do anything 2018-12-19 19:24:45 +01:00
Benjamin Pasero 8e169b600b electron 3.0.x: use the --no-untrusted-code-mitigations flag
Since Electron 3 we use a V8 version that comes with untrusted code mitigations enabled by default (https://v8.dev/docs/untrusted-code-mitigations). This comes at a performance cost according to the blog. Since we do not execute untrusted code, we disable these mitigations.
2018-12-17 17:44:53 +01:00
Benjamin Pasero 0bcf5cff8a
Update to Electron 3.0.10 (#56149)
* update to 3.0.0-beta.3

* update d.ts files; rename NodeBuffer => Buffer

* update to 3.0.0-beta.4

* undo invalid change

* remove some Electron 2.0.x specific workarounds

* pinch zoom is now disabled by default

* update vscode-nsfw

* change vscode-nsfw

* update smoke test electron version

* streams: use destroy() over close()

* workaround broken tests

* bump distro and OSS

* try to bump node version for build

* update macOS build to use node.js 10.8.0

* fix extension tests

* use node.js 10.2.1 for all builds

* remove nsfw from dev dependencies

* back to node 8.x for build

* Revert "back to node 8.x for build"

This reverts commit 90ea2b7af2.

* update distro

* disable test run on macOS prod build for now

* bump distro

* ensure proper nsfw dep

* fix more native dependencies

* temp disable failing test

* fix packages

* update deps

* fix deps

* update deps

* enable macOS unit tests again

* fix deprecated buffer use

* Electron 3.0.0.beta.5

* bump deps

* fix tree accidentally treating auxclick as click

* improve overlay cleanup scheduler (fixes flicker seen with Electron 3.0.x)

* update distro

* remove obsolete disableBlinkFeatures: 'Auxclick'

* update to Electron 3.0 beta 6

* fix compile

* workaround #56994

* do not use backgroundColor to find shared process (causes flicker)

* fix flicker on windows from shared process background color

* webview - bubble up keyboard events (workaround for #56988)

* bump electron to 3.0.0-beta.8

* webview - fix deprecation

* webview - fix another deprecation

* debt - handle SIGPIPE on more processes

* workaround more webview focus issues (for #56988)

* webview - use proper way to focus()

* debt - avoid window-focus/blur and use native focus events instead

* webview - restore previous focus method

* webview - improve focus tracking (do not rely on DOM events)

* bump to electron 3.0.0-beta.9

* update deps

* update electron@3.0.0-beta.10

* webview - do not rely on DOM focus for certain commands (for #56988)

* update to electron@3.0.0-beta.11

* electron@3.0.0-beta.12

* update to beta 13

* update to electron 3.0.0

* update to Electron 3.0.1

* electron@3.0.2

* revert build changes (node.js version)

* try with: enable mojave dark mode support

* fix types

* electron 3.0.3

* electron@3.0.4

* fix deps

* bump electron@3.0.6

* bump electron@3.0.9

* fix strict null issue

* reset format

* bump electron@3.0.10

* fix strict null issue

* webview - print error when revive fails

* electron 3.0.x - try to fix keybindings in webviews (#64417)

* bump @types/node => ^10.12.12

* 💄

* update distro
2018-12-10 12:54:38 +01:00
Benjamin Pasero d38c5b86ce
storage - enable global storage, disable workspace storage migration (#64719) 2018-12-10 12:30:55 +01:00
Benjamin Pasero b9e55b7047 storage - put migration behind flag 2018-11-30 17:16:02 +01:00
Benjamin Pasero 5f6573f109 storage - better check for migration 2018-11-30 16:45:53 +01:00
Benjamin Pasero b638c6bdea storage - add global storage migration 2018-11-30 14:35:05 +01:00
HYEWON HWANG c5c0d68c16 Fix typo in comments 2018-11-02 11:26:25 -07:00
Joshua 21816902db Fixed typo in comment (#61909) 2018-10-26 16:47:50 -07:00
Rob Lourens 49ba5a4b9c Fix #60203 - VSCODE_NODE_CACHED_DATA_DIR can be inherited from the DA process. If --no-cached-data is passed, that var should be cleared 2018-10-18 08:59:20 -07:00
Johannes Rieken 0c2388a008 perf - simplify cached data env var (enabled cached data for the extension host) 2018-10-02 12:14:02 +02:00
Benjamin Pasero 93d2f24394 fix #59018 2018-09-20 09:16:47 +02:00
Benjamin Pasero 1e98303d91 bootstrap - move workbench.js to electron-code 2018-09-10 07:48:52 +02:00
Benjamin Pasero f3b191ab38 @ts-check for bootstrap JS files 2018-09-07 16:05:28 +02:00
Benjamin Pasero 1c92139469 fix ASAR bootstrap issue 2018-09-07 14:49:26 +02:00
Benjamin Pasero a4bf919e59
Cleanup bootstrap files (#58171)
* bootstrap  - first cut

* bootstrap => bootstrap-fork, bootstrap-shared => bootstrap

* bootstrap - extract uriFromPath()

* bootstrap - extract readfile/writefile

* bootstrap - share more code when loading renderers

* boostrap-electron-browser => bootstrap-window

* bootstrap - cleanup main.js

* bootstrap - handle index.js

* bootstrap 💄
2018-09-07 12:23:09 +02:00
Dirk Baeumer 4d49248401 Mark the VSCODE_NLS_CONFIG to have language pack support 2018-08-27 15:55:35 +02:00
Dirk Baeumer 56220afb7d Fixes #54819: Support English locales like en-gb, en-au 2018-08-13 15:26:36 +02:00
Benjamin Pasero 7ce26a4a24
Electron 2.0.7 (#56256)
* update to Electron 2.0.7

* disable ColorCorrectRendering (for #51791)
2018-08-13 13:31:52 +02:00
Johannes Rieken 4944cc2847 debt - remove last usages of globals and any-casts when it comes to perf marks 2018-08-13 13:03:35 +02:00
Daniel Imms 5dc414cbc9 Revert "Merge pull request #54854 from Microsoft/revert-52782-electron-2.0.x"
This reverts commit 90fc7e66e2, reversing
changes made to 3b25417fa2.
2018-07-23 07:34:16 -07:00
Sandeep Somavarapu 1dc23e548e
Revert "Update to Electron 2.0.x" 2018-07-23 10:58:49 +02:00
Benjamin Pasero 50f90e4275 Merge branch 'master' into electron-2.0.x 2018-07-09 17:40:32 +02:00
Benjamin Pasero 1741b575a0 update comment 2018-07-09 17:38:15 +02:00
Joao Moreno efba880587 remove app.getPath('userData') calls
fixes #53706
2018-07-09 15:04:03 +02:00
Dirk Baeumer 3c0abb8d8a Add support to regenerate nsl cache if corrupted. 2018-07-03 12:13:30 +02:00
Benjamin Pasero 59c29b42db Merge branch 'master' into electron-2.0.x 2018-06-29 14:53:43 +02:00
Joao Moreno e087b31199 use data folder for win32 and linux portable mode
fixes #53108
2018-06-27 15:27:32 +02:00
Benjamin Pasero 9459d2aae0 Update to Electron 2.0.x 2018-06-25 09:32:06 +02:00
Benjamin Pasero e47a9c9eef revert electron 2.0.x update 2018-06-25 09:28:34 +02:00
Johannes Rieken 7a42b91d1f make sure jsflags are send asap #52581 2018-06-21 16:03:44 +02:00
Johannes Rieken f5c83d60d9 fix main.js/mkdir #52581 2018-06-21 13:02:06 +02:00
Dirk Baeumer 04cc5794d1 Fixes #51982: Platform.locale doesn't always point to the requested locale as speced. 2018-06-19 10:44:55 +02:00
Joao Moreno e43ab4e4c4 portable mode 2018-06-18 20:04:03 +02:00
Joao Moreno 76f39b2ed1 remove console.log 2018-06-18 20:02:02 +02:00
Benjamin Pasero 2f9f501a3b electron 2.0.x: force srgb color profile 2018-06-18 14:41:31 +02:00
Joao Moreno 3d43c10398 portable: check folder 2018-06-18 10:09:50 +02:00
Joao Moreno 7c8a164902 product.portableTemp 2018-06-14 12:05:39 +02:00
Joao Moreno bd799550fe portable mode 2018-06-13 17:13:55 +02:00
Joao Moreno d631cb8076 main.js cleanup 2018-06-13 15:53:26 +02:00
Benjamin Pasero e7d29e9ccc
Electron v2.0.0 (#48290)
* Update to Electron 2.0-beta.7

* back to exploration build

* fix compile errors

* workaround build issue (go back to 1.24.0)

* bump to 1.25.0

* use electron 2.0.2

* revert custom distro
2018-06-08 18:32:49 +02:00
Dirk Baeumer 77082177db Fixes #48404: Perfer language packs over built in languages even for core languages 2018-04-23 16:54:28 +02:00
Daniel Imms 94f5674695 electron - save some changes that are OK with 1.7.x 2018-04-06 09:47:00 +02:00
Benjamin Pasero 24d87a7eb0 Revert "Update to Electron v2.0.0-beta.6 (#46552)"
This reverts commit 88603b377d.
2018-04-06 09:33:18 +02:00
Daniel Imms 88603b377d Update to Electron v2.0.0-beta.6 (#46552)
* electron@2.0.0-beta-1

* Update distro

* Update electron.d.ts to 2.0.0-beta.1

* Disable asar as it causes a native crash

* Adopt Module._resolveLookupPaths ASAR patch

* electron 2.x - restore inspector URL in extension host

* electron 2.x - adopt context menu callback for onHide

* electron 2.x - remove workaround for https://github.com/electron/electron/issues/10442

* electron 2.x - update node.d.ts

* electron 2.x - update node.d.ts to 8.9.x

* electron 2.x - keep node.d.ts changes to a minimum

* electron 2.x - remove workaround for https://github.com/electron/electron/issues/10862

* electron 2.x - bump to 2.0.0-beta2

* bump to 2.0.0-beta.3

* Context menu: selecting "Rename" does not put focs into rename box (fix #45601)

* quality "exploration" for easier testing

* empty commit

* push a workaround for #45700

* Certain themes show UI artifacts over activity bar icons (fixes #45700)

* better fix for #45700

* bump to 2.0.0-beta.4

* another fix to prevent flickering for #45700

* avoid remote access in index.js

* bump distro commit

* electron 2.x - do not use --debug anymore

* bump electron to 2.0.0-beta.5

* electron 2.x - add libgtk-3-dev as build dependency for Linux 64

* electron 2.x - workaround freeze on linux on startup

* bump local storage telemetry key

* electron 2.x - do a one time backup of local storage

* enable ELECTRON_ENABLE_LOGGING on macOS at least

* 2.0.0-beta.6

* Fix ctrl+shift+e not focusing explorer on Linux

* distro - use GH electron builds for now
2018-04-03 12:39:25 +02:00
Dirk Baeumer 87ac8b13b8 Fixed typo in variable name 2018-03-26 09:52:30 +02:00
Alex Dima e3ce029935 Prepare for node >= v8.0.0 2018-03-19 12:59:32 +01:00
Dirk Baeumer d4bace7f75 Fixes #45370: tr is not supported to load "Turkish Language Pack" 2018-03-13 11:11:23 +01:00
Benjamin Pasero 9b6c69c8c8 main - stackTraceLimit = 100 2018-03-13 07:40:00 +01:00
Peng Lyu 6729e2b7df --max-memory and fix test failture. 2018-02-13 15:12:07 -08:00
Peng Lyu 50a1deb9f6 Fix #42839. avoid ui freeze when file is larger than heap size limit. 2018-02-13 14:07:01 -08:00
Andre Weinand 00a339ebf4 make locale comparison case-unsensitive; fixes #42304 2018-02-02 10:37:05 +01:00
Dirk Baeumer 519088548b Fixes #42513: Startup Performance regressed 2018-02-01 15:03:05 +01:00
Dirk Baeumer e91b851ca8 Upgrade to latest language pack format 2018-01-30 00:11:57 +01:00
Alex Dima 9ef087d510 Merge remote-tracking branch 'origin/master' into alex/asar 2018-01-26 09:39:00 +01:00
Dirk Baeumer 04594c864b Add support for Language Packs 2018-01-25 21:14:34 +01:00
Alex Dima 9774c071fc Use node_modules.asar if present 2018-01-09 17:04:02 +01:00
Johannes Rieken c219c3f733 debt - remove appReady from timerService, use perf-marks 2017-12-13 11:18:04 +01:00
Johannes Rieken 52c2843cc4 redo --prof-startup with the new protocol based profiler, also profile extension host startup 2017-11-23 10:55:02 +01:00
Johannes Rieken b289f0c5e2 rename startupTimer to performance, support mark and measure, drop promise support, add more marks to slowly phase out old timers 2017-11-06 18:51:15 +01:00
Benjamin Pasero 962cd50222 remove LC_ALL and LC_NUMERIC workaround for chrome issue of fat SVGs 2017-08-21 11:54:24 +02:00
Joao Moreno ec463ce282 add eslint to hygiene 2017-06-20 16:22:17 +02:00
Benjamin Pasero 240cf011a1 VS code icons is distorted when invoked from the command line (fixes #28345) 2017-06-12 12:38:08 +02:00
Johannes Rieken 3e81316eab Revert "load main.js while waiting for app.isReady, #17108"
This reverts commit 174fafae53.
2017-06-09 10:34:35 +02:00
Michel Kaporin e1bb941c17 Removed handling multiple '--user-data-dir' as no need for Spectron any more #25291. 2017-05-19 15:31:56 +02:00
Benjamin Pasero 90dcda507a add workaround for #24820 2017-05-09 16:02:16 +02:00
Michel Kaporin f3ca4f6e09 Added handling for multiple '--user-data-dir' to enable Spectron smoke testing in #25291. 2017-05-09 12:06:05 +02:00
Johannes Rieken 174fafae53 load main.js while waiting for app.isReady, #17108 2017-05-04 17:14:33 +02:00
Benjamin Pasero a5d21e1bf5 add todo for electron update related workaround 2017-04-23 18:55:01 +02:00
Johannes Rieken 876c35b8cd use --nolazy when starting renderer processes, #25019 2017-04-21 11:06:02 +02:00
Benjamin Pasero 2fc83dbb7b workaround #9225 2017-04-19 10:37:56 +02:00
Johannes Rieken 510aaf6fb0 make commit id part of the cached data path, #23883 2017-04-05 09:21:02 +02:00
Johannes Rieken daad7f6fd3 rename flag to prof-startup 2017-03-01 15:58:30 +01:00
Johannes Rieken 2776a40eb4 create issue and show profile files 2017-03-01 15:57:48 +01:00
Johannes Rieken b76c8bea27 add performance-startup-profile flag 2017-03-01 15:56:55 +01:00
Johannes Rieken 6d879597f7 uglify is ugly! 2017-02-02 17:41:50 +01:00
Johannes Rieken 4cb2c7da7e getNodeCachedData ignores all errors, #19662 2017-02-02 17:16:49 +01:00
Christof Marti bb3bb0c773 Create parent folders if they do not exist yet (fixes #19529) 2017-01-27 11:52:26 -08:00
Johannes Rieken e953f08acf log app.isReady separately because I suspect it to be slow, #18087 2017-01-06 12:57:59 +01:00
Johannes Rieken df2faa21fa don't set env variable to undefined 2016-12-21 14:26:10 +01:00
Johannes Rieken fc66ce18cd don't depend on version when computing cached data dir for node 2016-12-21 12:46:01 +01:00
Johannes Rieken cac9aa411b use nodeCachedData for main process, #17108 2016-12-21 11:42:51 +01:00
Benjamin Pasero 409e81432a More performance telemetry (for #15559) (#15556) 2016-11-16 12:25:30 +01:00
Daniel Imms 835893e9d7 Fix relative user data dirs on Windows
Fixes #11735
2016-10-22 03:47:07 -07:00
Joao Moreno de7267dc4e update uglify. bubble errors. scoped eslint 2016-09-19 10:22:57 +02:00
Joao Moreno 69e8c7acbc buffer open-url requests
related to #10340
2016-09-16 12:21:46 +02:00
Daniel Imms 34a8572577 Resolve --user-data-dir before calling app.setPath
Fixes #11735
2016-09-12 11:53:18 -07:00
Joao Moreno cd2cccfbde use minimist for locale parsing
fixes #10655
2016-08-26 16:48:00 +02:00
Joao Moreno 088d4fb45a paths.getDefaultUserDataPath 2016-08-17 12:58:30 +02:00
Benjamin Pasero 549c1772fe no more process.argv dependency in environmentService 2016-08-17 11:16:02 +02:00
Joao Moreno e0d6db948f lint 2016-07-27 09:31:07 +02:00
Dirk Baeumer 60c4d040f3 Fixes #6002: Unknown locale value falls back to English, not OS locale 2016-05-20 15:23:15 +02:00
Joao Moreno e634302883 extract userData path computation 2016-05-04 11:26:38 +02:00
Joao Moreno e9f9aad3f8 fix bad JS 2016-05-04 11:26:38 +02:00
Joao Moreno 8a59d104d4 use strings for process.env 2016-05-02 18:54:07 +02:00
Joao Moreno ca4519a3b2 workbench/electron-main -> code/electron-main 2016-05-02 16:05:37 +02:00
Benjamin Pasero b43c950147 polish 2016-04-07 09:23:32 +02:00
Daniel Imms 6456f85788 Disallow running as root without --user-data-dir
This commit adds the --user-data-dir argument which allows a custom data dir
for Chromium's user data. This is useful when running as root on Linux since
the root user does not have read or write permissions for the ~/.config/Code
dir.

Part of #3068
2016-04-06 16:31:36 -07:00