Commit graph

67513 commits

Author SHA1 Message Date
Benjamin Pasero 68bf05a59c 🆙 distro 2020-06-22 09:43:32 +02:00
Benjamin Pasero 0fca6246e4 build - add web ignore file 2020-06-22 09:41:43 +02:00
Alex Dima a2668168b2
Merge remote-tracking branch 'origin/master' into alex/extension-host 2020-06-22 09:39:20 +02:00
Benjamin Pasero d4377111b1 remote paths - deprecate resolvedUserHome 2020-06-22 09:34:47 +02:00
Benjamin Pasero 7f132c907b debt - use platform over node.js OS 2020-06-22 09:04:56 +02:00
Benjamin Pasero 58912ddc1f pathService 💄 2020-06-22 09:00:43 +02:00
Benjamin Pasero 9aafd57c2c sandbox - fix build 2020-06-22 08:45:01 +02:00
Benjamin Pasero a2d0b1b308 sandbox - move clipboard service into sandbox 2020-06-22 08:28:11 +02:00
Benjamin Pasero c45374ebfb editors - fix issue with exception saving state 2020-06-22 08:10:30 +02:00
Daniel Imms 269f0fdd83
Merge pull request #100496 from microsoft/tyriar/link_providers
Proposed terminal link provider API
2020-06-21 18:46:24 -07:00
Daniel Imms a560acd1bd Remove test link provider 2020-06-21 18:01:33 -07:00
Daniel Imms 56358ffdbe Create process on reused terminals 2020-06-21 16:06:06 -07:00
João Moreno fad4d8d254
fixes #100524 2020-06-21 22:58:32 +02:00
rebornix 85677aecfe 📓 temp disable nb tests on windows. 2020-06-21 13:53:16 -07:00
João Moreno cd3a3ea6fa
address codeql review 2020-06-21 17:17:51 +02:00
Daniel Imms d26e0e211c Remove resolved TODO 2020-06-21 08:14:36 -07:00
Daniel Imms cb5ddcf44f Resolve todos, move process creation after xterm
Having _processManager.createProcess called before _createXterm was causing
some event listeners like onProcessReady to fire before they were registered
within _createXterm.
2020-06-21 08:12:13 -07:00
champignoom e125e0a4d5
stage ibus-gtk3 to try to make ibus work (#100480)
try to address #96041
2020-06-21 17:05:58 +02:00
João Moreno a036ab0399
remove coveralls 2020-06-21 17:03:51 +02:00
João Moreno af74999e03
fix rich nav build 2020-06-21 16:59:03 +02:00
Noelle Caldwell d36713b94f
removed rich nav trigger on PRs (#100417)
* removed trigger on PRs

* added repo-token

* prevent workflow failure with continue-on-error

* replicate ci build setup

* remove sudo commands and update with failing dependency

* move continue-on-error to steps

* remove manual node-gyp installation

* Update .github/workflows/rich-navigation.yml

Co-authored-by: João Moreno <mail@joaomoreno.com>
2020-06-21 16:56:45 +02:00
Daniel Imms 34b20f9609 Merge branch 'master' into tyriar/link_providers 2020-06-21 07:36:20 -07:00
Daniel Imms e16aead215 Move hover service into core workbench
Fixes #100637
2020-06-21 07:26:22 -07:00
Milo Moisson fc8b56a966
Update logging
Remove enter after console.log/warn/error.
Really ennoying...
2020-06-20 18:26:14 +02:00
Benjamin Pasero 9c142ea383 🆙 distro 2020-06-20 10:55:06 +02:00
Fedor Nezhivoi 24e0a82229
Move encoding to common for #79275 (#100539)
* move encoding.ts to common for #79275

* load iconv-lite-umd and jschardet in web version for #79275

* move EncodingOracle to the AbstractTextFileService for #79275

* review

* update to new iconv-lite-umd

* add workaround for jschardet types

* fix indentation

* add iconv-lite-umd and jschardet to workbench.html

* fix paths for modules

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2020-06-20 10:47:29 +02:00
Benjamin Pasero aa06a3d3b9 editors - add label property to file inputs 2020-06-20 09:55:02 +02:00
Benjamin Pasero 59aad0d061 Changing character casing in file name doesn't take effect in editor (fix #100436) 2020-06-20 09:51:37 +02:00
Benjamin Pasero f17030d3eb editors - adopt more extUri 2020-06-20 09:46:33 +02:00
Benjamin Pasero 49fc0feffb "You cannot save this document with extension..." Is this new? (fix #100241) 2020-06-20 09:43:43 +02:00
Matt Bierner 97650fb8f3
Let core command such as undo/redo be overridden by webviews and notebooks (#98288)
* Add CoreCommandService

For #90110

This change introduce a new service (`ICoreCommandService`) that lets high levels parts of the editor (such as webviews) hook into core commands such as undo and redo that are fired from the editor menus.

## Why is this needed?
To implement undo/redo in custom editors / webviews, we currently register special commands (`editor.action.customEditor.undo` and `editor.action.customEditor.redo`). This is not ideal since it means that users have to update multiple commands if they wish to rebind undo/redo

These custom command also are not invoked when the user goes to the `edit` menu and select `undo` or `redo`. Instead, the edit menu always calls the core `UndoCommand`

We cannot make `UndoCommand` know about custom editors because it lives in `base`

## What this change does?
This change adds a new `ICoreCommandService` that lets higher level parts of the editor override core commands such as undo and redo. We use a similar approach in the `IOpenerService`.

Right now only `undo` and `redo` are overridable. If this approach looks ok, we could also extend it to `copy`, `paste`, `cut`, and `select all`

* Add docs and clean up types

* Rework implementation

Switch from using a command service to having each command state if is overrideable or not.

This hooks up overrides for:

- Undo/redo
- cut/copy/paste

for webviews, custom editors, and notebooks

* Add ProxyCommand so that multiple registered commands can share a single implementation

* Fix compilation & missing file being referenced

* Introduce and adopt MultiCommand for Undo

* Adopt MultiCommand for Redo and SelectAll

* Adopt MultiCommand for Cut, Copy and Paste

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2020-06-19 16:54:22 -07:00
Sandeep Somavarapu 2c73c38a11 dispose always 2020-06-20 01:31:17 +02:00
Sandeep Somavarapu 200df81691 Fix #100314 2020-06-20 01:25:55 +02:00
Sandeep Somavarapu 2f6ef86931 Fix #100411 2020-06-20 01:25:55 +02:00
Martin Aeschlimann c93c29c357 code.sh: loosen check for WSL2 2020-06-19 23:42:58 +02:00
Alex Dima e7a15497fa
Enable local web worker extension host behind a flag 2020-06-19 22:41:02 +02:00
Eric Amodio 98b5bec6bc Fixes issue w/ the firstOpen setting on the web
Adds a safety-net check for Codespaces until the fix can be verified
2020-06-19 16:12:22 -04:00
Martin Aeschlimann c23285f8c8 [json] server path fix (for json-server npm) 2020-06-19 21:58:54 +02:00
Martin Aeschlimann 3acea34ca5 [css] custom data polishes 2020-06-19 21:58:54 +02:00
Martin Aeschlimann e32da59d30 [npm] support serverless & cleanup 2020-06-19 21:58:54 +02:00
deepak1556 d2f06fbcec chore: bump electron@8.3.3 2020-06-19 11:12:28 -07:00
Alex Dima 0fe4535726
Extract running location computation to separate method 2020-06-19 19:51:16 +02:00
Alex Dima 0b7d6cb40a
Simplify logic 2020-06-19 19:40:11 +02:00
Jackson Kearl 9206176f45 close #100588 2020-06-19 10:31:48 -07:00
Daniel Imms 439489fb3d Switch link priority so ext links are higher than builtin 2020-06-19 09:56:23 -07:00
Jackson Kearl d6620fa042 Add extCpp as alias for extC++ command. 2020-06-19 09:47:21 -07:00
Benjamin Pasero 102f0d06c7 Quick open: configuring a prefix selects it all (fix #100584) 2020-06-19 17:21:22 +02:00
Alex Dima c95f24bb56
Minor refactorings 2020-06-19 15:48:35 +02:00
Sandeep Somavarapu ba27193e45 Web extensions support
- Add package nls url to scanned extension
- Introduce scanner service for builtin extensions
- Introduce scanner service for web extensions
- Use web extensions scanner service in management and runtime
- Apply default translation inside management service
2020-06-19 15:14:01 +02:00
Daniel Imms 8a7c490b26 Add IHoverService.hideOnHover 2020-06-19 06:12:00 -07:00