Commit graph

67513 commits

Author SHA1 Message Date
Sandeep Somavarapu eefe7b942f move readme and changelog props to IExtension 2020-06-18 11:31:52 +02:00
Johannes Rieken c66ac0387c move perf data into separate file that's ignored by search, fyi @sandy081 2020-06-18 11:21:23 +02:00
Johannes Rieken cda677da09 make NotebookConcatTextDocument extends "normal" TextDocument, https://github.com/microsoft/vscode/issues/100186 2020-06-18 11:10:23 +02:00
Dirk Baeumer 0980b4d681 Fixes #96794: php.validate.executablePath - Unable to override in workspace 2020-06-18 10:37:24 +02:00
Johannes Rieken 3281da1ce5 notebook - set forceReload when having cell options 2020-06-18 09:56:06 +02:00
Benjamin Pasero 2a9f87c3ce editors - clarify clearInput 2020-06-18 09:13:43 +02:00
Benjamin Pasero 031bb964fc editors - call setEditorVisible before removing editor from DOM and thus remove onWillHide() method (fix #100271) 2020-06-18 08:44:35 +02:00
Benjamin Pasero 6f28d89503 editors - remove onDidHide method (#100271) 2020-06-18 08:23:17 +02:00
Benjamin Pasero 063ea11611 editors - no need to dispose custom inputs 2020-06-18 08:06:45 +02:00
Jackson Kearl 4d91d96e5e Add assignment monitor 2020-06-17 21:10:40 -07:00
rebornix 69acdd4e14 editor association should override priority. 2020-06-17 19:49:25 -07:00
rebornix e51bb9be57 fix unit test. 2020-06-17 18:31:53 -07:00
rebornix 6c68514534 Fix #100329. Content providers can contribute to undo/redo stack of a notebook document. 2020-06-17 17:08:09 -07:00
Jackson Kearl ba6892d6de Bump to latest GPU classifier 2020-06-17 17:07:26 -07:00
Matt Bierner 0d82ff9c29 Throw an exception if we try adding a listener when the webview element does not exist
This should not silently fail as doing so could cause the webview to not init properly
2020-06-17 16:37:35 -07:00
Matt Bierner 1b8c604ae7 Skip extra call to set html if the html is still empty 2020-06-17 16:35:20 -07:00
Matt Bierner 49f35453c4 Make doUpdateContent take a parameter 2020-06-17 16:24:37 -07:00
Matt Bierner f175c79373 Add logging around webview creation
For #98746

Logs a few of the important events around webview lifecycles to hopefully track down #98746
2020-06-17 16:03:29 -07:00
Matt Bierner 2c53ad120d Defer webview loading until all listeners have definitely been hooked up on
Since webviews load on a different process, it may be possible that they load and start firing events before we have hooked up all the listeners we are interested in.

To fix, this defer setting the actual content on the webview until the listeners have been hooked up for sure

Possible cause of #98746 but since I can't repo  I can't confirm
2020-06-17 16:02:33 -07:00
Matt Bierner b95968eafb Don't include inline source maps in markdown preview scripts 2020-06-17 15:24:16 -07:00
Matt Bierner f7ec17d216
Move the webview port mapping from renderer to main process (#100342)
* Move the webview port mapping from renderer to main process

Fixes #95955

Our port mapping impl for webview currently relies on `getWebContents` to handle port mapping in the renderer process. This API has been deprecated by electron.

This change instead moves the webview port mapping handler to the main process. To make this change, I also realized that the tunnel service needed to be moved from `vs/workbench` to `vs/platform` so that we could consume it from the main process

Other changes made as part of this refactoring:

-  Register all webview in a `webview` partition. This ensures that our port mapping manger only intercepts requests made inside webviews.

- Send the `webContentsId` to the main process. This is required to implement `onBeforeRequest`. Unfortunatly the referrer always seems to be undefined for these requests

- Have the tunnel service take a resolved authority instead of taking the raw authority. This was required due to the tunnel service moving to `vs/platform`

* Cleanup and adding url filter
2020-06-17 15:15:05 -07:00
Matt Bierner d7ae69e916 Pick up TS 3.9.5 2020-06-17 15:13:42 -07:00
Matt Bierner 9edf21fd74 Update to latest TS version 2020-06-17 15:12:03 -07:00
rebornix 43450e4f65 💄 private _. 2020-06-17 14:58:30 -07:00
rebornix b23cfbdf84 💄 notebookEditorInput 2020-06-17 14:50:47 -07:00
rebornix c6f1839894 💄 notebookEditorWidget. 2020-06-17 14:49:43 -07:00
rebornix 08a8355233 Fix #97547. absolute position for notebook outputs. 2020-06-17 14:31:47 -07:00
Daniel Imms 2dbf1703b8 Get link providers passing all the way through to the renderer 2020-06-17 12:10:03 -07:00
Rob Lourens 3c9728579b Normalize property names in notebooks - remove _ on privates when possible 2020-06-17 12:39:13 -05:00
Rob Lourens 8ba8383072 Fix build error in notebooks 2020-06-17 12:12:23 -05:00
Don Jayamanne 1de8e1da31
Do not save untitled notebooks (#100256) 2020-06-17 08:39:52 -07:00
Sandeep Somavarapu 6a7a91bc8c fix useless regex escape 2020-06-17 16:46:39 +02:00
Rob Lourens 8065690aa8 Make pref sync button themable
Fix #100312
2020-06-17 09:34:21 -05:00
Sandeep Somavarapu 7df9c59685 Fix escaping issues 2020-06-17 16:24:40 +02:00
Johannes Rieken 55bdf23690 💄 readonly when possible, public optional, classList over util 2020-06-17 16:12:43 +02:00
Sandeep Somavarapu 1e0d9e7a48 fix prototype pollution 2020-06-17 16:09:41 +02:00
Sandeep Somavarapu f0478e2c81 Fix #99890 #91139 2020-06-17 16:09:41 +02:00
Benjamin Pasero a653936973 tests - disable more flaky windows tests 2020-06-17 16:06:25 +02:00
Rob Lourens e1a503f119
Merge pull request #100304 from gjsjohnmurray/fix-71295
Fix #71295 Permit command URIs in markdownDescription of extension setting
2020-06-17 07:01:45 -07:00
Johannes Rieken 29767ccc1a notebook - simpler view state storing 2020-06-17 15:46:42 +02:00
Johannes Rieken 67579ce71b update reference viewlet 2020-06-17 15:18:51 +02:00
Rob Lourens 50b08736a8 preserve indentation in markdown cell code blocks
Fix #100340
2020-06-17 08:16:09 -05:00
Sandeep Somavarapu 2da2634cc9 Remember current machine name 2020-06-17 15:03:55 +02:00
Sandeep Somavarapu 476e179d0e more tests 2020-06-17 15:03:55 +02:00
Sandeep Somavarapu 0457cb19b5 add more tests 2020-06-17 15:03:55 +02:00
Sandeep Somavarapu 322bd6082d move auto sync logic from sync service to auto sync service 2020-06-17 15:03:55 +02:00
Sandeep Somavarapu 836bde41a2 push to branch 2020-06-17 15:03:55 +02:00
Johannes Rieken f14fa4d0b5
Merge pull request #100266 from microsoft/joh/notebook-inputs
Ref-count notebook models, rework notebook inputs
2020-06-17 14:36:38 +02:00
Johannes Rieken bb55416b41 make sure to return empty array when calling dispose-util with array 2020-06-17 14:34:22 +02:00
Alex Ross d52f137ed5 Return task execution early from executeTask
Fixes #100361
2020-06-17 13:54:21 +02:00