Commit graph

49748 commits

Author SHA1 Message Date
Aurélien Pupier 7a5bca9faf Add License field to package.jsons #68423 (#68771)
it should avoid to have "warning XXX: No license field" during yarn
build

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
2019-06-06 11:44:50 +02:00
isidor df9ad66def loaded scripts view: add type to not be an array of any 2019-06-06 11:25:13 +02:00
isidor 31221e6299 debug: map polish
#74948
2019-06-06 11:21:24 +02:00
isidor 683d774ed0 loaded scripts: use Map
#74948
2019-06-06 11:21:06 +02:00
isidor 54ad623f8b compositePart use Map
#74948
2019-06-06 10:55:25 +02:00
Sandeep Somavarapu 20ea43cad3 #74920 Use panel service to hide 2019-06-06 10:52:41 +02:00
isidor 4f3fccf0ea explorer: do not reveal file on refresh when autoReveal = false
fixes #74851
2019-06-06 10:37:27 +02:00
Matt Bierner b86bdf8a0b Fix TS order of initilization issue around dispose and _register
By overriding _register in this case, we could end up invoking this function on a subclass that had not actually been inited yet (when `_toDispose` has not been set). I believe the overriding was an accident, so the fix is to remove it
2019-06-06 01:31:31 -07:00
isidor d44c5f4731 panel part: First check if panel is visible and hide if so
fixes #74920
2019-06-06 10:21:34 +02:00
Sandeep Somavarapu 77127c8a57 reuse severity icons 2019-06-06 10:17:05 +02:00
Martin Aeschlimann 3ce5cb0e02 [css] enable tests (fixes #74937) 2019-06-06 09:49:55 +02:00
Martin Aeschlimann b77b0defc4 sourcemap: ignore node_modules 2019-06-06 09:42:56 +02:00
Martin Aeschlimann 29daecda2e [css] add test resources 2019-06-06 09:30:58 +02:00
Benjamin Pasero fc294b683d Comment out failing test 2019-06-06 07:42:18 +02:00
Matt Bierner bd39f3d7a1 Revert disposing of emitter change for extHostQuickOpen since it was breaking integration tests 2019-06-05 19:30:04 -07:00
Daniel Imms b7f31aa595 Refactor shell config into common 2019-06-05 19:03:00 -07:00
Daniel Imms 9db001aa40 Localize Terminal strings inside TerminalInstance 2019-06-05 18:53:42 -07:00
Daniel Imms 7d97f6e02f Move TerminalProcessManager init into instance 2019-06-05 18:42:17 -07:00
SteVen Batten 22e00149f1 update menu and titlebar platform checks 2019-06-06 00:32:35 +00:00
Matt Bierner 619851fe2e Don't use Symbol
Not supported by ie11 for monaco
2019-06-05 16:29:55 -07:00
Matt Bierner 2641bd536d Adding disposable tracking helpers 2019-06-05 16:11:13 -07:00
Matt Bierner 139d51aec4 Use Disposable.None 2019-06-05 16:11:13 -07:00
Matt Bierner f94d5ba08e Fix merge conflict 2019-06-05 16:11:13 -07:00
Matt Bierner d57db50463 Fixing a few possible leaked disposables 2019-06-05 15:42:26 -07:00
Matt Bierner 3d3f1bae93 Fixing a few more dispoable cases 2019-06-05 15:42:26 -07:00
Matt Bierner 8de04a7442 Use map for storing registry values 2019-06-05 15:42:26 -07:00
Matt Bierner 29475925f4 Extend disposable 2019-06-05 15:42:26 -07:00
Matt Bierner d34324f8b3 Make WindowsManager disposable
This class registers emitters which should be disposed
2019-06-05 15:42:26 -07:00
Matt Bierner 3132d26813 Have Panel extend Disposable
The panel currently exposes a `disposables` protected member. In order to catch possible leaks of disposables, we should extend `Disposable` instead
2019-06-05 15:42:25 -07:00
Matt Bierner cd82bcb5bd Make Action extend Disposable
This class already is an implicit IDisposable and a number of subclasses to it re-implement the Disposable logic
2019-06-05 15:41:46 -07:00
Matt Bierner 025c005ffc Remove extra indirection in toDisposable 2019-06-05 15:41:46 -07:00
Matt Bierner a1c5ded681 Remove n-arg version of dispose
This overload was not heavily used and added complexity
2019-06-05 15:41:46 -07:00
Matt Bierner 6b7b5c0e0c Extend lifecycle/Disposable in more places instead of re-implementing it
`lifecycle/Disposable` includes some important fixes that can help catch common programming mistakes
2019-06-05 15:41:46 -07:00
Matt Bierner 680b30a370 Remove unused interface method 2019-06-05 15:41:46 -07:00
Matt Bierner 88e7b22359 Use clearer name 2019-06-05 15:41:46 -07:00
Matt Bierner 8f496f2242 Make sure we dispose of emitters for TerminalProcessExtHostProxy 2019-06-05 15:41:46 -07:00
Matt Bierner a6b38fc755 Use readonly instead of getters 2019-06-05 15:41:45 -07:00
Matt Bierner a6ea8be992 Make sure we dispose of emitters in a few more places
Emitters should be disposed of properly in order to help prevent leaks
2019-06-05 15:41:45 -07:00
Matt Bierner 79781e0fe2 Extend disposable 2019-06-05 15:41:45 -07:00
Matt Bierner 5d4e42422d Make sure we dispose of emitter 2019-06-05 15:41:45 -07:00
Matt Bierner 2c8de04126 Fix merge error related to disposables 2019-06-05 15:41:45 -07:00
Matt Bierner 1cdf995036 Build with TS 3.5.1
The dom.d.ts types changed to not allow null on the outline styles. I believe that setting this to empty string should be equivalent
2019-06-05 15:41:45 -07:00
Matt Bierner b33f52a46e Update highlightjs version 2019-06-05 15:41:45 -07:00
Matt Bierner 809386b670 Working on getting ts server class in a testable state 2019-06-05 15:41:45 -07:00
Matt Bierner 0b4d3cd604 Remove use of IDisposable[] in a few more places 2019-06-05 15:41:45 -07:00
Matt Bierner 869e5921d8 Update more places where we are using an IDispoable[]
Either extend `Disposable` or use a readonly `DispoableStore`
2019-06-05 15:41:45 -07:00
Matt Bierner 2be7ab1ef6 implement IDisposable instead of extending base class 2019-06-05 15:41:44 -07:00
Sandeep Somavarapu 5845970591 #74918 Move markers status contribution to markers 2019-06-06 00:21:23 +02:00
Rob Lourens acad875120 Remove references to deleted icons 2019-06-05 14:50:13 -07:00
Rob Lourens f6bee434bb Remove unused dep clean-css 2019-06-05 14:40:44 -07:00