Commit graph

9184 commits

Author SHA1 Message Date
Matt Bierner
dfde221caa Fix the remove unused source action not removing single unused interfaces 2020-05-29 11:05:38 -07:00
Matt Bierner
5f8e6d0b19 Make sure add all missing imports quick fix comes after individual add missing import quick fixes
Fixes #98613
2020-05-29 11:05:38 -07:00
Johannes Rieken
b0d056202b Use canonical uri for openTextDocument api, #93368 2020-05-29 18:16:31 +02:00
Matt Bierner
cd41dd1f60 Pick up new TS version 2020-05-28 19:53:50 -07:00
Martin Aeschlimann
e4e4343217 Improve new constant color, tests. For #97373 2020-05-29 00:22:17 +02:00
Martin Aeschlimann
6933f31854 Improve new constant color. For #97373 2020-05-29 00:08:56 +02:00
Martin Aeschlimann
9b4e59b7f7 Merge branch 'master' into aeschli/cssheadless 2020-05-28 22:20:53 +02:00
Martin Aeschlimann
c6f665734a add TextEncoder to runtime 2020-05-28 22:18:58 +02:00
Rachel Macfarlane
a79822ac0a Remove old auth provider migration code 2020-05-28 12:55:52 -07:00
Martin Aeschlimann
eba3d294a2 [css] path completion in web 2020-05-28 21:54:35 +02:00
rebornix
37a3496bb0 share undo stack between text models in a notebook. the undo stack is not shared with notebook itself yet due to #98750. 2020-05-28 10:29:04 -07:00
Martin Aeschlimann
1ece4c4c25 adopt new languageserver node modules 2020-05-28 18:04:11 +02:00
Matt Bierner
7a4880a6bd Add some extra guards around image loading 2020-05-27 19:56:02 -07:00
Matt Bierner
4f7afb5a98 Skip failing test 2020-05-27 19:33:10 -07:00
Peng Lyu
c86d1760ea
Merge pull request #98691 from microsoft/rebornix/multi-exthost-renderers
load custom renderers when reloading from backup.
2020-05-27 16:28:16 -07:00
rebornix
8bac4d17ad combine events from edits from ext host. 2020-05-27 16:00:49 -07:00
Martin Aeschlimann
32f9787b89 unused import 2020-05-27 22:51:58 +02:00
Martin Aeschlimann
3ed67bc863 add client/server browser parts 2020-05-27 22:35:37 +02:00
Jack Works
ece530adcf
Update typescript.code-snippets (#98521) 2020-05-27 11:41:23 -07:00
SteVen Batten
b41766a0d9 tweak sizing 2020-05-27 10:52:23 -07:00
SteVen Batten
b384147f84 add icon for npm scripts
refs #93964
2020-05-27 10:46:01 -07:00
Rachel Macfarlane
a6c47beb1b Remove unused code in github auth provider 2020-05-27 09:37:54 -07:00
rebornix
9ae8d33358 disable second move down. 2020-05-27 08:06:50 -07:00
João Moreno
e0046cbd1d
💄 2020-05-27 15:35:08 +02:00
João Moreno
844960ea1e
Merge branch 'master' into pr/97349 2020-05-27 15:30:08 +02:00
João Moreno
8cce062aaf
💄 2020-05-27 15:27:13 +02:00
João Moreno
9fcc5e8195
Merge branch 'master' into pr/84843 2020-05-27 15:18:44 +02:00
Rick van Galen
571b747c28
Containerfile support (#93184)
* Apply Dockerfile highlighting to Containerfile

* Recognize Containerfile in Search Editor highlighting

* Register opening Containerfile files on macOS

* Register opening Containerfile files on Windows
2020-05-27 14:47:27 +02:00
Martin Aeschlimann
90861d4924 Merge branch 'master' into aeschli/cssheadless 2020-05-27 10:54:07 +02:00
Martin Aeschlimann
2d47826dac Adopt LS service/client that has common & node 2020-05-27 09:34:02 +02:00
Matt Bierner
040034f7ae Update colorizer baselines 2020-05-26 16:22:50 -07:00
Miguel Solorio
a389e193e6
Merge branch 'master' into add-monokai-dimmed-terminal-colors 2020-05-26 13:40:48 -07:00
John Blackbourn
b398b7ea14
Treat *.ts.map files as JSON (#98409) 2020-05-26 11:59:28 -07:00
Andrew Branch
766e520783
Allow TS Server to be started with --inspect-brk (#98340) 2020-05-26 11:57:02 -07:00
Miguel Solorio
6d7800fe9c
Merge branch 'master' into misolori/seti-update-05-2020 2020-05-26 11:29:28 -07:00
Miguel Solorio
eb781a2e0a Fix #98602 2020-05-26 11:25:22 -07:00
rebornix
56393440fb add error messages for notebook workflow integration tests. 2020-05-26 10:14:52 -07:00
Martin Aeschlimann
d1a3e6ede6 run webpack in code-dev 2020-05-26 18:15:01 +02:00
Miguel Solorio
8213982e27 Update seti-ui theme 2020-05-26 08:50:43 -07:00
Martin Aeschlimann
f9bb157b09 Merge branch 'master' into aeschli/cssheadless 2020-05-26 16:38:03 +02:00
Benjamin Pasero
a23d4daefa
Dangling text file models of deleted files hanging around in memory (#98154)
* Dangling text file models of deleted files hanging around in memory (fix #98057)

* address feedback
2020-05-26 16:29:12 +02:00
Martin Aeschlimann
8fd550c193 [css] update service 2020-05-26 15:41:30 +02:00
Martin Aeschlimann
5ef9b1a707 [css] remove path completion (now provided by service) 2020-05-26 11:40:09 +02:00
Pascal Fong Kye
65fa899fbe refactor: stage all but merge 2020-05-24 21:58:25 +02:00
Pascal Fong Kye
d2b5d323d0 feat:new command stage all merge 2020-05-24 21:58:24 +02:00
rzj17
60d906fd57 Modify git add/revert to use splitInChunks 2020-05-23 18:13:55 +01:00
Martin Aeschlimann
2e5b0824d1 Allow to run css language server headless 2020-05-22 17:08:16 +02:00
Janis Gailis
a34e15b15f Add terminal colors
Terminal colors are taken from Monokai, with the exception for ANSI
black, which is the editor background color.
2020-05-21 16:15:39 +03:00
rebornix
dfb4dbe961 restore notebook state after test. 2020-05-20 16:22:17 -07:00
Matt Bierner
3e9b7f5072 Fix markdown fontsize
Fixes #98178
2020-05-20 15:40:27 -07:00
Matt Bierner
c3b1725a2d Make sure implement interface is prioritized over remove unused
Fixes #94212
2020-05-20 15:34:02 -07:00
Matt Bierner
85a336c885 Only return single ts-ignore action if there are multiple errors on one line
Fixes #97867
2020-05-20 15:17:22 -07:00
rebornix
da98a19a5d temporarily disable cell move event test. 2020-05-20 13:55:54 -07:00
rebornix
627dd8b0ca notebook webview test 2020-05-20 13:19:16 -07:00
rebornix
de5ddeca61 💄 2020-05-20 11:07:27 -07:00
rebornix
d321061c8c merge moveEvent into CellsChangeEvent. 2020-05-20 11:03:30 -07:00
rebornix
979ca623f1 onDidActiveNotebookEditorChange 2020-05-20 10:32:26 -07:00
Rob Lourens
9bc11824c3 Add notebook smoketests 2020-05-20 12:01:52 -05:00
rebornix
af6649b9f5 💄 2020-05-20 09:09:20 -07:00
João Moreno
a67d00db97
fixes #98157 2020-05-20 14:04:03 +02:00
João Moreno
025dc8a948
add remote from push 2020-05-20 11:37:53 +02:00
João Moreno
0700c9ea43
git: contributable add remote 2020-05-20 11:37:53 +02:00
João Moreno
dedf4e7903
address publish to GitHub awareness 2020-05-20 11:37:52 +02:00
Alex Ross
074fc4d8da Update Python grammar
Fixes #98179
2020-05-20 10:43:20 +02:00
Johannes Rieken
1ea6771919 fix https://github.com/microsoft/vscode/issues/97836 2020-05-20 10:19:54 +02:00
rebornix
5c928428df notebookEditor.visible 2020-05-19 17:20:20 -07:00
rebornix
8e02737abc notebookEditor.active 2020-05-19 16:55:38 -07:00
Matt Bierner
cfcf9d1195 Update to latest ts version 2020-05-19 16:05:53 -07:00
Peng Lyu
536078737f
Merge pull request #98126 from microsoft/rebornix/documentNEditors
Separate notebook document and editor events.
2020-05-19 15:09:52 -07:00
rebornix
cc151dd103 notebook tests for notebook content change events. 2020-05-19 14:46:14 -07:00
João Moreno
4bb364cc8e github: publish workspace folder 2020-05-19 11:57:41 +02:00
rebornix
a328f500d8 💂 move cells will not re-create cells in ExtHost. 2020-05-18 18:46:08 -07:00
rebornix
4c54f7124c shared document between split editors and dispose them properly 2020-05-18 17:22:12 -07:00
João Moreno
24e33630b7 Merge branch 'joao/github' 2020-05-18 21:17:36 +02:00
João Moreno
a85a2e6044 move credential provider to github 2020-05-18 21:04:29 +02:00
Matt Bierner
443098af77 Don't enable test on remote 2020-05-18 11:18:55 -07:00
João Moreno
b629dba454 export to, clone from github 2020-05-18 15:51:15 +02:00
João Moreno
ee4e97fe6a publish command 2020-05-18 14:59:22 +02:00
João Moreno
12b150a961 github: remote source provider 2020-05-18 14:37:53 +02:00
João Moreno
1c98bbbbc2 add github extension 2020-05-18 14:13:08 +02:00
rebornix
0e5cedb755 💂 copy cell does not copy custom metadata 2020-05-17 21:20:46 -07:00
Matt Bierner
0af3fc77e8 Fixing rewriting of some old-style vscode-resource uris that don't have explicit authorities 2020-05-15 14:36:01 -07:00
Rachel Macfarlane
87b0c54586 Make AuthenticationSession a class and remove getAccessToken method, fixes #91554 2020-05-15 14:34:04 -07:00
rebornix
f560b157c6 some fixes for editor reopen with another type 2020-05-15 14:11:11 -07:00
Matt Bierner
aa16d5dbfe Fix notebook tests 2020-05-15 13:08:22 -07:00
Matt Bierner
d9f0f110f9 Don't compile testworkspace 2020-05-15 13:08:22 -07:00
rebornix
946d994d1b 💂 notebook tab switching and pick editor types. 2020-05-15 11:03:12 -07:00
Matt Bierner
9efb82eda9 Fix kind of SourceAddMissingImports 2020-05-15 10:39:43 -07:00
Matt Bierner
39fb3b1065 Mark add missing imports as preferred fixes
Allow auto fixing add missing imports if:

- There is only one possible import
- And there are no better fixes (such as spelling changes)
2020-05-15 10:39:43 -07:00
Matt Bierner
541b9eb7a6 Don't mark fix all actions as preferred
Fixes #97866
2020-05-15 10:39:43 -07:00
Martin Aeschlimann
13952ac5b9 auto-renaming tags notifier popping up multiple times. Fixes #97833 2020-05-15 11:08:31 +02:00
João Moreno
4c36782f8e git api: publishRepository 2020-05-15 10:50:05 +02:00
João Moreno
6981f7c7fb 💄 2020-05-15 10:50:05 +02:00
João Moreno
6d127275f2 💄 2020-05-15 10:50:05 +02:00
Martin Aeschlimann
5d3e740a0d
Merge pull request #97812 from Jagua/fix-ext-json-lngsvr-document-indent
Fix indentation and typo of json-language server readme
2020-05-15 10:37:16 +02:00
rebornix
b9c163faee asWebUri. 2020-05-14 17:53:33 -07:00
Matt Bierner
f3454d430b Better clean for 452a377c5e 2020-05-14 12:13:31 -07:00
Martin Aeschlimann
0fffab3aaa
Merge branch 'master' into feature/node-module-resolution-for-css-import-parent-folders 2020-05-14 17:01:17 +02:00
Jagua
0a7841c45a Fix indentation and typo of json-language server readme 2020-05-14 22:11:26 +09:00
Alex Ross
6570efce0f
Add git extension API for branches (#97621)
Enables microsoft/vscode-pull-request-github#1781
2020-05-14 12:26:50 +02:00
Martin Aeschlimann
e045073284 json.schemaDownload.enable prevents vscode schemas from beeing fetched. #96083 2020-05-14 11:23:50 +02:00
Benjamin Pasero
45aa0bf525 fix compile error
fyi @mjbvz
2020-05-14 09:58:21 +02:00
Matt Bierner
452a377c5e Still search all projects if you are using TS 3.9 but are not in a TS file 2020-05-13 19:42:18 -07:00
rebornix
1669bde634 custom metadata for notebook document. 2020-05-13 15:00:59 -07:00
rebornix
118da97dc8 Re #96433 2020-05-13 12:53:03 -07:00
rebornix
03acd2250a Fix #96433 2020-05-13 12:47:39 -07:00
Rachel Macfarlane
9559d186d4 Rename vscode-account extension to microsoft-authentication 2020-05-13 09:41:42 -07:00
rebornix
f027dd6fae Re microsoft/vscode-github-issue-notebooks#26. test for regression. 2020-05-13 08:44:51 -07:00
Alex Ross
3da22e920b
Add path to LogOptions (#97693)
Part of microsoft/vscode-pull-request-github#1781
2020-05-13 16:04:28 +02:00
Martin Aeschlimann
74408bac89 guide users of the Auto Rename Tag extension to the new editor.renameOnType setting. Fixes #97700 2020-05-13 12:29:38 +02:00
João Moreno
ea89f2d8b9 related to microsoft/vscode-pull-request-github#1759 2020-05-13 11:24:51 +02:00
Martin Aeschlimann
15bd662fa7
Merge pull request #97646 from 9at8/add-shell-extensions
Support more shell script file extensions
2020-05-13 10:04:18 +02:00
Aditya Thakral
242781566c Support more shell script file extensions 2020-05-12 17:49:35 -04:00
Aditya Thakral
a33d16d97e Convert extension array to multiline array 2020-05-12 17:44:39 -04:00
Matt Bierner
2344d7cf7e Revert "add todo for matt"
This reverts commit cd93eaacd5.

Fixes #97636
2020-05-12 13:16:13 -07:00
Matt Bierner
b312fa2d33 Add initial source actions for remove unused and add missing imports
Fixes #95831
2020-05-12 13:16:08 -07:00
Matt Bierner
6efd86a30c Cleaning up fix all for JS/TS 2020-05-12 13:16:08 -07:00
João Moreno
cd93eaacd5 add todo for matt 2020-05-12 21:24:59 +02:00
João Moreno
5185d7e6f8 disable askpass, terminal and github auth when git is disabled
fixes #97320
2020-05-12 13:37:00 +02:00
Rachel Macfarlane
cbb0b04d7d Add supportsMultipleAccounts to auth providers 2020-05-11 18:32:36 -07:00
Matt Bierner
4da345ea2b Clairify breaks setting effect
Fixes #97382
2020-05-11 17:33:28 -07:00
Matt Bierner
c6db83b483 Extract error codes to constant file 2020-05-11 17:33:28 -07:00
Matt Bierner
2393521d37 Use equals helper 2020-05-11 17:33:28 -07:00
Rahul Kadyan
47c54f0e32
feat: use configNamespace for registering language providers of other extensions (#95621)
fixes #75890
2020-05-11 15:22:42 -07:00
Christos Pappas
03beeec722
Prevent aggressive image name encoding (#96935)
* Prevent aggressive image name encoding

* Fix typo on function name

Changes getWebiewContents to getWebviewContents in image-preview extension
2020-05-11 15:21:16 -07:00
Matt Bierner
e4e1099f8c Configure optional chain completions at the file level instead of per-request
Fixes #97398
2020-05-11 14:52:20 -07:00
Matt Bierner
df88d8a7ef Use vscode editor font variable in markdown preview
Fixes #97374
2020-05-11 14:23:16 -07:00
Matt Bierner
b1e9155139
Use generic for providers with resolve methods (#96955)
* Use generic for providers with resolve

Fixes #95852

Some of our providers have two phases: provide and resolve. This change updates the typings to make it clearer that the values returned by provider are passed into resolve.

* Remove duplicate vscode.d.ts in search-result extension

* Also use generic type in result of resolve
2020-05-11 13:06:03 -07:00
Rachel Macfarlane
bbb54b5ffc Remove trace setting from microsoft auth provider 2020-05-11 09:53:59 -07:00
Alex Ross
45da8ac9bc Fix resolveTask for npm install
Fixes #97197
2020-05-11 16:20:22 +02:00
Alex Ross
884fcedf97 Update grammars 2020-05-11 14:03:54 +02:00
Matt Bierner
ba33738bb3 Pick up TS 3.9.2 insiders 2020-05-10 13:29:53 -07:00
rebornix
26ededa858 NotebookDocumentEditEvent 2020-05-08 11:55:22 -07:00
Danny Lin
ff118340b5
Use system-ui alias for UI fonts (fixes #10144) (#96948)
Commit 45d93e9325 applied this change in
some areas, but it was reverted to fix #28619. The underlying cause of
the regression was Chromium bug 733219 [1], which has now been fixed, so
this change should be safe to apply now.

The old font stacks have been kept with lower priorities to work around
Chromium bug 724393 [2].

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=733219
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=724393
2020-05-08 08:21:40 +02:00
Peng Lyu
a671075754
Merge pull request #97043 from microsoft/rebornix/hotexit
Notebook document creation from UI side and hot exit
2020-05-07 14:51:15 -07:00
Ladislau Szomoru
ee8a6bc4f8
Git: Add "git rebase --abort" command (#97071)
Add "git rebase --abort" command
2020-05-07 14:26:55 +02:00
Rachel Macfarlane
9514854412 Add support for workspaces callbacks to MS auth provider 2020-05-06 18:15:57 -07:00
rebornix
e0882b95ff Fix selection after reverting the document 2020-05-06 16:42:38 -07:00
rebornix
4bd68b7dfe fix false negative test 2020-05-06 15:04:52 -07:00
rebornix
6ff9361158 Merge remote-tracking branch 'origin/master' into rebornix/hotexit 2020-05-06 12:43:00 -07:00
Martin Aeschlimann
8a97cbb47d [json] Add setting to disable downloading JSON schemas. Fixes #96083 2020-05-06 18:58:59 +02:00
Martin Aeschlimann
f8c59fed50 update seti font, support for inherit icon. Fixes #92951. Fixes #96326 2020-05-06 16:27:07 +02:00
Alasdair McLeay
06634e1025 Search in parent folders for node module resolution
as per comments from @octref on #78894 https://github.com/microsoft/vscode/issues/78894#issuecomment-535254539
2020-05-06 14:32:11 +01:00
Alasdair McLeay
237c803741 #78894 failing test 2020-05-06 14:30:49 +01:00
Martin Aeschlimann
3887bc8aca [rename on type] Language client is not ready yet. FIxes #97062 2020-05-06 13:29:44 +02:00
rebornix
1b5217985b notebook document creation in UI side 2020-05-05 18:43:25 -07:00
Christof Marti
987bd8f4d0 Make image/dockerfile/dockerComposeFile optional 2020-05-05 08:36:22 +02:00
Matt Bierner
986a9c8bc9 Don't save files on JS/TS server start
Fixes #96503

This workaround no longer seems needed
2020-05-04 17:36:34 -07:00
Matt Bierner
41ca01f942 Remove console log
Fixes #96915
2020-05-04 17:28:33 -07:00
Matt Bierner
996b5be2ed Update built-in JS/TS version to 3.9 2020-05-04 16:34:31 -07:00
rebornix
39d562346c Merge remote-tracking branch 'origin/master' into rebornix/notebook-textbuffer 2020-05-04 11:12:37 -07:00
rebornix
b7736a24c7 more testing for unsaved document 2020-05-01 17:21:30 -07:00
rebornix
715b135887 Slim NotebookEditorInput and model service for notebookEditorModel. 2020-05-01 15:36:41 -07:00
Martin Aeschlimann
fe5024cb35 Handle invalid token type/modifier indexes. Fixes #96540 2020-05-01 16:48:19 +02:00
Benjamin Pasero
6a8b201c8a smoke - restore skip-release-notes CLI arg (#96459) 2020-04-29 12:40:04 +02:00
Rachel Macfarlane
11ec8269ed Pass correct host for VSO token 2020-04-28 15:17:22 -07:00
Rachel Macfarlane
a1a98d07da Fix github authentication in the web, fixes #96406 2020-04-28 14:00:41 -07:00
Rachel Macfarlane
4b7882a2d2 Remove unused variable 2020-04-28 10:26:28 -07:00
Rachel Macfarlane
ed9be86c6a Remove auth provider extension contributed sign in/out commands, fixes #96346 2020-04-28 09:00:11 -07:00
Alex Ross
27a97b9534 Allow quick suggestions in strings in dockerfiles
Part of #95924
2020-04-28 15:46:05 +02:00
João Moreno
0209826b56 fixes #96399 2020-04-28 15:09:38 +02:00
Andrew Casey
13d3a9358b
Update npm script compile-extension:typescript-language-features (#96320) 2020-04-27 18:38:08 -07:00
Andrew Casey
3ecefe6d7a
Make char position optional in TS stack (#96321) 2020-04-27 18:37:50 -07:00
kieferrm
3aa931c67d fix GDPR annotation 2020-04-28 00:49:18 +00:00
Matt Bierner
686ad17217 Clean up onTypesInstallerInitializationFailed
- Convert to async
- don't require using inline type with id
2020-04-27 16:42:45 -07:00
Martin Aeschlimann
919c46deab [html] update dependencies 2020-04-27 23:15:37 +02:00
Martin Aeschlimann
0cb91f61bd [css] update dependencies 2020-04-27 23:07:25 +02:00
Martin Aeschlimann
4a3bd05497 [json] Go to definition for $ref. Fixes #69411 2020-04-27 22:30:58 +02:00
Andrew Casey
27e2e92a54
Clean up CallstackOrException telemetry in typescript-language-features (#96108)
One was actually SystemMetaData, all others were either dropped or
replaced with sanitized versions classifiable as SystemMetaData.
2020-04-27 12:13:00 -07:00
Rachel Macfarlane
b05b32bfd8 Use github auth server for provider 2020-04-27 08:10:46 -07:00
Daniel Imms
eb64e93b17 Add ref to why test is disabled 2020-04-27 07:34:59 -07:00
Daniel Imms
aebfe022af Disable tasks tests in web
Part of #90528
2020-04-27 07:30:06 -07:00
João Moreno
75877c8185
Merge pull request #96080 from johnbillion/fix/gitignore_global
Treat `.gitignore_global` as an Ignore file by default.
2020-04-27 15:58:23 +02:00
João Moreno
15e159a713 💄 2020-04-27 15:00:06 +02:00
João Moreno
8ff93b98c5 git: config.githubAuthentication 2020-04-27 14:57:47 +02:00
João Moreno
54d8261f93 git: config.terminalAuthentication 2020-04-27 14:57:47 +02:00
João Moreno
bc9854b494 git: use environmentVariableCollection 2020-04-27 14:57:47 +02:00
João Moreno
c7fec92849
Merge pull request #96069 from microsoft/joao/github-auth
Provide automatic git authentication to GitHub
2020-04-27 12:23:16 +02:00
João Moreno
bce93beff7 move github credential provider to git 2020-04-27 12:14:23 +02:00
Daniel Imms
7f5bada046
Move EnvironmentVariableCollection API into ExtensionContext (#96061)
* Move env var collection to ext context

* Remove dispose, fix persistent passing

* Fire collection change on persistence change

* Fix tests by forcing activation and getting ctx

* chore: bump js-debug

Co-authored-by: Connor Peet <connor@peet.io>
2020-04-24 16:45:30 -07:00
Rob Lourens
9b995534bc Add tests for metadata 2020-04-24 17:49:49 -05:00
Matt Bierner
4862602c4c Align custom editor API proposal with notebook API
Fixes #95854
Fixes #95849
For #77131

- Move all editing functionality back onto the provider. This better matches the notebook API.

- Rename `CustomEditorProvider` to `CustomReadonlyEditorProvider`.  `CustomEditorProvider` is now how editable custom editors are implemented

- Give extension a full suggested backup path instead of just a folder
2020-04-24 14:47:08 -07:00
rebornix
cea1d2f91f fix notebook integration test 2020-04-24 13:04:14 -07:00
Liying
ec5c1264bc
Update compilerOptions returned by host for javascript.implicitProjectConfig.experimentalDecorators. (#95923)
Co-authored-by: liyche <liyche@umich.edu>
2020-04-24 11:34:03 -07:00
Rob Lourens
12e92983ad Update notebook test command IDs 2020-04-24 12:59:06 -05:00
John Blackbourn
4281e933d3 Treat .gitignore_global as an Ignore file by default. Fixes #96079. 2020-04-24 18:44:18 +01:00
Andre Weinand
795050f81b serverReady fix for #95108 2020-04-24 18:37:32 +02:00
João Moreno
065bb1b5d6 wip: use registerCredentialsProvider in github-authentication extension 2020-04-24 18:04:47 +02:00
João Moreno
cab6f958a2 git extension api: registerCredentialsProvider 2020-04-24 18:04:36 +02:00
João Moreno
77d7351226 add log to askpass ipc 2020-04-24 15:40:03 +02:00
Daniel Imms
ae1670d4ea Disable terminal tests in remote
Too flaky they're not useful.

See #96057
2020-04-24 06:27:59 -07:00
Daniel Imms
aa91f911f9 Suppress exit code notification in terminal test 2020-04-24 06:08:58 -07:00
Matt Bierner
a4597e1905 Enable JS/TS workspace symbol search for all projects
Fixes #11026

Adds a new `typescript.workspaceSymbols.scope` setting that enables searching all known projects when using TS 3.9+
2020-04-24 00:42:55 -07:00
Matt Bierner
f35758ab21 Rename supportsMultipleEditorsPerResource -> supportsMultipleEditorsPerDocument
For #77131
2020-04-23 17:33:06 -07:00
rebornix
9b11e5d500 avoid conflict with jupyter in OSS 2020-04-23 14:30:54 -07:00
Matt Bierner
7d238f4281
Add 'open with' to the explorer context menu (#95805)
This change primarly adds a new `Open with...` entry to the explorer context menu. To do this however, I had to make a few other changes:

- Add a new explorer context key for availible editors
- Moved the editor select prompt into a new function called `openEditorWith`
- Use `openEditorWith` for the new `open with` explorer command as well as for the `reopen with` command
2020-04-23 14:16:36 -07:00
rebornix
600528da86 Fix #96007. 2020-04-23 13:53:58 -07:00
Peng Lyu
582ced0089
Merge pull request #96001 from microsoft/rebornix/integration-test
Notebook integration test and undo/redo
2020-04-23 13:06:21 -07:00
Rachel Macfarlane
badd41f04a Better error handling in github auth provider 2020-04-23 12:16:33 -07:00
Peng Lyu
dc6f64a0d0
Merge branch 'master' into rebornix/integration-test 2020-04-23 11:59:59 -07:00
rebornix
b9eafe5f66 intergration tests. 2020-04-23 11:55:23 -07:00
Daniel Imms
87c0080c3a
Merge pull request #95969 from microsoft/tyriar/95945
Make terminal echo integration test more reliable
2020-04-23 11:04:01 -07:00
Connor Peet
66744e3b25
debug: enable js-debug to auto attach (#95807)
* debug: enable js-debug to auto attach

This modifies the debug-auto-launch extension to trigger js-debug as
outlined in https://github.com/microsoft/vscode/issues/88599#issuecomment-617242405

Since we now have four states, I moved the previous combinational logic
to a `transitions` map, which is more clear and reliable. The state
changes are also now a queue (in the form of a promise chain) which
should avoid race conditions.

There's some subtlety around how we cached the "ipcAddress" and know
that environment variables are set. The core desire is being able to
send a command to js-debug to set the environment variables only if they
haven't previously been set--otherwise, reused
the cached ones and the address.

This process (in `getIpcAddress`) would be vastly simpler if extensions
could read the environment variables that others provide, though there
may be security considerations since secrets are sometimes stashed
(though I could technically implement this today by manually creating
and terminal and running the appropriate `echo $FOO` command).

This seems to work fairly well in my testing. Fixes #88599.

* fix typo

* clear js-debug environment variables when disabling auto attach
2020-04-23 09:49:29 -07:00
Daniel Imms
3d7745d6fc Dispose data listener before disposing terminal
Fixes #95945
2020-04-23 07:29:47 -07:00
Daniel Imms
84a884a97a Return after done(e)
Part of #95945
2020-04-23 07:27:29 -07:00
João Moreno
ab42ffc44c add git api to init 2020-04-23 16:26:24 +02:00
João Moreno
c7d7b0dc88 fix clone from 2020-04-23 15:26:47 +02:00
João Moreno
888f89b40a add renameRemote 2020-04-23 14:37:39 +02:00
Alex Dima
786d4dab94
Fix integration tests 2020-04-23 12:11:58 +02:00
João Moreno
df1a7b0e8a
Merge pull request #95780 from fleck/patch-1
remove duplicate git.pullFrom command
2020-04-23 11:10:25 +02:00
Martin Aeschlimann
e26a0dd2c3 Dark+/Light+: constant color that is closer to the variable color (for #95346) 2020-04-23 09:52:30 +02:00
Rachel Macfarlane
2e5312cd61 Add account id to authentication session object 2020-04-22 18:00:16 -07:00
Rachel Macfarlane
006cfcd949 Rename microsoft auth provider output channel 2020-04-22 14:21:25 -07:00
Rachel Macfarlane
93cff0f3b6 Change key for microsoft auth provider 2020-04-22 14:17:36 -07:00
Matt Bierner
0d5ed6bfde Add logging of service state
For #95122
2020-04-22 14:01:30 -07:00
Duncan Walter
c7c2301bc2
TS: Add setting to prompt users about workspace tsdk (#95566)
* add a setting to prompt users to switch to tsdk version

* version manager in control

Co-authored-by: Duncan Walter <dwalter@hubspot.com>
2020-04-22 10:57:22 -07:00
João Moreno
3b0ba06a7b RemoteSourceProvider.icon 2020-04-22 17:16:35 +02:00
João Moreno
97b2fe2f7e show git repo details 2020-04-22 16:56:33 +02:00
Martin Aeschlimann
389e9dd5e8
Merge pull request #95751 from iliazeus/95584-additional-json-file-extensions
add more json file extensions #95584
2020-04-21 23:38:44 -07:00
Rachel Macfarlane
8fdb90a496 Add .vscodeignore file to github auth extension 2020-04-21 12:13:23 -07:00
Rachel Macfarlane
fd88fb9667 Await keychain write on logout for github auth 2020-04-21 11:16:45 -07:00
Jonathan Fleckenstein
f12f21d320
remove duplicate git.pullFrom command 2020-04-21 10:44:38 -04:00
João Moreno
d1e315f5e1 fix git clone 2020-04-21 15:35:10 +02:00
João Moreno
3d04c5558e support multiple URLs 2020-04-21 14:20:30 +02:00
João Moreno
106552963c handle remote source provider errors 2020-04-21 12:13:56 +02:00
Ilia Pozdnyakov
dbdf8bb075 add more json file extensions #95584 2020-04-21 14:45:05 +07:00
Miguel Solorio
8409851de0 Update default sidebar section header colors (fixes #93764) 2020-04-20 10:30:40 -07:00
João Moreno
479b3dafb5 Merge branch 'joao/git-remote-providers' 2020-04-20 17:33:16 +02:00
João Moreno
0da6ba9071
Merge pull request #95549 from avdg/git-pager
Do not let git use a pager
2020-04-20 15:56:12 +02:00
Anthony Van de Gejuchte
bf9146eaf0 User 'cat' as GIT_PAGER option 2020-04-20 15:11:05 +02:00
João Moreno
968de61532 Merge commit 'refs/pull/81982/head' of github.com:microsoft/vscode into pr/81982 2020-04-20 14:25:59 +02:00
Anthony Van de Gejuchte
057500153b Move env declaration of GIT_PAGER 2020-04-20 14:13:34 +02:00
Anthony Van de Gejuchte
7374bff932 Do not let git use a pager 2020-04-17 18:37:51 +02:00
João Moreno
675ed02c1f move RemoteSourceProvider to git api 2020-04-17 16:34:22 +02:00
João Moreno
aeeec54c8e missing 2020-04-17 15:58:15 +02:00
João Moreno
1494dc7d08 improve ux around git remote picker 2020-04-17 15:56:13 +02:00
João Moreno
5f79de53e6 Merge branch 'master' into joao/git-remote-providers 2020-04-17 15:47:46 +02:00
Johannes Rieken
d1dfa5e91b iterate over suggestions only once, #95324 2020-04-17 09:06:34 +02:00
Rachel Macfarlane
b665721d95 Try downgrading vscode-extension-telemetry package 2020-04-16 22:50:48 -07:00
Rachel Macfarlane
87287d0275 Code cleanup, remove stuff related to sign in commands 2020-04-16 19:29:56 -07:00
Matt Bierner
5913061e1b Allow a custom editor to opt out of supporting multiple instances for a single resource
#77131
2020-04-16 17:40:20 -07:00
Rachel Macfarlane
c63a842f00 Add basic telemetry to auth providers 2020-04-16 11:59:07 -07:00
Matt Bierner
c189b2bb05 Remove use of memoize
Fixes #95324
2020-04-16 10:17:01 -07:00
Matt Bierner
b89738c83b Scope prepareRename to TS 3.1+
Fixes #95399
2020-04-16 10:17:01 -07:00
Eric Amodio
77e79529e1 Removes bogus code 2020-04-16 11:48:34 -04:00
João Moreno
e2e8461d68 Merge branch 'master' into joao/git-remote-providers 2020-04-16 11:38:01 +02:00
Matt Bierner
1c542d50be More improvements to TS completion computation
For #95324

- Get word range before we make the TS request
- Reuse the context
2020-04-15 14:14:20 -07:00
Matt Bierner
564c619d73 💄 2020-04-15 14:14:20 -07:00
Matt Bierner
a51f8c4626 Fix missing property description string 2020-04-15 12:46:40 -07:00
Matt Bierner
605d2cfadb 💄 2020-04-15 12:46:40 -07:00